[Freeciv-Dev] (PR#40341) Saving games fails silently on Windows Vista
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40341 Windows Vista SP1, Freeciv 2.1.5 2.0.9: Civserver says a game has been saved, but no file is created on disk. Caused by WinVista's 'improved' file access control. Seems to be solved if you give the group Users the rights to modify the containing directory. Dunno about any security implications caused by this change. Best, ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40341) Saving games fails silently on Windows Vista
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40341 [dmarks - Sun Jun 29 06:57:38 2008]: Windows Vista SP1, Freeciv 2.1.5 2.0.9: Civserver says a game has been saved, but no file is created on disk. Caused by WinVista's 'improved' file access control. Seems to be solved if you give the group Users the rights to modify the containing directory. Dunno about any security implications caused by this change. Best, ~Daniel Giving this to you Christian. Installer issue, I presume? Best, ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39568) cannot sell an improvement
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39568
Daniel Markstedt wrote:
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39568
[dmarks - Sun Jun 29 01:22:46 2008]:
[jdorje - Sun Jun 29 01:17:09 2008]:
[pepeto - Mon Oct 15 17:07:29 2007]:
Isn't this ticket resolved? Or does it need some more improvement?
What about 2.0? Is it still broken there?
-jason
Yes it is.
Tried to merge the first revision of the patch to S2_0, but just
worsens the issue. With attached patch selling buildings is completely
broken.
Ahh so.
pcity-owner is a player id not a pointer. So this patch does the trick.
-jason
Index: client/gui-gtk-2.0/citydlg.c
===
--- client/gui-gtk-2.0/citydlg.c(revision 14909)
+++ client/gui-gtk-2.0/citydlg.c(working copy)
@@ -2389,8 +2389,7 @@
return;
}
- if (pdialog-pcity-did_buy || pdialog-pcity-did_sell ||
- pdialog-pcity-owner != game.player_idx) {
+ if (pdialog-pcity-did_sell || pdialog-pcity-owner != game.player_idx) {
return;
}
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40338) [Patch] Configurable max lake size
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40338
2008/6/29 Jason Dorje Short:
Marko Lindqvist wrote:
2008/6/28 Jason Dorje Short:
- if (DEFAULT_LAKE_SEA_SIZE ocean_sizes[-here]
+ if (terrain_control.lake_max_size = ocean_sizes[-here]
num_laketypes 0) {
tile_change_terrain(ptile, lakes[myrand(num_laketypes)]);
Isn't this check backwards?
If size of the body of water (right side) is smaller or equal to
maximum size of lake (left side), it's lake.
Err. Right. So then...isn't the old check backwards?
Yes.
This code is used only if body of water is completely surrounded by
one continent. Potential lakes rarely appear with default landmass.
Lake creation code has probably not been tested before now.
- ML
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] trunk doesn't compile
2008/6/29 Jason Dorje Short [EMAIL PROTECTED]: aiparatrooper.c:37:23: error: utilities.h: No such file or directory Include path problem. I cannot reproduce. 1) Makefile.am should contain $(top_srcdir)/server/generator -path. 2) Are your Makefile.in and Makefile regenerated? This might require that you have configured with --enable-maintainer-mode or run automake manually again now. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40343) trunk fails to compile here too
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40343 ld: warning multiple definitions of symbol _locale_charset /opt/local/lib/libintl.dylib(localcharset.o) definition of _locale_charset /opt/local/lib/libiconv.dylib(localcharset.o) definition of _locale_charset ld: Undefined symbols: _gtk_image_clear make[3]: *** [civclient] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 This is on MacOSX 10.3.9, with GTK+ 2.6.8 Note that I haven't tried to build trunk for a very long time, so any change from the last few months may have broken it. -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] trunk doesn't compile
Marko Lindqvist wrote: 2008/6/29 Jason Dorje Short [EMAIL PROTECTED]: aiparatrooper.c:37:23: error: utilities.h: No such file or directory Include path problem. I cannot reproduce. 1) Makefile.am should contain $(top_srcdir)/server/generator -path. 2) Are your Makefile.in and Makefile regenerated? This might require that you have configured with --enable-maintainer-mode or run automake manually again now. Problem is fixed after rerunning autogen.sh. I still think it is *quite* wrong for the generator module code to be used outside of that directory. When we originally split that off, it was to make the code more modular, not to create a whole secondary set of dependencies to have to keep track of. That said get_continent_size() is not really generator-specific. In fact I'd think it should be in map.c... -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40342)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 Hello: Updated branch S2_2 to SVN 14910 today, and despite many different configurations, it now fails to compile, always exiting at the same place with same message: [...] make[4]: Leaving directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2/common/aicore' make[4]: Entering directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2/common' gcc -DHAVE_CONFIG_H -I. -I.. -I../utility -I./aicore -DLOCALEDIR=\/opt/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv:/opt/share/freeciv\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -O3 -pipe -m32 -MT base.o -MD -MP -MF .deps/base.Tpo -c -o base.o base.c mv -f .deps/base.Tpo .deps/base.Po gcc -DHAVE_CONFIG_H -I. -I.. -I../utility -I./aicore -DLOCALEDIR=\/opt/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv:/opt/share/freeciv\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -O3 -pipe -m32 -MT capstr.o -MD -MP -MF .deps/capstr.Tpo -c -o capstr.o capstr.c In file included from capstr.c:23: capstr.h:16:1: warning: NETWORK_CAPSTRING redefined In file included from capstr.c:15: ../config.h:364:1: warning: this is the location of the previous definition capstr.c: In function ‘init_our_capability’: capstr.c:84: error: ‘NETWORK_CAPSTRING_MANDATORY’ undeclared (first use in this function) capstr.c:84: error: (Each undeclared identifier is reported only once capstr.c:84: error: for each function it appears in.) capstr.c:84: error: expected ‘)’ before string constant make[4]: *** [capstr.o] Error 1 make[4]: Leaving directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2/common' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2/common' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2/common' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/Shared/Linux_Source_Code-Binaries/freeciv-2.2' make: *** [all] Error 2 [END] Last successful compile was with SVN 14806. Regards, VJS I disapprove of what you say, but I will defend to the death your right to say it. EB Hall, Friends of Voltaire, 1906 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39568) cannot sell an improvement
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39568 [EMAIL PROTECTED] - Dim. Jun. 29 07:41:05 2008]: pcity-owner is a player id not a pointer. So this patch does the trick. My patch was against S2_1, and there, pcity-owner is a pointer. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40343) trunk fails to compile here too
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40343 2008/6/29 Daniel Markstedt: ld: warning multiple definitions of symbol _locale_charset /opt/local/lib/libintl.dylib(localcharset.o) definition of _locale_charset /opt/local/lib/libiconv.dylib(localcharset.o) definition of _locale_charset At least revisions 14778 (PR #40275) and 14890 (PR #40301) affect how these libraries get linked in. Does S2_1 compile for you? These changes are there as well. I guess that correct behavior in your environment would be to link directly against libintl only, and not against libiconv, when nls is enabled. When nls disabled, should link against libiconv only. ld: Undefined symbols: _gtk_image_clear gtk_image_clear() seems to be gtk 2.8 feature. Either we have to replace this call or to make 2.8 minimum gtk version. This is on MacOSX 10.3.9, with GTK+ 2.6.8 - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40343) trunk fails to compile here too
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40343 [EMAIL PROTECTED] - Sun Jun 29 16:57:24 2008]: 2008/6/29 Daniel Markstedt: ld: Undefined symbols: _gtk_image_clear gtk_image_clear() seems to be gtk 2.8 feature. Either we have to replace this call or to make 2.8 minimum gtk version. This is on MacOSX 10.3.9, with GTK+ 2.6.8 I'll look into finding a compatible replacement for this function. -- それだけは、いいんだ。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40342) S2_2 SVN 14910 compile fails
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 My best guess is that you have a stale config.h hanging around. Does it work if you re-run autogen.sh? -- 気を付けてね ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40342) AM_MAINTAINER_MODE removal (Was: S2_2 SVN 14910 compile fails)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 2008/6/29 Madeline Book: My best guess is that you have a stale config.h hanging around. Even stale configure might do that. Modified version.in is considered part configure.ac. Here again, had it been configured with --enable-maintainer-mode, configure should be automatically regenerated. I'm getting convinced that need of --enable-maintainer-mode is much worse thing than always forcing those additional dependencies to users. I vote for removal of AM_MAINTAINER_MODE. If someone wants to copy source files around, they should setup timestamps in proper order by touching files (tar + untar reserves correct timestamps, so does svn checkout update). - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40342) S2_2 SVN 14910 compile fails
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 [EMAIL PROTECTED] - Sun Jun 29 20:05:25 2008]: 2008/6/29 Madeline Book: My best guess is that you have a stale config.h hanging around. Even stale configure might do that. Modified version.in is considered part configure.ac. Here again, had it been configured with --enable-maintainer-mode, configure should be automatically regenerated. I'm getting convinced that need of --enable-maintainer-mode is much worse thing than always forcing those additional dependencies to users. I vote for removal of AM_MAINTAINER_MODE. If someone wants to copy source files around, they should setup timestamps in proper order by touching files (tar + untar reserves correct timestamps, so does svn checkout update). After reading your argument and this page http://www.gnu.org/software/libtool/manual/automake/ maintainer_002dmode.html I would tend to agree. -- 異論はないだろう。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40342) S2_2 SVN 14910 compile fails
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 Madeline Book wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40342 [EMAIL PROTECTED] - Sun Jun 29 20:05:25 2008]: 2008/6/29 Madeline Book: My best guess is that you have a stale config.h hanging around. Even stale configure might do that. Modified version.in is considered part configure.ac. Here again, had it been configured with --enable-maintainer-mode, configure should be automatically regenerated. I'm getting convinced that need of --enable-maintainer-mode is much worse thing than always forcing those additional dependencies to users. I vote for removal of AM_MAINTAINER_MODE. If someone wants to copy source files around, they should setup timestamps in proper order by touching files (tar + untar reserves correct timestamps, so does svn checkout update). After reading your argument and this page http://www.gnu.org/software/libtool/manual/automake/ maintainer_002dmode.html I would tend to agree. Sure. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] FreeCivl SDL Civilopedia
Hello, I've been reading on old threads of the mailing list that there were plans to add a Civilopedia button to the main screen of freeciv-sdl. Is this still happening? Thanks, Gabriel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] FreeCivl SDL Civilopedia
On Mon, 30 Jun 2008 02:42:17 +0900, Gabriel Hurley [EMAIL PROTECTED] wrote: Hello, I've been reading on old threads of the mailing list that there were plans to add a Civilopedia button to the main screen of freeciv-sdl. Is this still happening? Thanks, Gabriel I put up a wishlist ticket 8 months ago, but unfortunately there have been no updates since. http://bugs.freeciv.org/Ticket/Display.html?id=39807 Best, ~Daniel -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40019) Feature Request: adjustable road movement multiplier
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40019 Giving to you Marko - seems to be in the scope of your expertise. ;) ~Daniel [EMAIL PROTECTED] - Tue Jan 15 11:03:44 2008]: Hello: REF: http://forum.freeciv.org/viewtopic.php?t=4113. Please consider making the road movement multiplier to be a ruleset-adjustable value, rather than hardcoded. This multiplier should probably affect river movement as well. I know that in Civ2, it could be changed in the rules.txt file. That was very convenient - it allowed finer tuning of unit movement rates for modpacks. For example, reducing the road movement multiplier to 2x or even 1x, and increasing terrain movement costs accordingly, you could have very slow units with only one move point, while still retaining the advantages of reduced movement for paved tiles (all movement between two tiles, both having roads, is reduced to 1/2 or 1, regardless of the underlying terrain move cost) and units with multiple movement points. And rugged terrain would still slow down most units. Or, you could speed things up by increasing the road movement multiplier to, say, 4x. Example: ruleset (effects.ruleset? game.ruleset? terrain.ruleset?) value of road movement multiplier (default 3) is changed to 1x for a modpack; terrain.ruleset is modified: flat terrain (grassland, plains, desert) move cost set to two, forest to 3-4, hills to 4, mountains/swamp/jungle to 5-6; units.ruleset is modified: slow units (slaves/workers, catapults) have one move point, standard units (most land units) have two move points, fast units have more (chariots and light/skirmishers 3, horsemen 4-5, etc.); across flat open terrain, then, any unit could move one tile, some two, others three (same as now); rugged terrain (forest, hills, etc.), however, would still slow down even fast-moving units (same as now) such that any land unit could only advance into only one mountain tile (same as now); on paved tiles however, some slow units would still only go one tile, most standard land units would now go two paved tiles, some fast units 3-4-5 or even more, as long as they stay on a road, and all regardless of the terrain type underlying the roads. As the rules stand, some units might be able to attack more than once - if they're very lucky and don't suffer much damage, and haven't moved yet. Now, they would have a much better chance of having one or more move points left after the first maneuver or attack to actually get in an extra attack at full strength (and therefore a reasonable chance of success), rather than being crippled by damage after the first charge (as is often now the case) or faced with only fractional move points remaining with which to attack, withdraw, or fortify. It is easy to see that the current movement scheme could be exactly duplicated by setting road multiplier to 1x, and simply increasing all unit move rates and terrain move costs by a factor of 3x; the only difference would then be that all units would automatically gain multiple-attack capability. In any case, it would be up to the modpack author to ensure that some units are flagged as one attack per turn only as desired (most standard land units currently fit this class, but do not require a flag to specify them as such). The game engine currently allows any unit with even a fractional movement point remaining, to move into another tile; it may be necessary to add a check to ensure that any unit, that can move at all, is allowed to move at least one tile per turn, regardless of the tile move cost. This change would have no direct effect on sea or air unit movement. Thanx and Regards, VJSchiavoni ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40022) Diplomacy with dead AIs?
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40022 [EMAIL PROTECTED] - Wed Jan 16 01:39:44 2008]: Hello: I was just informed that my cease-fire with the Phoenicians had expired, and that I was now at war with them - not a problem, they've been dead since the turn after I met them. Could you please look into this, and perhaps disable changes to the diplomatic state for dead players (at least AIs), since there's no way to negotiate with them? Thanx and Regards, VJSchiavoni A couple of questions: On what version of Freeciv did you see this? Do you have a sample savegame? Are you still seeing it in recent versions? Best, ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40050) RE: FreeCic-2.1.3 client crash
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40050 [EMAIL PROTECTED] - Sat Jan 26 22:47:57 2008]: Hello: Just upgraded to FreeCiv-2.1.3 and civclient crashes with following message to stdout: [...] [EMAIL PROTECTED] ~]$ civclient -d 3 --tiles default [...] 3: The tileset doesn't specify prefered themes or none of prefered themes can be used. Using system default Segmentation fault [EMAIL PROTECTED] ~]$ [...] FreeCiv-2.1.3 w/default GTK client compiled from source code with no known warnings or errors of any kind and running on Fedora 7 Linux. Configure options used: CFLAGS=-O -g -pipe ./configure --prefix=/usr --disable-nls --with-gettext uname -a: Linux presario.localdomain 2.6.23.14-60.fc7 #1 SMP Mon Jan 14 22:14:17 EST 2008 i686 athlon i386 GNU/Linux gcc-4.1.2-27.fc7 (has worked flawlessly with all FreeCiv-2.1.x releases to date). Thanx and Regards, VJSchiavoni [EMAIL PROTECTED] Strange, this looks like the error when a theme is missing for the _SDL_ client. It shouldn't be happening with the GTK client. Can you still reproduce? Best, ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39568) cannot sell an improvement
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39568 [pepeto - Sun Jun 29 11:30:06 2008]: [EMAIL PROTECTED] - Dim. Jun. 29 07:41:05 2008]: pcity-owner is a player id not a pointer. So this patch does the trick. My patch was against S2_1, and there, pcity-owner is a pointer. I can verify that this has been fixed in S2_0 now. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40343) trunk fails to compile here too
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40343
[book - Sun Jun 29 18:36:10 2008]:
[EMAIL PROTECTED] - Sun Jun 29 16:57:24 2008]:
2008/6/29 Daniel Markstedt:
ld: Undefined symbols:
_gtk_image_clear
gtk_image_clear() seems to be gtk 2.8 feature. Either we have to
replace this call or to make 2.8 minimum gtk version.
This is on MacOSX 10.3.9, with GTK+ 2.6.8
I'll look into finding a compatible replacement for this
function.
Attached patch gets rid of the two calls to gtk_image_clear
by taking advantage of the fact that passing a NULL pixbuf
to gtk_image_set_from_pixbuf does the same thing.
--
しやすい
diff --git a/client/gui-gtk-2.0/editgui.c b/client/gui-gtk-2.0/editgui.c
index fd32851..b96b3df 100644
--- a/client/gui-gtk-2.0/editgui.c
+++ b/client/gui-gtk-2.0/editgui.c
@@ -1464,22 +1464,18 @@ static void editinfobox_refresh(struct editinfobox *ei)
pixbuf = get_brush_pixbuf();
}
+ gtk_image_set_from_pixbuf(GTK_IMAGE(ei-mode_image), pixbuf);
if (pixbuf) {
-gtk_image_set_from_pixbuf(GTK_IMAGE(ei-mode_image), pixbuf);
g_object_unref(pixbuf);
pixbuf = NULL;
- } else {
-gtk_image_clear(GTK_IMAGE(ei-mode_image));
}
pixbuf = get_tool_value_pixbuf(ett, value);
+ gtk_image_set_from_pixbuf(GTK_IMAGE(ei-tool_image), pixbuf);
if (pixbuf) {
-gtk_image_set_from_pixbuf(GTK_IMAGE(ei-tool_image), pixbuf);
g_object_unref(pixbuf);
pixbuf = NULL;
- } else {
-gtk_image_clear(GTK_IMAGE(ei-tool_image));
}
my_snprintf(buf, sizeof(buf), span weight=\bold\%s/span,
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40344) Empty space in main page.
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40344 Some change in my patch in #40184 (r14846) seems to have made a giant, annoying, useless space below the buttons in the main page. I have no idea why that is but I will investigate. :D -- なんじゃそれは！何となく狂わせる ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
