[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Update of bug #15388 (project freeciv): Category:None = client-gtk-2.0 Status:None = Ready For Test Assigned to:None = pepeto Release: = 2.2.0-RC1 Planned Release: = 2.2.1 ___ Follow-up Comment #1: Fix attached: also add debug message when switching client pages. (file #8143) ___ Additional Item Attachment: File name: trunk_S2_2_client_pages.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Update of bug #15388 (project freeciv): Category:None = client-gtk-2.0 Status:None = Ready For Test Assigned to:None = pepeto Release: = 2.2.0-RC1 Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Follow-up Comment #2, bug #15388 (project freeciv): Why cannot I change the fields of this item? ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15379] segfault if requirement not given as string
Update of bug #15379 (project freeciv): Status:None = Confirmed Release:2.2.0-RC = trunk Planned Release: = 2.3.0 ___ Follow-up Comment #2: This is invalid for the S2_2 branch, I get the following message: 0: sectionfile data/default/effects.ruleset entry 'effect_calendar_4.reqs0.name' doesn't contain a string ___ Reply to this item at: http://gna.org/bugs/?15379 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15379] segfault if requirement not given as string
Update of bug #15379 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Release:2.2.0-RC = trunk Planned Release: = 2.3.0 ___ Follow-up Comment #3: Fix attached: load the requirement name with any entry. (file #8144) ___ Additional Item Attachment: File name: trunk_ruleset_load_req_name_ext.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15379 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Update of bug #15377 (project freeciv): Release: = 2.0.10, 2.2.0 ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15356] Server crash with supplied scenarios (trunk)
Update of bug #15356 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.1, 2.3.0 ___ Follow-up Comment #1: Fix attached. Applicable on S2_2, even if it doesn't crash on that branch. (file #8145) ___ Additional Item Attachment: File name: trunk_S2_2_sg_player_slot_set_used.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?15356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15347] Bad drawing and floating point exception with trade route line drawing in SDL client
Update of bug #15347 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Release: = S2_1, S2_2, trunk Planned Release: = 2.1.12, 2.2.1 ___ Follow-up Comment #3: Algorithm fix attached. (file #8146) ___ Additional Item Attachment: File name: trunk_S2_2_S2_1_sdl_put_line.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15347 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15402] Make default leader names translateable
URL: http://gna.org/bugs/?15402 Summary: Make default leader names translateable Project: Freeciv Submitted by: None Submitted on: Wednesday 17/02/10 at 14:52 CET Category: client Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: sini.ruoho...@cs.helsinki.fi Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Re: translator list thread on the topic: It appears that there would be a point in making default ruler names translateable, since their spelling actually differs from one language to the other. For example: Atawallpa is Atahualpa and Mary Stuart is Maria Stuart in Finnish. Greek philosophers are also typical causes for mismatches, I seem to recall from English class. ;) Languages with Kyrillic, Greek and Arabic lettering and Japanese currently get the names as standard ascii English versions too. The difference is particularly noticeable in Arabic and Hebrew, where writing order is right to left. Having a left to right name in a middle of a right-to-left sentence makes things difficult to read. A major technical obstacle suspected to be on the way is for server commands interacting with leaders/players to be able to handle multi-byte characterers. You should be able to e.g. /take a player regardless of server locale, Translating all the strings is a practical obstacle as well, since the number of leader strings can be on the order of 1600. However, for many languages, most leader names aren't problematic to print as they are, and making them translateable definitely won't make the translations look any worse than they do, except possibly in statistics. If that's a serious enough issue, there's always the possibility of making separate language packages for freeciv-leaders, with their own stats. ;) Thanks to Daniel Markstedt, Yoav Luft and Juhani Heino for helpful comments. ___ Reply to this item at: http://gna.org/bugs/?15402 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-i18n] Making default ruler names translateable?
I'll follow the top-posting style for a final note: I finally got back from the world of work deadlines enough to submit a bug for this: http://gna.org/bugs/index.php?15402 I'd like to express my infinite relief that this bug submission did not require me to first create and mail-verify an account and read captchas, the user interface was quite sensible and all on one page, and the submission went through on first attempt. If it's this abnormally easy, I'm surprised Freeciv hasn't completely drowned in bug reports/feature requests/spam by now! ;) Best regards, --Sini On Mon, 2010-02-08 at 21:40 +0100, Daniel Markstedt wrote: Yes, it's correct that no leader names are currently marked for translation. If we want to go down this path and internationalize leader names, I can see at least one major technical and one major practical obstacle: First, we must make sure all server commands that interact with leaders/players are able to handle multi-byte characters. You must f.e. be able to '/take' a player regardless of server locale. Secondly, there's the practical matter of actually translating all these strings. In trunk we've just about hit the 200 mark for nations, with perhaps a mean of 8 leaders per nation. That makes for 1600 strings to translate, which is a hefty number IMO. That said, I agree that such a measure would certainly improve the quality of many localizations. Feel free to raise a bug at gna.org and we can take it from there. Daniel On Mon, Feb 8, 2010 at 12:47 PM, Yoav Luft yoav.l...@gmail.com wrote: It's really noticeable in Arabic and Hebrew, where writing order it right to left. Having a left to right name in a middle of a right-to-left sentence makes things a bit difficult to read, so it seems like a good idea to me. On Mon, Feb 8, 2010 at 11:31 AM, Sini Ruohomaa sini.ruoho...@cs.helsinki.fi wrote: Hi, It appears that there might be a point in making default ruler names translateable, since their spelling actually differs from one language to the other. I haven't glimpsed at an up-to-date po file in quite a few months so I assume they haven't become translateable just now. O:) For example: Atawallpa is Atahualpa and Mary Stuart is Maria Stuart in Finnish. Greek philosophers are also typical causes for mismatches, I seem to recall from English class. ;) I expect that languages with Kyrillic, Greek and Arabic lettering and Japanese currently get the names as standard ascii English versions too? Please keep the i18n list in cc for any translator-relevant replies. :) (Dunno if the message gets to -dev past spam protection even, since I'm not on the list.) --Sini PS. Thanks to Juhani Heino for pointing this out. ___ Freeciv-i18n mailing list freeciv-i...@gna.org https://mail.gna.org/listinfo/freeciv-i18n ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-i18n mailing list freeciv-i...@gna.org https://mail.gna.org/listinfo/freeciv-i18n ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Changes to gna bugs not sticking (was Re: [bug #15388] Cancelling connection when password requested does not return to main screen)
pepeto writes (in http://gna.org/bugs/?15388): Why cannot I change the fields of this item? I've been running into this too (e.g., changing the Release in http://gna.org/bugs/?15373). For me, the change appears to go ahead (green banner at the top), an entry goes in the bug history, the email goes out, but the actual field remains unchanged. In one case I found that changing fewer fields at a time worked (http://gna.org/bugs/?15319). This seems like a bug in gna. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15403] Wrong help text about trade route formula
URL: http://gna.org/bugs/?15403 Summary: Wrong help text about trade route formula Project: Freeciv Submitted by: pepeto Submitted on: mercredi 17.02.2010 à 14:26 Category: docs Severity: 3 - Normal Priority: 3 - Low Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_2, trunk Discussion Lock: Any Operating System: None Planned Release: ___ Details: The help text says: The initial revenue depends on the trade already produced by the two cities involved and their distance apart. According to changes and fixes in RT#38029 and bug #15092, the formula now doesn't depend of the trade output of the city: bonus = real_map_distance(pc1-tile, pc2-tile) + pc1-size + pc2-size; if (tile_continent(pc1-tile) != tile_continent(pc2-tile)) { bonus *= 2; } if (city_owner(pc1) == city_owner(pc2)) { bonus /= 2; } bonus /= 6; ___ Reply to this item at: http://gna.org/bugs/?15403 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold
Update of bug #15400 (project freeciv): Category:None = bootstrap Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?15400 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15402] Make default leader names translateable
Update of bug #15402 (project freeciv): Category: client = rulesets Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?15402 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15404] Save event log with featured text tags
Follow-up Comment #1, bug #15404 (project freeciv): Fix attached, it seems I am not able to change the fields of this item neither... :-( ___ Reply to this item at: http://gna.org/bugs/?15404 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15404] Save event log with featured text tags
Update of bug #15404 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?15404 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Update of bug #15388 (project freeciv): Release: = 2.2.0-RC1 Planned Release: = 2.1.12 ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Update of bug #15388 (project freeciv): Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15388] Cancelling connection when password requested does not return to main screen
Update of bug #15388 (project freeciv): Release: = 2.2.0-RC1 ___ Reply to this item at: http://gna.org/bugs/?15388 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15379] segfault if requirement not given as string
Update of bug #15379 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15379 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Changes to gna bugs not sticking (was Re: [bug #15388] Cancelling connection when password requested does not return to main screen)
Le mercredi 17 février 2010 à 14:19 +, Jacob Nevins a écrit : pepeto writes (in http://gna.org/bugs/?15388): Why cannot I change the fields of this item? I've been running into this too (e.g., changing the Release in http://gna.org/bugs/?15373). For me, the change appears to go ahead (green banner at the top), an entry goes in the bug history, the email goes out, but the actual field remains unchanged. In one case I found that changing fewer fields at a time worked (http://gna.org/bugs/?15319). This seems like a bug in gna. It seems the problem is linked with the Release field. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15305] memory leak in map_allocate
Update of bug #15305 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.1, 2.3.0 ___ Follow-up Comment #10: Fix attached for both trunk and S2_2: * initialize to NULL the pointers. * use correct indentation and line break style. (file #8150, file #8151) ___ Additional Item Attachment: File name: trunk_map_allocate_mem_leak.diff Size:5 KB File name: S2_2_map_allocate_mem_leak.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15305 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15406] Error messages when loading a savegame
URL: http://gna.org/bugs/?15406 Summary: Error messages when loading a savegame Project: Freeciv Submitted by: pepeto Submitted on: mercredi 17.02.2010 à 17:33 Category: general Severity: 2 - Minor Priority: 3 - Low Status: Ready For Test Assigned to: pepeto Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Also occurs with scenarios on trunk/. The error messages are from settings_game_load() which assume the file has all entries. Fix attached. ___ File Attachments: --- Date: mercredi 17.02.2010 à 17:33 Name: trunk_settings_game_load.diff Size: 2 ko By: pepeto http://gna.org/bugs/download.php?file_id=8152 ___ Reply to this item at: http://gna.org/bugs/?15406 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1301] [Metaticket] settings patch series
Update of patch #1301 (project freeciv): Summary: Metaticket: settings patch series = [Metaticket] settings patch series Depends on: = bugs #15406 ___ Reply to this item at: http://gna.org/patch/?1301 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Changes to gna bugs not sticking (was R e: [bug #15388] Cancelling connection when passw ord requested does not return to main screen)
Am Wednesday 17 February 2010 17:45:46 schrieb Pepeto: Le mercredi 17 février 2010 à 14:19 +, Jacob Nevins a écrit : pepeto writes (in http://gna.org/bugs/?15388): Why cannot I change the fields of this item? I've been running into this too (e.g., changing the Release in http://gna.org/bugs/?15373). For me, the change appears to go ahead (green banner at the top), an entry goes in the bug history, the email goes out, but the actual field remains unchanged. In one case I found that changing fewer fields at a time worked (http://gna.org/bugs/?15319). This seems like a bug in gna. It seems the problem is linked with the Release field. I can confirm this. In http://gna.org/bugs/?14944 I tried to change the settings and it only worked without the Release field. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15363] unable to compile gui-xaw with recent is_changeable change
Update of bug #15363 (project freeciv): Status:None = Ready For Test Assigned to:None = infyquest ___ Reply to this item at: http://gna.org/bugs/?15363 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15409] Text Strings not translated
URL: http://gna.org/bugs/?15409 Summary: Text Strings not translated Project: Freeciv Submitted by: None Submitted on: Thursday 02/18/10 at 00:54 CET Category: client Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: jor...@ubuntu:~/freeciv/S2_2/freeciv-2.2$ ./civ -a Unable to find client executable: freeciv Searching for freeciv clients ... ... using ./client/freeciv-gtk2 Running ./client/freeciv-gtk2 2: No está presente un controlador real de audio. 2: Se prosigue con el sonido desactivado. 2: Para el soporte de sonido, instala SDL_mixer 2: http://www.libsdl.org/projects/SDL_mixer/index.html This texts in English does not appear on the po files. ___ Reply to this item at: http://gna.org/bugs/?15409 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15410] Freeciv does not compile with --enable-debug=yes
URL: http://gna.org/bugs/?15410 Summary: Freeciv does not compile with --enable-debug=yes Project: Freeciv Submitted by: jorneg Submitted on: Thursday 02/18/10 at 00:07 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: mv -f .deps/sanitycheck.Tpo .deps/sanitycheck.Plo /bin/bash ../libtool --preserve-dup-deps --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../utility -I./../common -I./../ai -I../common/aicore -I./generator -I./scripting -DLOCALEDIR=\/usr/local/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv:/usr/local/share/freeciv\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Werror -g -O2 -MT savegame.lo -MD -MP -MF .deps/savegame.Tpo -c -o savegame.lo savegame.c gcc -DHAVE_CONFIG_H -I. -I.. -I../utility -I./../common -I./../ai -I../common/aicore -I./generator -I./scripting -DLOCALEDIR=\/usr/local/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv:/usr/local/share/freeciv\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Werror -g -O2 -MT savegame.lo -MD -MP -MF .deps/savegame.Tpo -c savegame.c -o savegame.o cc1: warnings being treated as errors savegame.c: En la función ‘game_load_internal’: savegame.c:4310: aviso: la dereferencia de punteros de tipo castigado romperá las reglas de alias estricto make[3]: *** [savegame.lo] Error 1 make[3]: se sale del directorio `/home/jorneg/freeciv/S2_2/freeciv-2.2/server' make[2]: *** [all-recursive] Error 1 make[2]: se sale del directorio `/home/jorneg/freeciv/S2_2/freeciv-2.2/server' make[1]: *** [all-recursive] Error 1 make[1]: se sale del directorio `/home/jorneg/freeciv/S2_2/freeciv-2.2' make: *** [all] Error 2 jor...@ubuntu:~/freeciv/S2_2/freeciv-2.2$ When you try to compile with --enable-debug=yes the last S2_2 branch appears and error... The error is aprox: the dereference of casted pointer types would break the strict alias rule... ___ Reply to this item at: http://gna.org/bugs/?15410 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15403] Wrong help text about trade route formula
Update of bug #15403 (project freeciv): Assigned to:None = jtn ___ Reply to this item at: http://gna.org/bugs/?15403 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15403] Wrong help text about trade route formula
Update of bug #15403 (project freeciv): Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15403 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15411] investigating foreign city shows all tiles unworkable
URL: http://gna.org/bugs/?15411 Summary: investigating foreign city shows all tiles unworkable Project: Freeciv Submitted by: anbe Submitted on: Thursday 02/18/2010 at 01:51 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_2 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Hi, investigating a foreign city with a spy shows all tiles with a thick red border as unworkable. This is not what I would expect. A partial screenshot is attached. Andreas ___ File Attachments: --- Date: Thursday 02/18/2010 at 01:51 Name: citymap-spy-all-red-borders.png Size: 34kB By: anbe http://gna.org/bugs/download.php?file_id=8154 ___ Reply to this item at: http://gna.org/bugs/?15411 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15403] Wrong help text about trade route formula
Update of bug #15403 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: The patch attached: * Corrects the wrong description noted by jorneg and pepeto. * Mentions the 'trademindist' server option. * Explicitly describes how the double bonus from different civilizations is balanced by only getting the benefit from one end (per discussion in bug #15092). This will change two translateable strings. (file #8155) ___ Additional Item Attachment: File name: S2_2-trade-route-help-fix.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15403 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15403] Wrong help text about trade route formula
Follow-up Comment #2, bug #15403 (project freeciv): Actually, now I come to read pepeto's comment, it quotes The initial revenue depends on the trade already produced by the two cities. This is still true (I checked); it's not a problem for city refresh without side effects as it only happens once. The issue reported by jorneg on -i18n, about the ongoing revenue, is the one I've fixed; that indeed no longer depends on trade. ___ Reply to this item at: http://gna.org/bugs/?15403 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15412] Duff assertion in city_unit_unhappiness()
URL: http://gna.org/bugs/?15412 Summary: Duff assertion in city_unit_unhappiness() Project: Freeciv Submitted by: jtn Submitted on: Thursday 18/02/10 at 01:27 Category: None Severity: 2 - Minor Priority: 1 - Later Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.2.0-RC1 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Code looks like: int city_unit_unhappiness(..., int *free_unhappy) { ... if (... || !free_unhappy || ...) { return 0; } assert(free_unhappy = 0); ... } The assertion will probably never fire since it's the pointer being compared to 0, not its contents, so this is harmless. (Unless there's some platform where likely pointers look like negative numbers in such a comparison, in which case it'll fire spuriously.) Attached patch fixes to presumed intent. ___ File Attachments: --- Date: Thursday 18/02/10 at 01:27 Name: S2_2-free_unhappy-assertion.diff Size: 393B By: jtn http://gna.org/bugs/download.php?file_id=8156 ___ Reply to this item at: http://gna.org/bugs/?15412 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15409] Text Strings not translated
Follow-up Comment #1, bug #15409 (project freeciv): This is included in the civ script, so I doubt this should be translated and maybe it's not translatable at all... ___ Reply to this item at: http://gna.org/bugs/?15409 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15410] Freeciv does not compile with --enable-debug=yes
Update of bug #15410 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: The error is: dereferencing type-punned pointer will break strict-aliasing rules; I don't get it personally. Patches attached, could you test it? (file #8158, file #8159) ___ Additional Item Attachment: File name: trunk_savegame_compile_fix.diff Size:0 KB File name: S2_2_savegame_compile_fix.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?15410 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15411] investigating foreign city shows all tiles unworkable
Follow-up Comment #1, bug #15411 (project freeciv): I think the red borders indicate that you (as your player) has no access to these tiles (but the city owner has). It should be similar if your own cities have tiles worked by another city. ___ Reply to this item at: http://gna.org/bugs/?15411 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev