Re: [Freeciv-Dev] [bug #13599] [RFC; patch] pollution on lakes / ocean

I've started working on generalizing tile specials before school started, but now I hardly find time to sleep. Hopefully, when semester will end I'll get back into it. On Wed, Apr 14, 2010 at 4:05 PM, pepeto wrote: > > Update of bug #13599 (project freeciv): > >                Priority:          

[Freeciv-Dev] [patch #1574] add a player to a running game

Follow-up Comment #15, patch #1574 (project freeciv): This version of newcomers.sav works anyway. This version tries to create settlers and attack units to match the currently alive nations.. something similar to the newcomers code. (file #8974) __

[Freeciv-Dev] [patch #1616] add create_player lua function

Follow-up Comment #2, patch #1616 (project freeciv): It works well on testing (except not returning the player, but you can get the player variable back from other places of course). A comment on a very small thing: in the api_actions.[ch] files, all type names use the API typedefs, Nation_Type

[Freeciv-Dev] [patch #1574] add a player to a running game

Follow-up Comment #14, patch #1574 (project freeciv): create_player returns NULL, because the player-creating commands (newcomer and pregame) only take struct player *, not struct player ** arguments that are needed to be able to "write the pointer back" to the caller. __

[Freeciv-Dev] [patch #1629] cleanup struct unit

Follow-up Comment #1, patch #1629 (project freeciv): Using FC_FREE() is quite useless when you don't use the pointer after (e.g. at the end of a scope). FC_FREE() is not really a freeciv wrapper for free(), it's almost a macro of the client SDL to set the pointer to NULL. I personally doesn't lik

[Freeciv-Dev] [patch #1630] cleanup struct player

Follow-up Comment #1, patch #1630 (project freeciv): About _enum player_status_: * You should comment the values where the enumeration is defined, if someone adds a value, not sure he will find where this is commented. * Are you sure those values handle correctly all player possible states? Is it

[Freeciv-Dev] [bug #15881] Can't read the number of settings in the save file

Update of bug #15881 (project freeciv): Status: Confirmed => Ready For Test Assigned to:None => pepeto ___ Follow-up Comment #1: Fix attached. (f

[Freeciv-Dev] [patch #1616] add create_player lua function

Follow-up Comment #1, patch #1616 (project freeciv): add the possibility to select a nation (file #8969) ___ Additional Item Attachment: File name: 20100414-06-trunk-add-create_player-lua-function.patch Size:12 KB

[Freeciv-Dev] [bug #15881] Can't read the number of settings in the save file

URL: Summary: Can't read the number of settings in the save file Project: Freeciv Submitted by: pepeto Submitted on: mercredi 14.04.2010 à 22:11 Category: general Severity: 2 -

[Freeciv-Dev] [patch #1630] cleanup struct player

etails: ___ File Attachments: --- Date: Mittwoch 14.04.2010 um 23:48 Name: 20100414-03-trunk-cleanup-struct-player.patch Size: 24kB By: syntron <http://gna.org/patch/download.php?fil

[Freeciv-Dev] [patch #1574] add a player to a running game

nal Item Attachment: File name: 20100414-05-trunk-add-a-player-to-a-running-game.patch Size:16 KB ___ Reply to this item at: <http://gna.org/patch/?1574> ___ Nachricht geschickt von/dur

[Freeciv-Dev] [patch #1629] cleanup struct unit

etails: ___ File Attachments: --- Date: Mittwoch 14.04.2010 um 23:47 Name: 20100414-02-trunk-cleanup-struct-unit.patch Size: 96kB By: syntron <http://gna.org/patch/download.php?fil

[Freeciv-Dev] [patch #1601] [Metaticket] Scripting/API extension towards iteration and querying for newcomers

Update of patch #1601 (project freeciv): Depends on: => patch #1626 ___ Reply to this item at: ___ Meddelande

[Freeciv-Dev] [patch #1627] API: create_unit_full

URL: Summary: API: create_unit_full Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 21:09 Category: None Priority: 5 - Normal St

[Freeciv-Dev] [patch #1628] API: find.transport_unit(player, unit_type, tile)

URL: Summary: API: find.transport_unit(player, unit_type, tile) Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 21:09 Category: None Priority: 5 -

[Freeciv-Dev] [patch #1626] API: Player:knows_tech(..) and Unit_Type:can_exists_at_tile(..)

URL: Summary: API: Player:knows_tech(..) and Unit_Type:can_exists_at_tile(..) Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 21:00 Category: None

[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline

Update of patch #1494 (project freeciv): Depends on: => patch #1601 ___ Reply to this item at: ___ Meddelande

[Freeciv-Dev] [patch #1601] [Metaticket] Scripting/API extension towards iteration and querying for newcomers

Update of patch #1601 (project freeciv): Summary: [Metaticket] Scripting/API extension towards iteration and querying => [Metaticket] Scripting/API extension towards iteration and querying for newcomers ___ Reply to this

[Freeciv-Dev] [patch #1574] add a player to a running game

Follow-up Comment #12, patch #1574 (project freeciv): Attaching a later version of the newcomers scenario file. This version uses some new functions, just to check that there are no tiles or units close where we put the newcomer. I have other patches for create_unit_full and some other things ne

[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)

Update of bug #15586 (project freeciv): Status: Fixed => In Progress Open/Closed: Closed => Open ___ Follow-up Comment #5: A month wiser, I w

[Freeciv-Dev] [bug #15878] freeciv-server.desktop freeciv.desktop

Update of bug #15878 (project freeciv): Category:None => bootstrap Severity: 3 - Normal => 2 - Minor Priority: 1 - Later => 5 - Normal Assigned to:

[Freeciv-Dev] [bug #15878] freeciv-server.desktop freeciv.desktop

URL: Summary: freeciv-server.desktop freeciv.desktop Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 16:07 Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'

Follow-up Comment #2, patch #1611 (project freeciv): Committed to SVN revs r17341 (trunk) and r17342 (S2_2) ___ Reply to this item at: ___ Meddelandet skickades

[Freeciv-Dev] [bug #15857] Fix buggy find_transport_from_tile

Update of bug #15857 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #3: This fixes some th

[Freeciv-Dev] [bug #15860] Fix compiler warning in tolua-5.1

Update of bug #15860 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'

Update of patch #1611 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security

Update of bug #15725 (project freeciv): Depends on: => patch #1621 ___ Reply to this item at: ___ Meddelandet

[Freeciv-Dev] [patch #1621] API: [2.2] Protect string arguments with SCRIPT_ASSERT

Update of patch #1621 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities

Follow-up Comment #6, patch #1617 (project freeciv): Yet another version. To be consistent across save/load we have to restore even 'Nonexistent' values. Also removing the script_is_exported_object_valid function. It is mostly for debugging. Patches for trunk and 2.2 (file #8956, file #8957)

[Freeciv-Dev] [bug #15876] API: Lua part of runtime to be shipped in Freeciv data directory

URL: Summary: API: Lua part of runtime to be shipped in Freeciv data directory Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 13:23 Category: general

[Freeciv-Dev] [bug #14236] bases claiming territory

Update of bug #14236 (project freeciv): Severity: 2 - Minor => 1 - Wish Priority: 5 - Normal => 1 - Later ___ Reply to this item at:

[Freeciv-Dev] [bug #14095] GTK-gui goes under taskbar

Update of bug #14095 (project freeciv): Status:None => Confirmed ___ Follow-up Comment #2: I have the same problem since I bought a new monitor. There is a client option to arrange widge

[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security

Follow-up Comment #2, bug #15725 (project freeciv): To clarify the last comment: We hide '.get', but the tolua runtime will use it to look up object fields. This will be type safe, unlike direct access to the ".get" table. We remove '.set', so the tolua runtime will not allow writing back objec

[Freeciv-Dev] [bug #13812] Two bug trackers?

Update of bug #13812 (project freeciv): Priority: 5 - Normal => 1 - Later ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension

Update of bug #13803 (project freeciv): Priority: 5 - Normal => 3 - Low ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension

Update of bug #13803 (project freeciv): Status: Postponed => In Progress Assigned to: mbook => None Planned Release: => 2.3.0 _

[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security

Follow-up Comment #1, bug #15725 (project freeciv): Here is a plan: No unsafe functions (should be done) No NULL pointers and no wild pointers (in progress): 1. We check arguments everywhere. Script functions should try to assure success or raise a script error. 2. Debug module hidden to disall

[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension

Update of bug #13803 (project freeciv): Depends on: => bugs #13793 ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #13599] [RFC; patch] pollution on lakes / ocean

Update of bug #13599 (project freeciv): Priority: 5 - Normal => 1 - Later ___ Follow-up Comment #4: Before implementing this, shouldn't we make the tile special a part of the ruleset? _

[Freeciv-Dev] [bug #15816] add a comment about a needed empty line in the nation.ruleset file

Update of bug #15816 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15807] assert in player_invention_state() [tech.c::129]

Update of bug #15807 (project freeciv): Status: Need Info => Ready For Test Assigned to:None => pepeto ___ Follow-up Comment #6: > The old code spe