[Freeciv-Dev] [bug #18993] Bug in swiss.ruleset?

Follow-up Comment #1, bug #18993 (project freeciv): The flag name in the nation ruleset corresponds to a name in data/misc/{flags,flags-large}.spec, not the flag filename (the mapping to real filenames is in the flags spec files). So I don't think this is a bug. (Plus, I checked and the Swiss fl

[Freeciv-Dev] [bug #18980] destroying city/fortress makes tile neutral for a turn

Update of bug #18980 (project freeciv): Summary: destroying fortress makes tile neutral => destroying city/fortress makes tile neutral for a turn ___ Follow-up Comment #3: Hm. Hadn't thought of that. The same thing happe

[Freeciv-Dev] [bug #18687] Server timeouts >60 hours do not cause client update

Follow-up Comment #10, bug #18687 (project freeciv): (Chattiness raised separately as bug #19004.) ___ Reply to this item at: ___ Message sent via/by Gna! htt

[Freeciv-Dev] [bug #19004] Messages generated at LOG_NORMAL when using optional network capabilities

Update of bug #19004 (project freeciv): Status: In Progress => Ready For Test Release: => 2.3.0 ___ Additional Item Attachment: File name: t

[Freeciv-Dev] [bug #19004] Messages generated at LOG_NORMAL when using optional network capabilities

URL: Summary: Messages generated at LOG_NORMAL when using optional network capabilities Project: Freeciv Submitted by: jtn Submitted on: Wed Nov 16 01:06:17 2011 Category: general

[Freeciv-Dev] Optimizing /save (I failed)

My sparc64 502mhz is taking 4 minutes now to /save a game. I tried poor mans optimization and inlined a couple of functions. I tested it on a 8x3400mhz intel i7. The test .serv was loading the game, and saving it 10 times. I managed to only go down to 11.76 from 13.56 seconds, that's not very much.

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

Follow-up Comment #20, bug #18776 (project freeciv): Thanks for the analyses! Could you test the attached patch? It does not use player_count() but a new function player_slot_max_used_number() which returns the highest used player slot index. Thus, there should be enough memory be allocated. (fi

[Freeciv-Dev] [patch #3041] Make gtk3-client really gtk3-program

Update of patch #3041 (project freeciv): Status:None => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On Tue, Nov 15, 2011 at 10:11:58PM +0200, Marko Lindqvist wrote: > On 15 November 2011 21:52, Michal Mazurek wrote: > > a ruleset I download from dubious sources does > > not, from it's script.lua, run a file i already have on my filesystem, > > that's nasty. Even though it could just contain it,

[Freeciv-Dev] [patch #3049] gui_interface.[ch]

Update of patch #3049 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On 15 November 2011 22:48, Matthias Pfafferodt wrote: > > If you plan to continue to support S2_3, I think it would be easier to rebase > all longturn patches to S2_4 and do one patch which changes the network > protocol to be compatible to S2_3. ... > I attached a file with the diff between S2

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On 15 November 2011 21:52, Michal Mazurek wrote: > a ruleset I download from dubious sources does > not, from it's script.lua, run a file i already have on my filesystem, > that's nasty. Even though it could just contain it, You consider all files already in your system something that everyone

[Freeciv-Dev] [patch #3057] Rename default ai as classic

URL: Summary: Rename default ai as classic Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Nov 2011 10:00:00 PM EET Category: ai Priority: 5 - Normal

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On Tue, Nov 15, 2011 at 07:11:10PM +0100, Matthias Pfafferodt wrote: > > In S2_3 there is only lua that executes a line of lua code. There is no > > functionality to load a file, I'll try to backport it to my repo > > tomorrow. > > > > > > Frankly, I dont understand how that helps with security.

Re: [Freeciv-Dev] Moving Longturn patches to Lua

Am Dienstag, 15. November 2011, 11:26:49 schrieb Michal Mazurek: > On Mon, Nov 14, 2011 at 09:40:51PM +0100, Matthias Pfafferodt wrote: > > missed an important thing: > > > > The needed patches are only in S2_4 and trunk; you have to pick svn20274- > > sv20277 and svn20286-svn20296. These patches

Re: [Freeciv-Dev] Moving Longturn patches to Lua

> > > Why can't i dofile() in freeciv? > > > > The usage of such commands is restricted due to security implications. > > You can not load a lua file! Only default.lua and script.lua are read. > > Or you have to use the command 'lua file <...>' (I think it is named > > luafile in S2_3). > > In S2

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On Tue, Nov 15, 2011 at 06:27:31PM +0100, Matthias Pfafferodt wrote: > Am Dienstag, 15. November 2011, 10:59:47 schrieb Michal Mazurek: > > On Mon, Nov 14, 2011 at 10:09:56AM +0100, Michal Mazurek wrote: > > > Can i have other files than the default.lua and script.lua? I want each > > > functionali

[Freeciv-Dev] [patch #3043] Comparisons "< trait_end()" -> "!= trait_end()"

Update of patch #3043 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

Re: [Freeciv-Dev] Moving Longturn patches to Lua

Am Dienstag, 15. November 2011, 10:59:47 schrieb Michal Mazurek: > On Mon, Nov 14, 2011 at 10:09:56AM +0100, Michal Mazurek wrote: > > Can i have other files than the default.lua and script.lua? I want each > > functionality (auth, newcomers) to be in a separate file. > > I added dofile("longturn.

[Freeciv-Dev] [bug #18781] /save - strips everything from dot to eol

Follow-up Comment #3, bug #18781 (project freeciv): > For normal users it is OK if the savegame is saved in the > standard dirs I don't think this report has anything to do with directories. It's security feature that you cannot escape from savedirs, but this seem like everything after dot is co

[Freeciv-Dev] [bug #18855] gtk client, cities window, units supported

Follow-up Comment #3, bug #18855 (project freeciv): I agree with Jacob. I dont really care for food spent on settlers, as long as the food column is >= 0, or happiness caused specifically by military units as long as the city is not in uprise, but shields/gold upkeep is most useful.

[Freeciv-Dev] [bug #18843] The setting 'trading_city' can't be modified after the game has started.

Follow-up Comment #2, bug #18843 (project freeciv): I think the admin with access to the console should be able to change everything that is possible to be changed. I mean Freeciv is open source, a cheating admin can always change one flag and be able to change trading_city.

[Freeciv-Dev] [bug #18781] /save - strips everything from dot to eol

Follow-up Comment #2, bug #18781 (project freeciv): I don't understand how this helps with security. Is it supposed to prevent escaping from a save directory? ___ Reply to this item at:

[Freeciv-Dev] [patch #3056] Requirement vector for roads

Update of patch #3056 (project freeciv): Depends on: => patch #3055 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #3056] Requirement vector for roads

URL: Summary: Requirement vector for roads Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Nov 2011 04:43:00 PM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

Follow-up Comment #19, bug #18776 (project freeciv): The allocated table is not always of constant size: +verbose+ int lines = player_count()/32 + 1; --- ./player.c:640: int player_count(void) ./player.c:641: { ./player.c:642: return player_slots.used_slots; ./player.c:643: } +verbose+ Should

[Freeciv-Dev] [bug #18922] Server address binding fails

Follow-up Comment #12, bug #18922 (project freeciv): > I've retested things and came to conclusion that it's indeed > malloc->calloc change that's essential for making things work. One would assume that *either* of your changes would fix the problem in your particular case (either zeroing struct

[Freeciv-Dev] [bug #19001] Client crash when planning goto for immobile unit

URL: Summary: Client crash when planning goto for immobile unit Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Nov 2011 04:19:19 PM EET Category: client Severity: 3

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On Mon, Nov 14, 2011 at 09:40:51PM +0100, Matthias Pfafferodt wrote: > missed an important thing: > > The needed patches are only in S2_4 and trunk; you have to pick svn20274- > sv20277 and svn20286-svn20296. These patches do not change the network > interface. Thus, they should be easily be back

Re: [Freeciv-Dev] Moving Longturn patches to Lua

On Mon, Nov 14, 2011 at 10:09:56AM +0100, Michal Mazurek wrote: > Can i have other files than the default.lua and script.lua? I want each > functionality (auth, newcomers) to be in a separate file. I added dofile("longturn.lua") to script.lua. This is what i got: 1: lua error: data/longtu