[Freeciv-Dev] [patch #3452] Qt science report small fix
Follow-up Comment #2, patch #3452 (project freeciv): Hmm, right, I thought I solved that. Ok I added to that patch blocking signals while updating combo boxes and now is solved. (file #16244) ___ Additional Item Attachment: File name: QtSciUpdateUpdated.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?3452 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3460] Qt Revolution Menu - Confiramtion dialog
URL: http://gna.org/patch/?3460 Summary: Qt Revolution Menu - Confiramtion dialog Project: Freeciv Submitted by: mir3x Submitted on: Mon 30 Jul 2012 10:12:39 AM CEST Category: client-qt Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Changed behavior when selecting target government directly for asking for confirm first ___ File Attachments: --- Date: Mon 30 Jul 2012 10:12:39 AM CEST Name: RevolutionMenuFix.patch Size: 760B By: mir3x http://gna.org/patch/download.php?file_id=16245 ___ Reply to this item at: http://gna.org/patch/?3460 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3444] Ruleset defined trade% for each trade route type
Update of patch #3444 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3444 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3461] Disallow establishing trade routes with zero % trade income completely
URL: http://gna.org/patch/?3461 Summary: Disallow establishing trade routes with zero % trade income completely Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 12:33:00 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Having traderoute with 0 % trade makes no sense. Disallow establishing one - protect player who does not know what (s)he is doing. ___ File Attachments: --- Date: Mon 30 Jul 2012 12:33:00 PM EEST Name: DisallowZeropctTrade.patch Size: 628B By: cazfi http://gna.org/patch/download.php?file_id=16246 ___ Reply to this item at: http://gna.org/patch/?3461 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19778] National border colours on main map not ideal, e.g. green vs grassland, white vs glacier
Update of bug #19778 (project freeciv): Category: client = None Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19778 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19997] Changes to Lithuanian translation lost
Update of bug #19997 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19997 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3462] Separate metaserver version tag for Windows installer builds
URL: http://gna.org/patch/?3462 Summary: Separate metaserver version tag for Windows installer builds Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 03:08:50 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 ___ Details: Since Windows installer often gets built only after (source) release, latest Win Installer version is not same as latest freeciv release. Attached patch gives Win Installer builds version tag of its own on metaserver so user is not told about new version until build exist. ___ File Attachments: --- Date: Mon 30 Jul 2012 03:08:50 PM EEST Name: Win32Followtag.patch Size: 502B By: cazfi http://gna.org/patch/download.php?file_id=16247 ___ Reply to this item at: http://gna.org/patch/?3462 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3463] List language names in Win Installer po-file list
URL: http://gna.org/patch/?3463 Summary: List language names in Win Installer po-file list Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 03:25:20 PM EEST Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 ___ Details: This uses language names list that will be added in patch #3456 to display names of languages instead of just names of po-files in Windows installer list. This is just the low-hanging-fruit part of bug #19087 to improve language selection quickly (before 2.4.0-beta1). Listing language names also in default-language dropdown menu would be harder, so it's not part of this patch. ___ File Attachments: --- Date: Mon 30 Jul 2012 03:25:20 PM EEST Name: Win32InstLangnames.patch Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=16248 ___ Reply to this item at: http://gna.org/patch/?3463 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19087] Slicker language selection in Windows installer
Follow-up Comment #3, bug #19087 (project freeciv): The most easiest part handled in patch #3463 ___ Reply to this item at: http://gna.org/bugs/?19087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20005] Compile time decided database.lua location Windows installations
URL: http://gna.org/bugs/?20005 Summary: Compile time decided database.lua location Windows installations Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 05:46:57 PM EEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: There's conflict in how database.lua is expected strict compile time set location, and how SW to Windows is installed to user-selected location. Crosser builds do worse than that - they expect database.lua in directory used in build system while building. That's simple misuse of --prefix instead of DESTDIR in my build environment, should be easy to fix. ___ Reply to this item at: http://gna.org/bugs/?20005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20006] Server option -a help says -D required, but omitting one is considered error
URL: http://gna.org/bugs/?20006 Summary: Server option -a help says -D required, but omitting one is considered error Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 06:16:04 PM EEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: ./fcser --help ... -a, --authEnable server authentication (requires --Database). ... ./fcser -a starts without any complains, not even This freeciv-server program has player authentication support, but it's currently not in use. like invocation without -a ___ Reply to this item at: http://gna.org/bugs/?20006 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20006] Server option -a help says -D required, but omitting one is not considered error
Update of bug #20006 (project freeciv): Summary: Server option -a help says -D required, but omitting one is considered error = Server option -a help says -D required, but omitting one is not considered error ___ Reply to this item at: http://gna.org/bugs/?20006 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3464] Make it possible to use database.lua from srcdir in --enable-debug builds
URL: http://gna.org/patch/?3464 Summary: Make it possible to use database.lua from srcdir in --enable-debug builds Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 06:52:48 PM EEST Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: If there's no outcry against, I'll look in to implenting $subject. Though srcdir/data is one of freeciv datadirs, it's much safer to look explicitly from it than the old, now obsoleted, method of looking from *any* datadir. Looking directly from srcdir/data means that database.lua installed (possibly by malicious intent) to higher priority datadir will not be used. freeciv-modpack will not install anything to srcir/data, but to user's homedir. There *is* the possibility that someone manually unzips modpack with modified database.lua to srcdir/data. Anyway, we already accept that --enable-debug produces builds making freeciv developer's life easier at the cost of less security (those running --enable-debug builds are expected to know what they do) ___ Reply to this item at: http://gna.org/patch/?3464 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20007] script_fcdb_init() calls luascript_destroy(NULL)
URL: http://gna.org/bugs/?20007 Summary: script_fcdb_init() calls luascript_destroy(NULL) Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 07:23:44 PM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I don't know if this harmful or not, but certainly looks suspicious. script_fcdb.c:196 checks that fcl certainly is NULL, and then calls luascript_destroy(fcl) Also, there's shadowing of module wide static variable fcl in some of the functions in this file. Shadowing should be avoided (I remember that we used to get compiler warning about it, wondering why it's not accepted) ___ Reply to this item at: http://gna.org/bugs/?20007 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3465] Add comments, quotation, for AC_DEFINEs
URL: http://gna.org/patch/?3465 Summary: Add comments, quotation, for AC_DEFINEs Project: Freeciv Submitted by: cazfi Submitted on: Mon 30 Jul 2012 08:42:16 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Add comment parameter for all AC_DEFINEs currently missing one. Add complete quotation. ___ File Attachments: --- Date: Mon 30 Jul 2012 08:42:16 PM EEST Name: CommentQuoteAcDefine.patch Size: 16kB By: cazfi http://gna.org/patch/download.php?file_id=16249 ___ Reply to this item at: http://gna.org/patch/?3465 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3450] Base flag (bit) to draw owner flag (gfx)
Update of patch #3450 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3450 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3432] Core nation group
Follow-up Comment #10, patch #3432 (project freeciv): Is it possible to have 'extended' civil war nations spawn in a core nations game? If not then maybe it would be a good solution to add some non-core nations as non-playable nations to the core set, giving every core nation at least one related civil war nation. A game with only core nations would allow for an Algerian nation in the game; it shouldn't appear when picking an nation, but it could appear in case a civil war hits the French (and/or Arabs). The Spanish come up a lot... maybe they should be in the extras? (I'm sure they've been in at least one commercial Civ.) It seems I missed the Spanish... they should be in of course. earth-160x90-v2.sav: 24/30 in core Missing: Gallic, British, Inuit, Papuan, Cambodian, Manchu. Gallic could be represented by Celtic, British by English and Cambodian by Khmer. Polynesian could serve as a replacement for Papuan. I'm not sure about Inuit and Manchu; some Native American nation and Hunnic would be options. north_america_116x100-v1.2.sav: 9/12 Missing: Spanish, Scottish, Irish. Scottish or Irish could be represented by Celtic. ___ Reply to this item at: http://gna.org/patch/?3432 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3447] map_claim_base()
Follow-up Comment #2, patch #3447 (project freeciv): This patch (transitional state it produces) has some chicken-and-egg design problems with territory claiming bases. Though the version I finally submitted avoided (in a hackish way - code recurses more than it needs to, but changes between rounds make it to avoid infinite recursion) most obvious problems, I now think that it doesn't work correctly when tile has multiple bases. When the recursion causes other bases to change owner, tile is already owned by new owner and as tile owner is in this transtional phase used as base owner, new owner is considered old base owner - base is not cleared from real old owner, and as it seems like base is not changing hands at all, some base capturing stuff is skipped too. ___ Reply to this item at: http://gna.org/patch/?3447 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3449] Nation sets: initial cut-down implementation for 2.4.x
Follow-up Comment #7, patch #3449 (project freeciv): Then we'll take all nations not in that union set out of consideration, before assigning random nations, and remember that criterion for in-game nation assignment too (e.g. civil war). So, by default (nobody choosing their nations) this limitation is core set of about 50 nations. What happens if 45 players start a game and more than five of them would suffer civil war. Does it work similar to available nations limit in that civil war just never happen when all nations are already in use? ___ Reply to this item at: http://gna.org/patch/?3449 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3449] Nation sets: initial cut-down implementation for 2.4.x
Follow-up Comment #8, patch #3449 (project freeciv): Does it work similar to available nations limit in that civil war just never happen when all nations are already in use? No; for 2.4, with file #16237 applied, then the sixth civil war will cause the restriction to be limited and a non-core nation will appear. For the proposed long-term solution for 2.5+ (patch #3448), it would behave as you say. ___ Reply to this item at: http://gna.org/patch/?3449 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3455] Enable Refugee/Migrant art in Amplio/Amplio2 tilespecs for civ2civ3 / civ2-3
Update of patch #3455 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3455 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3453] metaserver.phtml - metaserver.php
Update of patch #3453 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3453 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20008] Tileset priority not respected
URL: http://gna.org/bugs/?20008 Summary: Tileset priority not respected Project: Freeciv Submitted by: cazfi Submitted on: Tue 31 Jul 2012 01:06:20 AM EEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Commenting out default_tileset_name from freeciv-client-2.5 causes client to start with amplio (and not amplio2) tileset (this is, of course, running from svn checkout where amplio is present). amplio2's priority is 30, and amplio's priority 20, so the priority is not working as expected. ___ Reply to this item at: http://gna.org/bugs/?20008 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20008] Tileset priority not respected
Follow-up Comment #1, bug #20008 (project freeciv): 1. First client gets list of possible default_tile_name values with get_tileset_list() that does not care about priority at all - I assume it returns them in alphabetical order. 2. First value from that list is assigned as initial default_tile_name value. 3. tilespec_try_read() would assign tileset by priority if there's no tileset selected, but as assignment in 2) makes it seems like user has selected amplio, it doesn't override that decision. ___ Reply to this item at: http://gna.org/bugs/?20008 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org
URL: http://gna.org/task/?7606 Summary: Setup freeciv 2.4 files in modpack.freeciv.org Project: Freeciv Submitted by: cazfi Submitted on: Tue 31 Jul 2012 01:38:55 AM EEST Should Start On: Tue 31 Jul 2012 12:00:00 AM EEST Should be Finished on: Thu 09 Aug 2012 12:00:00 AM EEST Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Percent Complete: 0% Assigned to: cazfi Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: ___ Details: modpack.freeciv.org should be ready to serve 2.4 freeciv-modpack when server URL changes to one pointing there with first beta release. ___ Reply to this item at: http://gna.org/task/?7606 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7603] Tracking release 2.4.0-beta1
Update of task #7603 (project freeciv): Depends on: = task #7606 ___ Reply to this item at: http://gna.org/task/?7603 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
