[Freeciv-Dev] [bug #21154] Conflicting definitions of ferry
Update of bug #21154 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: Attached patch introduced function dai_is_ferry() to unify the checks. - Unit needs to be able to move on (some) oceanic terrains, but it does not need to be is_sailing_unit() - experimental ruleset triremes are considered ferries - Unit needs to be able to transport some unit otherwise restricted to land terrains - Carriers are not considered ferries. I don't think this is an reggression in any way, as old code was broken for them anyway. I don't think this can be easily easily fixed - likely to remain that way in stable branches. (file #19065, file #19066) ___ Additional Item Attachment: File name: IsFerry.patch Size:6 KB File name: IsFerry-S2_4.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?21154 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4199] Make trying an illegal action cost a bit movement
Update of patch #4199 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4199 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4203] Add meta knowledge for unittype and player range government
Update of patch #4203 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4203 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19087] Slicker language selection in Windows installer
Follow-up Comment #4, bug #19087 (project freeciv): And the main problem: - Works only with English locale when every .po file has at least 2 (=plural) of each of translated, fuzzy, and untranslated strings. This is due to very fragile method of parsing msgmsrg --stat output. Even if we fix it to work with current version of gettext, it would depend on gettext output strings never to change... I'm not actually so worried about that. This only needs to absolutely work on the system of the person who builds the distribution tarballs (me, currently). I think if we force the locale for this command to C or en_US or something, and make the parsing script paranoid and bail out if it sees any text it doesn't completely understand how to parse, the risk of gettext's output changing under our feet is acceptably small as to be managed by the release manager doing a trial make dist run after major system upgrades / before committing to a new release. (Of course if there's a better way to get stats in machine-readable format without awkward dependencies, I'm interested.) This is going to want revisiting with the split of po-files in patch #4190. I think the desired outcome is that the installer includes stats for both core strings and extended nations (e.g., Faroese (fo): core game translation 100% complete, extended nations 36% complete). ___ Reply to this item at: http://gna.org/bugs/?19087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4190] [Metaticket] Split translations to multiple po-files
Follow-up Comment #3, patch #4190 (project freeciv): We might need to think about how to minimise disruption to the workflow of those translators who are happy to keep up with all nations. (But maybe I'm over-engineering this, so I welcome feedback from translators about whether they care, as it is extra work for us :) In particular, splitting by source file means there's a small set of strings that will be duplicated: leader titles. I haven't checked how many that'll be, but I'm sure there'll be some. * When we developers make update-po for release, I think we should canonicalise by propagating any duplicates by using each po-file as a compendium for the other (or something like that), so if Speaker %s is translated in one but not the other it'll end up in both (and conflicts will hopefully be spotted). * Translators who choose to work with two separate po-files can make their own arrangements to spot duplicates. * I think we should consider continuing to support translators working with a single po-file (but would welcome feedback from translators if they care about this, since it's a bit of work for us). We could arrange that automatically-generated combined po-files end up on cazfi.net, and when we receive a combined po-file we can split it back into individual translations for commit. In fact... if we were to go to that effort, we could equally well keep the combined files in svn as the canonical po-files (there's no technical need for separate catalogues to end up in binary packages, after all), and do the splitting at the translator interface: offer split po-files at cazfi.net, post stats on split files, etc. (The notion of splitting would still need to be reflected in our automake infrastructure to some extent, for bug #19087 if nothing else.) Changing what nations belong to core group later (when actively maintained translation is already in split form) will probably be painful. Patch #3448 (which I am still slowly picking away and and hope to get in 2.5) will also make it painful, as assumptions about which nations are part of the core group will end up embedded in save files and cause disruption if a nation is removed from core and an old savefile is loaded with nationset=core but mentioning the old nation. Added freeciv-i18n to cc of this ticket. I don't think that'll work, sadly, as the From: line of emails from Gna is not a list member. (I don't see comment #2 on -i18n, anyway.) ___ Reply to this item at: http://gna.org/patch/?4190 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3448] Nation sets: allow set of nations that will ever appear in-game to be chosen
Follow-up Comment #5, patch #3448 (project freeciv): I am still working on this, s-l-o-w-l-y. I still hope to get it in 2.5, and it does change the network protocol. ___ Reply to this item at: http://gna.org/patch/?3448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21155] City settings for new citizens
URL: http://gna.org/bugs/?21155 Summary: City settings for new citizens Project: Freeciv Submitted by: None Submitted on: Sun Sep 22 14:24:38 2013 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: The city settings for new citizens do not more work as expected. General behaviour: If a city has no governor and grows, or if the user double-clicks on the city centre in the mini-map, the citizens are automatically reset for an optimal output. Some citizens will be entertainers (= produce happiness) to balance unhappy citizens. Other citizens work on tiles to produce food, shields, or trade points. Old behaviour: All remaining citizens worked as entertainers, scientists, or taxmen determined per city by the settings for new citizen. The default entertainer was rather dubious. New behaviour (introduced before 2.3.4): All remaining citizens work as scientists. The settings for new citizens is ignored. This is typically better than the old behaviour; it is not more necessary to change the default entertainer to scientist for each city. However, after researching everything, scientists are less interesting than taxmen, and changing the settings for new citizens to taxmen does not more work as expected. Suggested fixes: (1) Revert to the old behaviour with a new default scientists instead of entertainers. (2) Replace the old per city settings for new citizens by global settings, with a default scientists. Players could then simply switch to taxmen or entertainers for new citizens in all cities. ___ Reply to this item at: http://gna.org/bugs/?21155 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4207] Steal Tech to action enabler framework
URL: http://gna.org/patch/?4207 Summary: Steal Tech to action enabler framework Project: Freeciv Submitted by: sveinung Submitted on: Sun 22 Sep 2013 04:29:00 PM GMT Category: general Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: * Split in two actions, one optionally targeted (used to depend on the Spy flag) and one untargeted. * Move the restriction that one can't use a spy to steal from barbarians to the rule set. * Still same text on targeted and untargeted version. Should this change? ___ File Attachments: --- Date: Sun 22 Sep 2013 04:29:00 PM GMT Name: action_enabler_steal_tech.patch Size: 21kB By: sveinung http://gna.org/patch/download.php?file_id=19067 ___ Reply to this item at: http://gna.org/patch/?4207 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4207] Steal Tech to action enabler framework
Update of patch #4207 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Rename the targeted tech stealing Industrial espionage in the UI in case both are possible at the same time. (file #19068) ___ Additional Item Attachment: File name: action_enabler_steal_tech.patch Size:20 KB ___ Reply to this item at: http://gna.org/patch/?4207 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4208] Add Expel Embassy, use action enabler framework
URL: http://gna.org/patch/?4208 Summary: Add Expel Embassy, use action enabler framework Project: Freeciv Submitted by: sveinung Submitted on: Sun 22 Sep 2013 06:37:38 PM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: See comment 1 in patch #4204 ___ Reply to this item at: http://gna.org/patch/?4208 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer
Update of bug #21144 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21144 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4209] Make Investigate City use the action enabler frame work
URL: http://gna.org/patch/?4209 Summary: Make Investigate City use the action enabler frame work Project: Freeciv Submitted by: sveinung Submitted on: Sun 22 Sep 2013 09:07:01 PM GMT Category: general Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Sun 22 Sep 2013 09:07:01 PM GMT Name: action_enabler_investigate_city.patch Size: 9kB By: sveinung http://gna.org/patch/download.php?file_id=19070 ___ Reply to this item at: http://gna.org/patch/?4209 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4205] Configure time check of compatible mixer
Update of patch #4205 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4196] README.graphics booleans documentation
Update of patch #4196 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4196 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4210] Store base sprites to extras-wide structure
URL: http://gna.org/patch/?4210 Summary: Store base sprites to extras-wide structure Project: Freeciv Submitted by: cazfi Submitted on: Mon 23 Sep 2013 01:37:36 AM EEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Replace bases sprite array with extras sprite array. The only indexes populated are still bases. ___ File Attachments: --- Date: Mon 23 Sep 2013 01:37:36 AM EEST Name: BaseExtraSprites.patch Size: 8kB By: cazfi http://gna.org/patch/download.php?file_id=19071 ___ Reply to this item at: http://gna.org/patch/?4210 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4211] tile_extra_rm_apply()
URL: http://gna.org/patch/?4211 Summary: tile_extra_rm_apply() Project: Freeciv Submitted by: cazfi Submitted on: Mon 23 Sep 2013 01:57:29 AM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add function tile_extra_rm_apply() that's like counter-function for tile_extra_apply() - it removes extra recursively so that anything depending on the extra gets removed too. Use that function in editor code instead of removing just the extra marked for the removal by the client, and in case of specials, instead of tile_remove_special(). Remove tile_remove_special() completely as it was for specials only, and with the dependency rules hardcoded to it. ___ File Attachments: --- Date: Mon 23 Sep 2013 01:57:29 AM EEST Name: TileExtraRmApply.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=19072 ___ Reply to this item at: http://gna.org/patch/?4211 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
