[Freeciv-Dev] [bug #21718] Can't steal tech without embassy
Follow-up Comment #3, bug #21718 (project freeciv): Both patches are in the git patch format (so they should work with git am). I have a slight preference for alternative 2 since it avoids any regressions. Alternative 1 is there in case saving work when the Freeciv svn version is updated is more important. ___ Reply to this item at: http://gna.org/bugs/?21718 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4540] Second pack of Oceanian unknowns nations: Marshall and Cook Islands
URL: http://gna.org/patch/?4540 Summary: Second pack of Oceanian unknowns nations: Marshall and Cook Islands Project: Freeciv Submitted by: None Submitted on: lun 24 feb 2014 10:55:48 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@otmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: ___ File Attachments: --- Date: lun 24 feb 2014 10:55:48 UTC Name: marshallese.ruleset Size: 905B By: None http://gna.org/patch/download.php?file_id=20170 --- Date: lun 24 feb 2014 10:55:48 UTC Name: cookislander.ruleset Size: 841B By: None http://gna.org/patch/download.php?file_id=20171 --- Date: lun 24 feb 2014 10:55:48 UTC Name: Marshall.svg Size: 1kB By: None http://gna.org/patch/download.php?file_id=20172 --- Date: lun 24 feb 2014 10:55:48 UTC Name: Cook.svg Size: 1kB By: None http://gna.org/patch/download.php?file_id=20173 ___ Reply to this item at: http://gna.org/patch/?4540 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4541] third and last oceanian duet: Tuvalu and the Mariana Islands
URL: http://gna.org/patch/?4541 Summary: third and last oceanian duet: Tuvalu and the Mariana Islands Project: Freeciv Submitted by: None Submitted on: lun 24 feb 2014 11:49:14 UTC Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: paf...@otmail.com Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: ___ File Attachments: --- Date: lun 24 feb 2014 11:49:14 UTC Name: tuvaluan.ruleset Size: 1kB By: None http://gna.org/patch/download.php?file_id=20174 --- Date: lun 24 feb 2014 11:49:14 UTC Name: marianaislander.ruleset Size: 1kB By: None http://gna.org/patch/download.php?file_id=20175 --- Date: lun 24 feb 2014 11:49:14 UTC Name: Tuvalu.svg Size: 2kB By: None http://gna.org/patch/download.php?file_id=20176 --- Date: lun 24 feb 2014 11:49:14 UTC Name: MarianaIslands.svg Size: 74kB By: None http://gna.org/patch/download.php?file_id=20177 ___ Reply to this item at: http://gna.org/patch/?4541 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4528] Gtk clients: Show the probability that a spy action will be successful
Update of patch #4528 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4528 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4529] Add success probability for the spy action investigate city.
Update of patch #4529 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4529 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4539] Take into account if the target player has anything to steal
Follow-up Comment #1, patch #4539 (project freeciv): tech_can_be_taken() checks if game.info.tech_trade_allow_holes, but stealing a tech is not trading them. I don't know if you need to make allow_holes a parameter to generic tech_can_be_taken(), or do you need to rename it so that it's clear that it applies to stealing only, and then have game.info.tech_steal_allow_holes there. ___ Reply to this item at: http://gna.org/patch/?4539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4539] Take into account if the target player has anything to steal
Follow-up Comment #2, patch #4539 (project freeciv): Do you have any ideas to improve handling of already-stolen-from-this-city -case? It's quite user-unfriendly that one just has to remember where he has already stolen a tech. Don't know if the current feature that one cannot know if some third party has stolen tech from a city is important to keep. ___ Reply to this item at: http://gna.org/patch/?4539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4542] Music Style
URL: http://gna.org/patch/?4542 Summary: Music Style Project: Freeciv Submitted by: cazfi Submitted on: Mon 24 Feb 2014 07:42:24 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add Music Style framework: - Music styles are read from styles.ruleset to in-memory structures - They are passed to client Music styles consist of music tags for each mood, and requirements vector for making them active. All supplied rulesets have only one music style thta has no requirements at all. ___ File Attachments: --- Date: Mon 24 Feb 2014 07:42:24 PM EET Name: MusicStyle.patch Size: 17kB By: cazfi http://gna.org/patch/download.php?file_id=20178 ___ Reply to this item at: http://gna.org/patch/?4542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4539] Take into account if the target player has anything to steal
Follow-up Comment #3, patch #4539 (project freeciv): tech_can_be_taken() checks if game.info.tech_trade_allow_holes, but stealing a tech is not trading them. Thank you, Marko. New version renames tech_can_be_taken() to tech_can_be_stolen() and use game.info.tech_steal_allow_holes. If needed it can be generalized to take allow_holes later. Do you have any ideas to improve handling of already-stolen-from-this-city -case? No, not yet. The reason I wrote this patch before having a full solution was to fix bug #21718. It's quite user-unfriendly that one just has to remember where he has already stolen a tech. I'll keep this in mind when looking for a full solution. (file #20179) ___ Additional Item Attachment: File name: 0006-Take-into-account-if-the-target-player-has-any-techs.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?4539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21718] Can't steal tech without embassy
Follow-up Comment #4, bug #21718 (project freeciv): New version of alternative 2 that include the new version of patch #4539. (file #20180) ___ Additional Item Attachment: File name: 0001-Alternative-2.patch Size:17 KB ___ Reply to this item at: http://gna.org/bugs/?21718 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Freeciv Github test
I did a test-migration from svn to github here: https://github.com/freeciv/freeciv-test This was done using svn2git: https://github.com/nirvdrum/svn2git https://help.github.com/articles/importing-from-subversion Feel free to test it out. The actual migration process was quite quick and easy to perform. I have not yet migrated all the users, branches and tags, but I just wanted to test out github for Freeciv to see what people thought about it first. Regards, Andreas On Sat, 22 Feb 2014, Marko Lindqvist wrote: On 22 February 2014 10:05, Andreas Røsdal andre...@pvv.ntnu.no wrote: Also, what do you think of moving Freeciv development from svn to github.com/freeciv? The only thing changed since this was discussed last time ( http://forum.freeciv.org/f/viewtopic.php?f=13t=160 ) is that now we have initial version of --enable-gitrev feature. For myself the roadmap would be to switch from plain svn to git-svn (setup my workflow to work with git that way) and then the master repository to switch from svn to git, but during all the years this has been in my TODO there has been virtually no progress. At some point I were thinking that it could be part of facelift to bump freeciv version number to 3.x, but we'll see. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Git (was: Freeciv-Web Project.)
Andreas Røsdal writes: Also, what do you think of moving Freeciv development from svn to github.com/freeciv? For me, integration with the ticket tracker is the dealbreaker. It is still painful having lost our RT history; I'm not not willing to lose our history again (or linkage to the VCS) without a very good reason. Otherwise I would generally be in favour of the main Freeciv repository being in Git; enough of us are using git-svn as it is. For one thing, I'd be more likely to actually review patches before commit if I could pull them from Git and view/test them in context. A possible downside is that we might lose translators who are used to svn and aren't up for learning a new VCS. I believe a version of Savane supports Git, but not the version installed on Gna. If that were ever fixed we might be able to keep our history but change our VCS, but I'm not holding my breath. (I vaguely poked #gna about this, and someone on #gna said something vaguely positive, but I wasn't entirely sure of their future plans.) Due to the above issues, I've not bothered to form an opinion about whether Github is a suitable project host. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption
Update of bug #21409 (project freeciv): Status:None = In Progress Assigned to:None = jtn ___ Follow-up Comment #4: Here's a proof of concept patch (for trunk) that makes the size penalty visible in the client. It still needs some work before becoming a commit candidate: * Autogame testing, since it has the potential to break the waste calculation. * Currently it shows up when you click on an output type, alongside Corruption, Trade routes, etc. But the Corruption entry on the city dialog is still not accounted for in this way, which is a bit annoying. That would benefit from becoming clickable and having a proper breakdown of corruption effects (Courthouses, etc) under a separate ticket. If/when that happens, the size penalty should move there, and the city output breakdown should just say corruption (with size penalty being understood to be a form of corruption, and is referred to as such in too many places in the UI to change). (file #20181) ___ Additional Item Attachment: File name: trunk-notradesize-corruption-ui-wip.patch Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?21409 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Freeciv Github test
Looks good to me. On Tue, Feb 25, 2014 at 1:35 AM, Andreas Røsdal andre...@pvv.ntnu.nowrote: I did a test-migration from svn to github here: https://github.com/freeciv/freeciv-test This was done using svn2git: https://github.com/nirvdrum/svn2git https://help.github.com/articles/importing-from-subversion Feel free to test it out. The actual migration process was quite quick and easy to perform. I have not yet migrated all the users, branches and tags, but I just wanted to test out github for Freeciv to see what people thought about it first. Regards, Andreas On Sat, 22 Feb 2014, Marko Lindqvist wrote: On 22 February 2014 10:05, Andreas Røsdal andre...@pvv.ntnu.no wrote: Also, what do you think of moving Freeciv development from svn to github.com/freeciv? The only thing changed since this was discussed last time ( http://forum.freeciv.org/f/viewtopic.php?f=13t=160 ) is that now we have initial version of --enable-gitrev feature. For myself the roadmap would be to switch from plain svn to git-svn (setup my workflow to work with git that way) and then the master repository to switch from svn to git, but during all the years this has been in my TODO there has been virtually no progress. At some point I were thinking that it could be part of facelift to bump freeciv version number to 3.x, but we'll see. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21668] Ferry stats not updated when unit changes type
Update of bug #21668 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21668 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4542 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4518] menu_music_enable_callback()
Update of patch #4518 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4518 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4520] Hard rule to prevent extra unambigiuous with terrain change
Update of patch #4520 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #1: Problem: This checks extra cause to determine if we're trying to build irrigation extra instead of irrigation terrain transformation, or to build mining extra instead mining terrain transformation. Result is not guaranteed to tell the activity currently planned, as extra can have multiple causes. We may return FALSE for some other activity simply because it would be impossible to irrigate the extra into existence. ___ Reply to this item at: http://gna.org/patch/?4520 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4539] Take into account if the target player has anything to steal
Follow-up Comment #4, patch #4539 (project freeciv): Do you have any ideas to improve handling of already-stolen-from-this-city -case? Yes. - the defender should receive the same information as the attacker. Currently only the attacker is told you have already-stolen-from-this-city. ___ Reply to this item at: http://gna.org/patch/?4539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4520] Hard rule to prevent extra unambigiuous with terrain change
Update of patch #4520 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: Make targeted fix to next_extra_for_tile() where the activity being planned is known instead. (file #20182) ___ Additional Item Attachment: File name: NextIrrigationMineTransformTile.patch Size:0 KB ___ Reply to this item at: http://gna.org/patch/?4520 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4534] Mood
Follow-up Comment #2, patch #4534 (project freeciv): http://forum.freeciv.org/f/viewtopic.php?f=14t=242#p1478 ___ Reply to this item at: http://gna.org/patch/?4534 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4534] Mood
Follow-up Comment #3, patch #4534 (project freeciv): - Updated against svn (file #20183) ___ Additional Item Attachment: File name: Mood-2.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?4534 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
