[Freeciv-Dev] [patch #4943] Single-veteran-level level name

2014-07-14 Thread Jacob Nevins
Follow-up Comment #2, patch #4943 (project freeciv): Ah, the comments say that freeciv never displays that name anyway, so green is just less work for translators. Indeed. Hopefully the comments are correct. This was a result of (bug #20023) (as recently amended).

[Freeciv-Dev] [bug #21629] civ2 - barb cities can't build anything due to waste

2014-07-14 Thread Jacob Nevins
Follow-up Comment #13, bug #21629 (project freeciv): in a game of Civ2 Test of Time [...] Apparently, barb cities have no waste at all but almost max corruption Note that since bug #22271, it is much harder to end up without a palace (unless 'savepalace' is off), and that includes barbarians.

[Freeciv-Dev] [bug #22308] civ2civ3: help claims fortresses/airbases can't be built on rivers

2014-07-14 Thread Jacob Nevins
Update of bug #22308 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22318] Nation translation domain not read properly by client

2014-07-14 Thread Jacob Nevins
Update of bug #22318 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4818] classic/experimental/multiplayer: set HasNoZOC on non-military units (Explorers, etc)

2014-07-14 Thread Jacob Nevins
Update of patch #4818 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22302] City map UI broken with init_city_radius_sq =15 in version 2.5

2014-07-14 Thread Jacob Nevins
Update of bug #22302 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22167] River listed under Terrain Alterations in help

2014-07-14 Thread Jacob Nevins
Update of bug #22167 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4935] Set HasNoZOC on some air units: AWACS, missiles, and bombers

2014-07-14 Thread Jacob Nevins
Update of patch #4935 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #2: Slightly more

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/patch/?4949 Summary: [Metaticket] Get rid of massive switch-cases Project: Freeciv Submitted by: cazfi Submitted on: Mon 14 Jul 2014 11:17:00 AM EEST Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4942] Set S2_5 follow tag to S2_5 for duration of betas/RCs (and trunk to S2_6)

2014-07-14 Thread Jacob Nevins
Update of patch #4942 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Summary: Set S2_5 follow tag to S2_5 for duration of betas/RCs = Set S2_5 follow tag to

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-07-14 Thread Jacob Nevins
Follow-up Comment #1, patch #4759 (project freeciv): After patch #4942, this should also update trunk's DEFAULT_FOLLOW_TAG to S3_0. ___ Reply to this item at: http://gna.org/patch/?4759 ___

[Freeciv-Dev] [patch #4950] National culture effects

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/patch/?4950 Summary: National culture effects Project: Freeciv Submitted by: cazfi Submitted on: Mon 14 Jul 2014 11:18:36 AM EEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4944] Want techs for direct effect value

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #1, patch #4944 (project freeciv): Base want needs to be moved outside the effects iteration loop - it currently adds it once for each effect provided by the tech, i.e., base want is multiplied by the number of effects. Still, for performance reasons, even base want should not

[Freeciv-Dev] [patch #4951] new nation Austria-Hungary

2014-07-14 Thread Wu Ti
URL: http://gna.org/patch/?4951 Summary: new nation Austria-Hungary Project: Freeciv Submitted by: kangxi Submitted on: Mon 14 Jul 2014 10:57:03 AM UTC Category: freeciv-web Priority: 9 - Immediate

Re: [Freeciv-Dev] [bug #21881] Wrong flags

2014-07-14 Thread J
Hi J. M. Maalderink, do you have any news on the flag of Manchuria? We communicated about correcting it. Thank you. - Wu Ti On Wednesday, April 30, 2014 2:24 PM, J altai...@yahoo.com wrote: Hi J. M. Maalderink,   your proposals sound fine to me. Thank you. From: J.M.

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-07-14 Thread Emmet Hikory
Follow-up Comment #1, patch #4949 (project freeciv): Modern optimising compilers sometimes compile into a branch table, which is precisely as efficient as an array of pointers to pointers to functions (so nearly, but not quite as efficient as an array of pointers to functions), but this isn't

Re: [Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

2014-07-14 Thread Vasco Alexandre da Silva Costa
Using function pointers is seldom a good idea. Also what will you do if the function calls take different parameters? On Mon, Jul 14, 2014 at 9:17 AM, Marko Lindqvist no-reply.invalid-addr...@gna.org wrote: URL: http://gna.org/patch/?4949 Summary: [Metaticket] Get rid of

[Freeciv-Dev] [bug #22339] Threaded AI log spamming

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22339 Summary: Threaded AI log spamming Project: Freeciv Submitted by: cazfi Submitted on: Mon 14 Jul 2014 11:40:09 PM EEST Category: ai Severity: 3 - Normal

[Freeciv-Dev] [bug #22339] Threaded AI log spamming

2014-07-14 Thread Marko Lindqvist
Update of bug #22339 (project freeciv): Planned Release: = 2.5.0-beta1, 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?22339 ___ Message sent

[Freeciv-Dev] [bug #22339] Threaded AI log spamming

2014-07-14 Thread Marko Lindqvist
Update of bug #22339 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Fix (file #21419) ___ Additional Item

[Freeciv-Dev] [bug #22311] Threaded AI mishandles NoBonus road types

2014-07-14 Thread Marko Lindqvist
Update of bug #22311 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #22320] Lua compilation tries to use _setjmp() when configure has only checked _longjmp()

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #2, bug #22320 (project freeciv): S2_5 version (file #21420) ___ Additional Item Attachment: File name: _SetJmpCheck-S2_5.patchSize:1 KB ___ Reply to

[Freeciv-Dev] [bug #22340] Barbarians get palace

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22340 Summary: Barbarians get palace Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 12:34:31 AM EEST Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #22341] Lua script calling has_base crashes freeciv

2014-07-14 Thread Jeffrey C. Jacobs
URL: http://gna.org/bugs/?22341 Summary: Lua script calling has_base crashes freeciv Project: Freeciv Submitted by: timehorse Submitted on: Mon 14 Jul 2014 09:41:57 PM UTC Category: general Severity: 5 -

[Freeciv-Dev] [bug #22341] Lua script calling has_base crashes freeciv

2014-07-14 Thread Jeffrey C. Jacobs
Additional Item Attachment, bug #22341 (project freeciv): File name: freeciv-T1429-Y03004-quitidle.sav.bz2 Size:722 KB ___ Reply to this item at: http://gna.org/bugs/?22341 ___ Message

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

2014-07-14 Thread Emmet Hikory
Update of patch #4934 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4938] Consolidate server precalcs and cache population

2014-07-14 Thread Emmet Hikory
Update of patch #4938 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4939] Use const for more sorts of requirement checks

2014-07-14 Thread Emmet Hikory
Update of patch #4939 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22319] Experimental ruleset Triremes can't move up rivers on trunk

2014-07-14 Thread Emmet Hikory
Update of bug #22319 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4937] Really assert tech is in valid range

2014-07-14 Thread Emmet Hikory
Update of patch #4937 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #21950] Game crash with popup message Exhausted city and unit numbers!

2014-07-14 Thread Marko Lindqvist
Update of bug #21950 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #21550] Make function of timeout / off label in UI more obvious somehow

2014-07-14 Thread Marko Lindqvist
Update of bug #21550 (project freeciv): Planned Release: 2.4.3, 2.5.0-beta1, 2.6.0 = 2.4.3, 2.5.0-beta2, 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?21550 ___ Message

[Freeciv-Dev] [patch #4951] new nation Austria-Hungary

2014-07-14 Thread Marko Lindqvist
Update of patch #4951 (project freeciv): Category: freeciv-web = rulesets Priority: 9 - Immediate = 5 - Normal Assigned to:None = mixcoatl

[Freeciv-Dev] [bug #22297] Road move_time = -1 doesn't get to client correctly

2014-07-14 Thread Marko Lindqvist
Update of bug #22297 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #22342] Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role]

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22342 Summary: Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role] Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 01:14:15 AM EEST Category:

[Freeciv-Dev] [bug #22342] Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role]

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #1, bug #22342 (project freeciv): I suspect patch #4938 that moved code to set up unit roles ( call to role_unit_precalcs(); ) ___ Reply to this item at: http://gna.org/bugs/?22342

[Freeciv-Dev] [patch #4816] civ2civ3: ZoCs not affected by non military units.

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #3, patch #4816 (project freeciv): - Updated against svn, but untested at the moment (since civ2civ3 ruleset does not load for other reasons) (file #21422) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #22034] Cannot build Irrigation and Mine simultaneously

2014-07-14 Thread Marko Lindqvist
Update of bug #22034 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4925] Alien ruleset with single Makefile.am

2014-07-14 Thread Marko Lindqvist
Update of patch #4925 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #22342] Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role]

2014-07-14 Thread Emmet Hikory
Update of bug #22342 (project freeciv): Status:None = In Progress Assigned to:None = persia ___ Reply to this item at:

[Freeciv-Dev] [bug #22340] Barbarians get palace

2014-07-14 Thread Jacob Nevins
Follow-up Comment #1, bug #22340 (project freeciv): in stable branches we need to hardcode it so that barbarians (any barbarian type) do not get initial buildings? This would be relatively easy: transfer_city() now has a build_free argument, which unit_enter_city() could conditionalise on

[Freeciv-Dev] [bug #22342] Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role]

2014-07-14 Thread Emmet Hikory
Update of bug #22342 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: The crash was caused by processing settings stored in game.ruleset: the settings validation code

[Freeciv-Dev] [bug #22342] Some supplied rulesets failing to load assertion 'index = 0 index n_with_role[role]

2014-07-14 Thread Emmet Hikory
Update of bug #22342 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22343] server.got_first_city sanity check fails

2014-07-14 Thread Jordi Negrevernis i Font
URL: http://gna.org/bugs/?22343 Summary: server.got_first_city sanity check fails Project: Freeciv Submitted by: jorneg Submitted on: dl 14 jul 2014 23:27:57 UTC Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #22340] Barbarians get palace

2014-07-14 Thread Emmet Hikory
Follow-up Comment #2, bug #22340 (project freeciv): A possible narrative justification for a player getting a free Palace in their first city, regardless of how acquired: Civilisation properly begins when a people sets aside a nomadic lifestyle for an urban lifestyle organised around one or more

[Freeciv-Dev] [bug #22343] server.got_first_city sanity check fails

2014-07-14 Thread Jacob Nevins
Update of bug #22343 (project freeciv): Planned Release: = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #1: Darn. I added that assertion in bug #22271. Do you have a savegame from which you can reproduce

[Freeciv-Dev] [bug #21437] Autosettlers ignoring special resources (mining hills without coal when coal is available)

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #10, bug #21437 (project freeciv): - Apply WORKER_FACTOR to value of improving currently unworked tiles (file #21424) ___ Additional Item Attachment: File name: TwoModeAutosettlers-2.patchSize:6 KB

[Freeciv-Dev] [bug #22343] server.got_first_city sanity check fails

2014-07-14 Thread Jordi Negrevernis i Font
Follow-up Comment #2, bug #22343 (project freeciv): Yep.. The previous savegame. (file #21425) ___ Additional Item Attachment: File name: freeciv-T0293-Y01818-auto.sav.bz2 Size:257 KB

[Freeciv-Dev] [patch #4952] Two-mode-workers for threaded AI

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/patch/?4952 Summary: Two-mode-workers for threaded AI Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 04:11:01 AM EEST Category: ai Priority: 5 - Normal

[Freeciv-Dev] [bug #22344] City owner not checked when worker task received from threaded AI

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22344 Summary: City owner not checked when worker task received from threaded AI Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 04:29:01 AM EEST Category: ai

[Freeciv-Dev] [patch #4953] Worker count stats from advdata to aidata

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/patch/?4953 Summary: Worker count stats from advdata to aidata Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 05:14:54 AM EEST Category: ai Priority: 5 - Normal

[Freeciv-Dev] [patch #4954] Build threaded AI to Windows Installer build

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/patch/?4954 Summary: Build threaded AI to Windows Installer build Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 05:39:52 AM EEST Category: general Priority: 5 -

[Freeciv-Dev] [bug #22345] adv_follow_path() loses activity target

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22345 Summary: adv_follow_path() loses activity target Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 05:46:13 AM EEST Category: ai Severity: 3 - Normal

[Freeciv-Dev] [bug #22345] adv_follow_path() loses activity target

2014-07-14 Thread Marko Lindqvist
Update of bug #22345 (project freeciv): Status: In Progress = Ready For Test Planned Release: 2.6.0 = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #1: Fix I'm not sure if

[Freeciv-Dev] [bug #22346] assertion '((void *)0) != punitclass-cache.native_tile_extras' failed

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22346 Summary: assertion '((void *)0) != punitclass-cache.native_tile_extras' failed Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 07:40:15 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [bug #22347] helptext_building() - is_nation_pickable(): assertion '!is_server()' failed

2014-07-14 Thread Marko Lindqvist
URL: http://gna.org/bugs/?22347 Summary: helptext_building() - is_nation_pickable(): assertion '!is_server()' failed Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Jul 2014 07:43:06 AM EEST Category: general