[Freeciv-Dev] [bug #22345] adv_follow_path() loses activity target

2014-07-22 Thread Marko Lindqvist
Update of bug #22345 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #22377] Alien ruleset: Savegames with cities are broken

2014-07-22 Thread Marko Lindqvist
Follow-up Comment #4, bug #22377 (project freeciv): specialist contains a space. This breaks saving. Certainly the bug is that saving gets broken for a legal (by expectation, and as far as any doucumentation goes) specialist name. Raised bug #22378

[Freeciv-Dev] [bug #22375] Unable to load test saved state

2014-07-22 Thread pepeto
Update of bug #22375 (project freeciv): Status:None = Wont Fix ___ Follow-up Comment #3: Reading the attached files. You used svn trunk version for saving the game. But the saving

[Freeciv-Dev] [bug #22079] AI settler doesn't consider base defense bonus when picking city spot

2014-07-22 Thread pepeto
Update of bug #22079 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4912] Server wants us to remove unit id xxxx, but we don't know about this unit!

2014-07-22 Thread pepeto
Follow-up Comment #3, patch #4912 (project freeciv): Fixed missed-placed send_unit_info() in unit_move() + reworked the part to remove test duplicates. (file #21506, file #21507) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #22380] Cannot jump from transport to another transport

2014-07-22 Thread pepeto
URL: http://gna.org/bugs/?22380 Summary: Cannot jump from transport to another transport Project: Freeciv Submitted by: pepeto Submitted on: mar. 22 juil. 2014 12:31:04 CEST Category: general Severity: 3 -

[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions

2014-07-22 Thread Emmet Hikory
Follow-up Comment #11, bug #22187 (project freeciv): Would also need patch #3900 (and follow-up bugfixes there), and possibly more (depending on dependencies found following that stack). I think it's probably relatively safe to leave this unimplemented for S2_5. The AI may try to disembark

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

2014-07-22 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?22381 Summary: Inconsistent nativity limits on source tile for regular attacks Project: Freeciv Submitted by: sveinung Submitted on: Tue 22 Jul 2014 12:18:46 PM UTC Category: None

[Freeciv-Dev] [bug #22378] Specialist name with space breaks savegames

2014-07-22 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, bug #22378 (project freeciv): A check that a specialist rule name is usable in a save game is added in patch #4972. _Savegame format freeze probably makes actual fix for this impossible in stable branches_ What if we replace unacceptable characters in the rulename before

[Freeciv-Dev] [patch #4970] Better path-finding reverse maps

2014-07-22 Thread Emmet Hikory
Follow-up Comment #3, patch #4970 (project freeciv): I prefer symbols to magic numbers, but agree -1 isn't PF_IMPOSSIBLE_MC in this case. Thanks for the explanation on attack cost. Everything else in this patch looked good, so please consider me not to have objected at all.

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

2014-07-22 Thread Emmet Hikory
Follow-up Comment #1, bug #22381 (project freeciv): This is a bit complicated. For the source tile in unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be better. For the destination tile, we may need a new test (or to refactor the existing ones), because UTYF_TRIREME

[Freeciv-Dev] [bug #22375] Unable to load test saved state

2014-07-22 Thread Jeffrey C. Jacobs
Follow-up Comment #4, bug #22375 (project freeciv): Thanks! Changing capital to got_first_city worked and I couldn't figure out how to specify a boolean true so I'll know for future it's a C-style TRUE, all caps. ___ Reply to this item

[Freeciv-Dev] [patch #4973] Utility for iterating transporters/cargo of a unit

2014-07-22 Thread pepeto
URL: http://gna.org/patch/?4973 Summary: Utility for iterating transporters/cargo of a unit Project: Freeciv Submitted by: pepeto Submitted on: mar. 22 juil. 2014 19:02:17 CEST Category: general Priority:

[Freeciv-Dev] [bug #22317] Path-finding unable to handle recursive transports restrictions

2014-07-22 Thread pepeto
Update of bug #22317 (project freeciv): Depends on: = patch #4973 ___ Reply to this item at: http://gna.org/bugs/?22317 ___ Message posté

[Freeciv-Dev] [bug #22317] Path-finding unable to handle recursive transports restrictions

2014-07-22 Thread pepeto
Update of bug #22317 (project freeciv): Status:None = Ready For Test Operating System:None = Any ___ Follow-up Comment #3: Patch ready for

[Freeciv-Dev] [bug #22273] Add action to the Unit UserData as a property and method

2014-07-22 Thread Marko Lindqvist
Follow-up Comment #2, bug #22273 (project freeciv): I can't find where direction8_invalid is installed so I don't know how to write activity_invalid()! :( It's generated by specenum preprocessor macros. See utility/specenum_gen.h ___

[Freeciv-Dev] [bug #22363] Zero value effect evaluation zeroes total value of improvement

2014-07-22 Thread Marko Lindqvist
Update of bug #22363 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4974] dai_effect_value() to return single effect value

2014-07-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?4974 Summary: dai_effect_value() to return single effect value Project: Freeciv Submitted by: cazfi Submitted on: Wed 23 Jul 2014 12:54:18 AM EEST Category: ai Priority: 5 -

[Freeciv-Dev] [bug #22366] Rotating specialists does not work in gtk3-client

2014-07-22 Thread Marko Lindqvist
Update of bug #22366 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #22360] Citizen nationality failures when loading 2.4 savegame to S2_5/trunk

2014-07-22 Thread Marko Lindqvist
Update of bug #22360 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4975] AM_DIST_FORMATS

2014-07-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?4975 Summary: AM_DIST_FORMATS Project: Freeciv Submitted by: cazfi Submitted on: Wed 23 Jul 2014 03:26:59 AM EEST Category: bootstrap Priority: 5 - Normal

[Freeciv-Dev] [patch #4840] Automake-NG

2014-07-22 Thread Marko Lindqvist
Follow-up Comment #1, patch #4840 (project freeciv): patch #4975 has part of this. ___ Reply to this item at: http://gna.org/patch/?4840 ___ Message sent via/by Gna! http://gna.org/

[Freeciv-Dev] [patch #4976] Sanity check ruleset data before saving

2014-07-22 Thread Marko Lindqvist
URL: http://gna.org/patch/?4976 Summary: Sanity check ruleset data before saving Project: Freeciv Submitted by: cazfi Submitted on: Wed 23 Jul 2014 04:11:06 AM EEST Category: freeciv-ruledit Priority: 5 -

[Freeciv-Dev] [bug #22374] Civ2Civ3 ruleset enforces restricted infrastructure setting on rivers

2014-07-22 Thread anonymous
Follow-up Comment #3, bug #22374 (project freeciv): This is a very strange setting indeed. Perhaps it will work. Have you tested it? What you have created - on a river tile in enemy territory land units ignore the river and travel on the terrain, but triremes ignore the terrain and travel on

[Freeciv-Dev] [bug #22385] Old civ2civ3 savegames fail to load

2014-07-22 Thread anonymous
URL: http://gna.org/bugs/?22385 Summary: Old civ2civ3 savegames fail to load Project: Freeciv Submitted by: None Submitted on: Wed 23 Jul 2014 04:25:33 UTC Category: rulesets Severity: 3 - Normal