[Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Oops. Your AC_GNU_SOURCE macro works and compiles fine but some time later I notice the cryptic warning + running aclocal ... configure.ac:168: warning: AC_COMPILE_IFELSE was called before AC_GNU_SOURCE ../../lib/autoconf/specific.m4:331: A

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Egor Vyscrebentsov wrote: > Main thought here is that we have different includes while configuring > and while compiling, and this may affects. The compiler notification is only a warning...the compilation will succeed if -Werror is not on

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > On 27/11/2007, Jason Short <[EMAIL PROTECTED]> wrote: > > > [EMAIL PROTECTED] - Tue Nov 27 17:48:50 2007]: > > > > On 27/11/2007, Marko Lindqvist wrote: > > > Now I got this same error in Ubuntu system. > > > > > > It seems that user has to

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Egor Vyscrebentsov
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > On Tue, 27 Nov 2007 10:10:57 -0800 Jason Short wrote: > > [cazfi74 - Tue Nov 27 17:48:50 2007]: > > On 27/11/2007, Marko Lindqvist wrote: > > > Now I got this same error in Ubuntu system. > > > > > > It seems that user has to define "_GNU_

[Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > > [EMAIL PROTECTED] - Tue Nov 27 17:48:50 2007]: > > On 27/11/2007, Marko Lindqvist wrote: > > Now I got this same error in Ubuntu system. > > > > It seems that user has to define "_GNU_SOURCE" for "__USE_GNU" to > be defined. > > > > No

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > On 27/11/2007, Marko Lindqvist wrote: > Now I got this same error in Ubuntu system. > > It seems that user has to define "_GNU_SOURCE" for "__USE_GNU" to be defined. > > No idea how it always gets set at configure time. Patch to define i

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Now I got this same error in Ubuntu system. It seems that user has to define "_GNU_SOURCE" for "__USE_GNU" to be defined. > ( export CFLAGS="-D_GNU_SOURCE" && ./autogen.sh && make) works No idea how it always gets set at configure ti

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > On 10/11/2007, Jason Dorje Short <[EMAIL PROTECTED]> wrote: > > #ifdef __USE_GNU which is > presumably being left undefined somehow in compilation while it was > defined properly during the configure check. I had similar problems in debian

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Egor Vyscrebentsov
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > On Fri, 9 Nov 2007 22:26:56 -0800 Jason Dorje Short wrote: > Jason Dorje Short wrote: > > > > William Allen Simpson wrote: > >> > >> Naive trunk implementation: > > > > Naive is fine but you forgot to add the check to configure.ac. Attach

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Jason Dorje Short wrote: >> Naive is fine but you forgot to add the check to configure.ac. Attached >> patch does that. >> I didn't forget; that ensured my new code was compiled and tested > ... Yet it is > clearly present in the hea

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Jason Dorje Short wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39849 > > > William Allen Simpson wrote: >> http://bugs.freeciv.org/Ticket/Display.html?id=39849 > >> >> Naive trunk implementation: > > Naive is fine but you forgot

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > William Allen Simpson wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39849 > > > Naive trunk implementation: Naive is fine but you forgot to add the check to configure.ac. Attached patch does that. But now it still won't compile

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Naive trunk implementation: Index: utility/support.c === --- utility/support.c (revision 13930) +++ utility/support.c (working copy) @@ -156,6 +156,40 @@ } /***

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Jason Dorje Short wrote: > But, strcasestr is a nonstandard glibc extension. To be portable we > need to use mystrcasestr and have a configure-time check or just > implement it ourselves. Or avoid using it, of course. > Actually a standa

[Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-08 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > ruleset.c: In function 'load_city_name_list': ruleset.c:2289: warning: implicit declaration of function 'strcasestr' ruleset.c:2289: warning: comparison between pointer and integer Now I'm not sure why I get this warning, since string.h is i