[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-19 Thread Marko Lindqvist
Update of bug #13843 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-19 Thread Marko Lindqvist
Follow-up Comment #8, bug #13843 (project freeciv): > can_units_do_base() and can_units_do_base_gui() return > essentially the same information, but with two different code > paths and different tests. You are welcome to improve the situation if it's possible, but... - Both of them use can_buil

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-13 Thread John Keller
Follow-up Comment #7, bug #13843 (project freeciv): OK, that makes sense - much better to fix the problem deeper down. Shows how much I have to learn about the depths of the code. :-) Still, I can't help but wonder: can_units_do_base() and can_units_do_base_gui() return essentially the same info

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-13 Thread Marko Lindqvist
Update of bug #13843 (project freeciv): Status: Fixed => In Progress Open/Closed: Closed => Open ___ Follow-up Comment #6: I see the problem

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-13 Thread John Keller
Follow-up Comment #5, bug #13843 (project freeciv): Sorry, Marko. I suppose I should have given more info so that you could reproduce. Steps: * with a unit capable of it, build a fortress (either with new "Build Base > Fortress" or with old "Build Fortress") * after fortress is built, now look a

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-12 Thread Marko Lindqvist
Follow-up Comment #4, bug #13843 (project freeciv): Please post new patches to new tickets. I almost forgot your patch as it's in already closed ticket! > It looks like can_units_do_base() checks to see if units can > build a base type and can do that activity on the current tile, > whereas can_

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-08 Thread John Keller
Follow-up Comment #3, bug #13843 (project freeciv): Thanks for taking the time to explain more in-depth, Marko! That really helps me to understand the context. I've make changes to my (upcoming) menu reorg patch. I have some better ideas, but for now I punted too and left the menu as-is. :-) On

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-06 Thread Marko Lindqvist
Follow-up Comment #2, bug #13843 (project freeciv): This new submenu lists all buildable base types - ruleset can specify arbitrary number of them. This is quite similar to "Change Government" submenu. Having almost duplicate entries for fortresses and airbases is far from optimal. Nobody has ye

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-05 Thread John Keller
Follow-up Comment #1, bug #13843 (project freeciv): I'm sorry I'm posting after this bug is closed, but it's of interest to me. I'm in the middle of redoing a menu layout change that I originally submitted about a year ago. Would you be able to go into a bit more depth about why this path moves

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-05 Thread Marko Lindqvist
Update of bug #13843 (project freeciv): Status:None => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-01 Thread Marko Lindqvist
URL: Summary: [Patch] Build base menu Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 07/01/2009 at 20:11 Category: client-gtk-2.0 Severity: 3 - Normal