[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Update of patch #1330 (project freeciv): Status: Ready For Test = Done ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #25, patch #1330 (project freeciv): I'm not sure that the trade tooltip justifies an own page. It would be an nearly empty page. Indeed, the S2_0 branch had such a tab, and it was (nearly empty). If we port warclient style trade route, then we also could port the trade route page on the city dialog. Then a specific page for it would make sense. For the moment, it is nearly empty, I agree with Matthias and Jacob. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
On 7 Apr, 2010, at 11:38 AM, Matthias Pfafferodt wrote: The only thing that would be better is if the main 'Civilization' menu had a new item which could display how many trade routes belong to each city, and name of the trading partner. Have you tried the client option 'Draw city trade routes'? If it is activated the number of trade routes per city are drawn and also a line between two trading cities. Hmm, i hadn't tried that before now. My map view is already rather crowded, so it wouldn't be useful to leave it on all the time. FWIW, i only get the lines and not the count [2.2.0]. For my part, i don't understand the logic that an information page is not worth keeping unless it is 'full'. I just wish there was some other way to view this information than by holding the mouse button down. However, i'm clearly a minority on this, so i'll just shut up about it. Sent from my MacBookPro Be careful when playing under the anvil tree. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #22, patch #1330 (project freeciv): I'm not sure if i'm using the correct terminology, but in the GTK city dialog there is a line of 'tabs' along the bottom: Overview, Production, Happiness, Governor, and Settings. I guess what i call tabs is more properly called pages? In any case, i submit that keeping track of trade routes is important enough to justify having a tab/page just for that. I don't have a mockup ready, but it would be essentially the same as what is currently presented by clicking on the trade number. This shouldn't take up much screen real estate other than the length of the label on the tab. The only thing that would be better is if the main 'Civilization' menu had a new item which could display how many trade routes belong to each city, and name of the trading partner. This is definitely off topic and will get a new ticket once i've worked up a proposed layout. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #23, patch #1330 (project freeciv): I'm not sure that the trade tooltip justifies an own page. It would be an nearly empty page. The only thing that would be better is if the main 'Civilization' menu had a new item which could display how many trade routes belong to each city, and name of the trading partner. Have you tried the client option 'Draw city trade routes'? If it is activated the number of trade routes per city are drawn and also a line between two trading cities. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #24, patch #1330 (project freeciv): I'm not sure that the trade tooltip justifies an own page. It would be an nearly empty page. Indeed, the S2_0 branch had such a tab, and it was (nearly empty). The only thing that would be better is if the main 'Civilization' menu had a new item which could display how many trade routes belong to each city, and name of the trading partner. You can get the number of trade routes in the city report (but not the names of the partners). ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #20, patch #1330 (project freeciv): Just my opinion but, the city dialog should not be as small as possible. If everything is just available via small clickable icons, it's hard to use. The gtk client uses a lot of space for common tasks (changing production from first city dialog page, arranging workers around the city), and I hope you agree that this is something good that we want to keep. (I don't compile the SDL client much, so take it with a grain of salt, but I find it violates this a bit too much, many things are only available via clicking small icons.) ___ Reply to this item at: http://gna.org/patch/?1330 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #21, patch #1330 (project freeciv): yes, you are right. To clarify: the size should not be increased or reduced but stay near or at the current size. At the time I started the city radii patches I had no update for the city map ... and it was somehow possible to view the city dialog on my screen. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #18, patch #1330 (project freeciv): I haven't gotten trunk yet, but let me ask: does the new dialog make it easier to see trade routes? In 2.2.0 this can only be viewed by clicking on the trade number, which i don't find very intuitive. Perhaps this information could go in a tab of it's own? The changes are only in the overview page and the happiness page. Mostly the bigger city map is inserted and some rearranging is done. There is no change wrt the trade. The left click to get a tooltip with more information is used also for the happiness information (see comment #15 and comment #16). ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #14, patch #1330 (project freeciv): Few comments on the new trunk Gtk city dialog layout on trunk (with default rules). Generally, I think I like it. (Any changes from this should probably go in a new ticket) * Overview tab: ** If the dialog is enlarged vertically, the extra space is wasted. It would be good if it were used to show either more improvements (as S2_2) or more units. * Happiness tab: ** Has lost detailed explanations of which buildings/wonders/etc are affecting happiness, but there's plenty of horizontal space to the right of the citizens (and some to the left) even with the minimum dialog size. (Admittedly the available space decreases with increasing city size, which would be a problem for a monster city like file #7251, but for normal cities I think there's plenty of space and in extremis a horizontal scrollbar can be added as for units on the Overview tab.) ** Also seems a bit sparse (Info pane has huge amounts of whitespace), but not a big issue. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #15, patch #1330 (project freeciv): Overview tab: will check; I think more improvements will be easyest Happiness tab: The detailed information can be found as tooltip on top of each of the happiness lines; perhaps add an hint for this? I tried to add the text but it ether increases the dialog horizontal or vertical. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #16, patch #1330 (project freeciv): The detailed information can be found as tooltip on top of each of the happiness lines (As in, left-click on the citizens.) Excellent, I hadn't spotted that, just the job! It's not very discoverable, but it's consistent with the longstanding Info box in that regard. Perhaps make the labels clickable too (I found I didn't want to click on the citizens, as I'm used to that reassigning specialists, even though that makes no sense here). ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Update of patch #1330 (project freeciv): Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #9, patch #1330 (project freeciv): Another problem with the new dialog: the citizens on top of the overview page are not left aligned but there is some offset (you can see this in file #8528). This wouldn't be a problem if it would still match the clickable areas to switch the specialists. But that seems to be still left aligned, so you need to click a bit left of the specialist you want to change, needing some guesswork ... ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #10, patch #1330 (project freeciv): ups; this citizens are clickable? I never did this ... ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #11, patch #1330 (project freeciv): The specialists can be rotated between entertainer, tax collector and scientist. Works similar to changing the tax rates on the main screen. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #12, patch #1330 (project freeciv): found the error: I used a vbox instead of a hbox ... I also added a similar line of citizens to the happiness page as it is also useable there ... (file #8609) ___ Additional Item Attachment: File name: 20100321-trunk-update-city-dialog-for-gtk-2.0.diff Size:35 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #8, patch #1330 (project freeciv): updated patch (svn 16977) * use 512 as max value for CITYMAP_WIDTH; this results in a 2/3 scaling for the amplio tileset (file #8588) ___ Additional Item Attachment: File name: 20100320-trunk-update-city-dialog-for-gtk-2.0.diff Size:30 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #4, patch #1330 (project freeciv): The new cityreport looks a bit blurry. It seems the city tiles as well as the units in the supported/present lists are scaled down a little bit (1-2 pixels per tile?) which is unneccessary and gives this bad impression. Screenshot comparing a city with the map window attached. I usually use isotrident tiles, but this problem seems to affect amplio as well. (file #8528) ___ Additional Item Attachment: File name: blurry-cityreport.png Size:290 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #5, patch #1330 (project freeciv): The new cityreport looks a bit blurry. You are right. Perhaps the size should be increased from 500 to 525? I don't have the right value at the moment and must get it using try and error. Is the size of the new city dialog OK. Compared to the old one it takes a little more space. This will be especially noteable on small displays. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #6, patch #1330 (project freeciv): 512 seems to work fine, it does no scaling on isotrident and 2/3 scaling on amplio. I added some debug code locally to get these numbers within city_dialog_update_supported_units(): 2: Loading tileset amplio. CITYMAP_SCALE 0.67 CITYMAP_WIDTH 512 canvas_width 768 2: Loading tileset isotrident. CITYMAP_SCALE 1.00 CITYMAP_WIDTH 512 canvas_width 512 2: Loading tileset hex2t. CITYMAP_SCALE 1.00 CITYMAP_WIDTH 320 canvas_width 320 2: Loading tileset isophex. CITYMAP_SCALE 1.00 CITYMAP_WIDTH 512 canvas_width 512 2: Loading tileset trident. CITYMAP_SCALE 1.00 CITYMAP_WIDTH 330 canvas_width 330 The last three ones were taken from a map generated for the isotrident topology and the city report looked OK (scaling wise) at a first glance. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Update of patch #1330 (project freeciv): Assigned to:None = syntron ___ Follow-up Comment #3: rebased to current trunk (file #8252) ___ Additional Item Attachment: File name: 20100224-trunk-update-city-dialog-for-gtk-2.0.patch Size:30 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Update of patch #1330 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Update of patch #1330 (project freeciv): Planned Release: = 2.3.0 ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #1, patch #1330 (project freeciv): Updated patch; the overview and the happiness page of the gtk citydialog are changed. The aim is to show as much information as possible in the available space. It is mainly needed if the variable city radius is used. The following images are attached: citydlg-old.png - the old city dialog (current trunk) citydlg-new.png - the new citydialog citydlg-new+cityradius.png - the new city dialog with the variable city radii patches The patch is independent from the patch series 'variable city radii'. (file #7245, file #7246, file #7247) ___ Additional Item Attachment: File name: 20091108-gtk_citydlg-0001-update-city-dialog-for-gtk-2.0.diff Size:30 KB File name: citydlg-new.pngSize:407 KB File name: citydlg-old.pngSize:387 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #2, patch #1330 (project freeciv): add missing file as jpg: citydlg-new+cityradius.jpg two more images showing a city with the largest possible radius: happiness page: citydlg2-new+cityradius-happiness.jpg overview page: citydlg2-new+cityradius.jpg (file #7251, file #7252, file #7253) ___ Additional Item Attachment: File name: citydlg2-new+cityradius-happiness.jpg Size:127 KB File name: citydlg2-new+cityradius.jpgSize:111 KB File name: citydlg-new+cityradius.jpg Size:70 KB ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
URL: http://gna.org/patch/?1330 Summary: update city dialog (gtk-2.0) Project: Freeciv Submitted by: syntron Submitted on: Sonntag 11.10.2009 um 00:21 Category: client-gtk-2.0 Priority: 1 - Later Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: * use a bigger map in the city dialog for city radii up to 5 * rearrange some widgets ___ File Attachments: --- Date: Sonntag 11.10.2009 um 00:21 Name: cityradius_sq20091010-0011-update-city-dialog-for-gtk-2.0-variable-city-radii.diff Size: 10kB By: syntron http://gna.org/patch/download.php?file_id=6950 ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
