[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-30 Thread Jacob Nevins
Update of patch #2077 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-29 Thread Jacob Nevins
Additional Item Attachment, patch #2077 (project freeciv): File name: trunk-allow-ruleset-rename-4.diff Size:80 KB ___ Reply to this item at: http://gna.org/patch/?2077 ___ Message sent

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-28 Thread Jacob Nevins
Update of patch #2077 (project freeciv): Planned Release: = 2.3.0 ___ Follow-up Comment #8: It may depends of the localization for client side... Indeed. There can be no check in

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-28 Thread Jacob Nevins
Update of patch #2077 (project freeciv): Depends on: = bugs #16962 ___ Reply to this item at: http://gna.org/patch/?2077 ___ Message sent

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-28 Thread pepeto
Follow-up Comment #9, patch #2077 (project freeciv): At least, Qn_(untranslated_name) is never displayed to the user... Well, unless they happen to have an English locale :) Then Qn_(untranslated_name) = name_translation(). In fact, if I keep the same tradeoff, then all the ENABLE_NLS

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-28 Thread Jacob Nevins
Follow-up Comment #10, patch #2077 (project freeciv): I insist that translated should be set in _name(s)_set()_. All this strings are translated at least once on client side (notably to generate the help). So there is no reason to use this as a mutable member. Done. This gets rid of a

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-27 Thread pepeto
Follow-up Comment #7, patch #2077 (project freeciv): (b) to avoid two separate game entities having the same user-visible string, which is more arguable. That's why I'm comparing after stripping off the qualifier with Qn() (and it's more or less equivalent to the old code). Comparing with

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-26 Thread Jacob Nevins
Update of patch #2077 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #3: Patch attached. Some additional design decisions: * rule_name added to: bases, city styles,

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-26 Thread pepeto
Follow-up Comment #4, patch #2077 (project freeciv): Fixes a bug where ruleset objects with qualified names weren't able to be translated on the client. The qualifier was stripped off before being sent over the network, so the client would end up trying to translate a string that wasn't

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-26 Thread Jacob Nevins
Follow-up Comment #6, patch #2077 (project freeciv): In my opinion Qn_(untranslated_name()) test should create a fatal error for the ruleset. It should test rule_name() or untranslated_name() with the qualifier. Note, it doesn't check the translation neither... I'm not sure what you're

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-22 Thread Jacob Nevins
Follow-up Comment #2, patch #2077 (project freeciv): Maybe for saving global worklists? And for saving city report columns (specialists)? Ah, yes, precisely this, otherwise you'll get the same problem in client settings. Thanks. ___

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-20 Thread Jacob Nevins
URL: http://gna.org/patch/?2077 Summary: Add optional separate rule name for ruleset objects, allowing them to be renamed Project: Freeciv Submitted by: jtn Submitted on: Thursday 10/21/10 at 01:47 Category: general

[Freeciv-Dev] [patch #2077] Add optional separate rule name for ruleset objects, allowing them to be renamed

2010-10-20 Thread pepeto
Follow-up Comment #1, patch #2077 (project freeciv): I haven't thought of a reason why the rule name needs to go over the network to the client yet; hopefully it can stay in the server. Otherwise it'll need packet formats changing, of course. Maybe for saving global worklists? And for saving