[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #5, bug #13846 (project freeciv): I added 'bool read_cmd'. I thin this can be changed to 'int read_level' and for 'read_level >= 5' there will be an error message ... ___ Reply to this item at:

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

Follow-up Comment #10, bug #13810 (project freeciv): > Why do you use the setting number as first argument > to almost every setting function? The only function > that takes a setting id should be setting_by_number(). > > > for (i = 0; i < SETTINGS_NUM; i++) { This way I can use pset_scate

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

Follow-up Comment #11, bug #13810 (project freeciv): > This way I can use > > pset_scategory(i) > > else I would have > > pset_scategory(setting_by_number(i)) There is an example of how to create an iteration macro when the array pointer is not available in the header in the patch in bug #

Re: [Freeciv-Dev] how to use git locally for freeciv

Am Thursday 02 July 2009 01:19:19 schrieben Sie: > On 01/07/2009, Matthias Pfafferodt wrote: > > You don't need to. As I said the 3 GB size is not a problem. I think I > > will also get warclient and longturn to compare ... > > The 3 GB is just silly. The entire history of the trunk and S2_1 > bra

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

Follow-up Comment #12, bug #13810 (project freeciv): > Sorry if something was unclear beforehand. > Unfortunately I will not be able to explain so much > now as I will be trying to finish the work for 2.2. Thanks for the help! I did learn something in the discussions and the last thing I did

[Freeciv-Dev] [bug #13850] add min/max definitions for saveturns

URL: Summary: add min/max definitions for saveturns Project: Freeciv Submitted by: syntron Submitted on: Donnerstag 02.07.2009 um 20:48 Category: general Severity: 2 - Minor

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #1, bug #13848 (project freeciv): Looks good in most part. - I don't like "switch" and "case" at same indentation level. I would vote for half indent step (2/2 = 1) for "case" - Could you add assert() rule that instead of "assert(FALSE)" assert with more verbose error message s

[Freeciv-Dev] [bug #13726] Add the flag in start page

Update of bug #13726 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13770] Emphasize OOP for path finding code

Update of bug #13770 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13637] [patch] add effect Migration_Pct

Update of bug #13637 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13828] move definition of GAME_*_COMPRESS_TYP to game.h

Update of bug #13828 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #13850] add min/max definitions for saveturns

Update of bug #13850 (project freeciv): Assigned to:None => cazfi ___ Reply to this item at: ___ Message sen

Re: [Freeciv-Dev] how to use git locally for freeciv

2009/7/2 Madeline Book : > On 01/07/2009, Matthias Pfafferodt wrote: >> >> You don't need to. As I said the 3 GB size is not a problem. I think I will >> also get warclient and longturn to compare ... > > The 3 GB is just silly. The entire history of the trunk and S2_1 > branches when cloned from

Re: [Freeciv-Dev] how to use git locally for freeciv

Am Thursday 02 July 2009 23:24:09 schrieb Marko Lindqvist: > 2009/7/2 Madeline Book : > > On 01/07/2009, Matthias Pfafferodt wrote: > >> You don't need to. As I said the 3 GB size is not a problem. I think I > >> will also get warclient and longturn to compare ... > > > > The 3 GB is just silly. T

[Freeciv-Dev] Mailing List

Hello, does the list has hickups? I'm missing some emails about comments to patches on gna since Thursday. The newest mail in the email archive is also from Thursday (https://mail.gna.org/public/freeciv-dev/2009-07/threads.html). I hope this Email will find its way. Matthias -- Matthias Pfaff

Re: [Freeciv-Dev] (PR#39923) ggz support for 2.1

http://bugs.freeciv.org/Ticket/Display.html?id=39923 > 2007/11/28 Jason Dorje Short : > However the default > profile hard-coded in freeciv is for pubserver.freeciv.org as the > server.  This patch should be applied to change that default profile, or > pubserver.freeciv.org should be changed to p

Re: [Freeciv-Dev] [bug #13726] Add the flag in start page

On 30/06/2009, Madeline Book wrote: > > Follow-up Comment #8, bug #13726 (project freeciv): > >> (Book, why don't I receive your message on my e-mail account?) > > I have no idea, maybe it was just late in arriving? > Maybe your spam filter got tired of reading through > my drivel. > > Was it just

[Freeciv-Dev] Gna email problems

2009/7/3 Madeline Book : > > Now I'm not getting any email from gna when I post > comments to tickets. O-o It seems that commit messages are not being sent to freeciv-commits. Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv - ML _

[Freeciv-Dev] [bug #13707] [Patch] Free memory allocated by init_nls()

Update of bug #13707 (project freeciv): Category:None => general Status:None => Fixed Assigned to:None => cazfi Open/Closed:

[Freeciv-Dev] [bug #13860] [Patch] Scripting: create_base

URL: Summary: [Patch] Scripting: create_base Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 03:17 Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #4, bug #13848 (project freeciv): Some "rules" I was just reminded of: - No more than 2 empty lines between any sections in the code. - #include the header corresponding to the current c source file after all other headers. ---

[Freeciv-Dev] [bug #13863] Remove old server goto code, step 1: warmap alternatives

URL: Summary: Remove old server goto code, step 1: warmap alternatives Project: Freeciv Submitted by: pepeto Submitted on: Saturday 07/04/2009 at 13:58 Category: general Severi

[Freeciv-Dev] [bug #13823] [Patch] Fix gtk2 theme installation when also sdl client compiled

Update of bug #13823 (project freeciv): Status:None => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #13857] [Patch] Debian package building

URL: Summary: [Patch] Debian package building Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 00:48 Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #13861] [Patch] Ruins

URL: Summary: [Patch] Ruins Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 03:19 Category: general Severity: 3 - Normal Priority: 1 -

[Freeciv-Dev] [bug #13860] [Patch] Scripting: create_base

Follow-up Comment #1, bug #13860 (project freeciv): Are there rules for the included files, i.e. sort them alphabetical? >+/* server */ >+#include "citytools.h" > #include "barbarian.h" >+#include "maphand.h" > #include "plrhand.h" >-#include "citytools.h" > #include "techtools.h" > #include "un

[Freeciv-Dev] [bug #13859] [Patch] Gen-movement version of prohibiting units in cities in the middle of non-native

URL: Summary: [Patch] Gen-movement version of prohibiting units in cities in the middle of non-native Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 02:05 Category:

[Freeciv-Dev] [bug #13863] Remove old server goto code, step 1: warmap alternatives

Update of bug #13863 (project freeciv): Assigned to:None => cazfi ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #13862] [Patch] Separate default.lua & script.lua

URL: Summary: [Patch] Separate default.lua & script.lua Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 12:14 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #13851] [Patch] Update wish list URL in TODO

URL: Summary: [Patch] Update wish list URL in TODO Project: Freeciv Submitted by: cazfi Submitted on: Friday 07/03/2009 at 01:34 Category: docs Severity: 3 - Normal

[Freeciv-Dev] [bug #13735] [Patch] Fix tolua-5.1b compiler warnings

Update of bug #13735 (project freeciv): Status:None => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #13858] [Patch] Move SINGLE_MOVE & co to movement.h

URL: Summary: [Patch] Move SINGLE_MOVE & co to movement.h Project: Freeciv Submitted by: cazfi Submitted on: Saturday 07/04/2009 at 01:50 Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #3, bug #13848 (project freeciv): > Could you add assert() rule that instead of > "assert(FALSE)" assert with more verbose error > message should be used when possible: [...] There is the die() function which can be used if the assert condition is not descriptive enough. I'll a

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #5, bug #13848 (project freeciv): Reason why I want "case" labels intendet is that having ending "}" as first line starting at the same level as "switch" itself makes it easier to see at one glance where current "switch" ends. My eyes (and brain) just work that way :-)

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #6, bug #13848 (project freeciv): I discourage use of die() in most cases. I don't think CodingStyle should advertise it. Note that die() kills even release builds (those with NDEBUG) when assert() does not. Of course failing assert() sometimes indicates problem that causes cra

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

Follow-up Comment #2, bug #13848 (project freeciv): > I don't like "switch" and "case" at same indentation > level. I would vote for half indent step (2/2 = 1) > for "case" I do not feel that using one space indentation for just this one area is very consistent with the two space indentation rul

[Freeciv-Dev] [bug #13811] [Patch] string vector

Follow-up Comment #1, bug #13811 (project freeciv): Some general notes: - The #include "shared.h" in iterator.h can be committed separately immediately if desired. - The string vector header+implementation and the changes in common/tech.c should be separate patch submissions. - Use 8 space

[Freeciv-Dev] [bug #13834] [Patch] struct ai_type

Update of bug #13834 (project freeciv): Status:None => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #13811] [Patch] string vector

Follow-up Comment #2, bug #13811 (project freeciv): > - I suggest a shorter "class" name, e.g. 'strvec'. > This would also help to distinguish it from > "vectors" created with the specvec macro. I renamed it str_vec, but it really looks ugly to me. I prefer the original name. What about string_

Re: [Freeciv-Dev] Mailing List

Am Saturday 04 July 2009 18:10:58 schrieb Matthias Pfafferodt: > Hello, > > does the list has hickups? I'm missing some emails about comments to > patches on gna since Thursday. The newest mail in the email archive is also > from Thursday > (https://mail.gna.org/public/freeciv-dev/2009-07/threads.h

Re: [Freeciv-Dev] Gna email problems

2009/7/4 cazfi wrote: > It seems that commit messages are not being sent to freeciv-commits. > > Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv > > > - ML I already experienced this problem when I started to work in warclient. It is actually due to the sebnding rights. I think