[Freeciv-Dev] [patch #2702] Gtk3 include path comments

2011-06-14 Thread Marko Lindqvist
Update of patch #2702 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #2708] Remove default ai includes from server code

2011-06-14 Thread Marko Lindqvist
Update of patch #2708 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #1, bug #18209 (project freeciv): Actually code to save exclude info even to new savegames seems to be missing. ___ Reply to this item at: ___

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #2, bug #18209 (project freeciv): > Actually code to save exclude info even to new savegames seems > to be missing. Actually I'm just blind. It's there. ___ Reply to this item at: ___

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

2011-06-14 Thread Marko Lindqvist
Update of bug #18209 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #3: Fix (file #13194) ___ Additional Item

[Freeciv-Dev] [bug #17954] Hotekys displayed twice

2011-06-14 Thread Marko Lindqvist
Update of bug #17954 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2615] Fix double hotkeys in some menu

2011-06-14 Thread Marko Lindqvist
Update of patch #2615 (project freeciv): Status:None => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [bug #18111] Replace some unsafe strcpy/strcat with fc_strlcpy/fc_strlcat

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #1, bug #18111 (project freeciv): First change this patch does is: > - strcpy(dest, str); > + fc_strlcpy(dest, str, strlen(str)+1); How that makes anything safer? Seems to me that it only obscures the fact that it's unsafe. Size of strcpy() area is already strlen()+1, and you

[Freeciv-Dev] [patch #2701] gtk3-client settings

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #2, patch #2701 (project freeciv): - Updated against svn (file #13195) ___ Additional Item Attachment: File name: Gtk3Settings_2701-3.diff.bz2 Size:7 KB ___ Re

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

2011-06-14 Thread Marko Lindqvist
URL: Summary: variable 'xxx' set but not used Project: Freeciv Submitted by: cazfi Submitted on: Tue 14 Jun 2011 08:27:24 PM EEST Category: general Severity: 3 - Normal

[Freeciv-Dev] [patch #2713] Include only allowed gtk3 headers

2011-06-14 Thread Marko Lindqvist
URL: Summary: Include only allowed gtk3 headers Project: Freeciv Submitted by: cazfi Submitted on: Tue 14 Jun 2011 08:35:13 PM EEST Category: client-gtk-3.0 Priority: 5 - Norma

[Freeciv-Dev] [bug #18182] Adjective of Botswana; Batswana and Bashoto nations

2011-06-14 Thread J.M. Maalderink
Update of bug #18182 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2705] Choctaw nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2705 (project freeciv): Status:None => In Progress ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #2707] Seminole nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2707 (project freeciv): Status:None => In Progress ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #2709] Japanese clans nations

2011-06-14 Thread J.M. Maalderink
Update of patch #2709 (project freeciv): Status:None => In Progress Assigned to:None => mixcoatl ___ Follow-up Comment #1: The flags should

[Freeciv-Dev] [patch #2710] Improving Hasinay nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2710 (project freeciv): Status:None => In Progress ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

2011-06-14 Thread Marko Lindqvist
Update of bug #18217 (project freeciv): Planned Release: => 2.2.6, 2.3.0, 2.4.0 ___ Follow-up Comment #1: Many of these warnings come deep from our macro magic. I rather don't rewrite those parts in st

[Freeciv-Dev] [patch #2709] Japanese clans nations

2011-06-14 Thread J. M. Gorbach
Follow-up Comment #2, patch #2709 (project freeciv): >>The flags should be in svg, and shields will be generated using the svg image. Ok! >>Maybe it's a better idea to turn this into a mod? Yes, it's a better idea. Thanks for reply. __

[Freeciv-Dev] [patch #2709] Japanese clans nations

2011-06-14 Thread Daniel Markstedt
Follow-up Comment #3, patch #2709 (project freeciv): FYI, there's an old "Japan" modpack by Rob Best available from the download server. It hasn't been updated for Freeciv 2.2 though. http://download.gna.org/freeciv/contrib/modpacks/japan/

[Freeciv-Dev] [patch #2685] Acrean nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2685 (project freeciv): Status: In Progress => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #2, bug #18217 (project freeciv): One noteworthy thing about these warnings is that they don't cause failure even with -Werror. I don't know why that is (gcc feature or bug) and how long that will last. ___ Reply to this

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

2011-06-14 Thread David Fernandez
Follow-up Comment #16, patch #1936 (project freeciv): I'd like to test this patch. May I install it over current trunk repository (together with "update hit point calculation for killunhomed")? Would AI handle it? or I should wait to v2.4.0 ___

[Freeciv-Dev] [bug #18219] sdl-client compiler warning about possibly uninitialized widget.

2011-06-14 Thread Marko Lindqvist
URL: Summary: sdl-client compiler warning about possibly uninitialized widget. Project: Freeciv Submitted by: cazfi Submitted on: Tue 14 Jun 2011 11:44:04 PM EEST Category: client-sdl

[Freeciv-Dev] [bug #18219] sdl-client compiler warning about possibly uninitialized widget.

2011-06-14 Thread Marko Lindqvist
Update of bug #18219 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #1968] add players_iterate_alive()

2011-06-14 Thread Marko Lindqvist
Update of patch #1968 (project freeciv): Assigned to:None => cazfi ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #2497] Scenario downloading support for freeciv-modpack

2011-06-14 Thread Marko Lindqvist
Update of patch #2497 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #1: Untested patch to add support for modpack type "Scenario" that will be loaded to ~/.freeciv/sc

[Freeciv-Dev] [patch #2529] Configure checks for gtk3-client

2011-06-14 Thread Marko Lindqvist
Update of patch #2529 (project freeciv): Status: In Progress => Ready For Test ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #2648] Updated "controls" help section based on comments in mapctrl.c

2011-06-14 Thread Marko Lindqvist
Update of patch #2648 (project freeciv): Category:None => client Planned Release: => 2.3.0, 2.4.0 ___ Reply to this item at:

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

2011-06-14 Thread David Fernandez
URL: Summary: Crash while playing custom Ruleset Project: Freeciv Submitted by: tirolalira Submitted on: mar 14 jun 2011 21:51:25 GMT Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #2660] Add gamename setting

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #1, patch #2660 (project freeciv): Is it intentional (this is just a first step) that this patch does not *use* gamename for anything, just allows setting it. I looked through the patch, but this should not be taken as indication that I'm about to take it into freeciv. I were j

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

2011-06-14 Thread Marko Lindqvist
Update of bug #18221 (project freeciv): Category:None => general Status:None => Confirmed Assigned to:None => cazfi _

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #2, bug #18221 (project freeciv): Well, I think that there's nothing in the code that would assert that balance really gets positive before this failing assert(). But this is not simply matter of removing the assert() as negative balance breaks a lot of things then on. Code blo

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

2011-06-14 Thread David Fernandez
Follow-up Comment #3, bug #18221 (project freeciv): Wow, you tested it pretty fast! Thank you very much. If the cause is negative treasury, then I know how to workarround it. The bug must be related to this patch: https://gna.org/bugs/?16413, where I already noticed treasure reached negative val

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #4, bug #18221 (project freeciv): I really should have read code more carefully before sending previous comment. Actually you do get upkeep back when building or unit is being sold (at least function headers claim so). But it now seems to me that there's bug in that not enough

[Freeciv-Dev] [patch #2688] Insert linebreaks to long happiness effect provider lists in happiness tab

2011-06-14 Thread Jacob Nevins
Update of patch #2688 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17906] Gold upkeep icon covers unhappiness upkeep icon

2011-06-14 Thread Jacob Nevins
Update of bug #17906 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-14 Thread Marko Lindqvist
Update of bug #18221 (project freeciv): Status: Confirmed => Ready For Test Planned Release: => 2.2.6, 2.3.0, 2.4.0 Summary: Crash while playing custom Ruleset => Not enough buildings/units sold to rest

[Freeciv-Dev] [patch #2686] Chiapanec nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2686 (project freeciv): Status: In Progress => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2687] Chickasaw nation

2011-06-14 Thread J.M. Maalderink
Update of patch #2687 (project freeciv): Status: In Progress => Ready For Test ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #18192] Client allocates unnecessarily memory for tile knowledge maps

2011-06-14 Thread Marko Lindqvist
Update of bug #18192 (project freeciv): Assigned to:None => cazfi Planned Release: => 2.4.0 ___ Reply to this item at:

[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #8, bug #18170 (project freeciv): > I can't find a ticket for its addition to Freeciv, so I don't > know more about its exact provenance (a "Mike Kaufman" was > involved). For the record: Mike & others originally wrote authentication code for freeciv pubserver only (now, how ma

[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64

2011-06-14 Thread Jacob Nevins
Update of bug #18170 (project freeciv): Status:None => In Progress Assigned to:None => jtn ___ Reply to this item at:

[Freeciv-Dev] [bug #18227] Qt-client configure check test program compilation fails

2011-06-14 Thread Marko Lindqvist
URL: Summary: Qt-client configure check test program compilation fails Project: Freeciv Submitted by: cazfi Submitted on: Wed 15 Jun 2011 03:38:25 AM EEST Category: bootstrap S

[Freeciv-Dev] [bug #18228] Configure does not support Mac OS Framework-style SDL installation

2011-06-14 Thread Marko Lindqvist
URL: Summary: Configure does not support Mac OS Framework-style SDL installation Project: Freeciv Submitted by: cazfi Submitted on: Wed 15 Jun 2011 03:41:21 AM EEST Category: bootstrap

[Freeciv-Dev] [bug #18200] Configure does not support Mac OS Framework-style Qt installation

2011-06-14 Thread Marko Lindqvist
Update of bug #18200 (project freeciv): Planned Release: => 2.4.0 Summary: Configure is unable to detect frameworks => Configure does not support Mac OS Framework-style Qt installation ___

[Freeciv-Dev] [bug #18228] Configure does not support Mac OS Framework-style SDL installation

2011-06-14 Thread Marko Lindqvist
Update of bug #18228 (project freeciv): Status:None => Need Info ___ Follow-up Comment #1: To get started with this I'd like someone with such a system to try to configure with --enable-

[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-14 Thread David Fernandez
Follow-up Comment #6, bug #18221 (project freeciv): Ok, thanks, no hurry. For now, gold upkeep style = 1 seems to avoid the crashes. ___ Reply to this item at: __

[Freeciv-Dev] [bug #18058] trunk: data/nation && data/flags/Makefile.am inconsistence

2011-06-14 Thread Marko Lindqvist
Follow-up Comment #3, bug #18058 (project freeciv): I'd rather place this check_flags.sh under scripts/. Attached version has data_dir path adjusted accordingly. If nobody objects in 48h, I'll add this to version control. (file #13204) ___

[Freeciv-Dev] [patch #2286] AI module directory structure

2011-06-14 Thread Marko Lindqvist
Update of patch #2286 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2529] Configure checks for gtk3-client

2011-06-14 Thread Marko Lindqvist
Update of patch #2529 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #2609] Polish localization for S2_3

2011-06-14 Thread Hubert Kowalewski
Follow-up Comment #6, patch #2609 (project freeciv): A small revision reflecting the changes from June 15. (file #13205) ___ Additional Item Attachment: File name: pl.po.zip Size:444 KB _