[Freeciv-Dev] [bug #16625] save chat message for the sender

Update of bug #16625 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #10, bug #16625 (project freeciv): There were still some oddities like if a player observer was sending a message to a player, it was sending strange messages. Changed the behaviour like: * "->{dest} message" is sent to the sender connection. * "{sender} message" is sent to the

[Freeciv-Dev] [bug #16625] save chat message for the sender

Update of bug #16625 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #9, bug #16625 (project freeciv): Looks reasonable, but I didn't test yet. ___ Reply to this item at: ___ Message posté via/par Gna! http:/

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #8, bug #16625 (project freeciv): I'm not familiar with observers or more than one connection for a player. I hope the attached version does sent the message to the right places. changes: - revert to the original style - add loop over the connections of the player of the sende

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #7, bug #16625 (project freeciv): Player observers still not get the player sent messages when they are sent, but get them if they reconnect, quite ugly... ___ Reply to this item at:

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #6, bug #16625 (project freeciv): here is the correct file (file #10158) ___ Additional Item Attachment: File name: 20100904v3-trunk-save-chat-message-for-the-sender.patch Size:3 KB

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #5, bug #16625 (project freeciv): updated version; changes: save the chat message for the recipient and for the player of the sender only if: - it is not an observer and - it is connected to a valid player You are right that the sender is only a connection. But most of the tim

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #4, bug #16625 (project freeciv): Forgot to mention also a second bug that your patch adds: if the sender is not attached to a player, the message is cached for all. I dunno also what should happen if a player observer send a message to a player. _

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #3, bug #16625 (project freeciv): I really understood the problem, and I maintain my comments. As long sending a message to a player is connection handled, there is no point to save it to the event cache. However, I am not against to change the behaviour to send the message als

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #2, bug #16625 (project freeciv): Perhaps I should describe the problem first: In longturn you reconnect once a day and all the old messages are replayed. If there is a private conversation between two players only one side is saved in the event cache. So lets say player A and

[Freeciv-Dev] [bug #16625] save chat message for the sender

Follow-up Comment #1, bug #16625 (project freeciv): I am not really sure this is a bug. chat_msg_to_player() currently send a message to all connections attached to a player and send a copy to the sender (only the connection). Saving the message for the player would also include the observers. A

[Freeciv-Dev] [bug #16625] save chat message for the sender

URL: Summary: save chat message for the sender Project: Freeciv Submitted by: syntron Submitted on: Samstag 04.09.2010 um 00:54 Category: general Severity: 2 - Minor