[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Release: 2.3.0-beta4 = 2.2.5,2.3.0-beta4 Planned Release: 2.3.0 = 2.2.6,2.3.0 ___ Follow-up Comment #15: It backports to S2_2 cleanly, and S2_2's minimum Gtk version is 2.6.0, same as S2_3. So I've committed it there. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Follow-up Comment #13, bug #18163 (project freeciv): Just in case we ever release 2.2.6, can this one be easily fixed in S2_2? It has been regression between 2.2.4 and 2.2.5. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #12: Committed to trunk despite the effect on Gtk3 efforts, for the sake of keeping it the same as S2_3 (and postponing the requirement for newer Gtk2 for as long as possible). ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #8: Patch attached which shouldn't use anything postdating 2.6.0 (I checked the header files, but didn't actually build it). Your current fix is probably better for gtk3-client than any gtk-2.12 compatible one. Maybe we should postpone changing gtk2-code to 2.12 compatibility after gtk3-client has been branched. Well, it's only one line, and I've left in a comment about what we should be called. Presumably the build failure from using -vbox directly with gtk3 will be fairly obvious? Or we could just bump the trunk requirement to 2.14 (released Sep 2008). That would leave Debian lenny (oldstable) out in the cold, dunno about other distros. (file #13070) ___ Additional Item Attachment: File name: trunk-S2_3-gtk-input-pre-2.14.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Follow-up Comment #9, bug #18163 (project freeciv): As to Ubuntu, all currently supported [desktop] versions have gtk+ = 2.20. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Follow-up Comment #7, bug #18163 (project freeciv): Your current fix is probably better for gtk3-client than any gtk-2.12 compatible one. Maybe we should postpone changing gtk2-code to 2.12 compatibility after gtk3-client has been branched. That branching is still pending patch #2572, which has some problems, or was it regression compared to old implementation (impossible to delete files or something) ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #6: cazfi points out that this introduces a dependency on Gtk 2.14: client/gui-gtk-2.0/inputdlg.c: In function ‘input_dialog_create’: client/gui-gtk-2.0/inputdlg.c:81: error: implicit declaration of function ‘gtk_dialog_get_content_area’ client/gui-gtk-2.0/inputdlg.c:81: error: cast to pointer from integer of different size dpkg -s libgtk2.0-0 ... Version: 2.12.12-1~lenny2 ... According to the INSTALL file, our current minimum requirements are 2.6.0 on S2_3, 2.12.0 on trunk. Re-opening to see if I can remove that dependency. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.3.0 ___ Follow-up Comment #3: Attached a substantially reworked version of the Gtk input_dialog_create() and its callers that avoids the problem. (file #13053, file #13054) ___ Additional Item Attachment: File name: trunk-gtk-input-build-city.diff Size:15 KB File name: S2_3-gtk-input-build-city.diff Size:15 KB ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Follow-up Comment #2, bug #18163 (project freeciv): Oh, true. Pressing Esc and closing dialog provokes the problem. But pressing Cancel does not. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
URL: http://gna.org/bugs/?18163 Summary: Cancelling city name request makes it impossible to do build city command anymore Project: Freeciv Submitted by: atorkhov Submitted on: Втр 24 Май 2011 19:38:37 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.0-beta4 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: If Cancel (or Esc) pressed on city name request (that is poping up on build city command for settler, i.e. B) then the original settler and ones that were on same square with it are not reacting on build city command anymore. It is possible to issue go to and build city command though. After saving/loading game all is restored and it is possible to create city. The bug is also present in 2.2. This bug might quite inconvenient for novice players that might change their mind on where to place city in last moment (like me :). ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Follow-up Comment #1, bug #18163 (project freeciv): Reproduced, and I believe I've found the cause. It seems specific to the Gtk client, and to closing the dialog with Esc rather than pressing the Cancel button (the latter doesn't provoke this problem when I try it -- can you confirm or deny that it works for you?) I think there's actually a general problem with input_dialog_create(), in that 'cancel_callback' isn't called if the dialog is closed with Esc. In this case, this leaves a unit with the 'asking_city_name' flag set, which suppresses all further city name requests for units on the same tile. I think this behaviour probably came in recently, with the fix for bug #14702. There are other uses of input_dialog_create(); I haven't worked out if the lack of callback will have any bad effects on them. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
