Re: [Freecol-developers] The size of dialogs

2015-05-19 Thread Michael T. Pope
On Sun, 17 May 2015 09:32:17 +0200 win...@genial.ms wrote: > the biggest problem in making it resizable was finding where in the code, > as its not in the panels. After I found out its buried in Canvas, it was > as simple as changing an enum or boolean value in the right method there. > Thats becau

Re: [Freecol-developers] The size of dialogs

2015-05-17 Thread winter
t; Von: "Michael T. Pope" > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] The size of dialogs > > On Mon, 9 Mar 2015 16:48:35 +1030 > "Michael T. Pope" wrote: > > Now that 0.11.3 is out I am looking through the list of

Re: [Freecol-developers] The size of dialogs

2015-05-16 Thread Michael T. Pope
On Mon, 9 Mar 2015 16:48:35 +1030 "Michael T. Pope" wrote: > Now that 0.11.3 is out I am looking through the list of issues I had put > aside. One of them is the question of whether dialogs/panels/whatever > should be resizable or not. What do people think? What we have ATM is > not consistent,

Re: [Freecol-developers] The size of dialogs

2015-04-13 Thread Caleb Williams
All: As I wrote at the end of the commit message (which was a bit long so you > may not have seen it completely without intentionally sidescrolling), that > is only a preferred size, and I tested that when you start the game with > "--windowed 1024x768" or even "--windowed 800x600" these panels >

Re: [Freecol-developers] The size of dialogs

2015-04-13 Thread winter
Hi, > Gesendet: Montag, 13. April 2015 um 11:15 Uhr > Von: "Michael T. Pope" > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] The size of dialogs > > On Sun, 12 Apr 2015 18:44:18 +0200 > win...@genial.ms wrote: > > It look

Re: [Freecol-developers] The size of dialogs

2015-04-13 Thread Michael T. Pope
On Sun, 12 Apr 2015 18:44:18 +0200 win...@genial.ms wrote: > It looks mostly presentable, though weird in some places. > I put most effort into getting the Map, InfoPanel, ColonyPanel, > EuropePanel, ReportPanels, Colopedia and their subpanels presentable. Just be wary of the sizing. We still cla

Re: [Freecol-developers] The size of dialogs

2015-04-12 Thread winter
Hi all, my long going efforts to get the code in shape for having the whole GUI resizable are beginning to pay off. You could check out the current state, when you apply the attached diff! It looks mostly presentable, though weird in some places. I put most effort into getting the Map, InfoPanel,

Re: [Freecol-developers] The size of dialogs

2015-04-08 Thread winter
called REMEMBER_PANEL_SIZES and not LOAD_PANEL_SIZES. I'd like to get the Europe Panel resizable btw.. Greetings, wintertime > Gesendet: Mittwoch, 08. April 2015 um 19:02 Uhr > Von: "Caleb Williams" > An: "FreeCol Developers" > Betreff: Re: [Freecol-deve

Re: [Freecol-developers] The size of dialogs

2015-04-08 Thread Caleb Williams
Please note that as of Wintertime's commit of [0d61c7 ], my issues with EuropePanel is now fixed. -- Caleb R. Williams -- BPM Camp - Free

Re: [Freecol-developers] The size of dialogs

2015-04-04 Thread Caleb Williams
> > The Indian advisor panel is showing most differences to other panels. > The small version of the headerfont is only used in a few other panels and > many dont use it. This could be made more consistent, though I'm unsure if > it should be removed or used more on other panels for subheaders. > A

Re: [Freecol-developers] The size of dialogs

2015-04-04 Thread Caleb Williams
On Apr 4, 2015 7:02 AM, wrote: > > > Gesendet: Montag, 30. März 2015 um 12:23 Uhr > > Von: "Michael T. Pope" > > An: freecol-developers@lists.sourceforge.net > > Betreff: Re: [Freecol-developers] The size of dialogs > > > > On Sun, 29 Mar 2015 22

Re: [Freecol-developers] The size of dialogs

2015-04-04 Thread winter
> Gesendet: Montag, 30. März 2015 um 12:23 Uhr > Von: "Michael T. Pope" > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] The size of dialogs > > On Sun, 29 Mar 2015 22:14:15 +0200 > win...@genial.ms wrote: > > as I slowly made

Re: [Freecol-developers] The size of dialogs

2015-04-03 Thread Caleb Williams
On Mon, Mar 30, 2015 at 4:48 AM, Michael T. Pope wrote: > On Fri, 27 Mar 2015 22:58:34 -0500 > Caleb Williams wrote: > > I'm not sure where to put that though. Any place I put it in > > EuropePanel.java I get the following error message: > > > > illegal start of type > > package clientOptions do

Re: [Freecol-developers] The size of dialogs

2015-03-30 Thread Michael T. Pope
On Sun, 29 Mar 2015 22:14:15 +0200 win...@genial.ms wrote: > as I slowly made some (of the many needed) changes to enable the game having > scaling > (see also BR#2726), I made a couple observations and would like to know what > you > think about them. > > I found I could very easily allow the m

Re: [Freecol-developers] The size of dialogs

2015-03-29 Thread winter
Hi, as I slowly made some (of the many needed) changes to enable the game having scaling (see also BR#2726), I made a couple observations and would like to know what you think about them. I found I could very easily allow the map to be zoomed in some more (2-3 line change, if no graphical glitc

Re: [Freecol-developers] The size of dialogs

2015-03-27 Thread Caleb Williams
On Wed, Mar 25, 2015 at 3:46 AM, Michael T. Pope wrote: > On Tue, 24 Mar 2015 17:14:13 -0500 > Caleb Williams wrote: > > Sorry for the confusion. > > > > To clarify, nothing has worked. None of the three revisions I tested > > ([3de6e8], [7ef16d] and [df01d9]) produced any changes. > > OK, so at

Re: [Freecol-developers] The size of dialogs

2015-03-25 Thread Michael T. Pope
On Tue, 24 Mar 2015 17:14:13 -0500 Caleb Williams wrote: > Sorry for the confusion. > > To clarify, nothing has worked. None of the three revisions I tested > ([3de6e8], [7ef16d] and [df01d9]) produced any changes. OK, so at least we did not break this recently. > Unfortunately, the trace write

Re: [Freecol-developers] The size of dialogs

2015-03-24 Thread Caleb Williams
On Tue, Mar 24, 2015 at 3:49 AM, Michael T. Pope wrote: > On Mon, 23 Mar 2015 21:40:57 -0500 > Caleb Williams wrote: > > I've tried modifying the following... > > Sorry, but I am confused by what you have written here. Has *anything* > worked? > > Also, looking at the code again, we should chec

Re: [Freecol-developers] The size of dialogs

2015-03-24 Thread Michael T. Pope
On Mon, 23 Mar 2015 21:40:57 -0500 Caleb Williams wrote: > I've tried modifying the following... Sorry, but I am confused by what you have written here. Has *anything* worked? Also, looking at the code again, we should check the value of model.option.rememberPanelSizes? If false, the EuropePane

Re: [Freecol-developers] The size of dialogs

2015-03-23 Thread Caleb Williams
On Mon, Mar 23, 2015 at 9:40 PM, Caleb Williams wrote: > On Mon, Mar 23, 2015 at 4:05 PM, Michael T. Pope > wrote: > >> On Mon, 23 Mar 2015 09:28:58 -0500 >> Caleb Williams wrote: >> > I found options for: >> > EuropePanel.w, EuropePanel.h, ...x, ...y. >> >> Deleting them should have worked. S

Re: [Freecol-developers] The size of dialogs

2015-03-23 Thread Caleb Williams
On Mon, Mar 23, 2015 at 4:05 PM, Michael T. Pope wrote: > On Mon, 23 Mar 2015 09:28:58 -0500 > Caleb Williams wrote: > > I found options for: > > EuropePanel.w, EuropePanel.h, ...x, ...y. > > Deleting them should have worked. Something weird is happening. Does > reverting back past the last Eu

Re: [Freecol-developers] The size of dialogs

2015-03-23 Thread Michael T. Pope
On Mon, 23 Mar 2015 09:28:58 -0500 Caleb Williams wrote: > I found options for: > EuropePanel.w, EuropePanel.h, ...x, ...y. Deleting them should have worked. Something weird is happening. Does reverting back past the last EuropePanel.java changes (say to git.3de6e87) fix the problem? Cheers, M

Re: [Freecol-developers] The size of dialogs

2015-03-23 Thread Caleb Williams
I found options for: EuropePanel.w, EuropePanel.h, ...x, ...y. Both deleting the file and changing the settings manually had no effect. The width of the Europe panel remains narrow. Caleb On Mar 23, 2015 3:22 AM, "Michael T. Pope" wrote: > On Sun, 22 Mar 2015 23:30:33 -0500 > Caleb Williams wr

Re: [Freecol-developers] The size of dialogs

2015-03-23 Thread Michael T. Pope
On Sun, 22 Mar 2015 23:30:33 -0500 Caleb Williams wrote: > > Should/can I delete the whole Documents/FreeCol/freecol/options.xml file? It is harmless to delete it, but that will remove all your local settings. Are you sure there are no EuropePanel settings in there, probably near the end? Cheer

Re: [Freecol-developers] The size of dialogs

2015-03-22 Thread Caleb Williams
Any update on this? I'd love to get my Europe panel back. On Thu, Mar 12, 2015 at 6:28 PM, Caleb Williams wrote: > How is that done? I can only find ClientOptions.java, and it would make > sense if nothing was there in the first place. > > Should/can I delete the whole Documents/FreeCol/freecol/

Re: [Freecol-developers] The size of dialogs

2015-03-13 Thread Michael T. Pope
On Thu, 12 Mar 2015 18:28:06 -0500 Caleb Williams wrote: > How is that done? I can only find ClientOptions.java Not in the source, in your local configuration. options.xml in /freecol/. Cheers, Mike Pope pgpgxjDCfSkR8.pgp Description: OpenPGP digital signature

Re: [Freecol-developers] The size of dialogs

2015-03-12 Thread Caleb Williams
How is that done? I can only find ClientOptions.java, and it would make sense if nothing was there in the first place. Should/can I delete the whole Documents/FreeCol/freecol/options.xml file? On Thu, Mar 12, 2015 at 4:02 PM, Michael T. Pope wrote: > On Thu, 12 Mar 2015 09:36:36 -0500 > Caleb W

Re: [Freecol-developers] The size of dialogs

2015-03-12 Thread Michael T. Pope
On Thu, 12 Mar 2015 09:36:36 -0500 Caleb Williams wrote: > Anyway to set that stuff (panel sizes) back to defaults? Delete the settings from the client options file. Cheers, Mike Pope pgp9OhLFw09Uf.pgp Description: OpenPGP digital signature -

Re: [Freecol-developers] The size of dialogs

2015-03-12 Thread Caleb Williams
On Mar 10, 2015 5:57 AM, "Michael T. Pope" wrote: > > On Tue, 10 Mar 2015 10:54:50 +0100 > win...@genial.ms wrote: > > I feel I need to admit it now, this is the only "BR" I feel strongly about > > and I know that it exists since years (and when getting reminded of it > > always hoping it gets for

Re: [Freecol-developers] The size of dialogs

2015-03-12 Thread Michael T. Pope
On Mon, 9 Mar 2015 23:41:55 +0100 win...@genial.ms wrote: > I'll try to take a closer look at those and see if circular dependencies > can be reduced that way. Since people are discussing code cleanups, here is a suggestion. We still have a few type checking warning suppressions, which I always t

Re: [Freecol-developers] The size of dialogs

2015-03-11 Thread winter
> Gesendet: Dienstag, 10. März 2015 um 11:56 Uhr > Von: "Michael T. Pope" > An: win...@genial.ms, "FreeCol Developers" > > Betreff: Re: [Freecol-developers] The size of dialogs > > On Tue, 10 Mar 2015 10:54:50 +0100 > win...@genial.ms wrote: &g

Re: [Freecol-developers] The size of dialogs

2015-03-10 Thread Michael T. Pope
On Tue, 10 Mar 2015 10:54:50 +0100 win...@genial.ms wrote: > I feel I need to admit it now, this is the only "BR" I feel strongly about > and I know that it exists since years (and when getting reminded of it > always hoping it gets forgotten, ignored or even finally closed). I have never closed i

Re: [Freecol-developers] The size of dialogs

2015-03-10 Thread winter
Hi, > Gesendet: Dienstag, 10. März 2015 um 01:45 Uhr > Von: "Michael T. Pope" > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] The size of dialogs > > BTW, I should have mentioned earlier that our oldest open bug (BR#479) is > a

Re: [Freecol-developers] The size of dialogs

2015-03-09 Thread Michael T. Pope
BTW, I should have mentioned earlier that our oldest open bug (BR#479) is about resizability, and there is some relevant discussion there. On Mon, 9 Mar 2015 11:53:37 +0100 win...@genial.ms wrote: > you are right that the colony panel is in most need of an update. In whatever discussion follows,

Re: [Freecol-developers] The size of dialogs

2015-03-09 Thread winter
" An: win...@genial.ms Cc: "FreeCol Developers" Betreff: Re: Re: [Freecol-developers] The size of dialogs     On Mon, Mar 9, 2015 at 5:18 PM, <win...@genial.ms> wrote: Hi,   the GUI class is really the class I feel is violating SRP most. I got the feeling it coul

Re: [Freecol-developers] The size of dialogs

2015-03-09 Thread Paolo Bizzarri
On Mon, Mar 9, 2015 at 5:18 PM, wrote: > Hi, > > the GUI class is really the class I feel is violating SRP most. I got the > feeling it could be split it into, for example: > GUI was there for a good reason - to create a facade that was hiding the whole GUI stuff from the rest of the application

Re: [Freecol-developers] The size of dialogs

2015-03-09 Thread winter
zarri" An: win...@genial.ms Cc: "FreeCol Developers" Betreff: Re: [Freecol-developers] The size of dialogs     Another, secondary thought on the games code I had was to slowly/continuously cut down on circular dependencies, near empty forwarding methods and getting it a b