Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > Instead of having DPU-specific defines, switch to the definitions from > > the mdp_common.xml.h file. This is the preparation for merged of DPU and > > MDP

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-10 Thread Dmitry Baryshkov
On Wed, Apr 10, 2024 at 01:42:33PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 05:23, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: > > > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > > > ab

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-10 Thread Dmitry Baryshkov
On Wed, 10 Apr 2024 at 14:53, Aleksandr Mishin wrote: > On 08.04.2024 12:03, Dmitry Baryshkov wrote: > > On Mon, 8 Apr 2024 at 11:57, Aleksandr Mishin wrote: > >> > >> In dpu_core_irq_callback_handler() callback function pointer is compared > >> to NULL

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 21:27, Konrad Dybcio wrote: > > > > On 4/9/24 20:15, Dmitry Baryshkov wrote: > > On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: > >> > >> > >> On 4/9/24 20:04, Dmitry Baryshkov wrote: > >>> On Tue, Apr

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: > > > On 4/9/24 20:04, Dmitry Baryshkov wrote: > > On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: > > > On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov > > > wrote: > > > >

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: > On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 4/6/24 04:56, Dmitry Baryshkov wrote: >

Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 05:13:15PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 05:25, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: > > > Add speebin data for A740, as found on SM8550 and derivative SoCs. > > > &

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 04:56, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: > > > From: Neil Armstrong > > > > > > Usually, speedbin 0 is the

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-09 Thread Dmitry Baryshkov
On Mon, Apr 08, 2024 at 09:33:01PM -0500, Bjorn Andersson wrote: > On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar > > wrote: > > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > > On Mon

[PATCH] drm/msm/gen_header: allow skipping the validation

2024-04-09 Thread Dmitry Baryshkov
https://lore.kernel.org/all/20240409120108.2303d...@canb.auug.org.au/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 8 drivers/gpu/drm/msm/Makefile| 9 - drivers/gpu/drm/msm/registers/gen_header.py | 14 +++--- 3 files change

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:17, Abhinav Kumar wrote: > > > > On 4/8/2024 2:13 PM, Dmitry Baryshkov wrote: > > On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/8/2024 1:41 PM, Bjorn Andersson wrote: > &g

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > &g

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar wrote: > > > > On 4/8/2024 1:41 PM, Bjorn Andersson wrote: > > On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > >>> On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar wrote: > > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > >> From: Kuogee Hsieh > > [..] > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_displa

Re: [PATCH v1 1/1] drm/msm/hdmi: Replace of_gpio.h by proper one

2024-04-08 Thread Dmitry Baryshkov
8 @@ > * Author: Rob Clark > */ > > +#include > #include > -#include > #include > #include > > -- > 2.43.0.rc1.1.gbec44491f096 > First one didn't reach the PW, let's try again: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 11:57, Aleksandr Mishin wrote: > > In dpu_core_irq_callback_handler() callback function pointer is compared to > NULL, > but then callback function is unconditionally called by this pointer. > Fix this bug by adding conditional return. > > Found by Linux Verification Center

Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 11:09, Jani Nikula wrote: > > On Fri, 05 Apr 2024, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 12:29:07PM +0300, Jani Nikula wrote: > >> Logging u32 pixel formats using %4.4s format string with a pointer to > >> the u32 is somewhat ques

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-04-06 Thread Dmitry Baryshkov
On Sat, 30 Mar 2024 at 18:49, Marijn Suijten wrote: > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > In case of CMD DSI panels, the vblank IRQ can be used outside of > > irq_enable/irq_disable pair. This results in the following kind of > > Can you clarify when exa

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-06 Thread Dmitry Baryshkov
move extra line added > > changes in v2: > - Fix the commit message to explain the scenario > - Fix the subject a little as well > > Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()") > Signed-off-by: Kuogee Hsieh > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2] drm/msm/dp: Remove now unused connector_type from desc

2024-04-05 Thread Dmitry Baryshkov
8-dp-connector-type-cleanup-v1-1-9bf84c5a6...@quicinc.com > --- > drivers/gpu/drm/msm/dp/dp_display.c | 48 > + > 1 file changed, 17 insertions(+), 31 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 0/6] Add SMEM-based speedbin matching

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:28AM +0200, Konrad Dybcio wrote: > Newer (SM8550+) SoCs don't seem to have a nice speedbin fuse anymore, > but instead rely on a set of combinations of "feature code" (FC) and > "product code" (PC) identifiers to match the bins. This series adds > support for that. >

Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: > Add speebin data for A740, as found on SM8550 and derivative SoCs. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/driver

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > abstracted through SMEM, instead of being directly available in a fuse. > > Add support for SMEM-based speed binning, which includes getting > "feature code" and "

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: > From: Neil Armstrong > > Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock > the highest. Falling back to it when things go wrong is largely > suboptimal, as more often than not, the top frequencies are not > sup

Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: > In preparation for parsing the chip "feature code" (FC) and "product > code" (PC) (essentially the parameters that let us conclusively > characterize the sillicon we're running on, including various speed > bins), move the socinfo ver

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > > Signed-off-by: Konrad Dybcio > --- > drivers/soc/qcom/smem.c | 66 > +++ > include/linux/soc/qcom/smem.h | 2 +

Re: [PATCH v2] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-05 Thread Dmitry Baryshkov
On Fri, Apr 05, 2024 at 05:17:14PM -0700, Abhinav Kumar wrote: > From: Kuogee Hsieh > > In the external HPD case, hotplug event is delivered by pmic glink to DP > driver > using drm_aux_hpd_bridge_notify(). There can be other drivers in front of the DP chain. For example, altmode driver uses dr

Re: [PATCH] drm/msm: remove an unused-but-set variable

2024-04-05 Thread Dmitry Baryshkov
On Fri, 5 Apr 2024 at 18:59, Arnd Bergmann wrote: > > From: Arnd Bergmann > > The modification to a6xx_get_shader_block() had no effect other > than causing a warning: > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set > but not used [-Werror,-Wunused-but-set-variab

Re: [PATCH 1/3] drm/msm/dsi: remove the drm_bridge_attach fallback

2024-04-05 Thread Dmitry Baryshkov
On Fri, 5 Apr 2024 at 21:17, Abhinav Kumar wrote: > > > > On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote: > > On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: >

Re: [PATCH 1/3] drm/msm/dsi: remove the drm_bridge_attach fallback

2024-04-05 Thread Dmitry Baryshkov
On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote: > > > > On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: > > All the bridges that are being used with the MSM DSI hosts have been > > converted to support DRM_BRIDGE_ATTACH_NO_CONNECTOR. Drop the fallb

Re: [PATCH 2/3] drm/msm/dsi: move next bridge acquisition to dsi_bind

2024-04-05 Thread Dmitry Baryshkov
On Fri, 5 Apr 2024 at 20:35, Abhinav Kumar wrote: > > > > On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: > > Currently the MSM DSI driver looks for the next bridge during > > msm_dsi_modeset_init(). If the bridge is not registered at that point, > > this might result

Re: [PATCH] drm: ci: fix the xfails for apq8016

2024-04-05 Thread Dmitry Baryshkov
the passing pipeline for apq8016 with this change: > > https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562 > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-05 Thread Dmitry Baryshkov
p/dpu1/dpu_encoder_phys_wb.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 24 +-- > drivers/gpu/drm/msm/msm_fb.c | 10 > 5 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE

2024-04-04 Thread Dmitry Baryshkov
> not good to write to the wrong register space, and maybe some other > version of this phy relies on this. > > Cc: Douglas Anderson > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Neil Armstrong > Cc: Abel Vesa > Cc: Steev Klimaszewski > Cc: Johan Hovold

Re: [PATCH] phy: qcom: qmp-combo: Fix VCO div offset on v3

2024-04-04 Thread Dmitry Baryshkov
some > monitors are very specific about their link clk frequency and if the > default power on reset value is still there the monitor will show a > blank screen or a garbled display. Other monitors are perfectly happy to > get a bad clock signal. > > Cc: Douglas Anderson > Cc:

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Dmitry Baryshkov
On Wed, Apr 03, 2024 at 10:22:37AM -0700, Kuogee Hsieh wrote: > Dmitry, > > Any more comments? > > On 3/29/2024 12:50 PM, Kuogee Hsieh wrote: > > Currently qmp_combo_dp_power_on() always return 0 in regardless of > > return value of cfg->configure_dp_phy(). This patch propagate > > return value o

Re: [PATCH v3] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 20:24, Kuogee Hsieh wrote: > > Dmitry, > > any more comments? > No, it was picked by Abhinav for msm-fixes. -- With best wishes Dmitry

Re: [PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 17:44, Jun Nie wrote: > > Dmitry Baryshkov 于2024年4月3日周三 17:57写道: > > > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > > > From: Jonathan Marek > > > > > > Add necessary DPU timing and control changes for DSC to

Re: [PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 17:27, Jun Nie wrote: > > Dmitry Baryshkov 于2024年4月3日周三 17:49写道: > > > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > > > This is follow up update to Jonathan's patch set. > > > > > > Changes

Re: [PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > From: Jonathan Marek > > Support slice_per_pkt in msm driver. > > Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" > comment is incorrect. > > Also trim the code to simplify the dsc reference. > > Signed-off-by: Jonathan Marek

Re: [PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-03 Thread Dmitry Baryshkov
configuration") > Signed-off-by: Jonathan Marek > Reviewed-by: Dmitry Baryshkov You S-o-b is missing > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/

Re: [PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > From: Jonathan Marek > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > driver is doing in video mode. Fix that by actually enabling widebus for > video mode. > > Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI")

Re: [PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > From: Jonathan Marek > > Add necessary DPU timing and control changes for DSC to work with DSI > video mode. > > Signed-off-by: Jonathan Marek > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 + >

Re: [PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > This is follow up update to Jonathan's patch set. > > Changes vs V2: > - Rebase to latest mainline. > - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in > latest mainline code. > - Drop the bonded DSI patch as I do not have device to te

Re: [PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > Add variable for slice number of a DSC compression bit stream packet. > Its value shall be specified in panel driver, or default value can be set > in display controller driver if panel driver does not set it. This is not a part of the standard. Ple

[PATCH v3 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-04-01 Thread Dmitry Baryshkov
As Qualcomm SM8150 got support for the DisplayPort, add displayport@ node as a valid child to the MDSS node. Fixes: 88806318e2c2 ("dt-bindings: display: msm: dp: declare compatible string for sm8150") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../devicetre

[PATCH v3 4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes

2024-04-01 Thread Dmitry Baryshkov
DisplayPort nodes must declare the dp_p1 register space in addition to dp_p0. Add corresponding resource to DisplayPort DT nodes. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6

[PATCH v3 2/4] arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells

2024-04-01 Thread Dmitry Baryshkov
The property #stream-id-cells is legacy, it is not documented as valid for the GPU. Drop it now. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1

[PATCH v3 3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

2024-04-01 Thread Dmitry Baryshkov
by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 99462b42cfc5..6d74867d3b61 100644 --- a/arch/arm6

[PATCH v3 0/4] arm64: dts: fix several display-related schema warnings

2024-04-01 Thread Dmitry Baryshkov
Fix several warnings produced by the display nodes. Please excuse me for the spam for sending v3 soon after v2. Signed-off-by: Dmitry Baryshkov --- Changes in v3: - Added tags which I forgot in v2 - Added the Fixes tag to the dp_p1 fix - Link to v2: https://lore.kernel.org/r/20240402-fd-fix

[PATCH v2 4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes

2024-04-01 Thread Dmitry Baryshkov
DisplayPort nodes must declare the dp_p1 register space in addition to dp_p0. Add corresponding resource to DisplayPort DT nodes. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot

[PATCH v2 0/4] arm64: dts: fix several display-related schema warnings

2024-04-01 Thread Dmitry Baryshkov
Fix several warnings produced by the display nodes. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Added Fixes tag to the DP change (Abhinav) - Switched the schema patch to use contains (Krzysztof) - Link to v1: https://lore.kernel.org/r/20240326-fd-fix-schema-v1-0-4475d6d6d...@linaro.org

[PATCH v2 3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

2024-04-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-

[PATCH v2 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-04-01 Thread Dmitry Baryshkov
As Qualcomm SM8150 got support for the DisplayPort, add displayport@ node as a valid child to the MDSS node. Fixes: 88806318e2c2 ("dt-bindings: display: msm: dp: declare compatible string for sm8150") Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/qcom,sm8150

[PATCH v2 2/4] arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells

2024-04-01 Thread Dmitry Baryshkov
The property #stream-id-cells is legacy, it is not documented as valid for the GPU. Drop it now. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 - 1 file changed, 1 deletio

Re: [PATCH] drm/msm/dp: allow voltage swing / pre emphasis of 3

2024-04-01 Thread Dmitry Baryshkov
On Mon, 1 Apr 2024 at 23:15, Kuogee Hsieh wrote: > > > On 4/1/2024 9:25 AM, Kuogee Hsieh wrote: > > > > On 2/3/2024 5:47 AM, Dmitry Baryshkov wrote: > >> Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and > >> pre-emphasis to 2, while th

[PATCH v5 16/18] drm/msm: drop A6xx GMU header

2024-03-31 Thread Dmitry Baryshkov
Now as the headers are generated during the build step, drop pre-generated copies of the Adreno A6xx GMU header. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 422 -- 1 file changed, 422 deletions(-) diff --git a/drivers/gpu/drm/msm

[PATCH v5 17/18] drm/msm: drop C++ parts of a6xx.xml.h

2024-03-31 Thread Dmitry Baryshkov
As a preparation to removal of a6xx.xml.h, drop the C++ part of the heder, it is not used by the kernel anyway. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 2478 - 1 file changed, 2478 deletions(-) diff --git a/drivers/gpu/drm/msm

[PATCH v5 10/18] drm/msm: import gen_header.py script from Mesa

2024-03-31 Thread Dmitry Baryshkov
Import the gen_headers.py script from Mesa, commit b5414e716684 ("freedreno/registers: Add license header"). This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_heade

[PATCH v5 11/18] drm/msm: generate headers on the fly

2024-03-31 Thread Dmitry Baryshkov
Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease reviews). Signed-off-by: Dmitry Baryshkov --- drivers/gpu

[PATCH v5 05/18] drm/msm: remove dependencies from core onto adreno headers

2024-03-31 Thread Dmitry Baryshkov
Two core driver files include headers from Adreno subdir, which also brings dependency on the Adreno register headers. Rework those includes to remove unnecessary dependency. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 2 files

[PATCH v5 02/18] drm/msm/hdmi: drop qfprom.xml.h

2024-03-31 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v5 04/18] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-31 Thread Dmitry Baryshkov
The msm_gpummu.c implementation is used only on A2xx and it is tied to the A2xx registers. Rename the source file accordingly. Reviewed-by: Akhil P Oommen Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/adreno/a2xx_gpu.c

[PATCH v5 03/18] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-31 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131

[PATCH v5 01/18] drm/msm/mdp5: add writeback block bases

2024-03-31 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp

[PATCH v5 00/18] drm/msm: generate register header files

2024-03-31 Thread Dmitry Baryshkov
synced between Mesa and the kernel tree. Unless there are any objections, I'd like to consider this a final revision with the target of it being merged for 6.10. Please review. Signed-off-by: Dmitry Baryshkov --- Changes in v5: - Updated gen_header.py to include licence header (Abhinav, Akhil) -

[PATCH] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible

2024-03-29 Thread Dmitry Baryshkov
s in the kernel output") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.

[PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-29 Thread Dmitry Baryshkov
] [drm:dpu_encoder_phys_cmd_control_vblank_irq] *ERROR* vblank irq err id:31 pp:0 ret:-22, enable true/0 [drm:dpu_encoder_phys_cmd_control_vblank_irq] *ERROR* vblank irq err id:31 pp:0 ret:-22, enable false/0 Fixes: d13f638c9b88 ("drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set") Signed-off-by: Dmitry Baryshkov --- .

Re: [PATCH v2] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-03-29 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 18:48, Kuogee Hsieh wrote: > > At current x1e80100 interface table, interface #3 is wrongly > connected to DP controller #0 and interface #4 wrongly connected > to DP controller #2. Fix this problem by connect Interface #3 to > DP controller #0 and interface #4 connect to DP

Re: [PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 06:02, Bjorn Andersson wrote: > > Now that the connector_type is dynamically determined, the > connector_type of the struct msm_dp_desc is unused. Clean it up. > > Signed-off-by: Bjorn Andersson > --- > This cleans up after, and hence depends on, > https://lore.kernel.org/a

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 04:47, Jun Nie wrote: > > Dmitry Baryshkov 于2024年3月28日周四 23:05写道: > > > > On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > > > > > Fix DSC timing and control configurations in DPU for DSI video mode. > > > Only compression rati

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar wrote: > > > > On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote: > > On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: >

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote: > > > > On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: > > On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/28/2024 1:58 PM, Stephen Boyd wrote: > >

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote: > > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > >> + Johan and Bjorn for FYI > >> > >> On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > >>> For internal HPD case, hpd_event_thread is created to handle

Re: [PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 23:36, Abhinav Kumar wrote: > > > > On 3/28/2024 2:07 PM, Kuogee Hsieh wrote: > > Currently qmp_combo_dp_power_on() always return 0 in regardless of > > return value of cfg->configure_dp_phy(). This patch propagate > > return value of cfg->configure_dp_phy() all the way back

Re: [PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Dmitry Baryshkov
rtions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Enable display compression (DSC v1.2) for 1080x2400 Visionox > VTDR6130 AMOLED DSI panel. DTS property is needed to enable DSC. > Default configuration is video mode + non-DSC for any back > compatibility. The changelog talks about the DSC only, wh

Re: [PATCH 2/3] dt-bindings: display: panel: visionox,vtdr6130: Add mode property

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Add DSI mode property and compression mode property > > Signed-off-by: Jun Nie > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 8 > 1 file changed, 8 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Fix DSC timing and control configurations in DPU for DSI video mode. > Only compression ratio 3:1 is handled and tested. > > This patch is modified from patchs of Jonathan Marek. > > Signed-off-by: Jun Nie This almost looks like a joke, except it

Re: [PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Dmitry Baryshkov
> drivers/gpu/drm/msm/dp/dp_debug.h | 38 +++- > drivers/gpu/drm/msm/dp/dp_display.c | 10 ++- > 3 files changed, 31 insertions(+), 76 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 10:45, Krzysztof Kozlowski wrote: > > On 26/03/2024 21:02, Dmitry Baryshkov wrote: > > diff --git > > a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > > b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yam

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 01:49, Abhinav Kumar wrote: > > > > On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > > Generate DRM/MSM headers on the fly during kernel build. This removes a > > need to push register changes to Mesa with the following manual > > synchronizati

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 00:34, Abhinav Kumar wrote: > > > > On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: &g

Re: [PATCH v4 09/16] drm/msm: import gen_header.py script from Mesa

2024-03-26 Thread Dmitry Baryshkov
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote: > > > > On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > > Import the gen_headers.py script from Mesa, commit FIXME. This script > > will be used to generate MSM register files on the fly during > > compilation.

Re: [PATCH v4 01/16] drm/msm/mdp5: add writeback block bases

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote: > > > > On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: > > In order to stop patching the mdp5 headers, import definitions for the > > writeback blocks. This part is extracted from the old Rob's patch. > > > &g

[PATCH 3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

2024-03-26 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-

[PATCH 4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes

2024-03-26 Thread Dmitry Baryshkov
DisplayPort nodes must declare the dp_p1 register space in addition to dp_p0. Add corresponding resource to DisplayPort DT nodes. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot

[PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-26 Thread Dmitry Baryshkov
As Qualcomm SM8150 got support for the DisplayPort, add displayport@ node as a valid child to the MDSS node. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation

[PATCH 2/4] arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells

2024-03-26 Thread Dmitry Baryshkov
The property #stream-id-cells is legacy, it is not documented as valid for the GPU. Drop it now. Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 - 1 file changed, 1 deletio

[PATCH 0/4] arm64: dts: fix several display-related schema warnings

2024-03-26 Thread Dmitry Baryshkov
Fix several warnings produced by the display nodes. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (4): dt-bindings: display/msm: sm8150-mdss: add DP node arm64: dts: qcom: sc8180x: drop legacy property #stream-id-cells arm64: dts: qcom: sc8180x: Drop flags for mdss irqs

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote: > > > > On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: > > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: &

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote: > > > > On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: > > On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda > > wrote: > >> > >> Hi, > >> > >> In today's next, I got: > >> &g

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda wrote: > > Hi, > > In today's next, I got: > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable > 'out' set but not used [-Werror,-Wunused-but-set-variable] > > `out` seems to be there since commit 64d6255650d4 ("drm/msm: More > full

Re: [PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-26 Thread Dmitry Baryshkov
gt; drivers/gpu/drm/msm/dp/dp_catalog.c | 39 > + > drivers/gpu/drm/msm/dp/dp_catalog.h | 18 + > 3 files changed, 28 insertions(+), 49 deletions(-) Reviewed-by: Dmitry Baryshkov Thanks a lot for the cleanup! -- With best wishes Dmitry

Re: [PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-26 Thread Dmitry Baryshkov
files changed, 17 insertions(+), 18 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-26 Thread Dmitry Baryshkov
ss the calling of the functions, > so replace this member with a function argument. Definitely yes, thank you! Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/dp/dp_aux.c | 9 +++-- > drivers/gpu/drm/msm/dp/dp_catalog.c

Re: [PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-26 Thread Dmitry Baryshkov
gpu/drm/msm/dp/dp_ctrl.c| 17 + > drivers/gpu/drm/msm/dp/dp_panel.h | 1 - > 4 files changed, 3 insertions(+), 19 deletions(-) Reviewed-by: Dmitry Baryshkov Kuogee could you possibly comment, why was this necessary at all? -- With best wishes Dmitry

Re: [PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-26 Thread Dmitry Baryshkov
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The members of struct dp_debug are no longer used, so the only purpose > of this struct is as a type of the return value of dp_debug_get(), to > signal success/error. > > Drop the struct in favor of signalling the

Re: [PATCH 3/6] drm/msm/dp: Remove unused defines and members

2024-03-26 Thread Dmitry Baryshkov
s split into somewhat logical chunks, but I think it doesn't make sense for such cleanup. Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/msm: Add newlines to some debug prints

2024-03-25 Thread Dmitry Baryshkov
ssed that while migrating to drm_dbg wrappers. > > Fixes: 7cb017db1896 ("drm/msm: Move FB debug prints to drm_dbg_state()") > Fixes: 721c6e0c6aed ("drm/msm: Move vblank debug prints to drm_dbg_vbl()") > Signed-off-by: Stephen Boyd Reviewed-by: Dmitry Baryshk

<    2   3   4   5   6   7   8   9   10   11   >