Re: [Freeipa-devel] [PATCH] 833 fix sudorule unit tests

2011-07-20 Thread Martin Kosek
On Tue, 2011-07-19 at 16:41 -0400, Rob Crittenden wrote: With the external user/group management fixed, correct the unit tests. The unit tests were incorrectly expecting the removed data back when removing external users. rob NACK There is still one unit test failure. Test

Re: [Freeipa-devel] [PATCH] 835 set default min int, handle longs

2011-07-20 Thread Martin Kosek
On Tue, 2011-07-19 at 22:15 -0400, Rob Crittenden wrote: Our handling of long values wasn't the best when dealing with negative values. Added a default minint similar to maxint and validate_scalar in Int to allow either int or long types. This lets it get to the min/max rules where we can

Re: [Freeipa-devel] [PATCH] 833 fix sudorule unit tests

2011-07-20 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-07-19 at 16:41 -0400, Rob Crittenden wrote: With the external user/group management fixed, correct the unit tests. The unit tests were incorrectly expecting the removed data back when removing external users. rob NACK There is still one unit test failure.

[Freeipa-devel] [PATCH] 066 Remove wrong kpasswd sysconfig

2011-07-20 Thread Jakub Hrozek
I noticed that the file kpasswd init script reads is called /etc/sysconfig/ipa-kpasswd but krbinstance.py saved and wrote into /etc/sysconfig/ipa_kpasswd. I removed the linkes rather than fixing them for two reasons: 1) /var/kerberos/krb5kdc/kpasswd.keytab is the default 2) it probably wouldn't

[Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

2011-07-20 Thread Jakub Hrozek
I was playing with ipa_kpasswd (long story short - I needed it running on a non-standard port) and I noticed there was a compilation warning - rtag was set but never checked. Also removes one unused #define. From 76a4895cd4f65bd9cb6251c23037e466bbd22eff Mon Sep 17 00:00:00 2001 From: Jakub Hrozek

Re: [Freeipa-devel] [PATCH] 833 fix sudorule unit tests

2011-07-20 Thread Martin Kosek
On Wed, 2011-07-20 at 09:12 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-07-19 at 16:41 -0400, Rob Crittenden wrote: With the external user/group management fixed, correct the unit tests. The unit tests were incorrectly expecting the removed data back when removing

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-20 Thread Rob Crittenden
JR Aquino wrote: On Jul 15, 2011, at 7:55 AM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2011-07-14 at 23:05 +, JR Aquino wrote: On Jul 14, 2011, at 11:55 AM, wrote: https://fedorahosted.org/freeipa/ticket/1272 * Added new container in etc to hold the automembership configs. *

Re: [Freeipa-devel] [PATCH] 820 make client errors clearer

2011-07-20 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-07-19 at 10:40 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-06 at 11:03 -0400, Rob Crittenden wrote: Some client errors were rather generic or outright misleading. This cleans up some return values and displays output from the

[Freeipa-devel] [PATCH] 0271-no-dns.

2011-07-20 Thread Adam Young
From d669b5523282df99d97829e68de7f4c4a17d25d2 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 20 Jul 2011 11:43:41 -0400 Subject: [PATCH] no dns Remove all DNS entities if the DNS server is not installed. Removes it from the navigation as well.

[Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Endi Sukma Dewata
A custom adder dialog has been added for DNS zones to simplify creating reverse zones from IP address. The dialog provides a checkbox which indicates whether the content of the zone name field is an IP address. The IP address will be used to generate the reverse zone name and email address.

Re: [Freeipa-devel] [PATCH] 0271-no-dns.

2011-07-20 Thread Rob Crittenden
Adam Young wrote: ack, works for me with and without dns rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0271-no-dns.

2011-07-20 Thread Adam Young
On 07/20/2011 12:44 PM, Rob Crittenden wrote: Adam Young wrote: ack, works for me with and without dns rob From 58b0745d1bf2c4541565b341eb94a279e059b734 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 20 Jul 2011 11:43:41 -0400 Subject: [PATCH] no dns Remove all DNS

[Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

2011-07-20 Thread Alexander Bokovoy
Hi, On 19.07.2011 16:36, Alexander Bokovoy wrote: I believe that nss-pam-ldapd uses a different configuration file than nss_ldap, I think I'd rather use the existence of that to determine what is being used. Calling out to rpm seems heavy-weight. In continuation of the same story, ticket 1368

Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

2011-07-20 Thread Alexander Bokovoy
On 20.07.2011 20:30, Alexander Bokovoy wrote: I moved existing code to ipapython/platform/redhat.py. ipapython/services.py is auto-generated and basically is one-liner: = from ipapython.platform.platform import * = Actual platform value is substituted using top-level Makefile's

Re: [Freeipa-devel] [PATCH] 0271-no-dns.

2011-07-20 Thread Adam Young
On 07/20/2011 12:51 PM, Adam Young wrote: On 07/20/2011 12:44 PM, Rob Crittenden wrote: Adam Young wrote: ack, works for me with and without dns rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

2011-07-20 Thread Simo Sorce
On Wed, 2011-07-20 at 20:36 +0300, Alexander Bokovoy wrote: On 20.07.2011 20:30, Alexander Bokovoy wrote: I moved existing code to ipapython/platform/redhat.py. ipapython/services.py is auto-generated and basically is one-liner: = from ipapython.platform.platform import * =

Re: [Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Adam Young
On 07/20/2011 12:10 PM, Endi Sukma Dewata wrote: A custom adder dialog has been added for DNS zones to simplify creating reverse zones from IP address. The dialog provides a checkbox which indicates whether the content of the zone name field is an IP address. The IP address will be used to

Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

2011-07-20 Thread John Dennis
On 07/20/2011 01:30 PM, Alexander Bokovoy wrote: Actualplatform value is substituted using top-level Makefile's SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined without modifying Makefile, in package building scripts, for example) and then ipapython/services.py is generated

Re: [Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 1:45 PM, Adam Young wrote: ACK, but put in the space between the reverse checkbox line and the next row. Add a ticket for refactoring the dialogs to allow more layout options on a widget, so we can reduce the complexity of the code in the future. New patch attached. -- Endi S.

Re: [Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Adam Young
On 07/20/2011 03:01 PM, Endi Sukma Dewata wrote: On 7/20/2011 1:45 PM, Adam Young wrote: ACK, but put in the space between the reverse checkbox line and the next row. Add a ticket for refactoring the dialogs to allow more layout options on a widget, so we can reduce the complexity of the code

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/19/2011 6:38 PM, Adam Young wrote: Missed a change to fix the unit tests. I haven't finished testing it, but here are some issues: 1. If DNS is disabled, the DNS zone entity throws an uncaught exception so the execution stops. 2. In add.js:41 the IPA.nav.show_entity_page() takes an

Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

2011-07-20 Thread Alexander Bokovoy
On 20.07.2011 21:59, John Dennis wrote: On 07/20/2011 01:30 PM, Alexander Bokovoy wrote: Actualplatform value is substituted using top-level Makefile's SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined without modifying Makefile, in package building scripts, for example)

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 2:50 PM, Adam Young wrote: 8. Triggering a stack trace by calling null function probably will only work with Firebug, normal users will not get any notification about the error. This happens in dialog.js:301 and widget.js:1137. Gonna leave this, as we will catch things in

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-20 Thread JR Aquino
On Jul 20, 2011, at 8:37 AM, Rob Crittenden wrote: JR Aquino wrote: On Jul 15, 2011, at 7:55 AM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2011-07-14 at 23:05 +, JR Aquino wrote: On Jul 14, 2011, at 11:55 AM, wrote: https://fedorahosted.org/freeipa/ticket/1272 * Added

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 9:18 PM, Adam Young wrote: 8. Triggering a stack trace by calling null function probably will only work with Firebug, normal users will not get any notification about the error. This happens in dialog.js:301 and widget.js:1137. Gonna leave this, as we will catch things in

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-20 Thread JR Aquino
Rob, I'm afraid I believe that ldap lookup is necessary. The user inputs a standard string to represent the possible host group… If i simply perform a get_dn it will indeed provide a dn, however, it won't verify that the host group actually exists… (you don't want to create an assignment

[Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-20 Thread Endi Sukma Dewata
The UUID field has been removed from the entitlement registration dialog box because it's currently not supported. The code has been modified not to send empty UUID value should this become supported in the future. Ticket #1506 -- Endi S. Dewata From bf72a8817b43172dd28d06bd3f4249153ac591e3 Mon