Re: [Freeipa-devel] [PATCH] 152 Enable automember for upgraded servers

2011-11-29 Thread Martin Kosek
On Mon, 2011-11-28 at 18:16 -0500, Rob Crittenden wrote: Nathan Kinder wrote: On 11/04/2011 02:35 PM, Nathan Kinder wrote: On 11/04/2011 02:26 PM, Martin Kosek wrote: On Fri, 2011-11-04 at 14:04 -0700, Nathan Kinder wrote: On 11/04/2011 02:02 PM, Rob Crittenden wrote: Martin Kosek

Re: [Freeipa-devel] [PATCH] 161 Make ipa-server-install clean after itself

2011-11-29 Thread Martin Kosek
On Mon, 2011-11-28 at 23:34 -0500, Rob Crittenden wrote: Martin Kosek wrote: How to test: 1) ipa-server-install -p secret123 -a secret123 --hostname ipa.example.com 2) Continue in interactive wizard until IP address is requested (as ipa.example.com cannot be resolved) 3) When it is

Re: [Freeipa-devel] [PATCH] 157 Add --delattr option to complement --setattr/--addattr

2011-11-29 Thread Martin Kosek
On Mon, 2011-11-28 at 23:24 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Sat, 2011-11-05 at 13:43 +0100, Martin Kosek wrote: On Fri, 2011-11-04 at 09:23 -0400, Rob Crittenden wrote: Martin Kosek wrote: Add a --delattr option to round out multi-valued attribute manipulation. The

Re: [Freeipa-devel] [PATCH] #2122 Fix PAC re-signing

2011-11-29 Thread Sumit Bose
On Mon, Nov 28, 2011 at 07:43:57PM -0500, Simo Sorce wrote: On Thu, 2011-11-24 at 13:54 +0100, Sumit Bose wrote: I think I found two issues which should be fixed by the following patch: - krb5_pac_add_buffer() expects krb5_pac and not krb5_pac * as a second argument good catch

Re: [Freeipa-devel] [PATCH] 5 User-add random password support

2011-11-29 Thread Martin Kosek
On Thu, 2011-11-24 at 17:51 +0100, Ondrej Hamada wrote: On 11/24/2011 03:54 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/1979 I've used code from ipalib/plugins/host.py to add support for random password generation. The '--random' option is now available in

Re: [Freeipa-devel] [PATCH] 0037 make-lint fails on Fedora 16/Rawhide

2011-11-29 Thread Martin Kosek
On Mon, 2011-11-28 at 17:26 +0200, Alexander Bokovoy wrote: On Mon, 28 Nov 2011, Alexander Bokovoy wrote: Hi, Attached are fixes for ldap.LDAPObject.add_s(self, dn, modlist) uses which now don't pass 'make-lint' on Fedora 16/Rawhide. -- / Alexander Bokovoy From

Re: [Freeipa-devel] [PATCH] 0037 make-lint fails on Fedora 16/Rawhide

2011-11-29 Thread Alexander Bokovoy
On Tue, 29 Nov 2011, Martin Kosek wrote: Conservative patch is attached. What about other add_s(entry) calls? I see we call it this way on more places, especially in replication.py: $ git grep add_s(e ipaserver/install/cainstance.py:ld.add_s(entry_dn, entry)

Re: [Freeipa-devel] [PATCH] 0037 make-lint fails on Fedora 16/Rawhide

2011-11-29 Thread Martin Kosek
On Tue, 2011-11-29 at 13:54 +0200, Alexander Bokovoy wrote: On Tue, 29 Nov 2011, Alexander Bokovoy wrote: On Tue, 29 Nov 2011, Martin Kosek wrote: Conservative patch is attached. What about other add_s(entry) calls? I see we call it this way on more places, especially in

Re: [Freeipa-devel] [PATCH 49/49] ticket #1870 - subclass SimpleLDAPObject

2011-11-29 Thread Martin Kosek
On Thu, 2011-09-29 at 15:06 -0600, Rich Megginson wrote: On 09/28/2011 01:27 PM, John Dennis wrote: We use convenience types (classes) in IPA which make working with LDAP easier and more robust. It would be really nice if the basic python-ldap library understood our utility types and could

Re: [Freeipa-devel] [PATCH 48/48] Ticket #1879 - IPAdmin undefined anonymous parameter lists

2011-11-29 Thread Martin Kosek
On Tue, 2011-10-04 at 14:26 +0200, Jan Cholasta wrote: On 26.9.2011 21:52, John Dennis wrote: The IPAdmin class in ipaserver/ipaldap.py has methods with anonymous undefined parameter lists. For example: def getList(self,*args): In Python syntax this means you can call getList

Re: [Freeipa-devel] [PATCH] 908 make some fields required

2011-11-29 Thread Rob Crittenden
Endi Sukma Dewata wrote: On 11/28/2011 12:09 PM, Rob Crittenden wrote: Some attributes in the framework were not marked as required even though they are in the schema. These are typically computed values and I think the intention was to not prompt for them. This has the side-effect of them

[Freeipa-devel] [PATCH] 6 Sort password policy by priority

2011-11-29 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/2045 'ipa pwpolicy-find' output is now sorted by priority of the policies. Lower position means lower priority. Global policy is then at the bottom. The changes has also affected LDAPSearch class in baseldap.py: LDAPSearch class sorts the search results

[Freeipa-devel] [PATCH] spec file fix

2011-11-29 Thread Simo Sorce
Pushed the following patch under one-liner. Simo. -- Simo Sorce * Red Hat, Inc * New York From 4d73e9cea769680a7b47db52f7f45440d0e27367 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Wed, 23 Nov 2011 08:25:55 -0500 Subject: [PATCH] spec: We do not need krb5-server-ldap

Re: [Freeipa-devel] [PATCH] 6 Sort password policy by priority

2011-11-29 Thread Ondrej Hamada
On 11/29/2011 03:46 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2045 'ipa pwpolicy-find' output is now sorted by priority of the policies. Lower position means lower priority. Global policy is then at the bottom. The changes has also affected LDAPSearch class in

Re: [Freeipa-devel] [PATCH] 265 Fixed layout problem in permission adder dialog.

2011-11-29 Thread Simo Sorce
Apparently this patch was pushed. On Fri, 2011-09-09 at 10:19 +0200, Petr Vobornik wrote: On 09/08/2011 06:51 PM, Endi Sukma Dewata wrote: On 9/8/2011 11:13 AM, Petr Vobornik wrote: In IPA.details_table_section: 1)not renamed list_section_create method Fixed. Code clean-up in

Re: [Freeipa-devel] [PATCH] 266 Fixed sudo rule association dialogs.

2011-11-29 Thread Simo Sorce
This patch too seem to have been pushed. On Fri, 2011-09-09 at 12:55 +0200, Petr Vobornik wrote: On 09/08/2011 06:53 PM, Endi Sukma Dewata wrote: On 9/8/2011 10:28 AM, Endi Sukma Dewata wrote: The adder dialog for the user and host tables in sudo rule details page have been fixed to use

Re: [Freeipa-devel] [PATCH] 286 Fixed tab and dialog widths.

2011-11-29 Thread Simo Sorce
This patch was pushed too. (I am closing loose ends) On Thu, 2011-09-29 at 11:20 +0200, Petr Vobornik wrote: On 09/28/2011 01:02 AM, Endi Sukma Dewata wrote: The width of the 1st level tab has been modified to expand according to the size of the tab label. The width of the adder dialogs

Re: [Freeipa-devel] [PATCH] 275 Use editable combobox for service type.

2011-11-29 Thread Simo Sorce
This patch was also pushed. On Thu, 2011-09-29 at 11:35 +0200, Petr Vobornik wrote: On 09/28/2011 12:59 AM, Endi Sukma Dewata wrote: On 9/16/2011 12:16 PM, Endi Sukma Dewata wrote: The service type field in the service adder dialog has been modified to use an editable combobox. Ticket

Re: [Freeipa-devel] [PATCH] 288 Disable enroll button if nothing selected.

2011-11-29 Thread Simo Sorce
This patch was also pushed. On Thu, 2011-09-29 at 13:59 +0200, Petr Vobornik wrote: On 09/29/2011 06:50 AM, Endi Sukma Dewata wrote: On 9/28/2011 7:59 PM, Adam Young wrote: On 09/28/2011 06:50 PM, Endi Sukma Dewata wrote: A new IPA.dialog_button class has been added to encapsulate the

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-11-29 Thread Simo Sorce
I couldn't find a clear ACK for this patch but it has been pushed as well. Guys please try to better report on the list when patches are pushed and close the thread. Simo. On Thu, 2011-09-29 at 14:52 +0200, Petr Vobornik wrote: On 09/27/2011 10:54 PM, Endi Sukma Dewata wrote: On 9/27/2011

Re: [Freeipa-devel] [PATCH] 888 always verify hostname

2011-11-29 Thread Simo Sorce
On Tue, 2011-10-11 at 17:07 +0200, Martin Kosek wrote: On Fri, 2011-10-07 at 09:18 -0400, Rob Crittenden wrote: Martin Kosek wrote: Yes but the entry is added /etc/hosts at the very END of installation, apparently too late for some things. We can alternately add this prior to

Re: [Freeipa-devel] [PATCH] 166+167 Zonemgr improvements

2011-11-29 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2011-11-14 at 10:37 +0100, Martin Kosek wrote: On Fri, 2011-11-11 at 10:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: There are 2 patches improving our zone zonemgr: 1) ipa-server-install --zonemgr option validation and normalization + the same thing in ipa

Re: [Freeipa-devel] [PATCH] 888 always verify hostname

2011-11-29 Thread Martin Kosek
On Tue, 2011-11-29 at 10:18 -0500, Simo Sorce wrote: On Tue, 2011-10-11 at 17:07 +0200, Martin Kosek wrote: On Fri, 2011-10-07 at 09:18 -0400, Rob Crittenden wrote: Martin Kosek wrote: Yes but the entry is added /etc/hosts at the very END of installation, apparently too late for

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-11-29 Thread Endi Sukma Dewata
On 11/29/2011 9:17 AM, Simo Sorce wrote: I couldn't find a clear ACK for this patch but it has been pushed as well. Correct. Guys please try to better report on the list when patches are pushed and close the thread. Yes, sorry, sometimes I missed a few, my fault. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 166+167 Zonemgr improvements

2011-11-29 Thread Martin Kosek
On Tue, 2011-11-29 at 10:39 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-11-14 at 10:37 +0100, Martin Kosek wrote: On Fri, 2011-11-11 at 10:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: There are 2 patches improving our zone zonemgr: 1) ipa-server-install

Re: [Freeipa-devel] [PATCH] 6 Sort password policy by priority

2011-11-29 Thread Rob Crittenden
Ondrej Hamada wrote: On 11/29/2011 03:46 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2045 'ipa pwpolicy-find' output is now sorted by priority of the policies. Lower position means lower priority. Global policy is then at the bottom. The changes has also affected

[Freeipa-devel] [PATCH] fix uninitialized free() [Fwd: daemons/ipa-kdb]

2011-11-29 Thread Simo Sorce
I pushed the attached patch under the oneliner rule -- Simo Sorce * Red Hat, Inc * New York ---BeginMessage--- daemons/ipa-kdb/ipa_kdb_principals.c |1 + 1 file changed, 1 insertion(+) New commits: commit e727dc50ccdc9c62e5c4a374f03d0b9fa2d6b19c Author: Simo Sorce sso...@redhat.com Date:

[Freeipa-devel] [PATCH] fix memleaks

2011-11-29 Thread Simo Sorce
Found a couple of memleaks while reviewing code. Attached. Simo. -- Simo Sorce * Red Hat, Inc * New York From 70840691e48e1ac89002499c08a9dd4fdcae7c50 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sun, 20 Nov 2011 20:50:11 -0500 Subject: [PATCH] ipa-kdb: fix memleaks in

Re: [Freeipa-devel] [PATCH] Add ipasam samba passdb backend

2011-11-29 Thread Alexander Bokovoy
On Tue, 29 Nov 2011, Sumit Bose wrote: @@ -199,10 +216,11 @@ class ADTRUSTInstance(service.Service): self.admin_conn.addEntry(entry) entry = ipaldap.Entry(self.smb_dom_dn) -entry.setValues(objectclass, [sambaDomain, nsContainer]) +

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-29 Thread Rob Crittenden
Ondrej Hamada wrote: On 11/11/2011 02:55 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install. Check is base on existence of nss_ldap

[Freeipa-devel] make-lint failures

2011-11-29 Thread Rob Crittenden
Seeing some new make-lint failures after the reworking of ipaldap function signatures; $ ./make-lint ipaserver/install/adtrustinstance.py:101: [E1120, ADTRUSTInstance.__create_samba_user] No value passed for parameter 'modlist' in function call ipaserver/install/adtrustinstance.py:190:

Re: [Freeipa-devel] make-lint failures

2011-11-29 Thread Alexander Bokovoy
On Tue, 29 Nov 2011, Rob Crittenden wrote: Seeing some new make-lint failures after the reworking of ipaldap function signatures; $ ./make-lint ipaserver/install/adtrustinstance.py:101: [E1120, ADTRUSTInstance.__create_samba_user] No value passed for parameter 'modlist' in function call

Re: [Freeipa-devel] Activation and password reset webapp UI

2011-11-29 Thread Endi Sukma Dewata
On 11/28/2011 3:11 PM, Ryan Thomson wrote: Hello, Attached is my amateur attempt at contributing to FreeIPA. The patch implements an account activation and password reset webapp UI to cover use cases where FreeIPA may be acting only as a backend to services such as Samba or other web

Re: [Freeipa-devel] make-lint failures

2011-11-29 Thread John Dennis
On 11/29/2011 05:12 PM, Alexander Bokovoy wrote: On Tue, 29 Nov 2011, Rob Crittenden wrote: Seeing some new make-lint failures after the reworking of ipaldap function signatures; $ ./make-lint ipaserver/install/adtrustinstance.py:101: [E1120, ADTRUSTInstance.__create_samba_user] No value

Re: [Freeipa-devel] Activation and password reset webapp UI

2011-11-29 Thread Ryan Thomson
Hi Endi, Thanks for reviewing the patch. Looks like I have some work to do. 1-2) I have to admit I didn't even try building with these patches. I was pretty sure install/Makefile.am would need modification to install it but I didn't know if submitting patches to install/Makefile.am and the

Re: [Freeipa-devel] Activation and password reset webapp UI

2011-11-29 Thread Adam Young
On 11/29/2011 08:57 PM, Ryan Thomson wrote: Hi Endi, Thanks for reviewing the patch. Looks like I have some work to do. 1-2) I have to admit I didn't even try building with these patches. I was pretty sure install/Makefile.am would need modification to install it but I didn't know if