[Freeipa-devel] [PATCH] 201 Fixed dirty dialog problems in HBAC/Sudo rules.

2011-07-07 Thread Endi Sukma Dewata
The update() in HBAC/Sudo details facet has been fixed to call the callback function which will show the dirty dialog properly. Ticket #1439 -- Endi S. Dewata From 673b6b00c036512bff70fca7e1ec23b44ff55231 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 7 Jul 2011 15:42:57 -0400 Subject

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 7:56 PM, Adam Young wrote: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Looks like this works even for checkboxes. There seems to be a race condition. Open the group adder dialog, then click Add. Sometimes only group name gets an er

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. To test, open user's adder dialog, don't enter anything, just click Add. The server will return an error (i.e. check_required() not called). Another

[Freeipa-devel] [PATCH] 200 Fixed blank self-service page.

2011-07-06 Thread Endi Sukma Dewata
The self-service navigation has been fixed to include the root of the navigation path. Ticket #1445 -- Endi S. Dewata From c3d8864cc64362f10b166ffc3ba3b184f97087e9 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 6 Jul 2011 17:39:49 -0400 Subject: [PATCH] Fixed blank self-service page.

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 4:44 PM, Adam Young wrote: On 07/06/2011 04:51 PM, Adam Young wrote: On 07/06/2011 03:54 PM, Adam Young wrote: On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view Some issues: 1. The red 'deny' text doesn't line up with the colum header or 'allow' text. The padding-left in .hbac-deny-rule class should be removed.

[Freeipa-devel] [PATCH] 199 Fixed HBAC/Sudo rules associations.

2011-07-06 Thread Endi Sukma Dewata
The HBAC/Sudo rules associations in users, groups, hosts and host groups have been fixed to use the correct associator and method names. Ticket #1438 -- Endi S. Dewata From 8a66e77d5d16a8150aa147e87813758ffe6e99f8 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 6 Jul 2011 10:03:04 -050

Re: [Freeipa-devel] [PATCH] 0263-password-expiration-label

2011-07-05 Thread Endi Sukma Dewata
On 7/5/2011 3:38 PM, Adam Young wrote: ACK but it needs a rebase. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0262-validate-ints

2011-07-05 Thread Endi Sukma Dewata
On 7/5/2011 3:00 PM, Adam Young wrote: 1. The validation process should stop after finding the first problem. So the validate_integers() needs to return a value which is then checked by validate() to determine if it should continue. Not really necessary. The validation is still correct, but su

Re: [Freeipa-devel] [PATCH] 198 Fixed object_name usage.

2011-07-05 Thread Endi Sukma Dewata
On 7/5/2011 3:07 PM, Adam Young wrote: I the strings in the plugins are supposed to be read by people, they should be internationalized. Is there any reason to not surround both object_name and object_name_plural with _( )? The original values were not internationalized and also sometimes they

Re: [Freeipa-devel] [PATCH] 198 Fixed object_name usage.

2011-07-05 Thread Endi Sukma Dewata
On 7/5/2011 1:45 PM, Adam Young wrote: On 07/05/2011 02:30 PM, Endi Sukma Dewata wrote: The object_name attribute was used as both an identifier and a label which sometimes require different values (e.g. hbacrule vs. HBAC rule). The code that uses object_name as an identifier has been changed

Re: [Freeipa-devel] [PATCH] 0262-validate-ints

2011-07-05 Thread Endi Sukma Dewata
On 7/5/2011 9:37 AM, Adam Young wrote: Some issues: 1. The validation process should stop after finding the first problem. So the validate_integers() needs to return a value which is then checked by validate() to determine if it should continue. 2. This is actually an existing problem, so

Re: [Freeipa-devel] [PATCH] 0261-entity-link-for-password-policy

2011-07-01 Thread Endi Sukma Dewata
On 7/1/2011 1:08 PM, Adam Young wrote: ACK but there's a jslint warning. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 197 Added arrow icons for details sections.

2011-07-01 Thread Endi Sukma Dewata
New arrow icons have been added to replace the plus/minus sign icons for expanding/collapsing details sections. Ticket #1422 -- Endi S. Dewata From b5901eddb5f77c2b06101815181e58bf344338ac Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 1 Jul 2011 13:37:43 -0500 Subject: [PATCH] Added

[Freeipa-devel] [PATCH] 196 Fixed button style in Entitlements

2011-06-30 Thread Endi Sukma Dewata
Pushed under one-liner rule. The entitlement buttons are located serveral levels underneath facet-controls, so the CSS selector has been fixed to extend beyond facet-controls' immediate children. Ticket #1419 -- Endi S. Dewata ___ Freeipa-devel maili

Re: [Freeipa-devel] [PATCH] 195 Added confirmation dialog for user activation.

2011-06-30 Thread Endi Sukma Dewata
On 6/30/2011 9:02 PM, Adam Young wrote: ACK. Minor tweak, put the "take effect immediately " on its own line so it stands out. Fixed and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.

[Freeipa-devel] [PATCH] 195 Added confirmation dialog for user activation.

2011-06-30 Thread Endi Sukma Dewata
The IPA.user_status_widget has been modified such that it checks the facet dirty status and asks the admin to either Update or Reset the changes. Then the widget shows a dialog to confirm whether the admin wants to activate/deactivate the user. Ticket #1395 -- Endi S. Dewata From c753984bf96d44f

Re: [Freeipa-devel] [PATCH] 0261-entity-link-for-password-policy

2011-06-30 Thread Endi Sukma Dewata
On 6/30/2011 4:42 PM, Adam Young wrote: Some issues: 1. Suppose initially you open an entry that contains a value that matches no_link_value, it will hide the link and show the label. Then suppose you open another entry that has no value, it will empty the link but leaving the label from t

Re: [Freeipa-devel] [PATCH] 0260-config-widgets

2011-06-30 Thread Endi Sukma Dewata
On 6/30/2011 12:57 PM, Adam Young wrote: As mentioned in ticket #1409, the checkbox should have a label (i.e. Enabled). Otherwise it's not clear what the checkbox means for migration mode. Other than that it's ACKed. -- Endi S. Dewata ___ Freei

Re: [Freeipa-devel] [PATCH] 193 Fixed hard-coded messages.

2011-06-30 Thread Endi Sukma Dewata
On 6/30/2011 11:45 AM, Endi Sukma Dewata wrote: On 6/30/2011 9:37 AM, Endi Sukma Dewata wrote: Hard-coded messages in the UI have been replaced with I18n messages. Ticket #1396 Rebased. Sent the wrong patch, attached should be the right one. -- Endi S. Dewata From

[Freeipa-devel] [PATCH] 194 Removed unused images.

2011-06-30 Thread Endi Sukma Dewata
Images that are no longer used have been removed. Ticket #990 -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0258-undefined-pkeys

2011-06-29 Thread Endi Sukma Dewata
On 6/29/2011 3:24 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0257-containing-entity-pkeys

2011-06-29 Thread Endi Sukma Dewata
On 6/29/2011 11:30 AM, Adam Young wrote: On 06/29/2011 10:34 AM, Adam Young wrote: On 06/29/2011 09:37 AM, Adam Young wrote: Better solution than the algorithm in 256 for nested entities. Changes for Hyphen and pkey names Some issues: 1. This statement will store undefined values into url_s

Re: [Freeipa-devel] [PATCH] shorten-url

2011-06-28 Thread Endi Sukma Dewata
On 6/28/2011 4:57 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] shorten-url

2011-06-28 Thread Endi Sukma Dewata
On 6/28/2011 2:33 PM, Adam Young wrote: On 06/28/2011 03:13 PM, Adam Young wrote: One known issue: uses the wrong style for automount tabs, leaving excess white space Some issues: 1. Reloading the some pages will bring you to a different page (i.e. bookmarking wouldn't work). Try reloading

Re: [Freeipa-devel] [PATCH] 0254-Generate-record-type-list-from-metadata

2011-06-28 Thread Endi Sukma Dewata
On 6/28/2011 1:07 PM, Adam Young wrote: This is for https://fedorahosted.org/freeipa/ticket/945 ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-deve

[Freeipa-devel] [PATCH] 192 Fixed undo all problem.

2011-06-27 Thread Endi Sukma Dewata
The IPA.multivalued_text_widget has been modified such that the 'undo all' will appear only if at least one of the values is dirty. Ticket #1109 -- Endi S. Dewata From 4b53e340d94465a87077c93852731e2f72d6ad95 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 27 Jun 2011 17:31:55 -0500 Su

Re: [Freeipa-devel] [PATCH] 0253-validate-required-fields

2011-06-27 Thread Endi Sukma Dewata
On 6/27/2011 3:58 PM, Adam Young wrote: Since the optional attribute is now added into IPA.widget, the following line on dialog.js:347 is no longer needed: field.optional = field_spec.optional || false; Other than that it's ACKed. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 191 Fixed DNS records page title.

2011-06-24 Thread Endi Sukma Dewata
On 6/24/2011 5:55 PM, Adam Young wrote: On 06/24/2011 03:43 PM, Endi Sukma Dewata wrote: The DNS records are presented as a facet in the DNS zone details page, so the page title should say DNS Zone. Forgot to add the patch Patch attached. -- Endi S. Dewata From

[Freeipa-devel] [PATCH] 191 Fixed DNS records page title.

2011-06-24 Thread Endi Sukma Dewata
The DNS records are presented as a facet in the DNS zone details page, so the page title should say DNS Zone. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 190 Removed invalid associations.

2011-06-24 Thread Endi Sukma Dewata
The following invalid associations have been removed: - group's memberindirect netgroup and role - hostgroup's memberofindirect host Ticket #1366 Ticket #1367 -- Endi S. Dewata From 188a71c189882b896dc072e6e86a141d99839a5e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 24 Jun 2011 1

Re: [Freeipa-devel] [PATCH] 0249-optional-uid.

2011-06-24 Thread Endi Sukma Dewata
On 6/24/2011 1:26 PM, Adam Young wrote: The old code on dialog.js:325-331 can be removed. It would be nice to set the focus to the input field automatically once you 'click to show'. But this might require adding focus() to all widgets. This can be done later. Other than that it's ACKed.

[Freeipa-devel] [PATCH] 188 Added singular entity labels.

2011-06-24 Thread Endi Sukma Dewata
A new attribute label_singular has been added to all entities which contains the singular form of the entity label in lower cases except for acronyms (e.g. HBAC) or proper nouns (e.g. Kerberos). In the Web UI, this label can be capitalized using CSS text-transform. The existing 'label' attribute

[Freeipa-devel] [PATCH] 187 Added record count into association facet tabs.

2011-06-23 Thread Endi Sukma Dewata
The details and association facets have been modified to show the number of records in each association in the corresponding facet tab. Ticket #1386 -- Endi S. Dewata From 3e6f3e2ce48b4405369006c101c0eda8b8f17b9b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 23 Jun 2011 11:44:44 -05

Re: [Freeipa-devel] [PATCH] 0252 Automount keys details

2011-06-23 Thread Endi Sukma Dewata
On 6/23/2011 4:18 PM, Adam Young wrote: Some issues: 1. Breadcrumb is not displayed in the automount key details facet. This is because usually when an entity only has 1 facet it will not have a back link/breadcrumb. That's not the case for automount key, so it has to be explicitly enabled

Re: [Freeipa-devel] [PATCH] 0010-Facet-icon-swap-and-tab-sizing

2011-06-23 Thread Endi Sukma Dewata
On 6/21/2011 11:13 AM, Kyle Baker wrote: Minor tweaks to the sizing of the facet tabs as well as new icons under the facets. Attached a screen shot of 0009 and 0010 results. The same screen shot is attached in 0009 as well. ACK and pushed to master. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 0009-Tab-and-spacing-on-list

2011-06-23 Thread Endi Sukma Dewata
On 6/21/2011 12:32 PM, Kyle Baker wrote: Both of those suggestions would be great, but it will require new styles to be created 1. we need a style for facet-controls on a list page and a totally separate style for controls on the detail pages. 2. This will require a umbrella style for all facet

[Freeipa-devel] [PATCH] 186 Added navigation breadcrumb.

2011-06-22 Thread Endi Sukma Dewata
Navigation breadcrumb has been added to the facet header. The breadcrumb will appear on details, association, and automount facets. Ticket #1323 -- Endi S. Dewata From 5bf32d412bbdd1b4d6bd78a5a1944c75af954b3b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 22 Jun 2011 21:54:28 -0500 Su

Re: [Freeipa-devel] [PATCH] 0251-absolute-to-relative

2011-06-22 Thread Endi Sukma Dewata
On 6/22/2011 9:14 AM, Adam Young wrote: As discussed over IRC, in this particular case the absolute positioning still has advantages over relative because it allows the elements in the header (e.g. title, back link, facet tabs, controls) to attach 'relative' to the header's borders. This

Re: [Freeipa-devel] [PATCH] 0250-tooltips-for-host-add

2011-06-21 Thread Endi Sukma Dewata
On 6/21/2011 1:52 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0009-Tab-and-spacing-on-list

2011-06-21 Thread Endi Sukma Dewata
On 6/21/2011 11:09 AM, Kyle Baker wrote: Changes some spacing on the list and facet tab pages as well as styles the tabs. This patch and 0010 should result in the attached screen shot. Some issues: 1. This is actually an existing problem, but it looks like we're relying a lot on button label

[Freeipa-devel] [PATCH] 184 Fixed problem with navigation tabs on reload.

2011-06-21 Thread Endi Sukma Dewata
The navigation have been fixed to show the correct active tabs after browser reload. Ticket #1362 -- Endi S. Dewata From ba291d0dad1b3f5aed3980b6dcc5790060ef Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 21 Jun 2011 09:18:24 -0500 Subject: [PATCH] Fixed problem with navigation ta

Re: [Freeipa-devel] [PATCH] 0249-optional-uid.

2011-06-21 Thread Endi Sukma Dewata
On 6/20/2011 8:25 PM, Adam Young wrote: Note that this patch needs a review by UXD in addition to code review Some issues: 1. The patch tries to find the elements to be hidden using span.find('input'). This will not work with all widgets because some widgets use other elements or some co

Re: [Freeipa-devel] [PATCH] 0247-entity-select-for-password-policy

2011-06-20 Thread Endi Sukma Dewata
On 6/20/2011 10:01 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0248-ipaddress-for-host-add

2011-06-20 Thread Endi Sukma Dewata
On 6/20/2011 2:44 PM, Adam Young wrote: ACK. As mentioned over IRC, it's better to show the IP address field before the force checkbox. This can be fixed before push. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-20 Thread Endi Sukma Dewata
On 6/17/2011 3:00 PM, Adam Young wrote: This version does the whitelist approach ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] 0245-entity-select-undo

2011-06-20 Thread Endi Sukma Dewata
On 6/18/2011 8:46 PM, Adam Young wrote: ACK and pushed to master. The set_dirty() invocation in reset() is no longer needed. This can be fixed later. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.co

Re: [Freeipa-devel] [PATCH] 0242-hide-automount-tabs

2011-06-20 Thread Endi Sukma Dewata
On 6/20/2011 11:32 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0243-entity-select-widget-for-manager

2011-06-20 Thread Endi Sukma Dewata
On 6/18/2011 8:18 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] 0241-enforce-proper-capitalization-with-stylesheet.

2011-06-17 Thread Endi Sukma Dewata
On 6/17/2011 4:00 PM, Adam Young wrote: Please take a look at the following capitalization. If these are considered OK feel free to push. Host-group => Host-group (the g is not capitalized) Max lifetime (days) => Max Lifetime (Days) (unit is capitalized) Min lifetime (hours) => Min Li

[Freeipa-devel] [PATCH] 183 Storing page number in URL.

2011-06-17 Thread Endi Sukma Dewata
The association facet has been modified to store the current page number in the browser's URL. This way page changes are stored in browser's history allowing the back button to work properly. Ticket #1264 -- Endi S. Dewata From 5f4c75eaa3012d97bbeec9c8dd576a8cfdcc6d81 Mon Sep 17 00:00:00 2001 Fr

[Freeipa-devel] [PATCH] 182 Merged direct and indirect association facets

2011-06-16 Thread Endi Sukma Dewata
The direct and indirect associations are now displayed in the same facet. The type of association to be displayed can be selected using radio buttons. Ticket #1338 -- Endi S. Dewata From 8e667ca1c43fc2b766027d94b48bfc7b3b00a095 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 16 Jun 201

Re: [Freeipa-devel] [PATCH]0240-test-dirty-onchange

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 2:39 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0239-test-dirty-multivalue

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 2:26 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0238-test-for-dirty

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 11:46 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 181 Fixed self-service links.

2011-06-16 Thread Endi Sukma Dewata
In self-service mode the user's association facets have been modified such that the entries are not linked since the only available entity is the user entity. A 'link' parameter has been added to IPA.association_facet and IPA.column to control whether to link the entries. The link_handler() metho

Re: [Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 6:44 PM, Adam Young wrote: On 06/15/2011 02:37 PM, Adam Young wrote: Part 2 https://fedorahosted.org/freeipa/ticket/1281 Now iterates through a list of known error types. If the server is down (service ipa stop) it throws an error with name 'NS_ERROR_NOT_AVAILABLE' which is n

[Freeipa-devel] [PATCH] 180 Renamed associate.js to association.js.

2011-06-15 Thread Endi Sukma Dewata
-- Endi S. Dewata From a84e4ad9d6327d3f0a17ba860ca53a7d883ad7d4 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 14 Jun 2011 00:02:54 -0500 Subject: [PATCH] Renamed associate.js to association.js. --- install/ui/Makefile.am |2 +- install/ui/{associate.js => as

[Freeipa-devel] [PATCH] 179 Fixed paging for indirect members.

2011-06-15 Thread Endi Sukma Dewata
Since ticket #1273 has been fixed, the indirect members can be shown using the regular association facet which supports paging. -- Endi S. Dewata From eae218c660109479c6a5f355f5ad184cbfe10c63 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 13 Jun 2011 16:18:48 -0500 Subject: [PATCH] Fix

[Freeipa-devel] Entity labels

2011-06-15 Thread Endi Sukma Dewata
Hi All, We need I18n labels for the entities to be used inside help messages and UI. Please take a look at the following tickets: https://fedorahosted.org/freeipa/ticket/1217 https://fedorahosted.org/freeipa/ticket/1249 Depending on the usage, we might need 4 different labels for each entity:

Re: [Freeipa-devel] [PATCH] 0236-no-redirect-on-search

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 11:37 AM, Adam Young wrote: Removed extra whitespace Facet can override what to do on error There's a jslint warning, but other than that it can be pushed. This patch fixes the first item in ticket #1281. The second item is still a problem. Steps to reproduce: 1. Open a search

[Freeipa-devel] [PATCH] 178 Removed FreeWay font files.

2011-06-15 Thread Endi Sukma Dewata
The CSS files in install/html and install/migration have been modified to use the Overpass font. The changes can be verified here: http://edewata.fedorapeople.org/freeipa/install/html/unauthorized.html http://edewata.fedorapeople.org/freeipa/install/migration/index.html -- Endi S. Dewata __

Re: [Freeipa-devel] [PATCH] 177 Fixed build break.

2011-06-15 Thread Endi Sukma Dewata
On 6/15/2011 10:51 AM, Martin Kosek wrote: On Wed, 2011-06-15 at 10:23 -0500, Endi Sukma Dewata wrote: The Makefile.am freeipa.spec.in have been updated according to the recent file changes. ACK. Works fine. Pushed to master. Thanks! -- Endi S. Dewata

[Freeipa-devel] [PATCH] 177 Fixed build break.

2011-06-15 Thread Endi Sukma Dewata
The Makefile.am freeipa.spec.in have been updated according to the recent file changes. -- Endi S. Dewata From a5cbeb30e1097d3d653900cced3d76c2b7cc2b94 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 15 Jun 2011 09:18:05 -0500 Subject: [PATCH] Fixed build break. The Makefile.am freeipa

Re: [Freeipa-devel] [PATCH] 0235-dns-multiple-records

2011-06-14 Thread Endi Sukma Dewata
On 6/14/2011 11:41 AM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/1319 ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0017-List-page-spacing-changes

2011-06-14 Thread Endi Sukma Dewata
On 6/14/2011 4:41 PM, Endi Sukma Dewata wrote: On 6/14/2011 10:47 AM, Kyle Baker wrote: Endi, Adjusted the spacing on the patch Endi merged. Kyle Baker Visual Designer Desk - 978 392 3116 IRC - kylebaker I pushed patch #16 and #17 to master with some minor adjustments. You probably meant to

Re: [Freeipa-devel] [PATCH] 0017-List-page-spacing-changes

2011-06-14 Thread Endi Sukma Dewata
On 6/14/2011 10:47 AM, Kyle Baker wrote: Endi, Adjusted the spacing on the patch Endi merged. Kyle Baker Visual Designer Desk - 978 392 3116 IRC - kylebaker I pushed patch #16 and #17 to master with some minor adjustments. You probably meant to remove the empty space between the page title an

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-14 Thread Endi Sukma Dewata
On 6/14/2011 8:46 AM, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 10:28 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: NACK. If there's a circular membership the code will run into an infinite loop. Here's a test scenario: Group 1 has 2 members: group 2 and grou

Re: [Freeipa-devel] [PATCH] 176 Fixed tab navigation.

2011-06-14 Thread Endi Sukma Dewata
On 6/13/2011 7:48 PM, Adam Young wrote: On 06/13/2011 07:28 PM, Endi Sukma Dewata wrote: The buttons were previously skipped during tab navigation because they do not have an href attribute. The IPA.button has been fixed to always provide an href attribute. Ticket #983 ACK. Pushed to

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-14 Thread Endi Sukma Dewata
On 6/13/2011 10:28 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: NACK. If there's a circular membership the code will run into an infinite loop. Here's a test scenario: Group 1 has 2 members: group 2 and group 3. Group 2 is a member of group 3. Group 3 is a member of group

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Endi Sukma Dewata
On 6/13/2011 6:00 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group

[Freeipa-devel] [PATCH] 176 Fixed tab navigation.

2011-06-13 Thread Endi Sukma Dewata
The buttons were previously skipped during tab navigation because they do not have an href attribute. The IPA.button has been fixed to always provide an href attribute. Ticket #983 -- Endi S. Dewata From 13a15e6de3ef904f33fd3ba8611f5d9bebd656aa Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Endi Sukma Dewata
On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group. So if group2 was a member of group1 and group3 was a member of group2 we

[Freeipa-devel] [PATCH] 175 Entitlement status.

2011-06-09 Thread Endi Sukma Dewata
A new facet has been added to show entitlement status and download the registration certificate. -- Endi S. Dewata From 34b60284da66082b7d7a954ed02b545665fd1d16 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 27 Apr 2011 12:17:13 -0500 Subject: [PATCH] Entitlement status. A new facet h

[Freeipa-devel] [PATCH] 174 Added selectable option for table widget.

2011-06-09 Thread Endi Sukma Dewata
A selectable option has been added to the table widget to show/hide the checkbox column for selecting table rows. By default it's set to true. The indirect association facet has been modified to hide the column because it is non-editable. -- Endi S. Dewata From a5b4c76264704670ead3e00d5531d29210e

Re: [Freeipa-devel] [PATCH] 793 add uid, gid and e-mail to user default attributes

2011-06-08 Thread Endi Sukma Dewata
On 6/8/2011 12:45 PM, Rob Crittenden wrote: Add uid, gid and e-mail to the default list of attributes for users. This will mostly affect user-show. ticket https://fedorahosted.org/freeipa/ticket/1265 ACK and pushed to master. -- Endi S. Dewata ___

[Freeipa-devel] [PATCH] 172 Fixed blank dialog box on internal error.

2011-06-03 Thread Endi Sukma Dewata
Previously when an internal error occurs on the server the UI will display a blank error dialog box. To fix the problem the string message thrown by Ajax has been converted into an object containing the error message. Ticket #1280 -- Endi S. Dewata From 9f810487cab9fb7c08caf5f53672dcafbf6defa2 M

[Freeipa-devel] [PATCH] 171 Temporary fix for indirect member tabs.

2011-06-02 Thread Endi Sukma Dewata
Since the group-show command doesn't return indirect members, the tabs for group's indirect members have been reverted to call user-find with the --in-groups parameter to get the entries. However, this is only a temporary solution since the user-find command returns both direct and indirect membe

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-06-01 Thread Endi Sukma Dewata
On 6/1/2011 10:09 AM, Adam Young wrote: 11. The option values for automount map adder dialog could be simplified to "direct" and "indirect". The values used are what is appended to the command's method. Had to leave them as is to keep that working. The option values (direct & indirect) could

Re: [Freeipa-devel] [PATCH] 0231-redirect-on-error

2011-06-01 Thread Endi Sukma Dewata
On 6/1/2011 8:36 AM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/1227 ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0230-redirect-on-show-erro

2011-05-31 Thread Endi Sukma Dewata
On 5/31/2011 4:50 PM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/1227 ACK and pushed to master. This patch fixes the details page, but for some entities the default facet is association instead of details. It can be fixed in another patch. -- Endi S. Dewata _

[Freeipa-devel] [PATCH] 170 Fixed pagination problem.

2011-05-31 Thread Endi Sukma Dewata
The association table needs to be emptied if there is no entries. Pushed under one-liner rule. -- Endi S. Dewata From 647c7f55ea5a9803dad8c088ccaa0a8c716acdc8 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 31 May 2011 16:55:56 -0500 Subject: [PATCH] Fixed pagination problem. The asso

Re: [Freeipa-devel] [PATCH] 169 Added pagination for associations.

2011-05-31 Thread Endi Sukma Dewata
On 5/31/2011 3:38 PM, Endi Sukma Dewata wrote: On 5/31/2011 2:18 PM, Endi Sukma Dewata wrote: The association facet has been modified to support pagination. The UI will show 20 members per page. There are buttons to go to a previous or next page. There is also an input text to jump directly to

Re: [Freeipa-devel] [PATCH] 169 Added pagination for associations.

2011-05-31 Thread Endi Sukma Dewata
On 5/31/2011 2:18 PM, Endi Sukma Dewata wrote: The association facet has been modified to support pagination. The UI will show 20 members per page. There are buttons to go to a previous or next page. There is also an input text to jump directly to a certain page. Ticket #1011 Attached is a

[Freeipa-devel] [PATCH] 169 Added pagination for associations.

2011-05-31 Thread Endi Sukma Dewata
The association facet has been modified to support pagination. The UI will show 20 members per page. There are buttons to go to a previous or next page. There is also an input text to jump directly to a certain page. Ticket #1011 -- Endi S. Dewata From fb05d4c5f5bfbf082da8a104aa93bdbe08368577 Mo

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Endi Sukma Dewata
On 5/31/2011 11:59 AM, Adam Young wrote: Some issues: 1. The labels for mount and parentmap fields in automount map are missing. 2. The mount and parentmap fields in automount map adder dialog shows undo button. This can be fixed by adding "undo: false" parameter. 3. The Delete button

[Freeipa-devel] [PATCH] 168 Fixed problem deleting value in text field.

2011-05-27 Thread Endi Sukma Dewata
Previously deleting a value in a text field did not work because the field is not included in the modify operation when the value is empty. The details facet's update() method has been modified to update only dirty fields. The section lists in details facet and dialog have been converted into ord

[Freeipa-devel] [PATCH] 167 Added Update and Reset buttons into Dirty dialog.

2011-05-27 Thread Endi Sukma Dewata
The Dirty dialogs have been combined into IPA.dirty_dialog. It provides the Update and Reset buttons with customizable callback. Previously the widget's dirty status is computed by comparing the old values with the new values. This method is sometimes inaccurate, so the is_dirty() method has been

[Freeipa-devel] [PATCH] 166 Fixed URL parameter parsing.

2011-05-26 Thread Endi Sukma Dewata
The $.bbq.getState() invocations have been modified not to coerce URL parameter values to avoid parsing error. Ticket #1208 -- Endi S. Dewata From 0543036b5d59cb8769ee1857737fddf582613a13 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 23 May 2011 17:48:37 -0500 Subject: [PATCH] Fixed

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-26 Thread Endi Sukma Dewata
On 5/25/2011 7:58 PM, Adam Young wrote: 17. The adder dialog boxes for map and key don't have a title. The titles should be defined in internal.py and the ipa_init.json needs to be regenerated. Fixed The ipa_init.json doesn't seem to be updated yet. More changes in this patch. I combined m

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Endi Sukma Dewata
A few more minor problems: On 5/25/2011 2:54 PM, Adam Young wrote: 12. The automount map has a description field which can be specified during add & modify. The UI doesn't have this. Fixed It's still missing from the map's adder dialog box. 17. The adder dialog boxes for map and key don't ha

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Endi Sukma Dewata
On 5/25/2011 11:31 AM, Adam Young wrote: 8. The column in the maps search facet doesn't have a title. Done. This actually was an indication of a deeper problem, that the columns were pointing to the wrong entity for param info. This is because the nested_search_facet is defined in the contain

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-24 Thread Endi Sukma Dewata
On 5/24/2011 5:32 PM, Adam Young wrote: On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote: On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed elsewhere. 1. The 3rd level tabs (Location, Maps

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-24 Thread Endi Sukma Dewata
On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed elsewhere. Some issues: 1. The 3rd level tabs (Location, Maps, Keys) can be removed because there's already a breadcrumb which provides th

[Freeipa-devel] [PATCH] 165 Fixed Selenium tests.

2011-05-24 Thread Endi Sukma Dewata
Fixed some validation and synchronization problems in Selenium tests. -- Endi S. Dewata From a944a440bc42948a2037675118eff20d0c480c7f Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 24 May 2011 01:17:37 -0400 Subject: [PATCH] Fixed Selenium tests. Fixed some validation and synchronizat

Re: [Freeipa-devel] [PATCH] 163 Fixed adder dialog title.

2011-05-24 Thread Endi Sukma Dewata
On 5/24/2011 9:43 AM, Adam Young wrote: On 05/23/2011 05:32 PM, Endi Sukma Dewata wrote: The IPA.entity_builder has been fixed to use the correct title for the entity's adder dialog. Ticket #1239 Seems like a lot of duplication in the messages. Shouldn't it be more along the li

[Freeipa-devel] [PATCH] 164 Fixed Add and Edit without primary key.

2011-05-23 Thread Endi Sukma Dewata
The IPA.add_dialog has been modified such that if the user clicks the Add and Edit button it will read the primary key returned by the add operation and use it to open the details page. Ticket #1108 -- Endi S. Dewata From f426b0502f27a2d149a1e2d51ec887aefaffd6bf Mon Sep 17 00:00:00 2001 From: En

[Freeipa-devel] [PATCH] 163 Fixed adder dialog title.

2011-05-23 Thread Endi Sukma Dewata
The IPA.entity_builder has been fixed to use the correct title for the entity's adder dialog. Ticket #1239 -- Endi S. Dewata From b28c0b343175981f259d24b71efa1a8d62669797 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 20 May 2011 23:29:38 -0500 Subject: [PATCH] Fixed adder dialog titl

[Freeipa-devel] [PATCH] 162 Fixed details tests.

2011-05-23 Thread Endi Sukma Dewata
Pushed under one-liner rule. -- Endi S. Dewata From 57e9da2a638a7b9ea7fd6396da681085388afb71 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 23 May 2011 14:48:31 -0500 Subject: [PATCH] Fixed details tests. --- install/ui/test/details_tests.js |2 +- 1 files changed, 1 insertions(+

Re: [Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Endi Sukma Dewata
On 5/23/2011 9:42 AM, Adam Young wrote: Patch 227 is the automount patch that I still am not ready to submit. This patch stands alone. A few issues in IPA.get_entity(): 1. It executes that.entities.get() twice. The result of the first invocation can be stored in a variable and reused later.

<    3   4   5   6   7   8   9   10   11   12   >