Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

2016-01-12 Thread Milan Kubik
Hello, sorry for delays. The patch no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" To: "Milan Kubík" Cc: freeipa-devel@redhat.com Sent: Wednesday, 9 December, 2015 7:01:02 PM Subject: Re:

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

2016-01-12 Thread Milan Kubik
Hi, the patch no longer applies to master. Please rebase it. Thanks, Milan - Original Message - From: "Filip Skola" To: freeipa-devel@redhat.com Cc: "Milan Kubík" , "Aleš Mareček" Sent: Tuesday, 22 December, 2015 11:56:15 AM

[Freeipa-devel] [patch 0004] spec file: Update the package name from libipa_hbac-python to python-libipa_hbac

2015-07-10 Thread Milan Kubik
Name update + the renamed package breaks 'dnf builddep'. I will report the bug. Yum can take care of the conflict resolution. Patch attached. Milan From 3d79c32ffad3ab280b7d84507d402039b70fa8e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= mku...@redhat.com Date: Fri, 10 Jul

Re: [Freeipa-devel] [patch 0004] spec file: Update the package name from libipa_hbac-python to python-libipa_hbac

2015-07-10 Thread Milan Kubik
On 07/10/2015 12:55 PM, Jan Cholasta wrote: Hi, Dne 10.7.2015 v 12:05 Milan Kubik napsal(a): Name update + the renamed package breaks 'dnf builddep'. I will report the bug. Yum can take care of the conflict resolution. Patch attached. You might as well update libsss_nss_idmap

[Freeipa-devel] [patch 0006] ipalib: pass api instance into textui in doctest snippets

2015-07-10 Thread Milan Kubik
Hi, the recent set of patches that modified api broke the tests that are included in ipalib/cli.py This patch fixes the problems by passing api instance to textui() calls. Milan From 5df216ad49c6787a6e170a483c545d0fdcc99828 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?=

Re: [Freeipa-devel] [patch 0006] ipalib: pass api instance into textui in doctest snippets

2015-07-10 Thread Milan Kubik
On 07/10/2015 01:57 PM, Milan Kubik wrote: Hi, the recent set of patches that modified api broke the tests that are included in ipalib/cli.py This patch fixes the problems by passing api instance to textui() calls. Milan This may not be the complete solution. Similar problems arise

[Freeipa-devel] certprofile test plan update

2015-06-22 Thread Milan Kubik
Hello, here is an update to certificate profile test plan based on the latest version of the design document [1,2]. The test itself is merely CRUD test at the moment. To write a functional test for the feature, I will need to write a test for CA ACLs (to implement the caacl tracker class).

[Freeipa-devel] [PATCH 0003] Fix for a typo in certprofile mod command.

2015-06-19 Thread Milan Kubik
Patch attached. Milan From e8f08c2f5a567701e7991b1db8e796a0b5db0512 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= mku...@redhat.com Date: Fri, 19 Jun 2015 11:57:21 +0200 Subject: [PATCH] Fix for a typo in certprofile mod command. --- ipalib/plugins/certprofile.py | 2 +- 1 file

Re: [Freeipa-devel] [PATCH 0040] generalize certificate creation during testing

2015-06-16 Thread Milan Kubik
On 06/09/2015 01:14 PM, Martin Babinsky wrote: A slight hack to ipatests/test_xmlrpc/testcert.py module in order to enable generation of multiple host/service/user certificates. It should make writing tests for new CA profile/sub-CA/user certificate functionality easier. Hi, looks good to

Re: [Freeipa-devel] [PATCH 0014 v3] Support multiple user and host certificates

2015-06-03 Thread Milan Kubik
On 06/03/2015 01:17 PM, Martin Basti wrote: On 02/06/15 16:03, Jan Cholasta wrote: Dne 2.6.2015 v 12:36 Martin Basti napsal(a): On 02/06/15 11:42, Fraser Tweedale wrote: On Mon, Jun 01, 2015 at 02:50:45PM +0200, Martin Basti wrote: On 01/06/15 06:40, Fraser Tweedale wrote: New version of

[Freeipa-devel] [patch 0002] Abstract the HostTracker class from host plugin test

2015-06-02 Thread Milan Kubik
Hello, this is the (first) patch with the Tracker class implementation based on host plugin test. It is meant to be used as a base class to implement a helper class to write xml-rpc (api) tests for LDAP based plugins and to replace the Declarative class which is used for most of the

Re: [Freeipa-devel] Fix password changes via kadmin

2015-05-29 Thread Milan Kubik
On 05/27/2015 04:50 PM, Martin Babinsky wrote: On 05/27/2015 04:33 PM, Martin Kosek wrote: On 05/27/2015 03:55 PM, Alexander Bokovoy wrote: On Wed, 27 May 2015, Simo Sorce wrote: On Wed, 2015-05-27 at 15:25 +0200, Martin Babinsky wrote: On 05/25/2015 10:48 AM, Martin Babinsky wrote: On

Re: [Freeipa-devel] [PATCH] Fixup fix for 4914

2015-05-29 Thread Milan Kubik
On 05/29/2015 06:03 PM, Simo Sorce wrote: New patch attached. Simo. Hi, thanks for the quick fix. With the patch applied, the server was able to install. ACK Thanks, Milan -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] certprofiles -- problem with delete

2015-05-21 Thread Milan Kubik
Hi Fraser and list, I ran into this when I was tinkering with the commands. The ipa certprofile plugin[s] does not take the backend result into the picture right now. When I tried to delete the *default profile*, the entry from ipa suffix got deleted. However the command failed and the profile

Re: [Freeipa-devel] [PATCH] 801-806 webui-ci: otptoken tests

2015-05-15 Thread Milan Kubik
On 05/12/2015 01:57 PM, Petr Vobornik wrote: On 05/11/2015 01:25 PM, Milan Kubik wrote: On 05/07/2015 01:38 PM, Petr Vobornik wrote: On 02/19/2015 03:51 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4307 For ipa-4-1 apply: - patch 800 (different thread) - patches 801-806

[Freeipa-devel] [QE] Place for test data

2015-05-14 Thread Milan Kubik
Hi list, while drafting the test cases I have realized I don't know how to approach $SUBJ. Is there any agreed on place or 'best practices' for the data that is needed for the testing? What I need for the test is to have a text file/s and pass them as arguments to the command. It is not feasible

Re: [Freeipa-devel] [PATCH] 801-806 webui-ci: otptoken tests

2015-05-11 Thread Milan Kubik
On 05/07/2015 01:38 PM, Petr Vobornik wrote: On 02/19/2015 03:51 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4307 For ipa-4-1 apply: - patch 800 (different thread) - patches 801-806 For master apply: - patch 800 (different thread) - patch 807 (different thread) - patch

Re: [Freeipa-devel] [PATCH] 807 webui-ci: do not open 2 browser windows

2015-05-06 Thread Milan Kubik
On 02/19/2015 03:51 PM, Petr Vobornik wrote: Only for master branch. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK Milan -- Manage your subscription for the Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 800 rpc-client: add forms based auth support

2015-05-06 Thread Milan Kubik
On 02/19/2015 03:51 PM, Petr Vobornik wrote: This patch is a prerequisite for patch 801 which will follow. It was developed to enable to use ipalib RPC client in Web UI tests. Plus it will enable to significantly speed up Web UI tests suite (if preparation of data is transformed to use this

Re: [Freeipa-devel] design review: Certificate Profiles

2015-04-17 Thread Milan Kubik
On 04/16/2015 10:03 AM, Fraser Tweedale wrote: Hi everyone, Please review my Certificate Profiles design proposal: http://www.freeipa.org/page/V4/Certificate_Profiles Let me know what is unclear, what needs expansion, and what is plain wrong :) The schema for storing multiple certificates for

Re: [Freeipa-devel] [PATCH 0027] do not install CA on replica during integration test if setup_ca=False

2015-04-14 Thread Milan Kubik
On 04/08/2015 08:44 AM, Martin Babinsky wrote: I have discovered another little bug in the integration test suite. Attaching a patch that fixes it. Hello, thanks for the patch. I hereby invoke the One Liner rule. Cheers, Milan -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0025] proper client host setup/teardown in forced client reenrollment integration test suite

2015-04-14 Thread Milan Kubik
On 04/14/2015 03:20 PM, Milan Kubik wrote: On 03/31/2015 10:42 AM, Martin Babinsky wrote: During the investigation of https://fedorahosted.org/freeipa/ticket/4614 I discovered a bug (?) in forced client reenrollment integration test. During test scenario, master and replica are setup

Re: [Freeipa-devel] [PATCH 0025] proper client host setup/teardown in forced client reenrollment integration test suite

2015-04-14 Thread Milan Kubik
On 03/31/2015 10:42 AM, Martin Babinsky wrote: During the investigation of https://fedorahosted.org/freeipa/ticket/4614 I discovered a bug (?) in forced client reenrollment integration test. During test scenario, master and replica are setup correctly at the beginning of the test, but the

Re: [Freeipa-devel] [PATCH 0210] DNSSEC: CI test

2015-04-13 Thread Milan Kubik
On 04/08/2015 12:46 PM, Martin Basti wrote: On 07/04/15 15:45, Milan Kubik wrote: On 03/23/2015 03:54 PM, Martin Basti wrote: Hello, a patch with DNSSEC CI tests attached. * Two types of installation tested * Tests check if zones are signed on both replica and master * The root zone test

Re: [Freeipa-devel] [PATCH 0210] DNSSEC: CI test

2015-04-07 Thread Milan Kubik
On 03/23/2015 03:54 PM, Martin Basti wrote: Hello, a patch with DNSSEC CI tests attached. * Two types of installation tested * Tests check if zones are signed on both replica and master * The root zone test also checks chain of trust Can somebody very familiar with pytest do review? I'm not

Re: [Freeipa-devel] [PATCH 0001] ipatests: port of p11helper test from github

2015-03-30 Thread Milan Kubik
Hi, thanks for the review and sparing me few rounds for these modifications. :) ACK for the improvements. Milan On 03/30/2015 10:28 AM, Martin Basti wrote: On 27/03/15 13:52, Milan Kubik wrote: Hi, On 03/24/2015 04:40 PM, Martin Basti wrote: On 24/03/15 14:41, Milan Kubik wrote: Hello

Re: [Freeipa-devel] [PATCH] ipatests: port of p11helper test from github

2015-03-27 Thread Milan Kubik
Hi, On 03/24/2015 04:40 PM, Martin Basti wrote: On 24/03/15 14:41, Milan Kubik wrote: Hello, thanks for the review. On 03/24/2015 12:39 PM, Martin Basti wrote: On 17/03/15 10:38, Milan Kubik wrote: Hi, On 03/16/2015 05:23 PM, Martin Basti wrote: On 16/03/15 15:32, Milan Kubik wrote

Re: [Freeipa-devel] [PATCH] ipatests: port of p11helper test from github

2015-03-24 Thread Milan Kubik
Hello, thanks for the review. On 03/24/2015 12:39 PM, Martin Basti wrote: On 17/03/15 10:38, Milan Kubik wrote: Hi, On 03/16/2015 05:23 PM, Martin Basti wrote: On 16/03/15 15:32, Milan Kubik wrote: On 03/16/2015 12:03 PM, Milan Kubik wrote: On 03/13/2015 02:59 PM, Milan Kubik wrote: Hi

Re: [Freeipa-devel] [PATCH] ipatests: port of p11helper test from github

2015-03-16 Thread Milan Kubik
On 03/16/2015 12:03 PM, Milan Kubik wrote: On 03/13/2015 02:59 PM, Milan Kubik wrote: Hi, this is a patch with port of [1] to pytest. [1]: https://github.com/spacekpe/freeipa-pkcs11/blob/master/python/run.py Cheers, Milan Added few more asserts in methods where the test could fail

[Freeipa-devel] [PATCH] ipatests: port of p11helper test from github

2015-03-13 Thread Milan Kubik
Hi, this is a patch with port of [1] to pytest. [1]: https://github.com/spacekpe/freeipa-pkcs11/blob/master/python/run.py Cheers, Milan From 0bbd56eb04e9494ed008d212dabdf32cf6f36e17 Mon Sep 17 00:00:00 2001 From: Milan Kubik mku...@redhat.com Date: Thu, 12 Mar 2015 16:52:33 +0100 Subject