[Freeipa-devel] [freeipa PR#276][synchronized] replica-conncheck: improve error msg + logging

2016-11-29 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/276 Author: tomaskrizek Title: #276: replica-conncheck: improve error msg + logging Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/276/head:pr276 git checkout

Re: [Freeipa-devel] NTP in FreeIPA

2016-11-29 Thread Jan Cholasta
On 28.11.2016 20:57, Rob Crittenden wrote: David Kupka wrote: On 22/11/16 23:15, Gabe Alford wrote: I would say that it is worth keeping in FreeIPA. I know myself and some customers use its functionality by having the clients sync to the IPA servers and have the servers sync to the NTP source.

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ From offline discussion I got that the PR should actually work in the end. I'll make the review. """ See the full comment at

Re: [Freeipa-devel] NTP in FreeIPA

2016-11-29 Thread Petr Spacek
On 29.11.2016 09:11, Jan Cholasta wrote: > On 28.11.2016 20:57, Rob Crittenden wrote: >> David Kupka wrote: >>> On 22/11/16 23:15, Gabe Alford wrote: I would say that it is worth keeping in FreeIPA. I know myself and some customers use its functionality by having the clients sync to the

[Freeipa-devel] [freeipa PR#225][comment] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides apophys commented: """ Thank you for the change of the order and using the objectclasses module. There are still things I'd like to be changed, though. """ See the full comment at

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization jcholast commented: """ Yes, my above comment is wrong (sorry). """ See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-263505232 -- Manage your

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @martbab Welcome to the party! This discussion has been running for a very long time and in multiple places. Let me bring you up to speed. First of all the requirements in

[Freeipa-devel] [freeipa PR#285][opened] Check the result of cert request in replica installer

2016-11-29 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/285 Author: flo-renaud Title: #285: Check the result of cert request in replica installer Action: opened PR body: """ When running ipa-replica-install in domain-level 1, the installer requests the LDAP and HTTP certificates using certmonger but

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension jcholast commented: """ @frasertweedale, if the subject DN need not match the LDAP DN, then DN SANs need not match it as well - both the subject DN and DN SANs are supposed to

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension frasertweedale commented: """ @jcholast OK. Let's put this PR on ice for now... I may well take up your suggestion to allow subject DN to match LDAP DN, but I don't have the cycles

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension tiran commented: """ @jcholast I'm not familiar with any standard that mandates that a X.509 Subject DN should identify a subject in a directory. Which standard mandates the

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ @tiran You can split patch to useful part and please send unneeded bumping of requires as separate pull request, we can continue with discussion there about bumping

[Freeipa-devel] [freeipa PR#279][synchronized] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-11-29 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/279 Author: dkupka Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/279/head:pr279

[Freeipa-devel] [freeipa PR#271][+ack] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts jcholast commented: """ You missed a few: ``` daemons/dnssec/ipa-dnskeysync-replica:124:ipalib.api.bootstrap(in_server=True, log=None) # no logging to file

[Freeipa-devel] [freeipa PR#280][synchronized] Set explicit confdir option for global contexts

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/280 Author: tiran Title: #280: Set explicit confdir option for global contexts Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/280/head:pr280 git checkout pr280

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension jcholast commented: """ @tiran, could you please stay on topic? I haven't said anything about it being mandatory, and it's not the point anyway (consistency between subject DN and

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension tiran commented: """ I'm on topic and I'm trying to understand your point. Why do you see a relationship between the subject DN of a X.509 and the directoryName general name in SAN

[Freeipa-devel] [freeipa PR#266][comment] ipapython: simplify Env object initialization

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/266 Title: #266: ipapython: simplify Env object initialization stlaz commented: """ This PR breaks almost all tests in test_ipalib/test_crud.py with `AttributeError: 'API' object has no attribute 'env'`. This error can be observed in some other

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts tiran commented: """ I fixed a few. Some scripts deliberately do not have the confdir flag in bootstrap. """ See the full comment at

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ I checked the rebase again as well as ran the tests. The changes in the PR clean the code nicely aside from doing what's proposed in

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts jcholast commented: """ Please explain, all of the affected scripts are server-only and thus not related to the integration effort and most probably won't work correctly with

[Freeipa-devel] [freeipa PR#245][synchronized] Allow full customisability of IPA CA subject DN

2016-11-29 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/245 Author: frasertweedale Title: #245: Allow full customisability of IPA CA subject DN Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/245/head:pr245 git

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-29 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module shanyin commented: """ Hello, I have sent fixing of missing translations as separated PR in https://github.com/freeipa/freeipa/pull/286. The changes in the ipaserver/rpcserver.py file was used for parsing the apache

[Freeipa-devel] [freeipa PR#273][comment] Build: workaround bug while calling parallel make from rpmbuild

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/273 Title: #273: Build: workaround bug while calling parallel make from rpmbuild martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/132b475c2586f3ced68724355e9c45722dccf604 """ See the full comment at

[Freeipa-devel] [freeipa PR#273][+pushed] Build: workaround bug while calling parallel make from rpmbuild

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/273 Title: #273: Build: workaround bug while calling parallel make from rpmbuild Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#273][closed] Build: workaround bug while calling parallel make from rpmbuild

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/273 Author: pspacek Title: #273: Build: workaround bug while calling parallel make from rpmbuild Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/273/head:pr273 git

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ > @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped > because 1.1.x has wrong dependency information for Python 3 (enum34). So, this is broken

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ You said Fedora, I didn't. The build bug is not related to Fedora at all. Cryptography 0.9 does not build on any distribution or platform with a recent version of OpenSSL.

[Freeipa-devel] [freeipa PR#225][synchronized] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/225 Author: ofayans Title: #225: tests: Added basic tests for certs in idoverrides Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/225/head:pr225 git checkout

[Freeipa-devel] [freeipa PR#225][synchronized] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/225 Author: ofayans Title: #225: tests: Added basic tests for certs in idoverrides Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/225/head:pr225 git checkout

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped because 1.1.x has wrong dependency information for Python 3 (enum34). cryptography 0.9 does not

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module mbasti-rh commented: """ Hello, what I meant was to send fixing of missing translations strings as separated PR and if you identified any parts of code that should be logged too, you can send a PR too. Basically

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ PS: There is no technical reason to bump the version of python-gssapi in freeipa.spec. The enum34 dependency issues is solely a Python packaging bug. It does not affect RPM

[Freeipa-devel] [freeipa PR#277][comment] DNS: URI records: bump python-dns requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/277 Title: #277: DNS: URI records: bump python-dns requirements mbasti-rh commented: """ Thank you, fixed. """ See the full comment at https://github.com/freeipa/freeipa/pull/277#issuecomment-263562846 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#277][synchronized] DNS: URI records: bump python-dns requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/277 Author: mbasti-rh Title: #277: DNS: URI records: bump python-dns requirements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/277/head:pr277 git checkout

[Freeipa-devel] [freeipa PR#277][+ack] DNS: URI records: bump python-dns requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/277 Title: #277: DNS: URI records: bump python-dns requirements Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension jcholast commented: """ Ok, > Why do you see a relationship between the subject DN of a X.509 and the > directoryName general name in SAN X.509v3 extension? According to RFC 5280

[Freeipa-devel] [freeipa PR#255][synchronized] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Author: tiran Title: #255: Adjustments for setup requirements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/255/head:pr255 git checkout pr255 From

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped because 1.1.x has wrong dependency information for Python 3 (enum34). cryptography 0.9 does not

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ You said Fedora, I didn't. The build bug is not related to Fedora at all. Cryptography 0.9 does not build on any distribution or platform with a recent version of OpenSSL. """

[Freeipa-devel] [freeipa PR#277][closed] DNS: URI records: bump python-dns requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/277 Author: mbasti-rh Title: #277: DNS: URI records: bump python-dns requirements Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/277/head:pr277 git checkout pr277 --

[Freeipa-devel] [freeipa PR#277][+pushed] DNS: URI records: bump python-dns requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/277 Title: #277: DNS: URI records: bump python-dns requirements Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#277][comment] DNS: URI records: bump python-dns requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/277 Title: #277: DNS: URI records: bump python-dns requirements mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/a291c6ded91611ea2bd1a1fdb96314721d73a75f """ See the full comment at

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ Would you rather claim to be compatible with a broken, unsupported, and old version? """ See the full comment at

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-11-29 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension tomaskrizek commented: """ @frasertweedale Oh, I didn't realize the DN in SAN matches the LDAP DN, while the Subject DN does not. In that case, this PR makes sense to me as is. I

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ So create a separate commits: - fixes ipasetup.py - bumps python-gssapi for pypi, with proper explanation in commit message and maybe comment in code may be helpful. And we

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ > PS: There is no technical reason to bump the version of python-gssapi in > freeipa.spec. The enum34 dependency issues is solely a Python packaging bug. > It does not

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts martbab commented: """ So can you imagine some scenario where this behavior may cause issues? Some exotic DNS setup maybe? """ See the full comment at

[Freeipa-devel] [freeipa PR#282][opened] replicainstall: give correct error message on DL mismatch

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/282 Author: stlaz Title: #282: replicainstall: give correct error message on DL mismatch Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6510 """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#269][comment] Prevent denial of replication updates during CA replica install

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/269 Title: #269: Prevent denial of replication updates during CA replica install mbasti-rh commented: """ Patch does not apply to 4.4.3 branch """ See the full comment at https://github.com/freeipa/freeipa/pull/269#issuecomment-263574061 -- Manage

[Freeipa-devel] [freeipa PR#200][+ack] Test: basic kerberos over http functionality

2016-11-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/200 Title: #200: Test: basic kerberos over http functionality Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#200][comment] Test: basic kerberos over http functionality

2016-11-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/200 Title: #200: Test: basic kerberos over http functionality apophys commented: """ Thank you for rebasing the commits. The test looks good. """ See the full comment at https://github.com/freeipa/freeipa/pull/200#issuecomment-263578009 -- Manage

[Freeipa-devel] [freeipa PR#255][synchronized] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Author: tiran Title: #255: Adjustments for setup requirements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/255/head:pr255 git checkout pr255 From

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient mbasti-rh commented: """ Ticket https://fedorahosted.org/freeipa/ticket/6474 is closed as wontfix and even doesn't seems right to me. """ See the full

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts pspacek commented: """ This entierly depens on configuration. Imagine following imaginary company setup: - public part of DNS tree is `example.com.` - private part of DNS

[Freeipa-devel] [freeipa PR#255][synchronized] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Author: tiran Title: #255: Adjustments for setup requirements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/255/head:pr255 git checkout pr255 From

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient stlaz commented: """ Last I checked the ticket was still open. The ticket was trying to solve the same issue as this PR although its aim shifted (see the

Re: [Freeipa-devel] NTP in FreeIPA

2016-11-29 Thread Rob Crittenden
Petr Spacek wrote: > On 29.11.2016 09:11, Jan Cholasta wrote: >> On 28.11.2016 20:57, Rob Crittenden wrote: >>> David Kupka wrote: On 22/11/16 23:15, Gabe Alford wrote: > I would say that it is worth keeping in FreeIPA. I know myself and some > customers use its functionality by

[Freeipa-devel] [freeipa PR#271][comment] Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/271 Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and ipaclient mbasti-rh commented: """ Ticket updated. """ See the full comment at https://github.com/freeipa/freeipa/pull/271#issuecomment-263581781 -- Manage your

[Freeipa-devel] [freeipa PR#283][opened] [ipa-4-4] Prevent denial of replication updates during CA replica install

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/283 Author: martbab Title: #283: [ipa-4-4] Prevent denial of replication updates during CA replica install Action: opened PR body: """ This is https://github.com/freeipa/freeipa/pull/269 rebased on top of ipa-4-4 branch.

[Freeipa-devel] [freeipa PR#225][synchronized] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread ofayans
URL: https://github.com/freeipa/freeipa/pull/225 Author: ofayans Title: #225: tests: Added basic tests for certs in idoverrides Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/225/head:pr225 git checkout

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts tiran commented: """ All bootstrap() calls without an explicit confdir argument are fine. If you think otherwise, please list all calls and give me a compelling reason to have them

[Freeipa-devel] [freeipa PR#268][comment] Build system must regenerate file when template changes

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/268 Title: #268: Build system must regenerate file when template changes mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ba6ae666acaf8b930d18f45efc7c9c9faad3526b

[Freeipa-devel] [freeipa PR#268][+pushed] Build system must regenerate file when template changes

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/268 Title: #268: Build system must regenerate file when template changes Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts martbab commented: """ I see. I guess we can live with the fact that we may break such eccentric DNS topologies. I think we cannot really handle all the corner cases

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts martbab commented: """ Thinking of this some more, shouldn't be `--no-host-dns` option used and advertised if you want to set unresolvable hostname during install? """ See

[Freeipa-devel] [freeipa PR#177][synchronized] Add options to write lightweight CA cert or chain to file

2016-11-29 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/177 Author: frasertweedale Title: #177: Add options to write lightweight CA cert or chain to file Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/177/head:pr177

[Freeipa-devel] [freeipa PR#177][comment] Add options to write lightweight CA cert or chain to file

2016-11-29 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/177 Title: #177: Add options to write lightweight CA cert or chain to file frasertweedale commented: """ @jcholast thanks for review. PR updated. No longer inheriting `BaseCertObject`. `--chain` now defined server-side and no longer implies

Re: [Freeipa-devel] NTP in FreeIPA

2016-11-29 Thread Petr Spacek
On 29.11.2016 16:02, Rob Crittenden wrote: > Petr Spacek wrote: >> On 29.11.2016 09:11, Jan Cholasta wrote: >>> On 28.11.2016 20:57, Rob Crittenden wrote: David Kupka wrote: > On 22/11/16 23:15, Gabe Alford wrote: >> I would say that it is worth keeping in FreeIPA. I know myself and

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts pspacek commented: """ `--no-host-dns` disables all checks (theoretically) so it should be used only in special cases. Given it acts as kind of force switch, we should not

[Freeipa-devel] [freeipa PR#275][comment] Enhance __repr__ method of Principal

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/275 Title: #275: Enhance __repr__ method of Principal martbab commented: """ Sorry I somehow botched that, but it worked nevertheless. I have re-worked the PR according to your comments. ``` In [1]: import ipapython.kerberos In [2]: p =

Re: [Freeipa-devel] NTP in FreeIPA

2016-11-29 Thread Alexander Bokovoy
On ti, 29 marras 2016, Petr Spacek wrote: On 29.11.2016 16:02, Rob Crittenden wrote: Petr Spacek wrote: On 29.11.2016 09:11, Jan Cholasta wrote: On 28.11.2016 20:57, Rob Crittenden wrote: David Kupka wrote: On 22/11/16 23:15, Gabe Alford wrote: I would say that it is worth keeping in

[Freeipa-devel] [freeipa PR#275][comment] Enhance __repr__ method of Principal

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/275 Title: #275: Enhance __repr__ method of Principal tiran commented: """ Can you please add a test to```ipatests/test_ipapython/test_kerberos.py``` ```test_principals```? Something along the line ```assert repr(princ) ==

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ Well from our (as upstream) POV 0.9 and later is required for Custodia to work correctly. This requirement was introduced by me in commit

[Freeipa-devel] [freeipa PR#275][synchronized] Enhance __repr__ method of Principal

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/275 Author: martbab Title: #275: Enhance __repr__ method of Principal Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/275/head:pr275 git checkout pr275 From

[Freeipa-devel] [freeipa PR#284][opened] ipautil: check for open ports on all resolved IPs

2016-11-29 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/284 Author: tomaskrizek Title: #284: ipautil: check for open ports on all resolved IPs Action: opened PR body: """ When a hostname is provided to host_port_open, it should check if ports are open for ALL IPs that are resolved from the hostname,

[Freeipa-devel] [freeipa PR#275][comment] Enhance __repr__ method of Principal

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/275 Title: #275: Enhance __repr__ method of Principal martbab commented: """ That sound like a good idea. Added such assert to the unit tests. """ See the full comment at https://github.com/freeipa/freeipa/pull/275#issuecomment-263638134 -- Manage

[Freeipa-devel] [freeipa PR#225][comment] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides apophys commented: """ Thank you for addressing the issues. The implementation is somehow minimal, however in the future it can be extended as needed. """ See the full comment at

[Freeipa-devel] [freeipa PR#225][+ack] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#225][closed] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/225 Author: ofayans Title: #225: tests: Added basic tests for certs in idoverrides Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/225/head:pr225 git checkout pr225

[Freeipa-devel] [freeipa PR#225][+pushed] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#225][comment] tests: Added basic tests for certs in idoverrides

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/225 Title: #225: tests: Added basic tests for certs in idoverrides martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ccd3677b50eab2223ddf1e1b6682c20fc695ad24

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts martbab commented: """ Ok I am fine with this. """ See the full comment at https://github.com/freeipa/freeipa/pull/281#issuecomment-263640183 -- Manage your subscription

[Freeipa-devel] [freeipa PR#281][+pushed] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/0e093f938d8126f11fed920b7381ba6e3d07da5b ipa-4-4:

[Freeipa-devel] [freeipa PR#281][closed] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Author: pspacek Title: #281: Accept server host names resolvable only using /etc/hosts Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/281/head:pr281 git checkout

[Freeipa-devel] [freeipa PR#281][+ack] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#267][comment] ipa-replica-conncheck: do not close listening ports until required

2016-11-29 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/267 Title: #267: ipa-replica-conncheck: do not close listening ports until required tomaskrizek commented: """ I've created a separate [ticket](https://fedorahosted.org/freeipa/ticket/6522) and PR #284 for the change discussed offline, since it

[Freeipa-devel] [freeipa PR#275][+ack] Enhance __repr__ method of Principal

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/275 Title: #275: Enhance __repr__ method of Principal Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: