Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Martin Kosek
On 04/08/2015 06:03 PM, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 17:53 +0200, Martin Basti wrote: On 08/04/15 17:46, Luc de Louw wrote: On 04/08/2015 05:14 PM, Martin Basti wrote: On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55,

Re: [Freeipa-devel] [PATCH] 0003-3 User life cycle: new stageuser plugin with add verb

2015-04-08 Thread Jan Cholasta
Dne 25.3.2015 v 10:04 thierry bordaz napsal(a): On 03/24/2015 01:45 PM, Jan Cholasta wrote: Dne 19.3.2015 v 13:07 thierry bordaz napsal(a): On 03/19/2015 07:37 AM, Jan Cholasta wrote: Dne 18.3.2015 v 19:39 thierry bordaz napsal(a): On 03/17/2015 08:01 AM, Jan Cholasta wrote: Dne 16.3.2015 v

Re: [Freeipa-devel] [PATCH] 0003-3 User life cycle: new stageuser plugin with add verb

2015-04-08 Thread Martin Kosek
On 04/08/2015 08:11 AM, Jan Cholasta wrote: Dne 25.3.2015 v 10:04 thierry bordaz napsal(a): On 03/24/2015 01:45 PM, Jan Cholasta wrote: Dne 19.3.2015 v 13:07 thierry bordaz napsal(a): On 03/19/2015 07:37 AM, Jan Cholasta wrote: Dne 18.3.2015 v 19:39 thierry bordaz napsal(a): On 03/17/2015

Re: [Freeipa-devel] [PATCH] 0004 User life cycle: support of MODRDN to a new superior

2015-04-08 Thread Jan Cholasta
Hi, Dne 1.4.2015 v 17:40 thierry bordaz napsal(a): Hello, In user life cycle, Active entries are moved to Delete container and Delete entries can be moved back to Staging container. This requires a LDAP modrdn with new superior that is not supported in ldap2. Since

[Freeipa-devel] [PATCH 0027] do not install CA on replica during integration test if setup_ca=False

2015-04-08 Thread Martin Babinsky
I have discovered another little bug in the integration test suite. Attaching a patch that fixes it. -- Martin^3 Babinsky From 4f4500d01a8b2234c1d3299d854d68926f930faf Mon Sep 17 00:00:00 2001 From: Martin Babinsky mbabi...@redhat.com Date: Tue, 7 Apr 2015 16:51:59 +0200 Subject: [PATCH] do not

Re: [Freeipa-devel] [PATCH 0210] DNSSEC: CI test

2015-04-08 Thread Martin Basti
On 07/04/15 15:45, Milan Kubik wrote: On 03/23/2015 03:54 PM, Martin Basti wrote: Hello, a patch with DNSSEC CI tests attached. * Two types of installation tested * Tests check if zones are signed on both replica and master * The root zone test also checks chain of trust Can somebody very

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/08/2015 10:23 AM, Jan Cholasta wrote: Dne 8.4.2015 v 10:22 David Kupka napsal(a): On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015

Re: [Freeipa-devel] [PATCH] 810 speed up indirect member processing

2015-04-08 Thread Jan Cholasta
Hi, Dne 31.3.2015 v 12:11 Petr Vobornik napsal(a): the old implementation tried to get all entries which are member of group. That means also user. User can't have any members therefore this costly processing was unnecessary. New implementation reduces the search only to entries which can have

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint changed slightly so we must react otherwise we'll be unable

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread Jan Cholasta
Dne 8.4.2015 v 10:22 David Kupka napsal(a): On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint changed

[Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Luc de Louw
Hi there, At the moment ipa otptoken-add-yubikey does not add the parameter APPEND_CR. This prevents submit the password+OTP. APPEND_CR is usually very handy, most people use this functionality. The patch changes the behavior to set APPEND_CR by default and let the user override this by

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Martin Basti
On 08/04/15 17:46, Luc de Louw wrote: On 04/08/2015 05:14 PM, Martin Basti wrote: On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Luc de Louw
On 04/08/2015 05:14 PM, Martin Basti wrote: On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment ipa otptoken-add-yubikey does not add the

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Luc de Louw
On 04/08/2015 05:53 PM, Martin Basti wrote: On 08/04/15 17:46, Luc de Louw wrote: On 04/08/2015 05:14 PM, Martin Basti wrote: On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200,

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Nathaniel McCallum
On Wed, 2015-04-08 at 17:53 +0200, Martin Basti wrote: On 08/04/15 17:46, Luc de Louw wrote: On 04/08/2015 05:14 PM, Martin Basti wrote: On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed,

Re: [Freeipa-devel] Designing better API compatibility

2015-04-08 Thread Martin Kosek
On 03/20/2015 05:00 PM, Petr Vobornik wrote: On 03/20/2015 04:16 PM, Petr Spacek wrote: On 20.3.2015 15:51, Nathaniel McCallum wrote: On Fri, 2015-03-20 at 09:58 -0400, Simo Sorce wrote: On Fri, 2015-03-20 at 14:38 +0100, Martin Kosek wrote: Correct. I see 2 approaches here: a) Thin

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Luc de Louw
On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment ipa otptoken-add-yubikey does not add the parameter APPEND_CR. This prevents submit the password+OTP. APPEND_CR is usually

[Freeipa-devel] [PATCH 408-423] ldap: Remove IPASimpleLDAPObject

2015-04-08 Thread Jan Cholasta
Hi, the attached patches remove IPASimpleLDAPObject from ipaldap. As a result, the one and only IPA LDAP API is the LDAPClient API. Honza -- Jan Cholasta From 89ffd2ed1a058f5d56129dd2b9f62383406898dc Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 23 Oct 2014

Re: [Freeipa-devel] [PATCH] 0004 User life cycle: support of MODRDN to a new superior

2015-04-08 Thread thierry bordaz
On 04/08/2015 08:34 AM, Jan Cholasta wrote: Hi, Dne 1.4.2015 v 17:40 thierry bordaz napsal(a): Hello, In user life cycle, Active entries are moved to Delete container and Delete entries can be moved back to Staging container. This requires a LDAP modrdn with new superior that is

Re: [Freeipa-devel] [PATCH] 0004 User life cycle: support of MODRDN to a new superior

2015-04-08 Thread Jan Cholasta
Dne 8.4.2015 v 15:00 thierry bordaz napsal(a): On 04/08/2015 08:34 AM, Jan Cholasta wrote: Hi, Dne 1.4.2015 v 17:40 thierry bordaz napsal(a): Hello, In user life cycle, Active entries are moved to Delete container and Delete entries can be moved back to Staging container. This

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread Simo Sorce
On Wed, 2015-04-08 at 15:16 +0200, David Kupka wrote: It seems weird to me that all the issues are found in tests only. Not a single report from code. Do you have pytest installed/upgraded? pytest is defined only in Requires not in BuildRequires and maybe this is the problem. I have the

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread Simo Sorce
On Wed, 2015-04-08 at 10:22 +0200, David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread Simo Sorce
On Wed, 2015-04-08 at 10:22 +0200, David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/08/2015 02:53 PM, Simo Sorce wrote: On Wed, 2015-04-08 at 10:22 +0200, David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Nathaniel McCallum
On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment ipa otptoken-add-yubikey does not add the parameter APPEND_CR. This prevents submit the password+OTP. APPEND_CR is usually very handy, most people use this functionality. The patch changes the behavior to

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Martin Basti
On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment ipa otptoken-add-yubikey does not add the parameter APPEND_CR. This prevents submit the password+OTP. APPEND_CR is usually very handy, most people use this functionality.

Re: [Freeipa-devel] [PATCH] otptoken_yubikey, append CR by default and add a option for not doing so

2015-04-08 Thread Martin Basti
On 08/04/15 17:12, Luc de Louw wrote: On 04/08/2015 05:05 PM, Martin Basti wrote: On 08/04/15 16:55, Nathaniel McCallum wrote: On Wed, 2015-04-08 at 11:57 +0200, Luc de Louw wrote: Hi there, At the moment ipa otptoken-add-yubikey does not add the parameter APPEND_CR. This prevents submit

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread Lukas Slebodnik
On (08/04/15 10:22), David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint changed slightly so we