Re: [Freeipa-devel] [PATCH] 894-896 webui: certificate profiles and acls

2015-07-08 Thread Tomas Babej
On 07/08/2015 04:54 PM, Martin Basti wrote: > On 08/07/15 15:11, Petr Vobornik wrote: >> On 07/08/2015 02:24 PM, Petr Vobornik wrote: >>> add Web UI for new certificate objects >>> >>> [PATCH] 894 webui: certificate profiles >>> [PATCH] 895 webui: caacl >>> [PATCH] 896 webui: hide facet tab in ce

Re: [Freeipa-devel] [PATCH 0278] Fix API logging

2015-07-08 Thread Tomas Babej
On 07/08/2015 02:18 PM, Martin Basti wrote: > log must be initilized before first usage in API, otherwise traceback is > shown: > > # ipa -e random-nonexistent-key=1 user-find > Traceback (most recent call last): > File "/bin/ipa", line 32, in > cli.run(api) > File "/usr/lib/python2.7/s

[Freeipa-devel] [PATCHES 0335-0336] adtrustinstance: Enable and start oddjobd

2015-07-08 Thread Tomas Babej
Hi, Enable and start the oddjobd service as part of the ipa-adtrust-install for the new IPA installations and upgraded ones. Tomas From 66d39f12a77d23e8d8ac2c11650258ed9f3eb200 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Wed, 8 Jul 2015 15:44:13 +0200 Subject: [PATCH] adtrustinstance

Re: [Freeipa-devel] [PATCH 463] spec file: Update minimal versions of required packages

2015-07-08 Thread Tomas Babej
On 07/08/2015 01:28 PM, Alexander Bokovoy wrote: > On Wed, 08 Jul 2015, Jan Cholasta wrote: >> Hi, >> >> the attached patch fixes . > ACK. > Pushed to master: 7c0e7f7e3ca3a971d4db64f80f02d4f79e5f5c4d -- Manage your subscription for the Freeipa-dev

Re: [Freeipa-devel] [PATCH 144] extdom: add unit-test for get_user_grouplist()

2015-07-07 Thread Tomas Babej
On 07/07/2015 03:47 PM, Sumit Bose wrote: > On Tue, May 26, 2015 at 02:47:02PM +0300, Alexander Bokovoy wrote: >> On Tue, 26 May 2015, Sumit Bose wrote: >>> On Tue, May 26, 2015 at 01:24:30PM +0200, Petr Vobornik wrote: On 05/26/2015 01:21 PM, Sumit Bose wrote: > Hi, > > this tes

Re: [Freeipa-devel] [PATCHES 145-148] ipa-kdb: add unit-test for filter_logon_info()

2015-07-07 Thread Tomas Babej
On 07/07/2015 03:49 PM, Sumit Bose wrote: > On Tue, May 26, 2015 at 01:36:35PM +0200, Martin Kosek wrote: >> On 05/26/2015 01:33 PM, Sumit Bose wrote: >>> Hi, >>> >>> these patches add some unit tests and some additional improvements >>> related to the issues described in >>> https://bugzilla.red

Re: [Freeipa-devel] [PATCH] 0180-0190 oneway trust and other trust-related patches

2015-07-07 Thread Tomas Babej
), it is >> in works. > Updated patch 0181 after discussion with Simo and Sumit about empty rid > array. > > > Works fine for me, thanks. ACK. Pushed to master: 5017726ebaf6eea3dedb1325efe00c0d6c4b6187 During review, I also pushed the attached oneliner. Tomas From d011ca3

Re: [Freeipa-devel] [PATCH 0055] ipa-replica-prepare: Do not create DNS zone it automatically.

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:16 PM, Martin Basti wrote: > On 03/07/15 06:17, David Kupka wrote: >> Since ipa-replica-* tools will be soon removed I think this simple >> check should be enough. >> >> >> > ACK > > -- > Martin Basti > > > Pushed to master: 6a91893ff50fee6d7c71d9bc982d85a3ec8b7583 -- Man

Re: [Freeipa-devel] [PATCH 0046] add option to skip client API version check and proceed at user's own risk

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:49 PM, Martin Basti wrote: > On 03/07/15 16:41, Martin Babinsky wrote: >> On 07/02/2015 01:58 PM, Martin Babinsky wrote: >>> First attempt at https://fedorahosted.org/freeipa/ticket/4768 >>> >>> >>> >> Attaching reworked patch. >> >> >> > ACK > > -- > Martin Basti > > > Pus

Re: [Freeipa-devel] [PATCH 0276] Fix: ipa-dns-install will add CA records if CA is installed

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:36 PM, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5101 > > Patch attached. > > > ACK. Pushed to master: 1d9bdb240943527e1e19704acd183eae254267ae -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/free

Re: [Freeipa-devel] [PATCH] 0024..0025 Add missing certprofile features

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:30 PM, Martin Basti wrote: > On 04/07/15 16:58, Fraser Tweedale wrote: >> On Fri, Jul 03, 2015 at 10:34:07PM +1000, Fraser Tweedale wrote: >>> On Thu, Jul 02, 2015 at 08:12:12PM +1000, Fraser Tweedale wrote: On Thu, Jul 02, 2015 at 11:23:49AM +0200, Jan Cholasta wrote: >

Re: [Freeipa-devel] [PATCH 0334] Hide topology and domainlevel features

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:16 PM, Martin Basti wrote: > On 07/07/15 10:33, Tomas Babej wrote: >> Hi, >> >> * Hide topology and domainlevel commands in the CLI >> * Hide topology and domainlevel in the WebUI >> * Set maximum allowed domain level to 0 >> * Do not c

Re: [Freeipa-devel] [PATCH] 004 Improve error handling in ipa-httpd-kdcproxy

2015-07-07 Thread Tomas Babej
On 07/07/2015 04:28 PM, Alexander Bokovoy wrote: > On Tue, 07 Jul 2015, Nathaniel McCallum wrote: >> This LGTM. However, I’ll let Alexander give the ACK. > Looks good for me too. > > > Pushed to master: 25d1afdc54284c6bcf1caf08beae2e66ceb7f4e8 -- Manage your subscription for the Freeipa-dev

Re: [Freeipa-devel] [PATCH 0051] Clear SSSD caches when uninstalling the client

2015-07-07 Thread Tomas Babej
On 06/30/2015 05:40 PM, Simo Sorce wrote: > On Tue, 2015-06-30 at 16:10 +0200, Martin Basti wrote: >> On 30/06/15 15:18, Martin Basti wrote: >>> On 30/06/15 14:47, Simo Sorce wrote: >>>> On Tue, 2015-06-30 at 13:19 +0200, Tomas Babej wrote: >>>>&g

Re: [Freeipa-devel] [PATCHES 330-331] Update translations and introduce Zanata configuration

2015-07-07 Thread Tomas Babej
On 07/07/2015 11:48 AM, Martin Basti wrote: > On 07/07/15 10:37, Tomas Babej wrote: >> >> On 07/07/2015 09:09 AM, Tomas Babej wrote: >>> >>> On 06/24/2015 04:33 PM, Tomas Babej wrote: >>>> On 06/24/2015 04:29 PM, Martin Basti wrote: >>>

Re: [Freeipa-devel] [PATCHES 330-331] Update translations and introduce Zanata configuration

2015-07-07 Thread Tomas Babej
On 07/07/2015 09:09 AM, Tomas Babej wrote: > > > On 06/24/2015 04:33 PM, Tomas Babej wrote: >> On 06/24/2015 04:29 PM, Martin Basti wrote: >>> On 24/06/15 14:39, Tomas Babej wrote: >>>> +msgid "Automount location name." >>>> +msgstr &

[Freeipa-devel] [PATCH 0334] Hide topology and domainlevel features

2015-07-07 Thread Tomas Babej
:00:00 2001 From: Tomas Babej Date: Tue, 7 Jul 2015 09:36:32 +0200 Subject: [PATCH] Hide topology and domainlevel features * Hide topology and domainlevel commands in the CLI * Hide topology and domainlevel in the WebUI * Set maximum allowed domain level to 0 * Do not configure and enable the

Re: [Freeipa-devel] [MAN] [PATCH] 0004 Fix phrasing in man page for stageuser.py

2015-07-06 Thread Tomas Babej
On 07/04/2015 02:03 PM, Jérôme Fenal wrote: > Hi all, > > A quick patch to the man page part of stageuser to avoid ambiguity in > the phrasing, spotted while translating the page. > > Regards, > > J. > > > Thanks, ACK. I will not push this patch to master until we branch off 4.2 developme

Re: [Freeipa-devel] [PATCHES 0252-0253, 268, 50 - 51] DNSSEC: allow to move DNSSEC key master to another IPA server

2015-07-06 Thread Tomas Babej
On 07/01/2015 12:47 PM, Petr Spacek wrote: > On 1.7.2015 12:35, Martin Basti wrote: >> On 30/06/15 22:09, Petr Spacek wrote: >>> On 30.6.2015 16:04, Martin Basti wrote: On 30/06/15 10:25, Martin Basti wrote: > On 29/06/15 15:16, Martin Basti wrote: >> On 25/06/15 13:46, Petr Spacek w

Re: [Freeipa-devel] [PATCH] 892 webui: add mangedby tab to otptoken

2015-07-06 Thread Tomas Babej
On 07/03/2015 02:49 PM, Martin Babinsky wrote: > On 07/01/2015 06:59 PM, Petr Vobornik wrote: >> Added managedby_user tab to manage users who can manage the token. >> >> https://fedorahosted.org/freeipa/ticket/5003 >> >> Nathaniel, I could not reproduce the following part of the ticket: >> """ >>

Re: [Freeipa-devel] [PATCH] 886-890 webui: API browser

2015-07-03 Thread Tomas Babej
On 07/03/2015 10:06 AM, Tomas Babej wrote: > > > On 07/02/2015 04:55 PM, Martin Kosek wrote: >> On 07/01/2015 04:51 PM, Petr Vobornik wrote: >>> For those of you who don't want to try the patches: >>> * https://pvoborni.fedorapeople.or

Re: [Freeipa-devel] [PATCH] 886-890 webui: API browser

2015-07-03 Thread Tomas Babej
On 07/02/2015 04:55 PM, Martin Kosek wrote: > On 07/01/2015 04:51 PM, Petr Vobornik wrote: >> For those of you who don't want to try the patches: >> * https://pvoborni.fedorapeople.org/images/api-user-show.png >> * https://pvoborni.fedorapeople.org/images/api-user-add.png >> >> On 07/01/2015 09:3

Re: [Freeipa-devel] [PATCH 0274] DNS: Check if dns package is installed

2015-07-03 Thread Tomas Babej
On 07/02/2015 02:03 PM, Petr Spacek wrote: > On 2.7.2015 13:54, Jan Cholasta wrote: >> Dne 2.7.2015 v 13:34 Petr Spacek napsal(a): >>> On 2.7.2015 12:57, Tomas Babej wrote: >>>> >>>> >>>> On 07/02/2015 08:50 AM, Petr Sp

Re: [Freeipa-devel] [PATCH] 885 topology: make cn of new segment consistent with topology plugin

2015-07-02 Thread Tomas Babej
On 07/02/2015 07:42 PM, David Kupka wrote: > On 30/06/15 16:16, Petr Vobornik wrote: >> SSIA >> >> > Works for me, ACK. > Pushed to master: 66ea322e7e01266cc916156860b684adb21c618d -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-de

Re: [Freeipa-devel] [PATCH] 884 topologysegment: hide direction and enable options

2015-07-02 Thread Tomas Babej
On 07/02/2015 07:42 PM, David Kupka wrote: > On 30/06/15 16:15, Petr Vobornik wrote: >> These options should not be touched by users yet. >> >> https://fedorahosted.org/freeipa/ticket/5061 >> >> > Works for me, ACK. > Pushed to master: 2b8e1caa7bfda5e540a94fe26fbcdbfd0ea68928 -- Manage your sub

Re: [Freeipa-devel] [PATCH] 882 ipa-replica-manage del: relax segment deletement check if, topology is disconnected

2015-07-02 Thread Tomas Babej
On 07/02/2015 07:42 PM, David Kupka wrote: > On 30/06/15 16:15, Petr Vobornik wrote: >> Comment from segment deletion check which describes the patch: >> >> Relax check if topology was or is disconnected. Disconnected topology >> can contain segments with already deleted servers. Check only if >> s

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-07-02 Thread Tomas Babej
On 07/01/2015 07:32 PM, Martin Babinsky wrote: > On 06/30/2015 05:55 PM, Tomas Babej wrote: >> >> >> On 06/16/2015 01:01 PM, Jan Cholasta wrote: >>> Dne 16.6.2015 v 10:14 Martin Babinsky napsal(a): >>>> On 05/06/2015 10:12 AM, Tomas Babej wrote: >&

[Freeipa-devel] [PATCH 0333] ipaplatform: Remove redundant definitions

2015-07-02 Thread Tomas Babej
Hi, I noticed two variables are redundant in the base/paths.py and base/tasks.py in the ipaplatform module. git grep -E 'path_namespace|task_namespace' ipaplatform/base/paths.py:path_namespace = BasePathNamespace ipaplatform/base/tasks.py:task_namespace = BaseTaskNamespace() This pat

Re: [Freeipa-devel] [PATCH 0274] DNS: Check if dns package is installed

2015-07-02 Thread Tomas Babej
On 07/02/2015 08:50 AM, Petr Spacek wrote: > On 1.7.2015 20:29, Tomas Babej wrote: >> >> >> On 07/01/2015 04:45 PM, Petr Spacek wrote: >>> On 1.7.2015 15:32, Martin Basti wrote: >>>> https://fedorahosted.org/freeipa/ticket/4058 >>>> Requi

Re: [Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-02 Thread Tomas Babej
On 07/02/2015 10:34 AM, thierry bordaz wrote: > On 07/01/2015 05:39 PM, Tomas Babej wrote: >> Hi Thierry, >> >> I think it would be better to use: >> >> error=_('Entry has no \'%s\'') % attr >> >> or even better, use named sub

Re: [Freeipa-devel] [PATCH 0018] allow deletion of segment, if not both nodes are managed

2015-07-02 Thread Tomas Babej
On 07/01/2015 08:59 PM, Simo Sorce wrote: > On Wed, 2015-07-01 at 12:05 +0200, Ludwig Krispenz wrote: >> This fix allows the removal of segments, where not both endpoints of the >> segments are managed. >> These segments can exist after deliberately disconnecting a topology by >> removal of a c

Re: [Freeipa-devel] [PATCH 0274] DNS: Check if dns package is installed

2015-07-01 Thread Tomas Babej
On 07/01/2015 04:45 PM, Petr Spacek wrote: > On 1.7.2015 15:32, Martin Basti wrote: >> https://fedorahosted.org/freeipa/ticket/4058 >> Requires patch freeipa-pspacek-0052 > > ACK > I must admit I don't really like wrapping a constant in the method in the TaskNamespace object. We're interested

Re: [Freeipa-devel] [PATCH 0275] DNS commands: do not show traceback if DNS is not installed

2015-07-01 Thread Tomas Babej
On 07/01/2015 05:53 PM, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5017 > > Patch attached > > > Repeated code hurts my eyes, but abstracting it seems like an overkill. ACK. Pushed to master: 96c23659fcb8adc64dd925556fb40f558fa7e37d -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH] 891 replication: fix regression in get_agreement_type

2015-07-01 Thread Tomas Babej
On 07/01/2015 06:32 PM, Petr Vobornik wrote: > dcb6916a3b0601e33b08e12aeb25357efed6812b introduced a regression where > get_agreement_type does not raise NotFound error if an agreement for > host does not exist. The exception was swallowed by > get_replication_agreement. > > ACK. Pushed to ma

Re: [Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-01 Thread Tomas Babej
Hi Thierry, I think it would be better to use: error=_('Entry has no \'%s\'') % attr or even better, use named substitution: error=_('Entry has no \'%(attribute)s\'') % dict(attribute=attr) This way will generate a more readable strings for translators. Tomas -- Manage your subscription for

Re: [Freeipa-devel] [PATCHES 326-328] ID Views improvements

2015-07-01 Thread Tomas Babej
On 07/01/2015 12:50 PM, Alexander Bokovoy wrote: > On Thu, 28 May 2015, Tomas Babej wrote: >>> From c4ad3ba829ab2816c6ddb64da8d5c6ceb8789340 Mon Sep 17 00:00:00 2001 >> From: Tomas Babej >> Date: Wed, 27 May 2015 16:30:48 +0200 >> Subject: [PATCH] idviews: Remov

Re: [Freeipa-devel] [PATCHES 326-328] ID Views improvements

2015-07-01 Thread Tomas Babej
On 05/28/2015 12:59 PM, Tomas Babej wrote: > Hi, > > this couple of patches improves ID Views and ID overrides handling. See > commit messages for details. > > Tomas > > > Bump. Can this sad, forgotten patch set get a review? -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH 0017] dirsrv crash on segment add if suffix does not exist

2015-07-01 Thread Tomas Babej
On 07/01/2015 12:11 PM, thierry bordaz wrote: > On 06/30/2015 04:50 PM, Ludwig Krispenz wrote: >> new patch attached >> >> On 06/30/2015 03:37 PM, thierry bordaz wrote: >>> On 06/30/2015 12:07 PM, Ludwig Krispenz wrote: added verification for issue reported in ticket 5088 and sanity che

Re: [Freeipa-devel] [PATCH] 0020..0022 pki-related upgrade fixes

2015-07-01 Thread Tomas Babej
On 07/01/2015 10:49 AM, Martin Basti wrote: > On 30/06/15 18:02, Fraser Tweedale wrote: >> On Mon, Jun 29, 2015 at 05:56:11PM +0200, Martin Basti wrote: >>> On 29/06/15 16:03, Fraser Tweedale wrote: On Thu, Jun 25, 2015 at 11:23:01AM +0200, Martin Basti wrote: > On 19/06/15 09:28, Fraser

Re: [Freeipa-devel] [PATCH 0046] DNSSEC: Store time & date key metadata in UTC

2015-07-01 Thread Tomas Babej
On 07/01/2015 10:37 AM, Martin Basti wrote: > On 30/06/15 14:36, Petr Spacek wrote: >> Hello, >> >> DNSSEC: Store time & date key metadata in UTC. >> >> OpenDNSSEC stores key metadata in local time zone but BIND needs >> timestamps in UTC. UTC will be stored in LDAP. >> >> https://fedorahosted.or

Re: [Freeipa-devel] [PATCH] 1114 don't rely on positional arguments in pykerberos calls

2015-07-01 Thread Tomas Babej
On 06/30/2015 01:37 PM, Tomas Babej wrote: > > > On 06/26/2015 05:56 PM, Rob Crittenden wrote: >> I'm working on rebasing python-kerberos (PyKerberos) in rawhide and when >> upstream accepted our patch which added the ability to pass in flags to >> authGSSClient

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-06-30 Thread Tomas Babej
On 06/16/2015 01:01 PM, Jan Cholasta wrote: > Dne 16.6.2015 v 10:14 Martin Babinsky napsal(a): >> On 05/06/2015 10:12 AM, Tomas Babej wrote: >>> >>> >>> On 05/05/2015 02:02 PM, Tomas Babej wrote: >>>> >>>> >>>> On 04/29/20

Re: [Freeipa-devel] [PATCH 0270] Sanitize CA replica install

2015-06-30 Thread Tomas Babej
On 06/30/2015 01:40 PM, Tomas Babej wrote: > > > On 06/30/2015 01:25 PM, Martin Basti wrote: >> Check if cafile exists first, before using it. >> >> Patch attached. >> >> >> > > ACK > Pushed to master: b2f0a018b6f2226106ec811cf01f9bce

Re: [Freeipa-devel] [PATCH 0270] Sanitize CA replica install

2015-06-30 Thread Tomas Babej
On 06/30/2015 01:25 PM, Martin Basti wrote: > Check if cafile exists first, before using it. > > Patch attached. > > > ACK -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pag

Re: [Freeipa-devel] [PATCH] 1114 don't rely on positional arguments in pykerberos calls

2015-06-30 Thread Tomas Babej
On 06/26/2015 05:56 PM, Rob Crittenden wrote: > I'm working on rebasing python-kerberos (PyKerberos) in rawhide and when > upstream accepted our patch which added the ability to pass in flags to > authGSSClientInit() they changed the ordering such that the IPA call > will fail as it relies on pos

Re: [Freeipa-devel] [PATCH 0051] Clear SSSD caches when uninstalling the client

2015-06-30 Thread Tomas Babej
On 06/30/2015 01:08 PM, Martin Basti wrote: > On 30/06/15 13:00, Tomas Babej wrote: >> >> On 06/29/2015 03:50 PM, Martin Basti wrote: >>> On 29/06/15 13:46, Jakub Hrozek wrote: >>>> On Fri, Jun 05, 2015 at 11:31:54AM -0600, Gabe Alford wrote: >>>>

Re: [Freeipa-devel] [PATCH 0051] Clear SSSD caches when uninstalling the client

2015-06-30 Thread Tomas Babej
On 06/29/2015 03:50 PM, Martin Basti wrote: > On 29/06/15 13:46, Jakub Hrozek wrote: >> On Fri, Jun 05, 2015 at 11:31:54AM -0600, Gabe Alford wrote: >>> Thanks. Updated patch attached. >>> >>> On Fri, Jun 5, 2015 at 9:53 AM, Jakub Hrozek wrote: >>> On Fri, Jun 05, 2015 at 09:46:05AM -0600,

Re: [Freeipa-devel] [PATCH 0038] increase NSS memcache timeout for IPA server

2015-06-30 Thread Tomas Babej
On 06/30/2015 09:47 AM, Martin Basti wrote: > On 27/05/15 13:40, Martin Babinsky wrote: >> On 05/27/2015 01:33 PM, Lukas Slebodnik wrote: >>> On (27/05/15 13:25), Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/4964 -- Martin^3 Babinsky >>> From ef8481ee02

Re: [Freeipa-devel] [PATCH 0016] clear start attr from segment after initialization

2015-06-30 Thread Tomas Babej
On 06/30/2015 12:45 PM, thierry bordaz wrote: > On 06/30/2015 12:05 PM, Ludwig Krispenz wrote: >> new patch with comments attached >> >> On 06/30/2015 10:43 AM, thierry bordaz wrote: >>> On 06/30/2015 09:19 AM, Ludwig Krispenz wrote: On 06/26/2015 02:14 PM, thierry bordaz wrote: > O

Re: [Freeipa-devel] [PATCH 0040-0045] DNSSEC improvements

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:36 PM, Tomas Babej wrote: > > > On 06/29/2015 01:14 PM, Martin Basti wrote: >> On 26/06/15 18:55, Petr Spacek wrote: >>> Hello, >>> >>> attached patches implement a portion of improvements for ticket >>> https://fedorahosted

Re: [Freeipa-devel] [PATCH] 881 add python-setuptools to requires

2015-06-29 Thread Tomas Babej
On 06/26/2015 01:18 PM, Martin Basti wrote: > On 19/06/15 14:06, Petr Vobornik wrote: >> Commit 9f049ca14403f3696d54d186e6b1b15181f055df introduced dependency on >> python-setuptools on line: >> from pkg_resources import parse_version >> >> This dependency is missing on *minimal* installation a

Re: [Freeipa-devel] [PATCH 0038] Add hint how to re-run IPA upgrade

2015-06-29 Thread Tomas Babej
On 06/26/2015 06:05 PM, Petr Vobornik wrote: > On 06/26/2015 12:41 PM, Petr Spacek wrote: >> Hello, >> >> Add hint how to re-run IPA upgrade. >> > > ACK Pushed to master: d5a07b50b4d8900c16dd8672e21de34647fff9ec -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.

Re: [Freeipa-devel] [PATCH 0014] correct handling of one directional segments

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:50 PM, thierry bordaz wrote: > On 06/29/2015 12:47 PM, Martin Basti wrote: >> On 17/06/15 11:05, Ludwig Krispenz wrote: >>> >>> On 06/17/2015 10:35 AM, thierry bordaz wrote: On 06/17/2015 09:25 AM, Ludwig Krispenz wrote: > Hi, > thanks for review, see answers inline.

Re: [Freeipa-devel] [PATCH] 00015 User life cycle: permission to delete a preserved user

2015-06-29 Thread Tomas Babej
On 06/29/2015 10:44 AM, Martin Basti wrote: > On 22/06/15 17:08, thierry bordaz wrote: >> Add the permission to Stage users administrators to delete already >> preserved user >> >> >> >> > > ACK > > -- > Martin Basti > > > Pushed to master: ffd6b039a755016c3de22a11fec037eca7180a79 -- Man

Re: [Freeipa-devel] [PATCH 0053] upgrade: Raise error when certmonger is not running.

2015-06-29 Thread Tomas Babej
On 06/29/2015 11:05 AM, Petr Spacek wrote: > On 29.6.2015 09:22, David Kupka wrote: >> On 26/06/15 19:45, Rob Crittenden wrote: >>> Petr Vobornik wrote: On 06/26/2015 10:54 AM, David Kupka wrote: > https://fedorahosted.org/freeipa/ticket/5080 > > ACK >>> >>> Is there a

Re: [Freeipa-devel] [PATCH] 1113 Hosts add their own services

2015-06-29 Thread Tomas Babej
On 06/29/2015 12:24 PM, Martin Basti wrote: > On 22/06/15 19:48, Rob Crittenden wrote: >> Add an ACI to allow a host to add its own services. This only grants >> add access. It can't subsequently delete or modify the entry. >> >> This requires 389-ds-1.3.4.0 GA. >> >> rob >> >> > ACK > > -- > M

Re: [Freeipa-devel] [PATCH 0267] Fix broken indicies

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:23 PM, Martin Babinsky wrote: > On 06/26/2015 05:50 PM, Martin Basti wrote: >> Patch fixes wrong value for ntUserDomainId and ntUniqueId indicies. >> >> Patch attached. >> >> >> > ACK > Pushed to master: 16f47ed4520d4f89db39d1dc58be7a8efb1d8612 -- Manage your subscription for

Re: [Freeipa-devel] [PATCH 0039] Rate-limit while loop in SystemdService.is_active()

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:28 PM, Martin Basti wrote: > On 26/06/15 15:58, Petr Spacek wrote: >> Hello, >> >> Rate-limit while loop in SystemdService.is_active(). >> >> Previously is_active() was frenetically calling systemctl is_active in >> tight loop which in fact made the process slower. >> > ACK > Pus

Re: [Freeipa-devel] [PATCH] 865 fix handling of ldap.LDAPError in installer

2015-06-29 Thread Tomas Babej
On 06/04/2015 05:19 PM, Petr Vobornik wrote: > based on: http://fpaste.org/228856/25049143/ > > The patch is not tested. > > Description: > 'info' is optional component in LDAPError > > http://www.python-ldap.org/doc/html/ldap.html#exceptions > > Pushed to master: 29c01e5ef4d4bb8c608720c3e0

Re: [Freeipa-devel] [PATCH 0040-0045] DNSSEC improvements

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:14 PM, Martin Basti wrote: > On 26/06/15 18:55, Petr Spacek wrote: >> Hello, >> >> attached patches implement a portion of improvements for ticket >> https://fedorahosted.org/freeipa/ticket/4657 >> >> It came to my mind that it will be better to review them at once - the >> previ

Re: [Freeipa-devel] [PATCH 0036] Bump minimal BIND version for CentOS

2015-06-29 Thread Tomas Babej
On 06/26/2015 09:43 AM, Martin Basti wrote: > On 23/06/15 14:14, Petr Spacek wrote: >> Hello, >> >> Bump minimal BIND version for CentOS. >> >> DNSSEC support added dependency on bind-pkcs11 sub-package. >> >> https://fedorahosted.org/freeipa/ticket/4657 >> >> >> > ACK > > -- > Martin Basti >

Re: [Freeipa-devel] [PATCHES 330-331] Update translations and introduce Zanata configuration

2015-06-24 Thread Tomas Babej
On 06/24/2015 04:29 PM, Martin Basti wrote: > On 24/06/15 14:39, Tomas Babej wrote: >> +msgid "Automount location name." >> +msgstr "Job Title" >> + > > in german po file > > +msgid "Automount location name." > +msgstr "Jo

[Freeipa-devel] Notice: FreeIPA localization strings updated, deadline 2015-07-01

2015-06-24 Thread Tomas Babej
Hello, FreeIPA translators! Updated translation strings are available for localization at the fedora.zanata.org Zanata server instance: https://fedora.zanata.org/iteration/view/freeipa/master Please update the translations at your leisure in the next 7 days, we plan to pull the translations for

Re: [Freeipa-devel] [PATCH] 867 topology: hide topologysuffix-add del mod commands

2015-06-08 Thread Tomas Babej
On 06/08/2015 06:57 PM, Petr Vobornik wrote: > Suffices are created on installation/upgrade. Users should not > modify them. > > https://fedorahosted.org/freeipa/ticket/4302 > ACK Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/fre

Re: [Freeipa-devel] [PATCH] 866 topology: allow only one node to be specified in, topologysegment-refresh

2015-06-08 Thread Tomas Babej
On 06/08/2015 06:57 PM, Petr Vobornik wrote: > > https://fedorahosted.org/freeipa/ticket/4302 > > ACK. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Cod

Re: [Freeipa-devel] SkipPluginModule error raised during new code installation

2015-06-04 Thread Tomas Babej
On 06/04/2015 03:55 PM, Oleg Fayans wrote: > Hi everybody > > The following error was raised during the installation of the freeipa > packages built from the current master branch: > > ofayans@f22master:~/freeipa/dist/rpms]$ sudo rpm -ihv *.rpm > Preparing... #

[Freeipa-devel] [PATCH 0329] ipa-replica-manage: Do not allow topology altering commands

2015-06-02 Thread Tomas Babej
of: https://fedorahosted.org/freeipa/ticket/4302 >From e96c3b045ced1773def444ffee9a45f813abb954 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Tue, 2 Jun 2015 14:06:26 +0200 Subject: [PATCH] ipa-replica-manage: Do not allow topology altering commands from DL 1 With Domain Level 1 and ab

Re: [Freeipa-devel] Domain level change failed

2015-06-01 Thread Tomas Babej
On 06/01/2015 04:13 PM, Oleg Fayans wrote: > Hi, > > In my installation of the freeipa built with the latest topology patches > applied, I was unable to reset domain level to 0 on neither of nodes: > > ofayans@testmaster:~/ldap]$ ipa domainlevel-set 0 > ipa: ERROR: Domain Level cannot be lowere

[Freeipa-devel] [PATCHES 326-328] ID Views improvements

2015-05-28 Thread Tomas Babej
Hi, this couple of patches improves ID Views and ID overrides handling. See commit messages for details. Tomas >From 8acc50c10d9886668a0147b46f311f9aa83294bb Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Wed, 27 May 2015 14:31:13 +0200 Subject: [PATCH] idviews: Set dcerpc detection f

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-26 Thread Tomas Babej
On 05/26/2015 01:51 PM, Tomas Babej wrote: > > > On 05/26/2015 12:39 PM, Tomas Babej wrote: >> >> >> On 05/26/2015 11:57 AM, Jan Cholasta wrote: >>> Dne 25.5.2015 v 17:15 Tomas Babej napsal(a): >>>> >>>> >>>> On 05/25/20

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-26 Thread Tomas Babej
On 05/26/2015 12:39 PM, Tomas Babej wrote: > > > On 05/26/2015 11:57 AM, Jan Cholasta wrote: >> Dne 25.5.2015 v 17:15 Tomas Babej napsal(a): >>> >>> >>> On 05/25/2015 12:42 PM, Tomas Babej wrote: >>>> >>>> >>>>

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-26 Thread Tomas Babej
On 05/26/2015 11:57 AM, Jan Cholasta wrote: > Dne 25.5.2015 v 17:15 Tomas Babej napsal(a): >> >> >> On 05/25/2015 12:42 PM, Tomas Babej wrote: >>> >>> >>> On 05/25/2015 07:30 AM, Jan Cholasta wrote: >>>> Dne 22.5.2015 v 12:36 Petr Vo

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-25 Thread Tomas Babej
On 05/25/2015 12:42 PM, Tomas Babej wrote: > > > On 05/25/2015 07:30 AM, Jan Cholasta wrote: >> Dne 22.5.2015 v 12:36 Petr Vobornik napsal(a): >>> On 05/22/2015 07:08 AM, Jan Cholasta wrote: >>>> Dne 21.5.2015 v 18:18 Tomas Babej napsal(a): >>>>&

Re: [Freeipa-devel] [PATCH] 0178 Fix AD trusts in Fedora 22

2015-05-25 Thread Tomas Babej
On 05/12/2015 04:03 PM, Alexander Bokovoy wrote: > On Tue, 12 May 2015, Alexander Bokovoy wrote: >> On Tue, 12 May 2015, Alexander Bokovoy wrote: >>> On Fri, 08 May 2015, Alexander Bokovoy wrote: Hi, attached patch fixes issues with Samba 4.2 in Fedora 22. See commit mess

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-25 Thread Tomas Babej
On 05/25/2015 07:30 AM, Jan Cholasta wrote: > Dne 22.5.2015 v 12:36 Petr Vobornik napsal(a): >> On 05/22/2015 07:08 AM, Jan Cholasta wrote: >>> Dne 21.5.2015 v 18:18 Tomas Babej napsal(a): >>>> >>>> >>>> On 05/19/2015 04:07 PM, Tomas Babej w

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-22 Thread Tomas Babej
On 05/22/2015 03:52 PM, Tomas Babej wrote: On 05/22/2015 03:32 PM, Petr Vobornik wrote: On 05/22/2015 03:18 PM, Petr Vobornik wrote: On 05/22/2015 01:08 PM, Tomas Babej wrote: snip 1) https://www.redhat.com/archives/freeipa-devel/2015-May/msg00228.html - I still don't agree tha

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-22 Thread Tomas Babej
On 05/22/2015 03:32 PM, Petr Vobornik wrote: On 05/22/2015 03:18 PM, Petr Vobornik wrote: On 05/22/2015 01:08 PM, Tomas Babej wrote: snip 1) https://www.redhat.com/archives/freeipa-devel/2015-May/msg00228.html - I still don't agree that the plugin should be based on LDAPObject. O

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-22 Thread Tomas Babej
On 05/22/2015 12:36 PM, Petr Vobornik wrote: On 05/22/2015 07:08 AM, Jan Cholasta wrote: Dne 21.5.2015 v 18:18 Tomas Babej napsal(a): On 05/19/2015 04:07 PM, Tomas Babej wrote: On 05/19/2015 03:59 PM, Martin Kosek wrote: On 05/19/2015 03:56 PM, Tomas Babej wrote: On 05/19/2015 03:51

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-21 Thread Tomas Babej
On 05/19/2015 04:07 PM, Tomas Babej wrote: On 05/19/2015 03:59 PM, Martin Kosek wrote: On 05/19/2015 03:56 PM, Tomas Babej wrote: On 05/19/2015 03:51 PM, Martin Kosek wrote: On 05/19/2015 03:49 PM, Ludwig Krispenz wrote: On 05/19/2015 03:36 PM, Martin Kosek wrote: On 05/19/2015 03:22

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-19 Thread Tomas Babej
On 05/19/2015 03:59 PM, Martin Kosek wrote: On 05/19/2015 03:56 PM, Tomas Babej wrote: On 05/19/2015 03:51 PM, Martin Kosek wrote: On 05/19/2015 03:49 PM, Ludwig Krispenz wrote: On 05/19/2015 03:36 PM, Martin Kosek wrote: On 05/19/2015 03:22 PM, Tomas Babej wrote: ... 3) Domain level is

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-19 Thread Tomas Babej
On 05/19/2015 03:51 PM, Martin Kosek wrote: On 05/19/2015 03:49 PM, Ludwig Krispenz wrote: On 05/19/2015 03:36 PM, Martin Kosek wrote: On 05/19/2015 03:22 PM, Tomas Babej wrote: ... 3) Domain level is just a single integer and it should be treated as such, there's no need for an LDAPO

Re: [Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-19 Thread Tomas Babej
On 05/14/2015 11:48 AM, Jan Cholasta wrote: Hi, Dne 14.5.2015 v 11:00 Tomas Babej napsal(a): Hi, this patch implements the domain level feature. https://fedorahosted.org/freeipa/ticket/5018 Tomas 1) +# Create entry proclaiming Domain Level support of this master +# This will update the

[Freeipa-devel] [PATCH 0325] Add Domain Level feature

2015-05-14 Thread Tomas Babej
Hi, this patch implements the domain level feature. https://fedorahosted.org/freeipa/ticket/5018 Tomas From 409961b882ff7b04e4b3193627f4677b01a902f0 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 14 May 2015 10:49:55 +0200 Subject: [PATCH] Add Domain Level feature https

Re: [Freeipa-devel] ipa-replica-manage del fails to delete host entry

2015-05-06 Thread Tomas Babej
en,reverse=True) >>> for l in list: ... print l ... ('123456', 'A') ('123', 'B') ('12345678', 'C') A quick fix would be to use key=lambda x: len(x.dn) then. Tomas >From 961fba0e09b4825e9db09f26fa19daba336ae437 Mon

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-05-06 Thread Tomas Babej
On 05/05/2015 02:02 PM, Tomas Babej wrote: On 04/29/2015 12:28 PM, Tomas Babej wrote: On 03/11/2015 04:20 PM, Jan Cholasta wrote: Hi, Dne 10.3.2015 v 16:35 Tomas Babej napsal(a): On 03/09/2015 12:26 PM, Tomas Babej wrote: Hi, this couple of patches provides a initial implementation

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-05-05 Thread Tomas Babej
On 04/29/2015 12:28 PM, Tomas Babej wrote: On 03/11/2015 04:20 PM, Jan Cholasta wrote: Hi, Dne 10.3.2015 v 16:35 Tomas Babej napsal(a): On 03/09/2015 12:26 PM, Tomas Babej wrote: Hi, this couple of patches provides a initial implementation of the winsync migration tool: https

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-04-29 Thread Tomas Babej
On 03/11/2015 04:20 PM, Jan Cholasta wrote: Hi, Dne 10.3.2015 v 16:35 Tomas Babej napsal(a): On 03/09/2015 12:26 PM, Tomas Babej wrote: Hi, this couple of patches provides a initial implementation of the winsync migration tool: https://fedorahosted.org/freeipa/ticket/4524 Some parts

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-24 Thread Tomas Babej
On 04/24/2015 03:50 PM, Martin Basti wrote: On 24/04/15 15:22, David Kupka wrote: On 04/24/2015 03:17 PM, Martin Basti wrote: On 23/04/15 15:26, David Kupka wrote: On 04/13/2015 01:23 PM, David Kupka wrote: On 04/10/2015 02:55 PM, Simo Sorce wrote: On Fri, 2015-04-10 at 12:55 +0200, Lukas

Re: [Freeipa-devel] [PATCH 0030] use separate ccache filename for each IPA DNSSEC daemon

2015-04-24 Thread Tomas Babej
On 04/20/2015 05:26 PM, Petr Spacek wrote: On 20.4.2015 17:02, Martin Babinsky wrote: The attached patch implements a request by Petr^2 Spacek during the review of my PATCHES 0015-0017, which are prerequisites of the patch and were pushed today. Petr wanted each DNSSEC daemon (ipa-dnskeysync

Re: [Freeipa-devel] OOO 2015-03-31-2015-04-01

2015-03-30 Thread Tomas Babej
Sorry about the noise. On 03/31/2015 07:23 AM, Tomas Babej wrote: Hours already accumulated this month. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute

[Freeipa-devel] OOO 2015-03-31-2015-04-01

2015-03-30 Thread Tomas Babej
Hours already accumulated this month. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0208] Remove --test option from upgrade

2015-03-23 Thread Tomas Babej
On 03/19/2015 12:25 PM, David Kupka wrote: On 03/17/2015 01:07 PM, Martin Basti wrote: On 12/03/15 16:10, David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensu

Re: [Freeipa-devel] [PATCHES 0204-0207, 0211] Server upgrade: Make LDAP data upgrade deterministic

2015-03-19 Thread Tomas Babej
On 03/19/2015 12:20 PM, David Kupka wrote: On 03/13/2015 03:08 PM, Martin Basti wrote: On 12/03/15 16:21, Rob Crittenden wrote: Martin Basti wrote: The patchset ensure, the upgrade order will respect ordering of entries in *.update files. Required for: https://fedorahosted.org/freeipa/tick

Re: [Freeipa-devel] [PATCH 0203] Remove unused PRE_SCHEMA upgrade

2015-03-19 Thread Tomas Babej
On 03/18/2015 01:42 PM, Martin Kosek wrote: On 03/18/2015 01:11 PM, Martin Basti wrote: On 12/03/15 17:30, Martin Basti wrote: On 12/03/15 17:08, Rob Crittenden wrote: Martin Basti wrote: On 12/03/15 16:22, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 04:52 PM, Martin Basti wrot

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/18/2015 01:10 PM, Alexander Bokovoy wrote: On Wed, 18 Mar 2015, Tomas Babej wrote: On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-18 Thread Tomas Babej
On 03/18/2015 11:23 AM, Jakub Hrozek wrote: On Wed, Mar 18, 2015 at 10:58:51AM +0100, Sumit Bose wrote: Please find attached a new version where the typo is fixed. bye, Sumit ACK I think the IPA gatekeepers shoudl feel free to just fix these trivial errors before pushing in the future. Pu

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:2

Re: [Freeipa-devel] [PATCH] 0041 Always reload StateFile before getting or modifying the, stored values.

2015-03-18 Thread Tomas Babej
On 03/17/2015 10:29 AM, Martin Basti wrote: On 16/03/15 13:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4901 ACK, it works as expected Pushed to master: 082c55fb9cf87263f1f585a1adeda464a9d7328a -- Manage your subscription for the Freeipa-devel mailing list: https://www.re

Re: [Freeipa-devel] [PATCHES 0018-0020] ipa-dns-install: Use LDAPI for all DS connections

2015-03-18 Thread Tomas Babej
On 03/16/2015 05:01 PM, Martin Basti wrote: On 16/03/15 14:26, Martin Babinsky wrote: On 03/16/2015 01:44 PM, Martin Basti wrote: On 12/03/15 17:15, Martin Babinsky wrote: On 03/12/2015 03:59 PM, Martin Babinsky wrote: On 03/11/2015 03:13 PM, Martin Basti wrote: On 11/03/15 13:00, Martin B

Re: [Freeipa-devel] [PATCH 0209] Fix logically dead code in ipap11helper module

2015-03-11 Thread Tomas Babej
On 03/11/2015 11:28 AM, Petr Spacek wrote: On 9.3.2015 13:52, Martin Basti wrote: Patch attached. ACK for this patch. When you are at it, it would be good to fix other warnings too. GCC on Fedora 21 is yelling at me: p11helper.c: In function ‘P11_Helper_find_keys’: p11helper.c:1062:23: warn

<    1   2   3   4   5   6   7   8   9   10   >