Re: [Freeipa-devel] [PATCH 0293] ipatests: Invoke class install methods properly with respect

2014-12-16 Thread Tomas Babej
On 12/16/2014 11:49 AM, Tomas Babej wrote: > On 12/15/2014 11:32 AM, Tomas Babej wrote: >> Hi, >> >> Multihost object was is not passed to the install method in the super >> construction. >> This fixes setup errors in AD Trust, Forced client reenrollment, CALess

Re: [Freeipa-devel] [PATCHES] 0682-0683 Use external pytest plugins: beakerlib and sourceorder

2014-12-17 Thread Tomas Babej
es work just fine. Glad to see the plugins extracted, let them be useful in the wild! ACK Pushed to master: bc5b13c3dac8e2b858bd397f91eddf738d13c832 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org

[Freeipa-devel] [PATCH 0296] ipatests: Make descriptions of declarative tests sorted according to their order

2014-12-19 Thread Tomas Babej
Hi, this allows us to sort the descriptions and preserve the test order. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 35e8a815e8b5b8baf04841de7dc5bec12214 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date:

Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

2015-01-13 Thread Tomas Babej
you ack or nack the patchset, other test tickets >>>> are waiting, >>>> and we want to avoid huge rebases/merging >>>> >>> From QA point of view, tests are OK. Can somebody do code review >>> please? >> Code looks OK, runs cleanly (ex

Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

2015-01-13 Thread Tomas Babej
On 01/13/2015 02:36 PM, Tomas Babej wrote: > > On 01/13/2015 01:36 PM, Martin Basti wrote: >> On 13/01/15 10:04, Martin Kosek wrote: >>> On 01/12/2015 06:43 PM, Martin Basti wrote: >>>> On 05/01/15 16:18, Martin Basti wrote: >>>>> On 17/12/14 15:

Re: [Freeipa-devel] [PATCH 0286] baseldap: Handle missing parent objects properly in *-find

2015-01-13 Thread Tomas Babej
On 11/21/2014 01:46 PM, Jan Cholasta wrote: > Dne 21.11.2014 v 11:28 Tomas Babej napsal(a): >> >> On 11/20/2014 04:01 PM, Jan Cholasta wrote: >>> Dne 19.11.2014 v 15:12 Tomas Babej napsal(a): >>>> >>>> On 11/19/2014 02:03 PM, Jan Cholasta wrote: &

Re: [Freeipa-devel] [PATCH 0296] ipatests: Make descriptions of declarative tests sorted according to their order

2015-01-14 Thread Tomas Babej
On 01/14/2015 11:53 AM, Petr Viktorin wrote: > On 12/19/2014 03:05 PM, Tomas Babej wrote: >> Hi, >> >> this allows us to sort the descriptions and preserve the test order. >> > > ACK > Pushed to master: 5416652f6f15de4cc2140a58466facdf07c70965 -- Tomas Bab

Re: [Freeipa-devel] [PATCHES] 0684-0687 Use tracker fixture in host plugin tests

2015-01-14 Thread Tomas Babej
and > re-created – independent tests are mainly useful for selecting > *subsets* of tests.) > ACK, nice work! Pushed to master: 07545569ecbdfdb1aeef6aa1878d827a7e5ddb38 Note: There was a build issue a fixed with attached patch, also pushed. -- Tomas Babej Associate Software Engi

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
s not belong to the legacy clients feature test. As for the any new tests that might come: I think tests for ipa-advise that are specific to that particular feature should be tested with that feature, more so, if they contain parts that are supposed to work copy-pasted. If a tests, however, tests a

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 05:37 PM, Tomas Babej wrote: > > On 01/14/2015 02:55 PM, Gabe Alford wrote: >> Hello, >> >>In looking into https://fedorahosted.org/freeipa/ticket/4029 I >> am wondering if there should be separate ipa-advise test, Yes/No? >> Could be

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:00 PM, Tomas Babej wrote: > > On 01/14/2015 05:37 PM, Tomas Babej wrote: >> >> On 01/14/2015 02:55 PM, Gabe Alford wrote: >>> Hello, >>> >>>In looking into https://fedorahosted.org/freeipa/ticket/4029 >>> I am wonderi

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:13 PM, Gabe Alford wrote: > On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej <mailto:tba...@redhat.com>> wrote: > > > On 01/14/2015 06:00 PM, Tomas Babej wrote: >> >> On 01/14/2015 05:37 PM, Tomas Babej wrote: >>> >>

Re: [Freeipa-devel] [PATCH 0170, 0183] Detect and warn about invalid forwardzone configuration

2015-01-15 Thread Tomas Babej
I do some work with >>> tests and adding new tests required by QE, I will add forwardzone warnings >>> tests when finish this. >>> >> Added tests (required patch 0170). >> Original and new patch attached. > Well done! ACK. > Pushed to master: c75c0e14f49

[Freeipa-devel] [PATCHES 297-299] Improvements for idviews xmlrpc tests

2015-01-21 Thread Tomas Babej
Hi, this couple of patches adds coverage for the scenario in https://fedorahosted.org/freeipa/ticket/4839 , plus fixes issues that caused ipa-run-tests to skip this test file. TomasFrom 2ae01c99cd0348aec1b6d2e90fb81e8691bc4b57 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Tue, 20 Jan 2015

[Freeipa-devel] [PATCH 300] Fix incorrect python shebang usage

2015-01-22 Thread Tomas Babej
Hi, attached patch fixes few python2 non-explicit shebangs that lurked into the codebase. TomasFrom ce5938cbf3df4b9ff6da08ebb114c342e763cc22 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 22 Jan 2015 12:47:13 +0100 Subject: [PATCH] ipapython: Fix incorrect python shebangs Make sure

Re: [Freeipa-devel] [PATCHES 297-299] Improvements for idviews xmlrpc tests

2015-01-26 Thread Tomas Babej
- Original Message - From: "David Kupka" To: "Tomas Babej" , freeipa-devel@redhat.com Sent: Thursday, January 22, 2015 2:51:50 PM Subject: Re: [Freeipa-devel] [PATCHES 297-299] Improvements for idviews xmlrpc tests On 01/21/2015 04:51 PM, Tomas Babej wrote: >

[Freeipa-devel] [PATCHES 301-302] ID override sshpubkey handling

2015-01-26 Thread Tomas Babej
: Tomas Babej Date: Mon, 26 Jan 2015 16:27:56 +0100 Subject: [PATCH] idviews: Make sure ssh public key can be set on ipauseroverride-add Clears up and generalizes ssh public key handling so that it can be used in ipaoverrideuser-add as well as ipaoverrideuser-mod commands. Also properly deals with

Re: [Freeipa-devel] [PATCH 0189] Prevent install scripts to fail silently if timeout exceeded

2015-02-12 Thread Tomas Babej
ACK, pushed to master: d5035c0ed99c03e25d5890e4d6f12f1079e8d892 Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0303] ipalib: Make sure correct attribute name is referenced for

2015-02-19 Thread Tomas Babej
Hi, Fixes the invalid attribute name reference in the 'System: Read User Addressbook Attributes' permission. https://fedorahosted.org/freeipa/ticket/4883 Tomas >From 93ab1bf897151992df4bd3588386cf8fed4849d2 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 19 Feb 2015 1

Re: [Freeipa-devel] [PATCH 0303] ipalib: Make sure correct attribute name is referenced for

2015-02-19 Thread Tomas Babej
On 02/19/2015 05:32 PM, Martin Kosek wrote: On 02/19/2015 05:29 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015, Tomas Babej wrote: Hi, Fixes the invalid attribute name reference in the 'System: Read User Addressbook Attributes' permission. https://fedorahosted.org/freeipa/t

Re: [Freeipa-devel] [PATCH 0303] ipalib: Make sure correct attribute name is referenced for

2015-02-19 Thread Tomas Babej
On 02/19/2015 05:45 PM, Martin Kosek wrote: On 02/19/2015 05:40 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015, Tomas Babej wrote: On 02/19/2015 05:32 PM, Martin Kosek wrote: On 02/19/2015 05:29 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015, Tomas Babej wrote: Hi, Fixes the invalid

Re: [Freeipa-devel] [PATCH 0303] ipalib: Make sure correct attribute name is referenced for

2015-02-19 Thread Tomas Babej
On 02/19/2015 06:13 PM, Martin Kosek wrote: On 02/19/2015 05:55 PM, Tomas Babej wrote: On 02/19/2015 05:45 PM, Martin Kosek wrote: On 02/19/2015 05:40 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015, Tomas Babej wrote: On 02/19/2015 05:32 PM, Martin Kosek wrote: On 02/19/2015 05:29 PM

Re: [Freeipa-devel] [PATCH 0303] ipalib: Make sure correct attribute name is referenced for

2015-02-19 Thread Tomas Babej
On 02/19/2015 06:33 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015, Tomas Babej wrote: On 02/19/2015 06:13 PM, Martin Kosek wrote: On 02/19/2015 05:55 PM, Tomas Babej wrote: On 02/19/2015 05:45 PM, Martin Kosek wrote: On 02/19/2015 05:40 PM, Alexander Bokovoy wrote: On Thu, 19 Feb 2015

[Freeipa-devel] [PATCH 0304] specfile: Add pki-kra to build requirements

2015-02-23 Thread Tomas Babej
Hi, Fixes the python lint errors at build time. Tomas >From 90857b35e211f1005aefd72301899e4bb53321b6 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 23 Feb 2015 11:59:51 +0100 Subject: [PATCH] specfile: Add pki-kra to build requirements Fixes the python lint errors at build t

Re: [Freeipa-devel] [PATCH 0304] specfile: Add pki-kra to build requirements

2015-02-23 Thread Tomas Babej
Discard, does not fix the problem. Still investigating. On 02/23/2015 12:02 PM, Tomas Babej wrote: Hi, Fixes the python lint errors at build time. Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman

[Freeipa-devel] [PATCH 0305] idviews: Use case-insensitive detection of Default Trust View

2015-02-23 Thread Tomas Babej
Hi, The usage of lowercased varsion of 'Default Trust View' can no longer be used to bypass the validation. https://fedorahosted.org/freeipa/ticket/4915 Tomas >From 549bb9a93c07ecf7ffdb913c094700129828017d Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 23 Feb 2015 1

Re: [Freeipa-devel] [PATCH 0305] idviews: Use case-insensitive detection of Default Trust View

2015-02-23 Thread Tomas Babej
On 02/23/2015 05:08 PM, Alexander Bokovoy wrote: On Mon, 23 Feb 2015, Tomas Babej wrote: Hi, The usage of lowercased varsion of 'Default Trust View' can no longer be used to bypass the validation. https://fedorahosted.org/freeipa/ticket/4915 I'm fine with the direction of the

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-24 Thread Tomas Babej
abe Alford <mailto:redhatri...@gmail.com>> wrote: Hello, Here is a patch for https://fedorahosted.org/freeipa/ticket/4029 I added test cases for valid and invalid advice. Thanks, Gabe On Wed, Jan 14, 2015 at 10:23 AM, Tomas Babej > wrote:

Re: [Freeipa-devel] [PATCH 133] ipa-range-check: do not treat missing objects as error

2015-02-24 Thread Tomas Babej
On 02/24/2015 06:47 PM, Sumit Bose wrote: Hi, this patch changes a return code and should fix https://fedorahosted.org/freeipa/ticket/4924 . bye, Sumit ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-25 Thread Tomas Babej
level of conciseness than with the separate test classes. Good luck! HTH, Tomas On 02/25/2015 03:52 PM, Gabe Alford wrote: No worries about the delay. Thanks for taking the time! Updated patch attached. Thanks, Gabe On Tue, Feb 24, 2015 at 11:03 AM, Tomas Babej <mailto:tba...@r

Re: [Freeipa-devel] [PATCH] 808 webui: service: add ipakrbrequirespreauth checkbox

2015-02-25 Thread Tomas Babej
On 02/25/2015 05:22 PM, Petr Vobornik wrote: Allow to configure missing krb ticket flag - ipakrbrequirespreauth from Web UI. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK, works f

Re: [Freeipa-devel] [PATCH 0042] ipa-replica-prepare should document ipv6 options

2015-02-25 Thread Tomas Babej
On 02/25/2015 09:26 PM, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4877. I just took what was in the ticket. Thanks, Gabe ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listi

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-26 Thread Tomas Babej
ACK. Pushed to: ipa-4-1: ddd7fb6a68fd413b1561eab9c29bac18882e5efd master: ae4ee6b53376bb7f3d1b4707c4e105c91b5cd8ab On 02/26/2015 05:58 PM, Gabe Alford wrote: Yeah. That makes more sense. Updated patch attached. Thanks, Gabe On Wed, Feb 25, 2015 at 3:55 PM, Tomas Babej <mailto:

Re: [Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

2015-03-03 Thread Tomas Babej
On 03/03/2015 04:01 PM, Martin Kosek wrote: On 03/03/2015 03:49 PM, Jan Cholasta wrote: Hi, the attached patches provide an attempt to fix . Patch 401 serves as an example and modifies ipa-advise to use its own API instance for Advice plugins. Ho

Re: [Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

2015-03-05 Thread Tomas Babej
On 03/04/2015 11:55 AM, Martin Kosek wrote: On 03/04/2015 11:13 AM, Jan Cholasta wrote: Dne 3.3.2015 v 16:11 Martin Kosek napsal(a): On 03/03/2015 04:09 PM, Jan Cholasta wrote: Dne 3.3.2015 v 16:04 Tomas Babej napsal(a): On 03/03/2015 04:01 PM, Martin Kosek wrote: On 03/03/2015 03:49 PM

Re: [Freeipa-devel] [PATCHES 0197-0198] Fix uniqueness plugins upgrade

2015-03-05 Thread Tomas Babej
On 03/04/2015 02:33 PM, Alexander Bokovoy wrote: On Wed, 25 Feb 2015, Martin Basti wrote: Modifications: * All plugins are migrated into new configuration style. * I left attribute uniqueness plugin disabled, cn=uid uniqueness,cn=plugins,cn=config is checking the same attribute. * POST_UPDATE

Re: [Freeipa-devel] [PATCH 0195] Fix memory leaks in ipapkcs11helper module

2015-03-06 Thread Tomas Babej
On 03/05/2015 02:45 PM, Petr Spacek wrote: On 26.2.2015 17:01, Martin Basti wrote: On 26/02/15 13:06, Petr Spacek wrote: Hello Martin, thank you for patch! This NACK is only aesthetic :-) On 25.2.2015 14:21, Martin Basti wrote: if (!check_return_value(rv, "import_wrapped_key: key unw

Re: [Freeipa-devel] [PATCH 0190] DNSSEC: add support for CKM_RSA_PKCS_OAEP mechanism

2015-03-06 Thread Tomas Babej
On 03/05/2015 02:45 PM, Petr Spacek wrote: On 26.2.2015 16:59, Martin Basti wrote: On 26/02/15 12:47, Petr Spacek wrote: On 11.2.2015 14:10, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4657#comment:13 Patch attached. -- Martin Basti freeipa-mbasti-0190-DNSSEC-add-support-f

Re: [Freeipa-devel] [PATCH 0194] Remove unused method to export secret key from ipapkcs11helper module

2015-03-06 Thread Tomas Babej
On 03/05/2015 02:45 PM, Petr Spacek wrote: On 25.2.2015 14:24, Martin Basti wrote: The method never been used, and never will be, because we do not want to export secrets. Ticket: https://fedorahosted.org/freeipa/ticket/4657 Patch attached (may require mbasti-0195, mbasti-0190) ACK, it works

Re: [Freeipa-devel] [PATCH 0023-0025] p11helper improvements

2015-03-06 Thread Tomas Babej
On 03/05/2015 04:10 PM, Martin Basti wrote: On 05/03/15 15:37, Petr Spacek wrote: On 5.3.2015 14:50, Petr Spacek wrote: Hello, please review this patch set. It should be applied on top of your previous p11helper patch set. Thank you! Reviewer requested reworded version of the error messag

[Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-03-09 Thread Tomas Babej
rom: Tomas Babej Date: Mon, 2 Mar 2015 16:30:56 +0100 Subject: [PATCH] winsync-migrate: Add initial plumbing --- install/tools/ipa-winsync-migrate | 23 ipaserver/winsync_migrate/__init__.py | 22 ipaserver/winsync_migrate/base.py |

Re: [Freeipa-devel] [PATCH 0199] Remove unused disable-betxn.ldif file

2015-03-09 Thread Tomas Babej
On 03/09/2015 11:56 AM, David Kupka wrote: On 02/25/2015 02:45 PM, Martin Basti wrote: Hello, the file 'disable-betxn.ldif' is not used in code in IPA master branch. There is 10-enable-betxn.update which is used. If I'm right we can remove it. Patch attached. Please correct me if the file is

Re: [Freeipa-devel] [PATCHES 134-136] extdom: handle ERANGE return code for getXXYYY_r()

2015-03-09 Thread Tomas Babej
On 03/06/2015 01:08 PM, Alexander Bokovoy wrote: On Thu, 05 Mar 2015, Sumit Bose wrote: On Thu, Mar 05, 2015 at 09:16:36AM +0100, Sumit Bose wrote: On Wed, Mar 04, 2015 at 06:14:53PM +0100, Sumit Bose wrote: > On Wed, Mar 04, 2015 at 04:17:55PM +0200, Alexander Bokovoy wrote: > > On Mon, 02 Ma

Re: [Freeipa-devel] [PATCHES 0200-0202] DNS fixes related to unsupported records

2015-03-09 Thread Tomas Babej
On 03/06/2015 01:30 PM, Petr Spacek wrote: On 4.3.2015 16:35, Martin Basti wrote: On 04/03/15 16:17, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/4930 0200: 4.1, master Fixes traceback, which was raised if LDAP contained a record that was marked as unsupported. Now uns

Re: [Freeipa-devel] [PATCHES 0200-0202] DNS fixes related to unsupported records

2015-03-09 Thread Tomas Babej
On 03/09/2015 03:20 PM, Martin Basti wrote: On 09/03/15 15:09, Tomas Babej wrote: On 03/06/2015 01:30 PM, Petr Spacek wrote: On 4.3.2015 16:35, Martin Basti wrote: On 04/03/15 16:17, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/4930 0200: 4.1, master Fixes

Re: [Freeipa-devel] [PATCH] extdom: return LDAP_NO_SUCH_OBJECT to the client

2015-03-10 Thread Tomas Babej
On 03/05/2015 07:28 AM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Sumit Bose wrote: Hi, with this patch the extdom plugin will properly indicate to a client if the search object does not exist instead of returning a generic error. This is important for the client to act accordingly and imp

Re: [Freeipa-devel] [PATCH 142] extdom: fix memory leak

2015-03-10 Thread Tomas Babej
On 03/05/2015 08:00 AM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Nathan Kinder wrote: On 03/04/2015 10:34 PM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Sumit Bose wrote: Hi, while running 389ds with valgrind to see if my other patches introduced a memory leak I found an older on

Re: [Freeipa-devel] [PATCH 142] extdom: fix memory leak

2015-03-10 Thread Tomas Babej
On 03/10/2015 12:10 PM, Sumit Bose wrote: On Tue, Mar 10, 2015 at 11:59:45AM +0100, Tomas Babej wrote: On 03/05/2015 08:00 AM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Nathan Kinder wrote: On 03/04/2015 10:34 PM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Sumit Bose wrote: Hi

Re: [Freeipa-devel] [PATCH] Use curl instead of wget

2015-03-10 Thread Tomas Babej
On 01/22/2015 04:01 PM, Alexander Bokovoy wrote: On Thu, 22 Jan 2015, Colin Walters wrote: On Thu, Jan 22, 2015, at 08:45 AM, Alexander Bokovoy wrote: We have abstraction layer to take care of different platforms on a wider scale than just this particular binary. We are gradually moving all

Re: [Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

2015-03-10 Thread Tomas Babej
On 03/09/2015 12:26 PM, Tomas Babej wrote: Hi, this couple of patches provides a initial implementation of the winsync migration tool: https://fedorahosted.org/freeipa/ticket/4524 Some parts could use some polishing, but this is a sound foundation. Tomas Attaching one more patch to

Re: [Freeipa-devel] [PATCH 0209] Fix logically dead code in ipap11helper module

2015-03-11 Thread Tomas Babej
On 03/11/2015 11:28 AM, Petr Spacek wrote: On 9.3.2015 13:52, Martin Basti wrote: Patch attached. ACK for this patch. When you are at it, it would be good to fix other warnings too. GCC on Fedora 21 is yelling at me: p11helper.c: In function ‘P11_Helper_find_keys’: p11helper.c:1062:23: warn

Re: [Freeipa-devel] [PATCHES 0018-0020] ipa-dns-install: Use LDAPI for all DS connections

2015-03-18 Thread Tomas Babej
On 03/16/2015 05:01 PM, Martin Basti wrote: On 16/03/15 14:26, Martin Babinsky wrote: On 03/16/2015 01:44 PM, Martin Basti wrote: On 12/03/15 17:15, Martin Babinsky wrote: On 03/12/2015 03:59 PM, Martin Babinsky wrote: On 03/11/2015 03:13 PM, Martin Basti wrote: On 11/03/15 13:00, Martin B

Re: [Freeipa-devel] [PATCH] 0041 Always reload StateFile before getting or modifying the, stored values.

2015-03-18 Thread Tomas Babej
On 03/17/2015 10:29 AM, Martin Basti wrote: On 16/03/15 13:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4901 ACK, it works as expected Pushed to master: 082c55fb9cf87263f1f585a1adeda464a9d7328a -- Manage your subscription for the Freeipa-devel mailing list: https://www.re

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:2

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-18 Thread Tomas Babej
On 03/18/2015 11:23 AM, Jakub Hrozek wrote: On Wed, Mar 18, 2015 at 10:58:51AM +0100, Sumit Bose wrote: Please find attached a new version where the typo is fixed. bye, Sumit ACK I think the IPA gatekeepers shoudl feel free to just fix these trivial errors before pushing in the future. Pu

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/18/2015 01:10 PM, Alexander Bokovoy wrote: On Wed, 18 Mar 2015, Tomas Babej wrote: On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06

Re: [Freeipa-devel] [PATCH 0203] Remove unused PRE_SCHEMA upgrade

2015-03-19 Thread Tomas Babej
On 03/18/2015 01:42 PM, Martin Kosek wrote: On 03/18/2015 01:11 PM, Martin Basti wrote: On 12/03/15 17:30, Martin Basti wrote: On 12/03/15 17:08, Rob Crittenden wrote: Martin Basti wrote: On 12/03/15 16:22, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 04:52 PM, Martin Basti wrot

Re: [Freeipa-devel] [PATCHES 0204-0207, 0211] Server upgrade: Make LDAP data upgrade deterministic

2015-03-19 Thread Tomas Babej
On 03/19/2015 12:20 PM, David Kupka wrote: On 03/13/2015 03:08 PM, Martin Basti wrote: On 12/03/15 16:21, Rob Crittenden wrote: Martin Basti wrote: The patchset ensure, the upgrade order will respect ordering of entries in *.update files. Required for: https://fedorahosted.org/freeipa/tick

Re: [Freeipa-devel] [PATCH 0208] Remove --test option from upgrade

2015-03-23 Thread Tomas Babej
On 03/19/2015 12:25 PM, David Kupka wrote: On 03/17/2015 01:07 PM, Martin Basti wrote: On 12/03/15 16:10, David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensu

[Freeipa-devel] OOO 2015-03-31-2015-04-01

2015-03-30 Thread Tomas Babej
Hours already accumulated this month. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] OOO 2015-03-31-2015-04-01

2015-03-30 Thread Tomas Babej
Sorry about the noise. On 03/31/2015 07:23 AM, Tomas Babej wrote: Hours already accumulated this month. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute

[Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

2012-07-27 Thread Tomas Babej
Hi, this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it. Uses nose.plugin.skip. https://fedorahosted.org/freeipa/ticket/2905 Tomas BabejFrom 2f7cb184619fddd40c7d141b42d35892b6cd5aff Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Fri, 27 Jul

Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

2012-08-02 Thread Tomas Babej
he tree in test_host_plugin.py On 07/27/2012 01:13 PM, Tomas Babej wrote: > Hi, > > this patch simply checks if ipa-join exists in ipa-client folder, if not, > skips tests relying on it. > Uses nose.plugin.skip. > > https://fedorahosted.org/freeipa/ticket/2905 > > Tomas Babej > H

Re: [Freeipa-devel] [Patch] 0001 Adds check for ipa-join.

2012-08-03 Thread Tomas Babej
All suggestions implemented. Tomas - Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Friday, August 3, 2012 11:24:03 AM Subject: Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_h

[Freeipa-devel] [PATCH] Permissions of replica files changed to 0600.

2012-08-06 Thread Tomas Babej
Hi, file system permissions on replica files in /var/lib/ipa were changed to 0600. https://fedorahosted.org/freeipa/ticket/2847 TomasFrom 21c23582bac3c3ca54b413f95cac948daad90084 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 6 Aug 2012 08:57:14 -0400 Subject: [PATCH] Permissions of

[Freeipa-devel] [PATCH] Handle SSSD restart crash more gently.

2012-08-07 Thread Tomas Babej
Hi, In ipa-client-install, failure of restart of sssd service no longer causes the crash of the install process. Adds a warning message to the root logger instead. https://fedorahosted.org/freeipa/ticket/2827 Tomas ___ Freeipa-devel mailing list Freei

Re: [Freeipa-devel] [PATCH] 0003 Handle SSSD restart crash more gently.

2012-08-07 Thread Tomas Babej
Sorry, I forgot to attach the patch. - Original Message - From: "Tomas Babej" To: freeipa-devel@redhat.com Sent: Tuesday, August 7, 2012 5:58:32 PM Subject: [PATCH] Handle SSSD restart crash more gently. Hi, In ipa-client-install, failure of restart of sssd service no longer

[Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap.

2012-08-10 Thread Tomas Babej
Hi, I checked the rest of the description as well, seems alright. https://fedorahosted.org/freeipa/ticket/2959 Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap.

2012-08-10 Thread Tomas Babej
I forgot the patch once again. - Original Message - From: "Tomas Babej" To: freeipa-devel@redhat.com Sent: Friday, August 10, 2012 12:44:41 PM Subject: [Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap. Hi, I checked the rest of the descripti

[Freeipa-devel] [PATCH] 0005 Improves exception handling in ipa-replica-prepare.

2012-08-10 Thread Tomas Babej
00:00:00 2001 From: Tomas Babej Date: Fri, 10 Aug 2012 08:59:58 -0400 Subject: [PATCH] Improves exception handling in ipa-replica-prepare. A backtrace is no longer displayed when trying to prepare a replica file with the local LDAP server down. Also adds --debug option and no longer displays info

Re: [Freeipa-devel] [PATCH] 0005-2 Improves exception handling in ipa-replica-prepare.

2012-08-10 Thread Tomas Babej
Man page edited. - Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Friday, August 10, 2012 3:49:45 PM Subject: Re: [Freeipa-devel] [PATCH] 0005 Improves exception handling in ipa-replica-prepare. On 08/10/2012 03:07 P

Re: [Freeipa-devel] [PATCH] 0004-2 Corrects help description of selinuxusermap.

2012-08-10 Thread Tomas Babej
Suggestion incorporated. Tomas - Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Friday, August 10, 2012 3:43:06 PM Subject: Re: [Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap. On 08/10/2012 0

Re: [Freeipa-devel] [PATCH] 0003-2 Handle SSSD restart crash more gently.

2012-08-14 Thread Tomas Babej
Issue resolved. Tomas - Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Tuesday, August 14, 2012 9:26:03 AM Subject: Re: [Freeipa-devel] [PATCH] 0003 Handle SSSD restart crash more gently. On 08/07/2012 06:14 PM, Tomas

Re: [Freeipa-devel] [PATCH] 0004-3 Corrects help description of selinuxusermap.

2012-08-14 Thread Tomas Babej
- Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Tuesday, August 14, 2012 8:41:44 AM Subject: Re: [Freeipa-devel] [PATCH] 0004-2 Corrects help description of selinuxusermap. Looking at the changes, I think there is stil

Re: [Freeipa-devel] [PATCH] 0005-3 Improves exception handling in ipa-replica-prepare.

2012-08-14 Thread Tomas Babej
- Original Message - From: "Martin Kosek" To: "Tomas Babej" Cc: freeipa-devel@redhat.com Sent: Tuesday, August 14, 2012 8:55:19 AM Subject: Re: [Freeipa-devel] [PATCH] 0005-2 Improves exception handling in ipa-replica-prepare. >On 08/10/2012 04:32 PM, Tomas B

[Freeipa-devel] [PATCH] 0006 Removes sssd.conf after uninstall.

2012-08-17 Thread Tomas Babej
Hi, The sssd.conf file is no longer left behind in case sssd was not configured before the installation. https://fedorahosted.org/freeipa/ticket/2740 TomasFrom ae338576d912f494707653e311517070baedb986 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Fri, 17 Aug 2012 08:56:45 -0400 Subject

[Freeipa-devel] [PATCH] 0007 Adds dependency on samba4-windbind.

2012-08-20 Thread Tomas Babej
Hi, Dependency on samba4-winbind has been added to the package freeipa-server-trust-ad. TomasFrom 63123b9a753df05cec06e369c80a58e01601423a Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 20 Aug 2012 03:57:55 -0400 Subject: [PATCH] Adds dependency on samba4-windbind. Dependency on samba4

Re: [Freeipa-devel] [PATCH] 0007 Adds dependency on samba4-windbind.

2012-08-20 Thread Tomas Babej
Fixed typo in the commit message. Tomas - Original Message - From: "Tomas Babej" To: freeipa-devel@redhat.com Sent: Monday, August 20, 2012 10:08:41 AM Subject: [Freeipa-devel] [PATCH] 0007 Adds dependency on samba4-windbind. Hi, Dependency on samba4-winbind has been ad

Re: [Freeipa-devel] [PATCH] 0007 Adds dependency on samba4-windbind.

2012-08-21 Thread Tomas Babej
On 08/20/2012 02:05 PM, Alexander Bokovoy wrote: On Mon, 20 Aug 2012, Petr Vobornik wrote: On 08/20/2012 10:16 AM, Tomas Babej wrote: Fixed typo in the commit message. Tomas - Original Message - From: "Tomas Babej" To: freeipa-devel@redhat.com Sent: Monday, August 20, 201

[Freeipa-devel] [PATCH] 0008 Fixes different behaviour of permission-mod and show.

2012-08-22 Thread Tomas Babej
Hi, Both commands now produce the same output regarding the attributelevelrights. https://fedorahosted.org/freeipa/ticket/2875 Tomas >From 67c3a3337fe6ce40510f60ecacfc7b8dc8a6cc9d Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Wed, 22 Aug 2012 10:39:01 -0400 Subject: [PATCH] Fixes differ

Re: [Freeipa-devel] [PATCH] 0008 Fixes different behaviour of permission-mod and show.

2012-08-22 Thread Tomas Babej
On 08/22/2012 05:15 PM, Rob Crittenden wrote: Tomas Babej wrote: Hi, Both commands now produce the same output regarding the attributelevelrights. https://fedorahosted.org/freeipa/ticket/2875 I think some unit tests would be helpful so we don't regress and we know which other commands

[Freeipa-devel] [PATCH 0154] man: sshd should be run at least once before client

2014-02-24 Thread Tomas Babej
Hi, If SSH keys have not been generated prior to enrolling the client to the IPA server, they will not be uploaded to the server, since they're not present. Clarify this issue in the man pages. https://fedorahosted.org/freeipa/ticket/4055 -- Tomas Babej Associate Software Engeneer | Re

Re: [Freeipa-devel] [PATCH 0138] ipalib: Expose krbPrincipalExpiration in CLI

2014-02-24 Thread Tomas Babej
Rebased to current master. On 01/09/2014 04:31 PM, Tomas Babej wrote: > Hi, > > Adds a krbPrincipalExpiration attribute to the user class > in user.py ipalib plugin as a DateTime parameter. > > Part of: https://fedorahosted.org/freeipa/ticket/3306 > -- Tomas Babej Associ

Re: [Freeipa-devel] [PATCH 0153] ipatests: Fix incorrect order of operations when restoring

2014-02-24 Thread Tomas Babej
produce >> correct error, SELinux-related or other. > > In that case you're on your own, you should wrap the test in custom > setup & teardown code. > > > There's no way we can perfectly restore a system after IPA has been > installed on it, much less if it

Re: [Freeipa-devel] [PATCH 0137] ipalib: Add DateTime parameter

2014-02-25 Thread Tomas Babej
On 01/14/2014 10:19 AM, Petr Viktorin wrote: > On 01/14/2014 09:27 AM, Jan Cholasta wrote: >> On 13.1.2014 14:57, Petr Vobornik wrote: >>> On 13.1.2014 13:41, Jan Cholasta wrote: >>>> Hi, >>>> >>>> On 10.1.2014 21:21, Nathaniel McCallum wrote

[Freeipa-devel] [PATCH 0155] ipatests: Kill winbindd process after uninstall

2014-02-25 Thread Tomas Babej
Hi, As a part of a better cleanup procedure in the integration tests, make sure that winbindd is not running after uninstalling the IPA server. -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCH] 0138, 0141: ipa-kdb fixes

2014-02-26 Thread Tomas Babej
> > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel After some thorough testing, ACK! With this patch, not only we solve the referenced IPA ticket, but adding a trust no lon

Re: [Freeipa-devel] [PATCH] 0138, 0141: ipa-kdb fixes

2014-02-26 Thread Tomas Babej
On 02/26/2014 02:16 PM, Tomas Babej wrote: > On 02/26/2014 12:39 PM, Martin Kosek wrote: >> On 02/26/2014 09:33 AM, Alexander Bokovoy wrote: >>> On Wed, 26 Feb 2014, Martin Kosek wrote: >>>> On 02/25/2014 07:59 PM, Simo Sorce wrote: >>>>> On Tue, 2014-

[Freeipa-devel] [PATCH 0156] trusts: Remove usage of deprecated LDAP API

2014-02-27 Thread Tomas Babej
Hi, Remove a reference to the old deprecated LDAP API invoked by the usage of trust_add method. https://fedorahosted.org/freeipa/ticket/4204 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCHES] 0337-0343 YAML test configuration

2014-03-03 Thread Tomas Babej
; >> >> https://fedorahosted.org/freeipa/ticket/3938 > > Tests added, new version attached. > As for #4081 (Export dynamic roles properly in ipa-test-config), hosts > are exported like static roles are (from the TestComplexConfig case): > > TESTHOST_EXTRAROLEM_env1=&quo

Re: [Freeipa-devel] [PATCH 0113] ipa-client: Set NIS domain name in the installer

2014-03-03 Thread Tomas Babej
https://bugzilla.redhat.com/show_bug.cgi?id=1071951 On 11/14/2013 12:54 PM, Ana Krivokapic wrote: > On 09/26/2013 10:28 AM, Tomas Babej wrote: >> +if options.no_nisdomain and not options.nisdomain: > This should be `if options.no_nisdomain and options.nisdomain:`. >> +parser.error("-

[Freeipa-devel] [PATCH 0157] ipa-client-install: Configure sudo to use SSSD as data source

2014-03-03 Thread Tomas Babej
Hi, Makes ipa-client-install configure SSSD as the data provider for the sudo service by default. This behaviour can be disabled by using --no-sudo flag. https://fedorahosted.org/freeipa/ticket/3358 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site

Re: [Freeipa-devel] [PATCHES] 0337-0343 YAML test configuration

2014-03-04 Thread Tomas Babej
Thanks, PATCH 341: ACK (this is the last remaining ACK for this patchset) On 03/04/2014 11:58 AM, Petr Viktorin wrote: > On 03/03/2014 01:41 PM, Tomas Babej wrote: >> Finally got to this patchset! >> >> PATCH 337: ACK >> PATCH 338: ACK >> >> This proh

Re: [Freeipa-devel] [PATCH 0154] man: sshd should be run at least once before client

2014-03-05 Thread Tomas Babej
Thanks Jan, both fixed. Tomas On 03/05/2014 10:53 AM, Jan Pazdziora wrote: > On Mon, Feb 24, 2014 at 02:58:13PM +0100, Tomas Babej wrote: >> Hi, >> >> If SSH keys have not been generated prior to enrolling the client to the >> IPA server, they will not be uploaded t

[Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of trusts as well. https://fedorahosted.org/freeipa/ticket/4247 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
.2014 13:20, Martin Kosek wrote: >>>>>> On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: >>>>>>> On Thu, 13 Mar 2014, Martin Kosek wrote: >>>>>>>> On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: >>>

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
On 03/13/2014 04:28 PM, Tomas Babej wrote: > On 03/13/2014 01:47 PM, Alexander Bokovoy wrote: >> On Thu, 13 Mar 2014, Martin Kosek wrote: >>> On 03/13/2014 01:36 PM, Martin Kosek wrote: >>>> On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: >>>>> On T

[Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-03-17 Thread Tomas Babej
ID mapping derivation capabilities. https://fedorahosted.org/freeipa/ticket/4137 Test coverage coming soon! -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 0d038fb71f02fab5320e4843be80feb34c5c3303 Mon Sep 17 00

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-03-18 Thread Tomas Babej
On 03/18/2014 09:19 AM, Alexander Bokovoy wrote: > On Mon, 17 Mar 2014, Tomas Babej wrote: >> Hi, >> >> The ipa-range-check plugin used to determine the range type depending >> on the value of the attributes such as RID or secondary RID base. This >> approached c

[Freeipa-devel] [PATCH 0159] ipatests: test_trust: Change expected home directories for

2014-03-20 Thread Tomas Babej
/freeipa/ticket/4184 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From acadb5537c26b0f27065c172b7952f3e14474939 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 27 Feb 2014 15:40:54 +0100 Subject: [PATCH] ipate

<    1   2   3   4   5   6   7   8   9   10   >