pvoborni commented on a pull request
"""
Promotion of replica is missing ds.enable_ssl step (or how is it called). Tomas
is working on it in ticket https://fedorahosted.org/freeipa/ticket/6226
"""
See the full comment at
https://github.com/freeipa/freeipa/
pvoborni commented on a pull request
"""
nack for f72ae94
it needs this update
```diff
diff --git a/install/ui/src/freeipa/certificate.js
b/install/ui/src/freeipa/certificate.js
index ad7fd87..9ab4002 100755
--- a/install/ui/src/freeipa/certificate.js
+++ b/install
pvoborni's pull request #63: "fix for 6238 "Unable to view certificates issued
by Sub CA in Web UI" separated from pr31" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/63
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.
pvoborni's pull request #63: "fix for 6238 "Unable to view certificates issued
by Sub CA in Web UI" separated from pr31" was opened
PR body:
"""
Pavel's patch separated from pr #31. Pavel is on vacation so he cannot split it.
"""
See the full pull-request at https://github.com/freeipa/freeipa/pu
pvoborni commented on a pull request
"""
These 2 commits were already ACKed in PR #31 so we can merge them.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/63#issuecomment-245112325
--
Manage your subscription for the Freeipa-devel mailin
pvoborni's pull request #65: "#6216 - webui: cert_revoke should use --cacn to
set correct CA when revoking certificate" was opened
PR body:
"""
This is Pavel's patch with changes mentioned in pull request #31 comment 1
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/65
.
pvoborni's pull request #65: "#6216 - webui: cert_revoke should use --cacn to
set correct CA when revoking certificate" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/65
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/fre
pvoborni commented on a pull request
"""
Obsoleted by pull request #65
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/31#issuecomment-245200659
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/lis
pvomacka's pull request #31: "WebUI: add support for sub-CAs while revoking
certificates and removing certificate hold" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/31
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
pvoborni commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/7fea3914fbfc0748f26dfe41445b5f0d12f406e6
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/a68da14654243821274848b9af57fec3dc2fdb39
"""
See the full comment
pvoborni's pull request #65: "#6216 - webui: cert_revoke should use --cacn to
set correct CA when revoking certificate" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/65
--
Manage your subscription for the Freeipa-devel mailing list:
https://ww
pvoborni's pull request #65: "#6216 - webui: cert_revoke should use --cacn to
set correct CA when revoking certificate" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/65
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
URL: https://github.com/freeipa/freeipa/pull/69
Title: #69: Fix ipa-replica-install with RHEL 6.8 master
pvoborni commented:
"""
Is it still needed? Seems that fixing IPA 3.0 fixes the issue.
"""
See the full comment at
https://github.com/freeipa/freeipa/
URL: https://github.com/freeipa/freeipa/pull/139
Title: #139: WebUI: Vault Management
pvoborni commented:
"""
For other optional UIs like CA/Trusts or DNS, Web UI checks on UI start if the
component is installed by batch command with:
```JavaScript
{method: "env",
URL: https://github.com/freeipa/freeipa/pull/158
Title: #158: WebUI: update Patternfly and Bootstrap
pvoborni commented:
"""
I don't think the patternfly package can be included in Fedora as is. It
internally bundles several packages, some of them already packaged (jquery
URL: https://github.com/freeipa/freeipa/pull/165
Title: #165: Tests: Verify that cert-find show CA without --all
pvoborni commented:
"""
that reminds me this regression in cert-show:
https://fedorahosted.org/freeipa/ticket/6022#comment:6
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/165
Title: #165: Tests: Verify that cert-find show CA without --all
pvoborni commented:
"""
Right, I only wanted to highlight the issue in #6022. It should be a separate
patch.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/132
Title: #132: Port all setup.py files to setuptools
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4cd83fb51cc35a2ba7773b62a7aa8d295a1e1e4a
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/132
Author: tiran
Title: #132: Port all setup.py files to setuptools
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/132/head:pr132
git checkout pr132
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/132
Title: #132: Port all setup.py files to setuptools
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
pvoborni commented:
"""
The debug patch breaks test installation on RHEL. Following exception is
printed only if install.py is adjusted to print exception on line
```
ipa :
URL: https://github.com/freeipa/freeipa/pull/186
Author: pvoborni
Title: #186: replicainstall: log ACI and LDAP errors in promotion check
Action: opened
PR body:
"""
to enable debugging of such errors.
E.g.: https://fedorahosted.org/freeipa/ticket/5741
"""
To
URL: https://github.com/freeipa/freeipa/pull/166
Title: #166: WebUI: services without canonical name are shown correctly
pvoborni commented:
"""
Works for me. Code look OK. I have only one minor nitpick: name of the adaper.
Current is `SearchTableColumnFieldAdapter` imho bett
URL: https://github.com/freeipa/freeipa/pull/166
Title: #166: WebUI: services without canonical name are shown correctly
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.or
URL: https://github.com/freeipa/freeipa/pull/166
Title: #166: WebUI: services without canonical name are shown correctly
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4f760dffa011a3656b6072c74088b497ff416a8d
ipa-4-4:
https://fedorahos
URL: https://github.com/freeipa/freeipa/pull/166
Title: #166: WebUI: services without canonical name are shown correctly
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa
URL: https://github.com/freeipa/freeipa/pull/166
Author: pvomacka
Title: #166: WebUI: services without canonical name are shown correctly
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/166/head:pr166
git checkou
URL: https://github.com/freeipa/freeipa/pull/166
Title: #166: WebUI: services without canonical name are shown correctly
pvoborni commented:
"""
new version works for me ACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/166#issuecom
URL: https://github.com/freeipa/freeipa/pull/145
Title: #145: Refactoring: LDAP Connection Management
pvoborni commented:
"""
We have a lot of refactoring patches which needs to be serialized and pushed
and we don't have much time for it.
If the remaining issue doesn
URL: https://github.com/freeipa/freeipa/pull/197
Title: #197: Make setup.py files PyPI compatible
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Co
URL: https://github.com/freeipa/freeipa/pull/197
Author: tiran
Title: #197: Make setup.py files PyPI compatible
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/197/head:pr197
git checkout pr197
--
Manage your su
URL: https://github.com/freeipa/freeipa/pull/197
Title: #197: Make setup.py files PyPI compatible
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/2dd66c6366454f9edd9b89861530e97c75b2d869
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
pvoborni commented:
"""
If I understand it correctly, the review is stalled for some time given that
there is misalignment if this pull request i
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization
pvoborni commented:
"""
I don't understand the "Nevermind this PR then.".
fixing ticket 6482 is good but fixing ticket 6408 is required event more for
@t
URL: https://github.com/freeipa/freeipa/pull/255
Title: #255: Adjustments for setup requirements
pvoborni commented:
"""
The commit message doesn't explain why python-gssapi version is raised. Is it
required by something? It also doesn't explain if the minimal re
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
If I understand Christian right, it is not disagreement about something which
needs to be done. But rather a proposal to address rest of the s
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To
rest later by Honza?
"""
See the full com
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To
rest later by Honza?
"""
See the full com
URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts
pvoborni commented:
"""
Lets push this code if it is correct but only misses usecases mentioned above".
Honza will implement the missing usecases in separate P
URL: https://github.com/freeipa/freeipa/pull/295
Author: tiran
Title: #295: Issue6474 fixups
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/295/head:pr295
git checkout pr295
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/295
Title: #295: Issue6474 fixups
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/fb307ba582d4e7339b7026cbe26c3b170221e249
https://fedorahosted.org/freeipa/changeset/3e3b5462b28f2133fd4170645
URL: https://github.com/freeipa/freeipa/pull/295
Title: #295: Issue6474 fixups
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
pvoborni commented:
"""
Honza, would this work?
```diff
diff --git a/ipalib/config.py b/ipalib/config.py
index 9d87782..6c3a0b1 100644
--- a/ipal
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
pvoborni commented:
"""
True, also thinking that it might not be the best name because it can be
confused with buildin EnvironmentError so th
URL: https://github.com/freeipa/freeipa/pull/302
Author: pvoborni
Title: #302: Use env var IPA_CONFDIR to get confdir for 'cli' context
Action: opened
PR body:
"""
This is continuation of PR #182 . It contains patch from #182 and additional
one which addresses t
URL: https://github.com/freeipa/freeipa/pull/302
Author: pvoborni
Title: #302: Use env var IPA_CONFDIR to get confdir for 'cli' context
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/302/head
URL: https://github.com/freeipa/freeipa/pull/325
Title: #325: WebUI: Hide incorrectly shown buttons on hosts tab in ID Views
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeip
URL: https://github.com/freeipa/freeipa/pull/325
Title: #325: WebUI: Hide incorrectly shown buttons on hosts tab in ID Views
pvoborni commented:
"""
Works for me
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/325#issuecomment-266495026
--
Ma
URL: https://github.com/freeipa/freeipa/pull/325
Author: pvomacka
Title: #325: WebUI: Hide incorrectly shown buttons on hosts tab in ID Views
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/325/head:pr325
git che
URL: https://github.com/freeipa/freeipa/pull/325
Title: #325: WebUI: Hide incorrectly shown buttons on hosts tab in ID Views
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.fre
URL: https://github.com/freeipa/freeipa/pull/325
Title: #325: WebUI: Hide incorrectly shown buttons on hosts tab in ID Views
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/17392b0ef754781775a10973b2fee8a6d1697f5d
ipa-4-4:
https://f
URL: https://github.com/freeipa/freeipa/pull/355
Title: #355: Set up DS TLS on replica in CA-less topology
pvoborni commented:
"""
Running `ipa-certupdate` on all systems after `ipa-ca-install` is problematic.
But we can at least make sure that `ipa-ca-install` on replica will g
URL: https://github.com/freeipa/freeipa/pull/158
Title: #158: WebUI: update Patternfly and Bootstrap
pvoborni commented:
"""
works for me
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/158#issuecomment-270705015
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/158
Title: #158: WebUI: update Patternfly and Bootstrap
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Co
URL: https://github.com/freeipa/freeipa/pull/158
Title: #158: WebUI: update Patternfly and Bootstrap
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/18425dbbe7b7c311cf947074d505225b235df769
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/158
Title: #158: WebUI: update Patternfly and Bootstrap
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute
URL: https://github.com/freeipa/freeipa/pull/158
Author: pvomacka
Title: #158: WebUI: update Patternfly and Bootstrap
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/158/head:pr158
git checkout pr158
--
Manage y
URL: https://github.com/freeipa/freeipa/pull/327
Title: #327: WebUI: RPC refactoring
pvoborni commented:
"""
works for me, the travis failure is invalid̈́ - web ui is not related to the
tests and pylint passes
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/327
Title: #327: WebUI: RPC refactoring
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/327
Title: #327: WebUI: RPC refactoring
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/5a950aeb29963ed22a2c3c1b80723589ac4097de
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/327
Title: #327: WebUI: RPC refactoring
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/327
Author: pvomacka
Title: #327: WebUI: RPC refactoring
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/327/head:pr327
git checkout pr327
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/381
Title: #381: disable hostname canonicalization by Kerberos library
pvoborni commented:
"""
To not forget to update the release notes later at release, @martbab could you
update the respected fields in both ticket and BZ when the
URL: https://github.com/freeipa/freeipa/pull/395
Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1"
pvoborni commented:
"""
Btw our goal is not to make pure IPv6 working - this was not tested even before
the regression.
URL: https://github.com/freeipa/freeipa/pull/395
Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1"
pvoborni commented:
"""
Possible ways how to fix upgrades are outlined in
https://bugzilla.redhat.com/show_bug.cgi?id=1398600#c4
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
pvoborni commented:
"""
@HonzaCholasta with @pspacek no longer caring about this PR, we should close
it. But before we do it, what are y
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
pvoborni commented:
"""
Shouldn't we rather remove lite sever completely?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/407#issuecomment-274
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
pvoborni commented:
"""
When I was still developing server-side then I used lsyncd to rsync files from
my local laptop working git repo to their location on vm in a lab.
So the pro
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
pvoborni commented:
"""
Maybe the lite-server approach is great and other people would appreciate that.
I shouldn't be the one to judge it.
What about demonstrating it to the
URL: https://github.com/freeipa/freeipa/pull/395
Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1"
pvoborni commented:
"""
Yes, but in different patch please. PKI with the fix was not released yet. So
it should not block rev
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
pvoborni commented:
"""
Could we rather add the mod_auth_gssapi and gssproxy packages into
@freeipa/freeipa-master copr repo? Without the rpms in master copr repo,
URL: https://github.com/freeipa/freeipa/pull/437
Title: #437: FIPS: replica install check
pvoborni commented:
"""
@MartinBasti I'm not sure from your comment if you would like to provide a way
to change non-FIPS server into a FIPS server or just brainstorming ways how it
URL: https://github.com/freeipa/freeipa/pull/443
Title: #443: Stronger check for DM password during server install
pvoborni commented:
"""
Function check_password_fips_nssdb_compatible looks like a great candidate for
unit test.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/423
Title: #423: dns-update-system-records: add support for nsupdate output format
pvoborni commented:
"""
I've added acceptance criteria and user story to the related FreeIPA ticket.
I miss a "how to use part" - a
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I still think that this use case needs to be documented in
http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use .
IMHO `make dist
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
Is there a way(I did not read changes thoroughly) to enable sorting and
indentation, e.g. for testing purposes?
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
It's usually quicker to read raw response in browser than the folded "preview"
because everything is visible and no clicking is required. Same f
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
pvoborni commented:
"""
As mention on meeting, if rpcserver prettyprints into output in debug mode then
it is fine.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/379
Title: #379: Packaging: Add placeholder and IPA commands packages
pvoborni commented:
"""
I thought that I understand why this PR is needed bud in fact I don't. Ticket
#6484 is closed. Why is it attached to it?
How wil
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
pvoborni commented:
"""
@tiran I have very vague idea how this is helpful. You have mentioned it
during post-devconf "API meeting". Bu
URL: https://github.com/freeipa/freeipa/pull/379
Title: #379: Packaging: Add placeholder and IPA commands packages
pvoborni commented:
"""
If there is reason it can be maintained in IPA, but what is the reason?
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/23
Title: #23: Time-Based HBAC Policies
Label: +postponed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/215
Title: #215: Add script to setup krb5 NFS exports
pvoborni commented:
"""
Justin, pasting here re-phrased mail I wrote you on Dec 5.
This is a tool which integrates external host with FreeIPA. It is written in a
way th
URL: https://github.com/freeipa/freeipa/pull/215
Title: #215: Add script to setup krb5 NFS exports
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute
URL: https://github.com/freeipa/freeipa/pull/215
Author: jumitche
Title: #215: Add script to setup krb5 NFS exports
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/215/head:pr215
git checkout pr215
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values
pvoborni commented:
"""
LGTM (reading code).
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/331#issuecomment-279984562
-
URL: https://github.com/freeipa/freeipa/pull/468
Title: #468: Remove non-sensical kdestroy on https stop
pvoborni commented:
"""
And AFAIK b) is not supported. @martbab , does something indicate otherwise?
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I think it is OK to keep the behavior of the patch and go with it provided that
the behavior is properly document in the design page after push.
The
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
I still fail to see why we should care about `make dist` with `configure
--disable-server` this is not a combination of options which should be used
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed
pvoborni commented:
"""
Would it be better to suppress the warning and use sensible size limit. I.e.
the entity select doesn't need to show all entries. I'm a
URL: https://github.com/freeipa/freeipa/pull/368
Title: #368: WebUI: fix incorrect behavior of ESC button on combobox
pvoborni commented:
"""
Code LGTM, but I did not tests the behavior, so cannot give ACK now.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/368
Title: #368: WebUI: fix incorrect behavior of ESC button on combobox
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.
URL: https://github.com/freeipa/freeipa/pull/368
Title: #368: WebUI: fix incorrect behavior of ESC button on combobox
pvoborni commented:
"""
ACK given that Martin did functional testing
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribu
URL: https://github.com/freeipa/freeipa/pull/364
Author: tiran
Title: #364: Client-only builds with --disable-server
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/364/head:pr364
git checkout pr364
--
Manage yo
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/70554938d4f9ba5b347cd4bc8001428e905198e4
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/494
Author: lslebodn
Title: #494: Support client-only build
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/494/head:pr494
git checkout pr494
--
Manage your subscript
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
pvoborni commented:
"""
#364 was pushed.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/494#issuecomment-281690828
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
pvoborni commented:
"""
Also I added section to FreeIPA wiki:
http://www.freeipa.org/page/V4/Build_system_refactoring#Packager_-_client_only_build
"""
1 - 100 of 175 matches
Mail list logo
