URL: https://github.com/freeipa/freeipa/pull/452
Title: #452: [ WIP] ipa-run-tests: allow to run tests with server-api
tiran commented:
"""
It's going to get simpler when privilege separation patch has landet.
"""
See the full comment at
https://
URL: https://github.com/freeipa/freeipa/pull/458
Author: tiran
Title: #458: Bytes deprecation warnings
Action: opened
PR body:
"""
* Enable bytes and deprecation warnings
* Fix a couple of bytes and deprecation warnings
https://fedorahosted.org/freeipa/ticket/6631
""
URL: https://github.com/freeipa/freeipa/pull/458
Author: tiran
Title: #458: Bytes deprecation warnings
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/458/head:pr458
git checkout pr458
From
URL: https://github.com/freeipa/freeipa/pull/458
Author: tiran
Title: #458: Enable Bytes and deprecation warnings
Action: edited
Changed field: title
Original value:
"""
Bytes deprecation warnings
"""
--
Manage your subscription for the Freeipa-devel mailin
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
In the latest version, ```--disable-server``` does not affect ```make dist```.
It only changes the components that are built by ```make``` and instal
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: Faster JSON encoder/decoder
Action: opened
PR body:
"""
Improve performance of FreeIPA's JSON serializer and deserializer.
* Don't indent and sort keys. Both options trigger a slow path i
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: [WIP] Faster JSON encoder/decoder
Action: edited
Changed field: title
Original value:
"""
Faster JSON encoder/decoder
"""
--
Manage your subscription for the Freeipa-devel mailin
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
@lslebodn it works even better without your proposed changes. Parts
```ipatests``` work fine for ```--disable-server``` builds. I need the package
to run
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: [WIP] Faster JSON encoder/decoder
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/459/head:pr459
git checkout pr459
From
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Packaging is a different issue. The PR does not provide RPM packaging for
client-only build. It merely implements configuration and building without
se
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Two reasons
1. ```make install```
2. I need ipatests to be part of the build process in order to get a Python
package for tox later.
"""
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
Why would you want to sort or indent the raw output? The extra verbose output
of ```ipa``` just loads and dumps the output a second time. It's less effi
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
```curl url | python -m json.tool```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/459#issuecomment-279375693
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
No, the test runner should either detect missing packages and skip tests
automatically, or should grow an option to load and execute client tests only.
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I'm following the development principals of **minimum viable product**. This PR
solves a critical use case for me. With the PR I can build FreeIPA c
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: [WIP] Faster JSON encoder/decoder
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/459/head:pr459
git checkout pr459
From
URL: https://github.com/freeipa/freeipa/pull/459
Title: #459: [WIP] Faster JSON encoder/decoder
tiran commented:
"""
@pvoborni I have modified the PR and added a pretty_print option. JSON is now
pretty printed for verbose level 2 and higher.
The old implementation converted all
URL: https://github.com/freeipa/freeipa/pull/462
Title: #462: [WIP] pylint: add custom check for forbidden imports
tiran commented:
"""
Can you turn module matching into a regular expression? We need bit more
advanced checks, e.g. ```ipalib``` should not import from ```ipaplat
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: [WIP] Faster JSON encoder/decoder
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/459/head:pr459
git checkout pr459
From
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I'm following a different design and development philosophy. In my experience
an iterative approach with small, incremental improvements is often bet
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: [WIP] Faster JSON encoder/decoder
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/459/head:pr459
git checkout pr459
From
URL: https://github.com/freeipa/freeipa/pull/379
Title: #379: Packaging: Add placeholder and IPA commands packages
tiran commented:
"""
I don't mind to maintain my own copy of ipacommands with ```ipa-getkeytab```
until we agree on a permanent solution.
""&qu
URL: https://github.com/freeipa/freeipa/pull/407
Author: tiran
Title: #407: New lite-server implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/407/head:pr407
git checkout pr407
From
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
tiran commented:
"""
PR #314 has landed. I have rebased the branch and made the lite-server even
more convenient to use. You can now run it with ```make lite-server``` or
```make lit
URL: https://github.com/freeipa/freeipa/pull/469
Author: tiran
Title: #469: Ignore unlink error in ipa-otpd.socket
Action: opened
PR body:
"""
Don't fail in case the file does not exist.
Signed-off-by: Christian Heimes
"""
To pull the PR as Git bra
URL: https://github.com/freeipa/freeipa/pull/407
Author: tiran
Title: #407: New lite-server implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/407/head:pr407
git checkout pr407
From
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
tiran commented:
"""
PR #314 has landed. I have rebased the branch and made the lite-server even
more convenient to use. You can now run it with ```make lite-server``` or
```make lit
URL: https://github.com/freeipa/freeipa/pull/407
Title: #407: New lite-server implementation
tiran commented:
"""
Example of a single request profile with new lite-server:
```
127.0.0.1 - - [15/Feb/2017 12:55:20] "POST /ipa/session/json HTTP/1.1" 200 -
ipa: INFO: [
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
tiran commented:
"""
FYI, KRA and vault are broken because KRA cert is not migrated:
https://fedorahosted.org/freeipa/ticket/6675
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
tiran commented:
"""
Cookie parsing bug with FreeIPA 4.4 client:
https://fedorahosted.org/freeipa/ticket/6676
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/429
Title: #429: [py3] ipactl restart: log httplib failues as debug
tiran commented:
"""
Yeah, I reported the issue as https://fedorahosted.org/freeipa/ticket/6674 .
Feel free to close it as duplicate.
"""
URL: https://github.com/freeipa/freeipa/pull/459
Author: tiran
Title: #459: Faster JSON encoder/decoder
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/459/head:pr459
git checkout pr459
From
URL: https://github.com/freeipa/freeipa/pull/468
Title: #468: Remove non-sensical kdestroy on https stop
tiran commented:
"""
Why do we back up ccache in the first place?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/468#issuecom
URL: https://github.com/freeipa/freeipa/pull/468
Title: #468: Remove non-sensical kdestroy on https stop
tiran commented:
"""
I'm with @rcritten .
If we need to clean up / remove some files during a restore, then these
clean-ups should be handled by ```ipa-restore```. T
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
You are missing the point. Obviously tests are an important part of building. I
can't test the client bits when ipatests is not available.
Let
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Lukas, you are wasting both my and your precious time with a needless
bike-shedding discussion about semantics. The ```--disable-server``` option
skips a
URL: https://github.com/freeipa/freeipa/pull/472
Author: tiran
Title: #472: Packaging: Add placeholder packages
Action: opened
PR body:
"""
The ipa and freeipa packages are placeholders to prevent PyPI squashing
attacks and reserve the names for future use. `pip instal
URL: https://github.com/freeipa/freeipa/pull/464
Title: #464: Bump required python-cryptography version
tiran commented:
"""
```ipasetup.py.in``` hasn't been updated.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/464#issuecomment-280
URL: https://github.com/freeipa/freeipa/pull/464
Author: stlaz
Title: #464: Bump required python-cryptography version
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/464/head:pr464
git checkout pr464
--
Manage
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
PS: I'm not attached to the new of the option. Please speak up if you can come
up with a better name than ```--ipaclient-unittests```.
"&q
URL: https://github.com/freeipa/freeipa/pull/475
Author: tiran
Title: #475: Add options to run only ipaclient unittests
Action: opened
PR body:
"""
A new option for ipa-run-tests makes the test runner ignore
subdirectories or skips tests that depend on the ipaserver package
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I have one very important question: Without ipatests, how are you going to
automatically test client-only builds?
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
My first PoC used the approach. ipa-run-tests can already takes arguments to
limit tests to subdirectories. One has to remember that ipa-run-tests
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
I have to validate client-only Python wheel packages any way. We can just reuse
the same infrastructure to test client-only RPMs later. See PR #4
URL: https://github.com/freeipa/freeipa/pull/464
Title: #464: Bump required python-cryptography version
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute
URL: https://github.com/freeipa/freeipa/pull/475
Author: tiran
Title: #475: Add options to run only ipaclient unittests
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/475/head:pr475
git checkout pr475
URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket
tiran commented:
"""
Would you rather use ```/usr/bin/rm -f``` to only ignore missing files but
propagate permission errors? I'm not sure why unlink was used in favor of rm
URL: https://github.com/freeipa/freeipa/pull/468
Title: #468: Remove non-sensical kdestroy on https stop
tiran commented:
"""
How about we use systemd PrivateTmp for temporary files? It is not only more
secure but it also automatically removes all temporary files when the serv
URL: https://github.com/freeipa/freeipa/pull/468
Title: #468: Remove non-sensical kdestroy on https stop
tiran commented:
"""
That's my point. Why is the ccache file not stored in ```PrivateTmp```? The
ccache can be removed at any time. It doesn't have to be retained.
URL: https://github.com/freeipa/freeipa/pull/471
Title: #471: Fix some privilege separation regressions
tiran commented:
"""
@HonzaCholasta, we got merge conflicts.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/471#issuecomment-280659419
--
URL: https://github.com/freeipa/freeipa/pull/477
Title: #477: Use RemoveOnStop to cleanup systemd sockets
tiran commented:
"""
RemoveonStop was added in systemd-214. Let me figure which version is on RHEL.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/477
Title: #477: Use RemoveOnStop to cleanup systemd sockets
tiran commented:
"""
RemoveonStop was added in systemd-214. Let me figure which version is on RHEL.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/477
Title: #477: Use RemoveOnStop to cleanup systemd sockets
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribu
URL: https://github.com/freeipa/freeipa/pull/469
Author: tiran
Title: #469: Ignore unlink error in ipa-otpd.socket
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/469/head:pr469
git checkout pr469
--
Manage
URL: https://github.com/freeipa/freeipa/pull/364
Author: tiran
Title: #364: Client-only builds with --disable-server
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/364/head:pr364
git checkout pr364
From
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Thanks for your contribution. I added your patch to my PR. On my system I ran
into a minor issue. Some C99 types like ```uint8_t``` were not defined and I
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
tiran commented:
"""
At the moment wheels are not required for RPM building. python-wheel is not
available on RHEL, but I can work around it. Should the RPM spec file only
conta
URL: https://github.com/freeipa/freeipa/pull/472
Author: tiran
Title: #472: Packaging: Add placeholder packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/472/head:pr472
git checkout pr472
From
URL: https://github.com/freeipa/freeipa/pull/442
Title: #442: Add option to run tests in-tree and out-of-tree mode
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org
URL: https://github.com/freeipa/freeipa/pull/442
Title: #442: Add option to run tests in-tree and out-of-tree mode
tiran commented:
"""
Not useful or relevant any more.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/442#issuecomment-28070802
URL: https://github.com/freeipa/freeipa/pull/442
Author: tiran
Title: #442: Add option to run tests in-tree and out-of-tree mode
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/442/head:pr442
git checkout pr442
URL: https://github.com/freeipa/freeipa/pull/453
Author: tiran
Title: #453: Cleanup certdb
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/453/head:pr453
git checkout pr453
From
URL: https://github.com/freeipa/freeipa/pull/483
Author: tiran
Title: #483: lite-server: validate LDAP connection and cache schema
Action: opened
PR body:
"""
The LDAP schema cache makes the lite-server behave more like mod_wsgi.
See https://fedorahosted.org/freeipa/ticket/6
URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft
tiran commented:
"""
Or you could always clean up ```/root/.dogtag``` and remove the tmp dir when
the var is not None.
By the way do you clean up ```/root/.dogtag``` during update?
&q
URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft
tiran commented:
"""
pylint needs some attention, too.
```
* Module ipaserver.install.cainstance
ipaserver/install/cainstance.py:685: [E1101(no-member),
CAInstance.import_ra_ce
URL: https://github.com/freeipa/freeipa/pull/488
Author: tiran
Title: #488: Speed up client schema cache
Action: opened
PR body:
"""
It's inefficient to open a zip file over and over again. By loading all
members of the schema cache file at once, the ipa CLI script s
URL: https://github.com/freeipa/freeipa/pull/487
Title: #487: Limit request sizes to /KdcProxy
tiran commented:
"""
You fixed the issue in summer 2015.
https://github.com/latchset/kdcproxy/commit/f274aa6787cb8b3ec1cc12c440a56665b7231882
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/487
Title: #487: Limit request sizes to /KdcProxy
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Cod
URL: https://github.com/freeipa/freeipa/pull/486
Title: #486: Migrate OTP import script to python-cryptography
tiran commented:
"""
Thanks Indiana Nathaniel, good code archaeology. The ticket aligns nicely with
https://fedorahosted.org/freeipa/ticket/6650
"""
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
tiran commented:
"""
Yes, it is the right thing to do. You can trust in the expert with a decade of
experience with Python packaging (formerly known as cheese shop).
""&
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@pvoborni The main reason for this PR is explained in the initial PR message. I
like to run an IPA framework server
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
To clarify and emphasis, this PR has nothing to do with the PyPI packaging
effort. Zero. Zip. Nada. Nilch!
The sole inten
URL: https://github.com/freeipa/freeipa/pull/489
Title: #489: Fix error in ca_cert_files validator
tiran commented:
"""
tentative ack, see comment
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/489#issuecomment-281295634
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/472
Author: tiran
Title: #472: Packaging: Add placeholder packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/472/head:pr472
git checkout pr472
From
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: [WIP] certdb: use certutil and match_hostname for cert verification
tiran commented:
"""
Do we ensure that the function is always called with an IDN A-Label encoded
hostname? ```ssl.match_hostname``` assumes that
URL: https://github.com/freeipa/freeipa/pull/489
Title: #489: Fix error in ca_cert_files validator
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: [WIP] certdb: use certutil and match_hostname for cert verification
tiran commented:
"""
The hostname must be ASCII text. Something like ```hostname.encode('ascii')```
should catch non-ASCII text and Pyt
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
tiran commented:
"""
You requsted a dependency in the first place :)
If you are going to add a special build or dependency flavor for PyPI
packaging, please also add ```python[23]
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
https://github.com/HonzaCholasta/freeipa/blob/4ebf4b907213c9951eb9cbd276e0460552563fb1/ipalib/config.py#L579
initializes server from jsonrpc_uri. Does it
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
It does matter. In the current version ```if 'server' not in self:``` is
checked and ```self.server``` is checked a couple of lines after ```i
URL: https://github.com/freeipa/freeipa/pull/397
Author: tiran
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/397
URL: https://github.com/freeipa/freeipa/pull/379
Author: tiran
Title: #379: Packaging: Add placeholder and IPA commands packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/379/head:pr379
git checkout
URL: https://github.com/freeipa/freeipa/pull/453
Title: #453: Cleanup certdb
tiran commented:
"""
@stlaz You did most work with NSS and certdb recently. Can you have a look at
this collection of fixes. Iis it useful for you or do you plan to rip out the
module soonish? Either
URL: https://github.com/freeipa/freeipa/pull/364
Author: tiran
Title: #364: Client-only builds with --disable-server
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/364/head:pr364
git checkout pr364
From
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Now ```-without-ipatests``` argument for @lslebodn
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecom
URL: https://github.com/freeipa/freeipa/pull/364
Title: #364: Client-only builds with --disable-server
tiran commented:
"""
Now ```-without-ipatests``` argument for @lslebodn
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/364#issuecom
URL: https://github.com/freeipa/freeipa/pull/301
Title: #301: scripts, tests: explicitly set confdir in the rest of server code
tiran commented:
"""
My philosophy is: _Don't fix it it it ain't broken._
"""
See the full comment at
https://github.c
URL: https://github.com/freeipa/freeipa/pull/301
Title: #301: scripts, tests: explicitly set confdir in the rest of server code
tiran commented:
"""
My philosophy is: _Don't fix it it it ain't broken._
"""
See the full comment at
https://github.c
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
Can you add a comment to explain the order of checks and assignments? Without
explanation, it's going to confuse the next poor developer.
"&q
URL: https://github.com/freeipa/freeipa/pull/472
Author: tiran
Title: #472: Packaging: Add placeholder packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/472/head:pr472
git checkout pr472
From
URL: https://github.com/freeipa/freeipa/pull/472
Title: #472: Packaging: Add placeholder packages
tiran commented:
"""
OK, you got ```with_wheels``` in ```freeipa.spec.in``` now. ```with_wheels```
is more logical than ```with_pypi``` because wheels have more uses than ju
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@HonzaCholasta FreeIPA has conditional imports for SSSD modules in several
places, e.g. in the trust plugin. 96f614e clo
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
NACK on aece4c3c
We compromised on ```--without-ipatests``` with installation of ipatests
defaulting to true. The compromose was already ACKed by @simo5
""&
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
There are two reasons we decided on ```--without-ipatests```:
* ```--with-tests``` / ```--without-tests``` is technically not correct. We
still compile C tests. The fl
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
NACK on 42fb9b1c
* Either use ```--with-ipaplatform=redhat``` on CentOS
* Or implement a proper way to fill ipaplatfrom from ```/etc/os-relase``` value
```ID
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
You assumption is incorrect. ```ipatests``` does not depend on ```ipaserver```,
https://github.com/freeipa/freeipa/blob/master/ipatests/setup.py#L61
```
i
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
You are aware that your example code checks the wrong code? It is testing
in-tree sources, not the actual sources that get packaged and installed.
"""
URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build
tiran commented:
"""
python-requests is a bad example because it suffers from the same issue as IPA.
A better example is any other modern Python project like cryptography. It runs
tests
URL: https://github.com/freeipa/freeipa/pull/495
Title: #495: Fix ipa-server-upgrade
tiran commented:
"""
Looks totally reasonable.
I checked, ```SimpleServiceInstance('ipa_memcached')``` does not raise an
exception if systemd has no service file for IPA memcached
URL: https://github.com/freeipa/freeipa/pull/495
Title: #495: Fix ipa-server-upgrade
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
401 - 500 of 802 matches
Mail list logo
