Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-09 Thread Martin Basti
On 04/12/14 14:18, Gabe Alford wrote: Thanks for the assistance Lukas! I have an updated patch attached. Thanks, Gabe On Wed, Dec 3, 2014 at 9:30 AM, Lukas Slebodnik lsleb...@redhat.com mailto:lsleb...@redhat.com wrote: On (02/12/14 21:13), Gabe Alford wrote: This patch removes the

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-04 Thread Gabe Alford
Thanks for the assistance Lukas! I have an updated patch attached. Thanks, Gabe On Wed, Dec 3, 2014 at 9:30 AM, Lukas Slebodnik lsleb...@redhat.com wrote: On (02/12/14 21:13), Gabe Alford wrote: This patch removes the changelog and Makefile.am for ipaclient as well. Thanks, Gabe On

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-03 Thread Martin Kosek
On 12/03/2014 05:13 AM, Gabe Alford wrote: This patch removes the changelog and Makefile.am for ipaclient as well. Thanks, Gabe On Mon, Dec 1, 2014 at 8:28 AM, Martin Kosek mko...@redhat.com wrote: On 12/01/2014 04:25 PM, Rob Crittenden wrote: Gabe Alford wrote: On Mon, Dec 1, 2014

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-03 Thread Gabe Alford
Yeah. This is what I was talking about ipaclient builds still relying on Makefile.am. Plus if you remove the ipaclient/Makefile.am and then run `make rpm`, it fails to find the *.py files to package into the rpm. Gabe On Wed, Dec 3, 2014 at 6:05 AM, Martin Kosek mko...@redhat.com wrote: On

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-03 Thread Petr Spacek
On 3.12.2014 14:38, Gabe Alford wrote: Yeah. This is what I was talking about ipaclient builds still relying on Makefile.am. Plus if you remove the ipaclient/Makefile.am and then run `make rpm`, it fails to find the *.py files to package into the rpm. Gabe On Wed, Dec 3, 2014 at 6:05 AM,

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-03 Thread Lukas Slebodnik
On (02/12/14 21:13), Gabe Alford wrote: This patch removes the changelog and Makefile.am for ipaclient as well. Thanks, Gabe On Mon, Dec 1, 2014 at 8:28 AM, Martin Kosek mko...@redhat.com wrote: On 12/01/2014 04:25 PM, Rob Crittenden wrote: Gabe Alford wrote: On Mon, Dec 1, 2014 at 6:05

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-02 Thread Gabe Alford
This patch removes the changelog and Makefile.am for ipaclient as well. Thanks, Gabe On Mon, Dec 1, 2014 at 8:28 AM, Martin Kosek mko...@redhat.com wrote: On 12/01/2014 04:25 PM, Rob Crittenden wrote: Gabe Alford wrote: On Mon, Dec 1, 2014 at 6:05 AM, Martin Kosek mko...@redhat.com

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-01 Thread Martin Kosek
On 11/30/2014 03:28 AM, Gabe Alford wrote: Ignore the last patch. Updated patch attached. On Sat, Nov 29, 2014 at 6:03 PM, Gabe Alford redhatri...@gmail.com wrote: This patch removes the app_PYTHON usage. Thanks, Gabe On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek mko...@redhat.com

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-01 Thread Gabe Alford
On Mon, Dec 1, 2014 at 6:05 AM, Martin Kosek mko...@redhat.com wrote: On 11/30/2014 03:28 AM, Gabe Alford wrote: Ignore the last patch. Updated patch attached. On Sat, Nov 29, 2014 at 6:03 PM, Gabe Alford redhatri...@gmail.com wrote: This patch removes the app_PYTHON usage.

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-12-01 Thread Martin Kosek
On 12/01/2014 04:25 PM, Rob Crittenden wrote: Gabe Alford wrote: On Mon, Dec 1, 2014 at 6:05 AM, Martin Kosek mko...@redhat.com mailto:mko...@redhat.com wrote: On 11/30/2014 03:28 AM, Gabe Alford wrote: Ignore the last patch. Updated patch attached. On Sat, Nov 29, 2014

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-29 Thread Gabe Alford
This patch removes the app_PYTHON usage. Thanks, Gabe On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek mko...@redhat.com wrote: Exactly, this was the message from Martin :-) I did not test it myself, but removing all app_PYTHON should be benign given we use Python setup.py packaging. On

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-29 Thread Gabe Alford
Ignore the last patch. Updated patch attached. On Sat, Nov 29, 2014 at 6:03 PM, Gabe Alford redhatri...@gmail.com wrote: This patch removes the app_PYTHON usage. Thanks, Gabe On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek mko...@redhat.com wrote: Exactly, this was the message from Martin

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-27 Thread Martin Basti
On 27/11/14 00:50, Gabe Alford wrote: Hello, Wondering if I could get a review. Updated patch attached. Thanks, Gabe On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford redhatri...@gmail.com mailto:redhatri...@gmail.com wrote: Hello, Fix for

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-27 Thread Petr Spacek
On 27.11.2014 11:00, Martin Basti wrote: On 27/11/14 00:50, Gabe Alford wrote: Hello, Wondering if I could get a review. Updated patch attached. Thanks, Gabe On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford redhatri...@gmail.com mailto:redhatri...@gmail.com wrote: Hello,

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-27 Thread Martin Kosek
On 11/27/2014 04:12 PM, Petr Spacek wrote: On 27.11.2014 11:00, Martin Basti wrote: On 27/11/14 00:50, Gabe Alford wrote: Hello, Wondering if I could get a review. Updated patch attached. Thanks, Gabe On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford redhatri...@gmail.com

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-27 Thread Gabe Alford
Thanks guys. Sounds like it would be better to submit a patch that removes app_PYTHON if it is considered dead code. Gabe On Thursday, November 27, 2014, Petr Spacek pspa...@redhat.com wrote: On 27.11.2014 11:00, Martin Basti wrote: On 27/11/14 00:50, Gabe Alford wrote: Hello,

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-27 Thread Martin Kosek
Exactly, this was the message from Martin :-) I did not test it myself, but removing all app_PYTHON should be benign given we use Python setup.py packaging. On 11/27/2014 04:27 PM, Gabe Alford wrote: Thanks guys. Sounds like it would be better to submit a patch that removes app_PYTHON if it is

Re: [Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-26 Thread Gabe Alford
Hello, Wondering if I could get a review. Updated patch attached. Thanks, Gabe On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford redhatri...@gmail.com wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/4700 Thanks, Gabe From 4af61cbaafdadb1b338601699d160bd4a15db551 Mon Sep

[Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

2014-11-11 Thread Gabe Alford
Hello, Fix for https://fedorahosted.org/freeipa/ticket/4700 Thanks, Gabe From b6674996bb00ac82943b90248a20114d4ca43073 Mon Sep 17 00:00:00 2001 From: Gabe redhatri...@gmail.com Date: Tue, 11 Nov 2014 07:02:15 -0700 Subject: [PATCH] Add missing python files to Makefiles