Re: [Freeipa-devel] [PATCH 0024][Tests] Fix integration tests not to produce incorrect /etc/hosts file

ACK On 07/19/2016 01:19 PM, Lenka Doudova wrote: On 06/29/2016 06:49 PM, Petr Spacek wrote: On 29.6.2016 18:39, Oleg Fayans wrote: In fact, I believe /etc/hosts file should not be touched at all. Hostname resolution is usually governed by the DNS system of the lab in which tests are running.

[Freeipa-devel] [PATCHES 681-682] cert: speed up cert-find, do not crash on invalid data in cert-find

Hi, the attached patches fix and . Honza -- Jan Cholasta From 61ad08415fa22dfb56342fd1fca7904ebddfc956 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 1 Aug 2016 09:53:39 +0200 Subject: [PATCH

Re: [Freeipa-devel] [PATCH 0024][Tests] Fix integration tests not to produce incorrect /etc/hosts file

On 01.08.2016 09:21, Oleg Fayans wrote: ACK On 07/19/2016 01:19 PM, Lenka Doudova wrote: On 06/29/2016 06:49 PM, Petr Spacek wrote: On 29.6.2016 18:39, Oleg Fayans wrote: In fact, I believe /etc/hosts file should not be touched at all. Hostname resolution is usually governed by the DNS sy

Re: [Freeipa-devel] [PATCHES 681-682] cert: speed up cert-find, do not crash on invalid data in cert-find

On 1.8.2016 10:19, Jan Cholasta wrote: Hi, the attached patches fix and . Self-NACK, proper patches attached. Honza -- Jan Cholasta From 70ef1075bc361d836c1e836114a5367c3c5879d6 Mon Sep 17 00:00:00 2

Re: [Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to removal of has_keytab key from list of expected attributes of update command

Greetings! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" To: "freeipa-devel" Sent: Monday, August 1, 2016 8:20:05 AM Subject: [Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to re

Re: [Freeipa-devel] [PATCH 0560] ipa-client-automount: don not initialize API during uninstall

On 07/29/2016 04:56 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/6072 Patch attached. Hi Martin, thanks for your patch. I could not reproduce the issue anymore with ipa-client-automount --uninstall, thus looks good to me. Ack, Flo. -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

On 07/29/2016 03:00 PM, Pavel Vomacka wrote: On 07/28/2016 08:16 AM, Lenka Doudova wrote: On 07/20/2016 04:51 PM, Pavel Vomacka wrote: Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahosted.org/freeipa/ticket/6064 Hi, thanks for p

[Freeipa-devel] [PATCH] 0001 Added new authentication method

Hi, I have added few lines to code to make optional login with personal certificate (or with smartcard) possible. Some ui changes has to be made. It is not cosher but it definitely work. Thank you, Tibor From 91201035c02a186ad7311880730554925d7bf58e Mon Sep 17 00:00:00 2001 From: Tiboris Date: M

Re: [Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

On 01.08.2016 16:13, Lenka Doudova wrote: On 07/29/2016 03:00 PM, Pavel Vomacka wrote: On 07/28/2016 08:16 AM, Lenka Doudova wrote: On 07/20/2016 04:51 PM, Pavel Vomacka wrote: Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahoste

Re: [Freeipa-devel] [PATCH 0197] re-set canonical principal name on migrated users

On 29.07.2016 15:10, Martin Basti wrote: On 29.07.2016 14:42, Florence Blanc-Renaud wrote: On 07/28/2016 10:56 AM, Martin Babinsky wrote: Fixes https://fedorahosted.org/freeipa/ticket/6101 I have also noticed that the principal aliases are not preserved during migration from FreeIPA 4.4.

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

Tibor Dudlak wrote: Hi, I have added few lines to code to make optional login with personal certificate (or with smartcard) possible. Some ui changes has to be made. It is not cosher but it definitely work. Thank you, Tibor What about the Apache changes to require a certificate in /ipa/sess

Re: [Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to removal of has_keytab key from list of expected attributes of update command

On 01.08.2016 12:01, Ganna Kaihorodova wrote: Greetings! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" To: "freeipa-devel" Sent: Monday, August 1, 2016 8:20:05 AM Subject: [Freeipa-devel] [PATCH 0030][Tests] Fix

Re: [Freeipa-devel] [PATCH 0560] ipa-client-automount: don not initialize API during uninstall

On 01.08.2016 14:28, Florence Blanc-Renaud wrote: On 07/29/2016 04:56 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/6072 Patch attached. Hi Martin, thanks for your patch. I could not reproduce the issue anymore with ipa-client-automount --uninstall, thus looks good to

Re: [Freeipa-devel] [PATCH 0151-0152] install: Call hostnamectl set-hostname only if --hostname option is use server-install: Fix --hostname option to always override api.env value

On 1.8.2016 08:27, Jan Cholasta wrote: > On 28.7.2016 16:55, Petr Spacek wrote: >> On 28.7.2016 16:44, Jan Cholasta wrote: >>> On 28.7.2016 16:37, Petr Spacek wrote: On 28.7.2016 16:35, Jan Cholasta wrote: > On 28.7.2016 16:20, Petr Spacek wrote: >> Hello, >> >> install: Call h

[Freeipa-devel] [PATCH 0153] Fix ipa-replica-prepare's error message about missing local CA instanc

Hello, Fix ipa-replica-prepare's error message about missing local CA instance ipa-replica-prepare must be run on a replica with CA or all the certs needs to be provided (for CA-less case). The old messages were utterly confusing because they mixed errors about missing certs and missing local CA

Re: [Freeipa-devel] [PATCH] webui: Fix coverity bugs

On 07/29/2016 03:25 PM, Alexander Bokovoy wrote: > On Fri, 29 Jul 2016, Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which fixes errors from Coverity. >> >> -- >> Pavel^3 Vomacka >> > >> From 0391289b3f6844897e2a9f3ae549bd4c33233ffc Mon Sep 17 00:00:00 2001 >> From: Pavel V

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

On 28.07.2016 18:29, Ariel Barria wrote: 2016-07-28 7:10 GMT-05:00 Petr Spacek : On 27.7.2016 18:26, Ariel Barria wrote: 2016-07-26 9:39 GMT-05:00 Petr Spacek : On 26.7.2016 16:28, Jan Cholasta wrote: Hi, On 26.7.2016 16:09, Martin Basti wrote: On 22.07.2016 00:14, Ariel Barria wrote: H

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

On 1.8.2016 18:31, Martin Basti wrote: > > > On 28.07.2016 18:29, Ariel Barria wrote: >> 2016-07-28 7:10 GMT-05:00 Petr Spacek : >>> On 27.7.2016 18:26, Ariel Barria wrote: 2016-07-26 9:39 GMT-05:00 Petr Spacek : > On 26.7.2016 16:28, Jan Cholasta wrote: >> Hi, >> >> On 26.7.

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https://paste.fedoraproject.org/399504/00843641/ On 06/28/2016 01:40 PM, Oleg Fayans wrote: Patch-0050 rebased against latest upstream branch On 06/28/2016 10:45 AM, Oleg Fayans wrot

Re: [Freeipa-devel] [PATCH 0004-0012] Automatic CSR generation

On Fri, Jul 29, 2016 at 11:13:16AM -0400, Ben Lipton wrote: > > On 07/29/2016 09:39 AM, Petr Spacek wrote: > > On 27.7.2016 19:06, Ben Lipton wrote: > > > Hi all, > > > > > > I think the automatic CSR generation feature > > > (https://fedorahosted.org/freeipa/ticket/4899, > > > http://www.freeipa