[Freeipa-devel] [PATCHES] All-around improvements to baseldap.py classes.

2009-07-31 Thread Pavel Zůna
0001: Enable attribute re-mapping and ordering when printing entries. Also print multiple values on one line separated by commas. --- 0002: Prevent double encoding/decoding when processing compound types.

[Freeipa-devel] [PATCH] Rewrite pwpolicy plugin based on baseldap.py.

2009-07-31 Thread Pavel Zůna
Fix bugs: 510740, 510739, 510735, 510733, 510532 Pavel 0005-Rewrite-pwpolicy-plugin-based-on-baseldap.py.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Replace TYPE_ERROR by ValidationError

2009-07-31 Thread Pavel Zůna
No more tracebacks when an INT parameter is beyond the type limit. Fix bug: 5107333 There will probably be more patches similar to this one in the future. TYPE_ERROR is used in a several places where a better suited exception is available. Pavel

[Freeipa-devel] [PATCH] Fix typo bug in aci.py

2009-07-31 Thread Pavel Zůna
Pavel 0007-Fix-typo-bug-in-aci.py.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Add wrapping when printing multi-value attributes that don't fit on one line.

2009-08-05 Thread Pavel Zůna
Nathan Kinder wrote: On 08/04/2009 09:32 AM, Pavel Zuna wrote: This is how it looks like in practice: ./ipa user-show pzuna --all --raw -- user-show: -- ... memberof: cn=ipausers,cn=groups,cn=accounts,dc=pzuna, cn=dráčci,cn=groups,cn=accounts,dc=pzuna For an

[Freeipa-devel] [PATCH] Fix bug in dns_find - execute() returned different value than expected.

2009-09-08 Thread Pavel Zůna
dns_find.execute() wasn't returning the truncated (truncated search results) flag. It threw an exception when invoked. Pavel 0002-Fix-bug-in-dns_find-execute-returned-different-v.patch Description: application/mbox ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] Improve attribute printing in the CLI.

2009-09-08 Thread Pavel Zůna
This patch makes printing of LDAP attributes more versatile. The caller can now choose if attributes with more than one value should be printed on one line (each value separated by ', ') or on several lines (each value on its own line). In the later case, the patch also introduces smart word

[Freeipa-devel] [PATCH] Remove obsolete CRUD base classes as they aren't used anymore.

2009-09-08 Thread Pavel Zůna
This removes legacy CRUD base classes (Add, Get, Del, Mod, Find) that aren't (and won't be) used anymore. They have been replaced by Create, Retrieve, Update, Delete and Search (and their LDAP oriented extensions). Note: This patch doesn't remove unit tests associated with these classes, but

[Freeipa-devel] [PATCHES] Improve ipalib.plugins.baseldap classes.

2009-09-08 Thread Pavel Zůna
- remove obsolete code related to PluginProxy - remove parent_key attribute, for the purpose of nested objects the parent's primary key is retrieved automatically - added support for auto-generating UUIDs - make use of the improved attribute printing in CLI !!! depends on previous patch !!! -

[Freeipa-devel] [PATCH] Fix: Object.params_minus_pk was invalid when there was no primary_key.

2009-09-08 Thread Pavel Zůna
params_minus_pk was set to None when there was no primary_key=True parameter. This patch changes this, so that params_minus_pk is set to a reference to params. It makes special cases easier to handle and I think it makes sense that: C - 0 = C Anyway I did it, because there were some blow

[Freeipa-devel] [PATCHES] Add support for different automount maps per location.

2009-09-08 Thread Pavel Zůna
0007: Add support for different automount maps per location. This patch enabled us to have a different set of automount maps per location and to manage those locations via command plugins. To add a new location: ipa automountlocation-add Brno To add a map to this location: ipa

[Freeipa-devel] [PATCH] Automatically generate an auto.master map for new automount location.

2009-09-08 Thread Pavel Zůna
I thought that it might be a good idea to automatically generate the auto.master map for new locations. It depends on my previous automount patch. Pavel 0010-Automatically-generate-an-auto.master-map-for-new-au.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] 266 remove deprecated comment

2009-09-14 Thread Pavel Zůna
Rob Crittenden wrote: Remove comment about plugin naming conventions. We've dumped this convention. rob ack Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 267 fix virtual plugin

2009-09-14 Thread Pavel Zůna
Rob Crittenden wrote: Fix the virtual access plugin to work with the new backend. Also do a more explicit objectviolation catch. We will switch this to use GER when that is completed. rob ack Pavel ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 268 explicitly set verbose to false in RPC client

2009-09-14 Thread Pavel Zůna
Rob Crittenden wrote: I've needed to set verbose to True in the rpc client and every time I have to do this I hunt around trying to figure out where to put it. This will make it easier to find next time :-) rob ack Pavel ___ Freeipa-devel mailing

Re: [Freeipa-devel] Re: [PATCHES] Make plugins use baseldap classes.

2009-09-18 Thread Pavel Zůna
Rob Crittenden wrote: Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zůna wrote: This is a series of patches that depends on patches: - Improve attribute printing in the CLI. - Improve ipalib.plugins.baseldap classes. All plugins are converted to extend baseldap classes

[Freeipa-devel] [PATCH] Display membership attributes (member, memberOf) by default in show/find.

2009-10-21 Thread Pavel Zůna
Rob Crittenden wrote: The 10% failure is really just 1 test failing: ++ '[' 0 '!=' 0 ']' ++ ssh r...@iparhel5-64vmb.dsdev.sjc.redhat.com 'ipa group-find testgroup1 | grep testusr1' ++ '[' 1 '!=' 0 ']' ++ echo 'ERROR - ipa testusr1 not found in testgroup1 failed on

[Freeipa-devel] [PATCH] Fix bug in print_attribute.

2009-10-22 Thread Pavel Zůna
When a multi-value attribute had no values, and exception was generated while trying to word-wrap it. Pavel 0001-Fix-bug-in-print_attribute.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] Remove ipalib/plugins/basegroup.py. It's become obsolete.

2009-10-22 Thread Pavel Zůna
It's not used anymore. Pavel 0002-Remove-ipalib-plugins-basegroup.py.-It-s-become-obso.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Filter all NULL values in ldap2.add_entry. python-ldap doesn't like'em.

2009-10-23 Thread Pavel Zůna
Previously we only filtered None values, but it turns out that's not enough. For example, empty lists/tuples generate ProtocolErrors. Pavel 0001-Filter-all-NULL-values-in-ldap2.add_entry.-python-ld.patch Description: application/mbox ___

Re: [Freeipa-devel] [PATCH] 302 clean up join plugin

2009-10-23 Thread Pavel Zůna
Rob Crittenden wrote: Remove a bunch of unused imports, add some docstrings, etc. rob ack. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Change checks in List.normalize to filter out illegal values.

2009-10-23 Thread Pavel Zůna
As we started converting NULL values to None a while back, List.normalize blows up if we set an empty tuple default value. Pavel 0001-Change-checks-in-List.normalize-to-filter-out-illega.patch Description: application/mbox ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] Change checks in List.normalize to filter out illegal values.

2009-10-24 Thread Pavel Zůna
Pavel Zůna wrote: As we started converting NULL values to None a while back, List.normalize blows up if we set an empty tuple default value. Pavel nack! This actually introduces a bigger problem than it solves, my mistake. Fixed version attached. To demonstrate the bug

Re: [Freeipa-devel] [PATCH] 285 CRL publishing

2009-11-25 Thread Pavel Zůna
Rob Crittenden wrote: This enables CRL publishing by dogtag to a place where Apache can get the files. I have to do a couple of tricks here because dogtag is an optional component. This is why in the installer I first see if the dogtag SELinux policy is installed and if not add it. Similarly

Re: [Freeipa-devel] [PATCH] Add {user, host, sourcehost}Category to HBAC and make accessTime multivalue.

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Due to the format of accessTime (it has commas and spaces in it), we can't use the List parameter type. I made it so that accessTime values have to be entered one by one using new commands. We also agreed, that

Re: [Freeipa-devel] [PATCH] Change object_class of group object.

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: Some groups created by default don't have ipaUserGroup and won't show up in searches. Pavel nack, isn't the better approach to fix up the groups that are created by default without the ipaUserGroup objectclass? It is. Fixed patch attached. rob

Re: [Freeipa-devel] [PATCH] jderose 027 Extensible return values

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Jason Gerard DeRose wrote: On Wed, 2009-11-25 at 12:05 -0500, Rob Crittenden wrote: This is purely from reading the patch, I haven't applied and tested it yet. ipalib/output.py: +primary_key = Output('primary_key', unicode, +'The primary key of the deleted entry' +)

Re: [Freeipa-devel] [PATCH] 354 removing bogus code

2010-01-26 Thread Pavel Zůna
Rob Crittenden wrote: Somehow the same block of code got added twice to ipa-rmkeytab causing, not surprisingly, a double-free. This resolves it. rob ack Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] jderose 034 Enable WebUI CRUDS using wehjit 0.2.0

2010-01-26 Thread Pavel Zůna
Jason Gerard DeRose wrote: This patch enables webUI Create-Retrieve-Updated-Delete-Search operations for all api.Object plugins that: 1. implement all the required CRUDS methods 2. have a primary_key Last night I realized that the upgrade to wehjit 0.2.0 broke the installer, so I hurried

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-11 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: I compiled 3 patches, that effectively bring back all the functionality we had before Jasons big patch (i.e. before introducing output validation and the common output interface). --all and --raw are back, but

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-11 Thread Pavel Zůna
Jason Gerard DeRose wrote: On Wed, 2010-02-10 at 10:30 -0500, Rob Crittenden wrote: Pavel Zuna wrote: What I'm saying is that the Env object stores all strings as str and the env command uses the same output_for_cli as LDAP commands, that only use str for binary. So, we either need to

Re: [Freeipa-devel] [PATCH] 387 fix test failures

2010-02-23 Thread Pavel Zůna
Rob Crittenden wrote: This fixes the failures in the Env due to switching to unicode internally. Now that --all works this also adds the dn to the output in the XML-RPC tests. rob ack. Pavel ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] Fix bug where parameter cloning didn't clone validating rules.

2010-02-23 Thread Pavel Zůna
I thought we had validation fixed, but this little bit was still missing. Pavel 0001-Fix-bug-where-parameter-cloning-didn-t-clone-validat.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] Complete netgroup attributes.

2010-02-23 Thread Pavel Zůna
Add missing attributes to the netgroup plugin. The plugin will now correctly display membership information and allow searching for netgroups by UUID. Pavel 0003-Complete-netgroup-attributes.patch Description: application/mbox ___ Freeipa-devel

[Freeipa-devel] [PATCH] Make the --all option work in Add/Remove Member commands.

2010-02-23 Thread Pavel Zůna
Add/Remove Member commands didn't work with the --all option. They do now. Pavel 0001-Make-the-all-option-work-in-Add-Remove-Member-comman.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [DOC] about netgroups

2010-02-23 Thread Pavel Zůna
I was asked to complete the documentation of IPA commands on the internal wiki. Unfortunatly, I currently don't have access to it and have decided to put some of the information I've been gathering here on freeipa-devel. It's not a secret after all and is easier to review by other team

[Freeipa-devel] [PATCH] Add plugin versioning and dependency checking

2010-03-02 Thread Pavel Zůna
Since there weren't any comments on my proposal about plugin versioning and dependencies, I decided to make a first implementation, that shows what I had in mind. This patch adds two class variables to plugable.Plugin: VERSION and DEPENDENCIES. VERSION is supposed to be a tuple with 2 ints

Re: [Freeipa-devel] [PATCH] Add plugin versioning and dependency checking

2010-03-02 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zůna wrote: Since there weren't any comments on my proposal about plugin versioning and dependencies, I decided to make a first implementation, that shows what I had in mind. Sorry, I had looked at it and never responded. Seeing an implementation does help though

[Freeipa-devel] [PATCH] Add interface for baseldap plugins to register additional callbacks.

2010-03-04 Thread Pavel Zůna
This is somewhat of a tech-preview patch. It works, but the whole concept might need some more work/thinking done. It adds another way to extend plugins without resorting to the versioning system. Until now, every baseldap command had two callbacks. The pre-callback called before data was

Re: [Freeipa-devel] [PATCH] Add interface for baseldap plugins to register additional callbacks.

2010-03-04 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zůna wrote: This is somewhat of a tech-preview patch. It works, but the whole concept might need some more work/thinking done. It adds another way to extend plugins without resorting to the versioning system. Until now, every baseldap command had two callbacks

Re: [Freeipa-devel] [PATCH] Enable LDAPObject subclasses to disable DN normalization in their methods.

2010-03-18 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: New attribute in LDAPObject: normalize_dn Defaults to True. If False, LDAP* methods won't normalize DNs before passing them to python-ldap. Pavel This also makes entries returned by LDAPSearch a list instead of a tuple. What is the purpose of

[Freeipa-devel] [PATCH] Fix output of commands, that do not return entries.

2010-03-24 Thread Pavel Zůna
This patch fixes Command.output_for_cli for the env plugin. Before we assumed, that a list/tuple is always a list of entries and a dict is always an entry. Still, this solution isn't perfect. I think, that in the future, we should allow Output subclasses to control the way we output values

[Freeipa-devel] [PATCH] Fix output of env plugin. It displayed more than it should.

2010-03-24 Thread Pavel Zůna
Some outputs were missing the 'no_display' flag. Pavel 0001-Fix-output-of-env-plugin.-It-displayed-more-than-it-.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Fix output of commands, that do not return entries.

2010-03-24 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zůna wrote: Pavel Zůna wrote: This patch fixes Command.output_for_cli for the env plugin. Before we assumed, that a list/tuple is always a list of entries and a dict is always an entry. Still, this solution isn't perfect. I think, that in the future, we should

Re: [Freeipa-devel] [PATCH] Fix DNS plugin: proper output definitions, --all, dns-add-rr overwritting

2010-04-14 Thread Pavel Zůna
On 4/13/2010 10:51 PM, Rob Crittenden wrote: Pavel Zuna wrote: The DNS plugin is getting old, tired and already looking forward to his pension in the Carribean. It will be replaced soon by a younger, faster, safer, shorter (in terms of code) and more maintainable version. Until that happens,

Re: [Freeipa-devel] [PATCH] Fix DNS plugin: proper output definitions, --all, dns-add-rr overwritting

2010-04-14 Thread Pavel Zůna
On 4/14/2010 5:36 PM, Rob Crittenden wrote: Pavel Zůna wrote: On 4/13/2010 10:51 PM, Rob Crittenden wrote: Pavel Zuna wrote: The DNS plugin is getting old, tired and already looking forward to his pension in the Carribean. It will be replaced soon by a younger, faster, safer, shorter

Re: [Freeipa-devel] Use ldap2 instead of legacy LDAP code from v1 in installer scripts.

2010-04-14 Thread Pavel Zůna
On 4/14/2010 4:35 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 03/30/2010 10:27 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 03/23/2010 09:40 PM, Rob Crittenden wrote: Pavel Zuna wrote: This is the first in a series of patches, that replace all the legacy code from v1 related to LDAP. I

[Freeipa-devel] [PATCH] Fix ipa-dns-install. It was failing when DNS was reinstalling.

2010-04-14 Thread Pavel Zůna
I noticed a few bugs when DNS was reinstalling: - Service.move_service returned None, because the service entry was already in the right place - BindInstance didn't expect that. - We were passing a unicode string to python-ldap although we know it hates that. - We were catching all

Re: [Freeipa-devel] Use ldap2 instead of legacy LDAP code from v1 in installer scripts.

2010-04-16 Thread Pavel Zůna
On 4/15/2010 8:18 PM, Rob Crittenden wrote: Pavel Zůna wrote: On 4/14/2010 4:35 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 03/30/2010 10:27 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 03/23/2010 09:40 PM, Rob Crittenden wrote: Pavel Zuna wrote: This is the first in a series

Re: [Freeipa-devel] [PATCH] Use escapes in DNs instead of quoting.

2010-04-16 Thread Pavel Zůna
On 4/16/2010 5:09 PM, Rob Crittenden wrote: Pavel Zuna wrote: This patch effectively removes all LDAPv2 style quoted DNs and makes sure we don't use them anymore. KDC doesn't seem to have any problems with LDAPv3 style DNs, but I kept the option to disable DN normalization for now. I also had

[Freeipa-devel] [PATCH] Add new pwpolicy plugin based on baseldap classes

2010-04-16 Thread Pavel Zůna
Don't mind the numbering. This is a completely independent patch. It adds a new pwpolicy plugin based on baseldap.py classes. It has the same functionality as the current pwpolicy plugin, but a more clean and consistent interface, fine grained search capabilities, etc. This is actually an

Re: [Freeipa-devel] [PATCH] 432 add default open HBAC on install

2010-05-05 Thread Pavel Zůna
On 2010-05-04 21:30, Rob Crittenden wrote: Create an HBAC that allows all users to access all hosts from any host. This should make initial installation and testing easier. It is expected that this rule (allow_all) will be removed before deployment. In case you know you don't want this you can

Re: [Freeipa-devel] [PATCH] 433 improve hbac output

2010-05-05 Thread Pavel Zůna
On 2010-05-04 21:31, Rob Crittenden wrote: This patch adds more attributes to the default output and fixes up some labels. rob ack. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Correctly handle EmptyModlist exception in pwpolicy2-mod.

2010-05-12 Thread Pavel Zůna
On 2010-05-10 15:44, Pavel Zuna wrote: EmptyModlist exception was generated by pwpolicy2-mod when modifying policy priority only. It was because the priority attribute is stored outside of the policy entry (in a CoS entry) and there was nothing left to be changed in the policy entry. This patch

Re: [Freeipa-devel] [PATCH] 439 spec file cleanups

2010-06-03 Thread Pavel Zůna
On 2010-05-10 20:11, Rob Crittenden wrote: Remove references to Fedora 10 and add some tests for RHEL 6. rob ack. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 451 fix i18n test

2010-06-03 Thread Pavel Zůna
On 2010-06-02 21:01, Rob Crittenden wrote: Pavel Zuna wrote: On 05/21/2010 11:35 PM, Rob Crittenden wrote: Fix this test to work from source tree root It would work if you ran the test from its location in tests/test_ipalib but this isn't the most common method. If you want to run it

Re: [Freeipa-devel] [Patch] Simple-plugin-for-reflecting-user-principal

2010-08-05 Thread Pavel Zůna
On 2010-08-04 01:49, Adam Young wrote: This is a required patch for the UI code. Basically, the Kerberos authentication method does not provide any way for the web ui to know who logged in. With this patch, we can do the equivalent of 'ipa whoami' that returns the user principal in the summary

Re: [Freeipa-devel] [PATCH] 502 hosts can fetch keytabs

2010-08-09 Thread Pavel Zůna
On 2010-08-06 04:50, Rob Crittenden wrote: Enable a host to retrieve a keytab for all its services. Using the host service principal one should be able to retrieve a keytab for other services for the host using ipa-getkeytab. This required a number of changes: - allow hosts in the service's

[Freeipa-devel] [PATCH] Make LDAPObject classes JSON serializable

2010-08-09 Thread Pavel Zůna
Allow LDAPObject classes (and sub-classes) to be serialized into a JSON string using: json.dumps(obj, default=ipalib.util.json_serialize) Pavel From 209162028b58ba8cc59e8c90409082eb8478a0dd Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Mon, 9 Aug 2010 16:45:26 -0400

[Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters

2010-08-09 Thread Pavel Zůna
setattr and addattr can now be used both to set all values of ANY attribute. the last setattr always resets the attribute to the specified value and all addattr append to it. Examples: user-mod testuser --setattr=title=msc title: msc user-mod testuser --setattr=title=msb title: msb user-mod

[Freeipa-devel] [PATCH] Fix bug: not found exc. handler was failing for singleton objects

2010-08-09 Thread Pavel Zůna
Very minor bug, that would probably never happen in production anyway, but why not fix it. Pavel From 1492f14a59f0e0a1a818b6b920c77ede3f5e2a36 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Mon, 9 Aug 2010 19:50:15 -0400 Subject: [PATCH 3/4] Fix bug: not found exc. handler was

[Freeipa-devel] [PATCH] Add new parameters to LDAPSearch: timelimit and sizelimit.

2010-08-09 Thread Pavel Zůna
Doesn't include Robs loading of default values from cn=ipaConfig. Pavel From a81e2b42d16473b0102969246dcf81820b1930f0 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Mon, 9 Aug 2010 19:56:14 -0400 Subject: [PATCH 4/4] Add new parameters to LDAPSearch: timelimit and sizelimit.

Re: [Freeipa-devel] [Patch] Changes to the python infrastructure-supporting-the-web ui

2010-08-09 Thread Pavel Zůna
On 2010-08-06 17:57, Adam Young wrote: On 08/06/2010 11:51 AM, Rob Crittenden wrote: Adam Young wrote: This code contains the changes to the python code necessary to support the new web ui. It handles the changes to the baseldap code necessary to expose the meta data to the front end, as well

Re: [Freeipa-devel] [PATCH] Fix bug: not found exc. handler was failing for singleton objects

2010-08-09 Thread Pavel Zůna
On 2010-08-09 23:00, Rob Crittenden wrote: Pavel Zůna wrote: Very minor bug, that would probably never happen in production anyway, but why not fix it. Can you describe the situation this could occur in? How useful would the error be if the key isn't available? rob Well, I caught the bug

Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-11 Thread Pavel Zůna
On 2010-08-10 21:45, Rob Crittenden wrote: Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel Oops, sorry, commented on wrong patch. This looks ok but you have a serious whitespace issue in the def __json__ method.

Re: [Freeipa-devel] [PATCH] 509 add BuildRequries for authconfig

2010-08-11 Thread Pavel Zůna
On 2010-08-10 22:41, Rob Crittenden wrote: In ipapython/dnsclient.py we import acutil which is provided by authconfig. This can get invoked by setup.py so we need to have it at build time. rob ack. Pavel ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-12 Thread Pavel Zůna
On 2010-08-11 22:55, Rob Crittenden wrote: Pavel Zůna wrote: On 2010-08-10 21:45, Rob Crittenden wrote: Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel Oops, sorry, commented on wrong patch. This looks ok

Re: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters

2010-08-12 Thread Pavel Zůna
On 2010-08-12 04:46, Rob Crittenden wrote: Pavel Zůna wrote: setattr and addattr can now be used both to set all values of ANY attribute. the last setattr always resets the attribute to the specified value and all addattr append to it. Examples: user-mod testuser --setattr=title=msc title: msc

Re: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters

2010-08-12 Thread Pavel Zůna
On 2010-08-12 14:38, Rob Crittenden wrote: Pavel Zůna wrote: On 2010-08-12 04:46, Rob Crittenden wrote: Pavel Zůna wrote: setattr and addattr can now be used both to set all values of ANY attribute. the last setattr always resets the attribute to the specified value and all addattr append

Re: [Freeipa-devel] [PATCH] Hash Params Redux

2010-08-19 Thread Pavel Zůna
On 2010-08-18 22:59, Adam Young wrote: The patch replaces the earlier Hash Params patch. It fixs the build issues, and fixes the group details page as well. Git still reports white space errors, but that's hardly a show stopper. ACK. Pavel ___

Re: [Freeipa-devel] [PATCH] Fix script tags in index.xhtml. End tag is required.

2010-08-19 Thread Pavel Zůna
On 2010-08-20 00:48, Pavel Zůna wrote: The paste server had some issues with it and end tags are required by the standard anyway. Pavel I forgot to mention that this applies after Adam's 0009 patch (updated Hash Params). Pavel ___ Freeipa-devel

Re: [Freeipa-devel] BA-BBQ

2010-08-23 Thread Pavel Zůna
On 2010-08-23 16:41, Adam Young wrote: On 08/23/2010 07:51 AM, Pavel Zuna wrote: On 08/23/2010 04:12 AM, Adam Young wrote: Pavel, Thoughts of jquery.ba-bbq have been marinating in the back of my brain. I know that the Back button doesn't work so well with hjashparams, and that BBQ purports

Re: [Freeipa-devel] [PATCH] Fix script tags in index.xhtml. End tag is required.

2010-08-23 Thread Pavel Zůna
On 2010-08-20 02:26, Adam Young wrote: On 08/19/2010 06:51 PM, Pavel Zůna wrote: On 2010-08-20 00:48, Pavel Zůna wrote: The paste server had some issues with it and end tags are required by the standard anyway. Pavel I forgot to mention that this applies after Adam's 0009 patch (updated

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-25 Thread Pavel Zůna
On 2010-08-24 23:57, Adam Young wrote: This is a fairly substantial patch that makes use of the hashchange event to drive the site. It affcets just about all places where click events are triggered. Just started reviewing the patch a few moments ago. Just 2 notes in advance: 1) It doesn't

[Freeipa-devel] [PATCH] Make changes to details.js. See commit message.

2010-08-25 Thread Pavel Zůna
First off: I know I promised this patch yesterday, but I just didn't make it - I felt asleep on the keyboard and there were still some things to fix. :) This patch has some of the most important things, that we discussed on Tuesday last week, namely: - Add/Remove links are now only

[Freeipa-devel] [PATCH] Add 'hint' kwarg to Param. Used for context help in webUI.

2010-08-25 Thread Pavel Zůna
Used like this: Str('someparam', cli_name='sp', label='Some Param', hint='Use at own risk!', ), After the following patch (pzuna-freeipa-0021-details), it will show up in the webUI as (details page): Some Param: [ ] Hint: Use at own risk! Pavel

Re: [Freeipa-devel] [PATCH] Make changes to details.js. See commit message.

2010-08-25 Thread Pavel Zůna
On 2010-08-25 13:54, Pavel Zůna wrote: First off: I know I promised this patch yesterday, but I just didn't make it - I felt asleep on the keyboard and there were still some things to fix. :) This patch has some of the most important things, that we discussed on Tuesday last week, namely

Re: [Freeipa-devel] [PATCH] Add 'hint' kwarg to Param. Used for context help in webUI.

2010-08-25 Thread Pavel Zůna
On 2010-08-25 15:52, Rob Crittenden wrote: Pavel Zůna wrote: Used like this: Str('someparam', cli_name='sp', label='Some Param', hint='Use at own risk!', ), After the following patch (pzuna-freeipa-0021-details), it will show up in the webUI as (details page): Some Param: [ ] Hint: Use

Re: [Freeipa-devel] [PATCH] 517 updated command documentation

2010-08-26 Thread Pavel Zůna
On 2010-08-25 05:52, Rob Crittenden wrote: David O'Brien reviewed all the per-command documentation last month and provided a ton of great feedback. I've applied all his changes. rob ACK. Pavel ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0016-sampledata.patch

2010-08-30 Thread Pavel Zůna
On 2010-08-30 16:01, Adam Young wrote: THis patch usese the protocol part of the URL to decide whether or not to use sample data. Thus, file: - use sample data http:, https: - Don't. This will prevent the use of sample data in the lite-server. It also reduces by one the number of page

Re: [Freeipa-devel] Proposed Javascript coding standards

2010-09-14 Thread Pavel Zůna
On 2010-09-13 23:46, Simo Sorce wrote: On Mon, 13 Sep 2010 17:02:19 -0400 Adam Youngayo...@redhat.com wrote: The is a really nasty bug that the same line policy avoids. Javascript often attempts to guess where you meant to put semicolons, and puts the in for you, without telling you. return

[Freeipa-devel] [PATCH] Rename parent LDAPObject pkeys in child LDAPObject methods.

2010-11-08 Thread Pavel Zůna
If the parent and child entries have the same attribute as primary key (such as in the DNS schema), we need to rename the parent key to prevent a param name conflict. It has no side effects, because the primary key name is always taken from the LDAPObject params, never from the method params.

[Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-08 Thread Pavel Zůna
Finally, there it is. :) I redesigned the whole thing to fit the baseldap model. Here's some example on how it's used: # create zone 'example.com' # ipa dnszone-add example.com --name=ns.example.com --admin=ad...@example.com # create a resource in zone 'example.com' named 'machine1' #

[Freeipa-devel] [PATCH] Replace 'Locking' in `ipa help user` with 'Disabling'.

2010-11-08 Thread Pavel Zůna
Ticket #452 Pavel From e03d082523a677b1d57e829ba10c31fd7f8d87b5 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Mon, 8 Nov 2010 22:45:27 -0500 Subject: [PATCH] Replace 'Locking' in `ipa help user` with 'Disabling'. Ticket #452 --- ipalib/plugins/user.py |2 +- 1 files

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-08 Thread Pavel Zůna
On 2010-11-09 05:07, Pavel Zůna wrote: Finally, there it is. :) I redesigned the whole thing to fit the baseldap model. Here's some example on how it's used: # create zone 'example.com' # ipa dnszone-add example.com --name=ns.example.com --admin=ad...@example.com # create a resource in zone

[Freeipa-devel] [PATCH] Enable filtering search results by member attributes.

2010-11-28 Thread Pavel Zůna
LDAPSearch base class has now the ability to generate additional options for objects with member attributes. These options are used to filter search results - search only for objects without the specified members. Any class that extends LDAPSearch can benefit from this functionality. This patch

Re: [Freeipa-devel] [PATCH] Enable filtering search results by member attributes.

2010-11-30 Thread Pavel Zůna
On 2010-11-30 04:06, Rob Crittenden wrote: Pavel Zůna wrote: LDAPSearch base class has now the ability to generate additional options for objects with member attributes. These options are used to filter search results - search only for objects without the specified members. Any class

[Freeipa-devel] [PATCH] Enable custom list of attributes to retrieve effective rights.

2010-12-30 Thread Pavel Zůna
LDAPObject sub-classes can define a custom list of attributes for effective rights retrieval. Fix #677 Pavel From 98b7456f1c4d872e265ea4e8c26ab42e206375e8 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Thu, 30 Dec 2010 08:48:12 -0500 Subject: [PATCH 2/4] Enable custom list of

[Freeipa-devel] [PATCH] Translate IA5Str paramaters the editable text fields in the webUI.

2010-12-30 Thread Pavel Zůna
Fix #684 Pavel From ea2cd3c1c97c11c216c0c2baff07615d2f14298e Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Thu, 30 Dec 2010 09:11:58 -0500 Subject: [PATCH 3/4] Translate IA5Str paramaters the editable text fields in the webUI. Fix #684 --- install/static/details.js |3

[Freeipa-devel] [PATCH] Fix 'ipa help permissions'; add 'dns' in allowed types.

2010-12-30 Thread Pavel Zůna
Pavel From 08534b8e0fe9ab9713599de166a5bfb4232c1776 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Thu, 30 Dec 2010 09:12:35 -0500 Subject: [PATCH 4/4] Fix 'ipa help permissions'; add 'dns' in allowed types. --- ipalib/plugins/permission.py |2 +- 1 files changed, 1

Re: [Freeipa-devel] [PATCH] Translate IA5Str paramaters the editable text fields in the webUI.

2010-12-30 Thread Pavel Zůna
On 2010-12-30 10:29, Pavel Zůna wrote: Fix #684 Pavel Left some debugging output in the original patch. Fixed version attached. Pavel From 508a68cc41f812683cbf62640c3dc2de02dd2981 Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Thu, 30 Dec 2010 09:11:58 -0500 Subject

[Freeipa-devel] [PATCH] Disable action panel links when the selected entry is deleted.

2010-12-30 Thread Pavel Zůna
Fix #685 Pavel From 2dd2304d8f10272d3e376090cbe2565e21ff627d Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Thu, 30 Dec 2010 16:41:50 -0500 Subject: [PATCH] Disable action panel links when the selected entry is deleted. Fix #685 --- install/static/search.js |6 +- 1

Re: [Freeipa-devel] [PATCH] admiyo-0127-add-missing-files-in-rpm

2011-01-06 Thread Pavel Zůna
On 2011-01-05 20:57, Adam Young wrote: Had to move some files around, and added to both Makefile.am and ipa.spec ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Fix crash when displaying values composed of white chars only in CLI.

2011-01-21 Thread Pavel Zůna
Fix #825 Pavel From 8a7e6119399aa974457eda41b998cb765186d4eb Mon Sep 17 00:00:00 2001 From: Pavel Zuna pz...@redhat.com Date: Fri, 21 Jan 2011 09:30:23 -0500 Subject: [PATCH] Fix crash when displaying values composed of white-space chars only in CLI. Ticket #825 --- ipalib/cli.py |2 ++ 1

Re: [Freeipa-devel] [PATCH] Remove deprecated i18n code from ipalib.request and all references to it.

2011-02-04 Thread Pavel Zůna
On 2011-02-04 16:24, Rob Crittenden wrote: Pavel Zuna wrote: On 02/04/2011 04:03 PM, Rob Crittenden wrote: Pavel Zuna wrote: On 02/02/2011 09:36 PM, Rob Crittenden wrote: Pavel Zuna wrote: This ticket effectively fixes the translation of exception messages. Ticket #903 Pavel On hold

Re: [Freeipa-devel] [PATCH] Send Accept-Language header over XML-RPC and translate on server.

2011-02-16 Thread Pavel Zůna
On 2011-02-04 18:35, Pavel Zůna wrote: On 2011-02-04 16:23, Rob Crittenden wrote: Pavel Zuna wrote: This patch makes the ipa client send the Accept-Language header, so that the server can translate things like exceptions, that cannot be translated on the client. It also fixes the language

[Freeipa-devel] [PATCH] Translate docstrings.

2011-02-16 Thread Pavel Zůna
This patch prepares the built-in help system for localized docstrings. Pavel freeipa-pzuna-80-docstringloc.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] Fix translatable strings in ipalib plugins.

2011-02-16 Thread Pavel Zůna
Some translatable strings were in a wrong format a there were some more related issues. This patch tries to fix all of them. Needed for xgettext/pygettext processing. Pavel freeipa-pzuna-81-fixlocstrings.patch Description: application/mbox ___

[Freeipa-devel] [PATCH] Fix i18n related failures in unit tests.

2011-02-16 Thread Pavel Zůna
Fixes unit test failures cause by the changes introduced in my other localization related patches. Pavel freeipa-pzuna-82-fixlocutests.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Fix translatable strings in ipalib plugins.

2011-02-17 Thread Pavel Zůna
On 2011-02-16 16:25, Pavel Zůna wrote: Some translatable strings were in a wrong format a there were some more related issues. This patch tries to fix all of them. Needed for xgettext/pygettext processing. Pavel Rebased version attached. Pavel freeipa-pzuna-81-2-fixlocstrings.patch

  1   2   >