jcholast's pull request #20: "cert: include CA name in cert command output" was
opened
PR body:
"""
Include name of the CA that issued a certificate in cert-request, cert-show
and cert-find.
This allows the caller to call further commands on the cert without having
to call ca-find to find the
jcholast's pull request #21: "custodia: include known CA certs in the PKCS#12
file for Dogtag" was opened
PR body:
"""
This fixes CA replica install in a topology upgraded from CA-less to
CA-full.
https://fedorahosted.org/freeipa/ticket/6207
"""
See the full pull-request at
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/34
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/34/head:pr34
jcholast commented on a pull request
"""
NACK on the while loop which could loop infinitely.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/47#issuecomment-244690568
--
Manage your subscription for the Freeipa-devel mailing list:
https://w
dkupka's pull request #47: "schema cache: Store and check info for pre-schema
servers" label *ack* has been removed
See the full pull-request at https://github.com/freeipa/freeipa/pull/47
--
Manage your subscription for the Freeipa-devel mailing list:
jcholast's pull request #54: "cli: use full name when executing a command" was
opened
PR body:
"""
Fixes the CLI not to always call the default version of a command even when
the version was explicitly specified.
https://fedorahosted.org/freeipa/ticket/6279
"""
See the full pull-request at
jcholast commented on a pull request
"""
NACK, see my inline comments above.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-244858726
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/
jcholast commented on a pull request
"""
More comments inline.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-244967015
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/lis
dkupka's pull request #47: "schema cache: Store and check info for pre-schema
servers" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/47
--
Manage your subscription for the Freeipa-devel mailing list:
dkupka's pull request #47: "schema cache: Store and check info for pre-schema
servers" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/47
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
jcholast commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/ec2401917456d6f643532c0d0218c9e75172c2d8
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/2be232f67074ef052debb91962dbc8acd09d45bd
"""
See the full comment
jcholast's pull request #45: "custodia: force reconnect before retrieving CA
certs from LDAP" was opened
PR body:
"""
Force reconnect to LDAP as DS might have been restarted after the
connection was opened, rendering the connection invalid.
This fixes a crash in ipa-replica-install with
jcholast's pull request #44: "rpcserver: fix crash in XML-RPC system commands"
was opened
PR body:
"""
Fix an AttributeError in XML-RPC methodSignature and methodHelp commands
caused by incorrect mangled name usage.
https://fedorahosted.org/freeipa/ticket/6217
"""
See the full pull-request at
jcholast commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/89de60c5d8ba64d619101a7498b8c4469b6e50ae
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/29#issuecomment-243343065
--
Manage your subs
mbasti-rh's pull request #3: "User add fix #6199" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/3
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3/head:pr3
git checkout pr3
--
Manage your
mbasti-rh's pull request #3: "User add fix #6199" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/3
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
jcholast commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/5c50b265e6b5a0d06f213b5eb581c96e3392aeea
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/3#issuecomment-243344321
--
Manage your subs
tomaskrizek's pull request #29: "Enable LDAPS in replica promotion" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/29
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
tomaskrizek's pull request #29: "Enable LDAPS in replica promotion" label *ack*
has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/29
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute
jcholast's pull request #37: "cert: add missing param values to cert-find
output" was opened
PR body:
"""
Add back `serial_number_hex` and `revoked` param values to cert-find output
accidentally removed in commit c718ef058847bb39e78236e8af0ad69ac961bbcf.
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/34
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/34/head:pr34
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/34
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/34/head:pr34
jcholast commented on a pull request
"""
I have decided to instead copy & paste the code, as it exists solely for the
purpose of supporting old servers, so it should not get any additional
improvements in the future.
"""
See the full comment at
https://
jcholast commented on a pull request
"""
@tomaskrizek: none of them except `ipa trust-find` fail with "cannot connect to
'http://localhost:/ipa/json'", so I would say only `ipa trust-find` needs
to be fixed.
"""
See the full comment at
ht
jcholast's pull request #20: "cert: include CA name in cert command output" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/20
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/20/head:pr20
jcholast commented on a pull request
"""
`ipa-replica-install` fails with:
```
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ipaserver/install/service.py", line
448, in start_creation
run_step(full_msg, method)
File "/usr/lib/pyt
jcholast commented on a pull request
"""
However, I don't think this should block the release of 4.4.1, so I would just
revert 89de60c5d8ba64d619101a7498b8c4469b6e50ae and keep the ticket open.
"""
See the full comment at
https://github.com/freeipa/freeipa/
jcholast's pull request #88: "test_plugable: update the rest of test_init" was
opened
PR body:
"""
In commit ed4c2d9252a995d01dc098e5b761ded8cd9373d8, changes to the Plugin
class were made, but the test was updated only partially.
Update the rest to fix the failing test.
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was
opened
PR body:
"""
If ipa-client-install is executed with --no-sssd, check if pam_krb5 is
available before proceeding with the install.
https://fedorahosted.org/freeipa/ticket/5557
"""
See the full pull-request at
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/89
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/89/head:pr89
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Fix update_from_dict function testing
jcholast commented:
"""
@abbra:
> Update plugins are higher level of abstraction. They use
> ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and
jcholast commented on a pull request
"""
Functional ACK, but please don't use newlines in exception messages. If you
want the original error on a separate line, you can use the logger to log it,
but I think it would be preferable to use this format:
```
Peer's certificate issuer
jcholast's pull request #87: "dns: re-introduce --raw in dnsrecord-del" was
opened
PR body:
"""
The flag was removed in commit ff52c25ae299abba8bed653fe324951979a41293
because it is unused. Add it back for compatibility with old clients.
https://fedorahosted.org/freeipa/ticket/5644
"""
See the
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/50
Author: flo-renaud
Title: #50: Add cert checks in ipa-server-certinstall
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/50/head:pr50
git checkout pr50
--
Manage
URL: https://github.com/freeipa/freeipa/pull/89
Author: jcholast
Title: #89: client: remove hard dependency on pam_krb5
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/89/head:pr89
git checkout pr89
--
Manage
URL: https://github.com/freeipa/freeipa/pull/89
Title: #89: client: remove hard dependency on pam_krb5
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/984ae3858d8fb25d30b886bb953df1b06ab34ec7
ipa-4-4:
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/50
Title: #50: Add cert checks in ipa-server-certinstall
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/50
Title: #50: Add cert checks in ipa-server-certinstall
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0c4a91348a57ee941db94b31f59952eb1fcd4565
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/50
Title: #50: Add cert checks in ipa-server-certinstall
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/88
Author: jcholast
Title: #88: test_plugable: update the rest of test_init
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/88/head:pr88
git checkout pr88
From
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
jcholast commented:
"""
1. I'm afraid `certrequest` (actually `certreq`) is already taken. What about
`csrgen`?
2. I would be perfectly happy with `ipaclient.`.
3. OK.
Logistical stu
jcholast's pull request #64: "cert: fix cert-find --certificate when the cert
is not in LDAP" was opened
PR body:
"""
Always return the cert specified in --certificate in cert-find result, even
when the cert is not found in LDAP.
https://fedorahosted.org/freeipa/ticket/6304
"""
See the full
jcholast's pull request #20: "cert: include CA name in cert command output" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/20
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/20/head:pr20
jcholast's pull request #20: "cert: include CA name in cert command output" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/20
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/20/head:pr20
dkupka's pull request #22: "otptoken: Convert ipatokenotpkey on server" was
closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/22
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/22/head:pr22
git
dkupka's pull request #22: "otptoken: Convert ipatokenotpkey on server" label
*ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/22
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
jcholast commented on a pull request
"""
LDAPS is not enabled during replica promotion because of this condition in DS
setup:
https://github.com/freeipa/freeipa/blob/master/ipaserver/install/dsinstance.py#L391
Maybe we can remove the condition rather than add `ds.enable_s
jcholast's pull request #20: "cert: include CA name in cert command output" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/20
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/20/head:pr20
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was
opened
PR body:
"""
Fix the code which determines if a record part is required and thus should
be prompted not to wrongfully consider all record parts to be optional.
Add a client-side fallback of the
jcholast's pull request #35: "rpcserver: assume version 1 for unversioned
command calls" was opened
PR body:
"""
When a command is called on the server over RPC without its version
specified, assume version 1 instead of the highest known version.
This ensures backward compatibility with old
jcholast commented on a pull request
"""
I'm afraid this can't be easily fixed due to the manner in which the dns plugin
is implemented.
I'm open to suggestions if you have any.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/34#issuecom
URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode
jcholast commented:
"""
NACK, see inline comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/117#issuecomment-25104403
URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/187
Title: #187: Register entry points of Custodia plugins
jcholast commented:
"""
Just curious, why is the store class called `iSecStore` and not `IPASecStore`
or something similar to make it apparent that it comes from IPA?
&q
URL: https://github.com/freeipa/freeipa/pull/173
Author: frasertweedale
Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/173/head:pr173
git
URL: https://github.com/freeipa/freeipa/pull/173
Title: #173: Ensure correct IPA CA nickname in DS and HTTP NSSDBs
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/214
Title: #214: ipaldap: remove do_bind from LDAPClient
jcholast commented:
"""
DM password may be `None` in `dns_container_exists()` and
`dnssec_container_exists()` (for example in `BindInstance.setup()`), so you
can't simple bind
URL: https://github.com/freeipa/freeipa/pull/214
Author: tomaskrizek
Title: #214: ipaldap: remove do_bind from LDAPClient
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/214/head:pr214
git checkout pr214
--
URL: https://github.com/freeipa/freeipa/pull/232
Title: #232: Installer refactoring
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/232
Title: #232: Installer refactoring
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/232
Title: #232: Installer refactoring
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/eac6f52957c361c219ad6048b515ddb62da31154
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/232
Author: jcholast
Title: #232: Installer refactoring
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/232/head:pr232
git checkout pr232
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
Sorry, but I just don't see an explanation in the comment you linked, just that
you think it's easier to set an environment varia
URL: https://github.com/freeipa/freeipa/pull/229
Title: #229: Remove the renewal lock file upon uninstall
jcholast commented:
"""
The file is owned by the server, not the client, so it should be deleted in
`ipa-server-install --uninstall`, not in `ipa-client-install --unins
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
For example, if your `IPA_CONFDIR` PR was merged, setting the variable could
break `ipa-client-install`, because the hard coded half of it assumes that the
configuration dire
URL: https://github.com/freeipa/freeipa/pull/219
Title: #219: Refactor installer code requesting certificates
jcholast commented:
"""
Turns out the request does not time out in certmonger, but the 60 seconds wait
in `request_and_wait_for_cert()` it too short.
"&quo
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
"Everyone else does it" is not really a good argument to anything. Just saying.
Also you still haven't provided a single ex
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
Sure, just please keep this in mind for your other changes.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/143#issuecomment-25967029
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
OK, but you should at least make sure that where the code depends on hard-coded
paths, the API is bootstrapped with a hard coded `confdir` as well, otherwise
things might
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
Care to point me to some actual standard which recommends this? Using explicit
configuration via library initialization arguments is n
URL: https://github.com/freeipa/freeipa/pull/180
Title: #180: Make api.env.nss_dir relative to api.env.confdir
jcholast commented:
"""
See my comment on #143.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/180#issuecomment-25966379
URL: https://github.com/freeipa/freeipa/pull/219
Title: #219: Refactor installer code requesting certificates
jcholast commented:
"""
Can we fix this in a separate PR to unblock the merge of this one?
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
@tiran, setting `confdir` explicitly is not a hack, but the proper way to set
the config directory path and there is nothing that makes
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
Care to point me to some actual standard which recommends this? Using explicit
configuration via library initialization arguments is n
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
@tiran, setting `confdir` explicitly is not a hack, but the proper way to set
the config directory path and there is nothing that makes
URL: https://github.com/freeipa/freeipa/pull/163
Title: #163: Do not create Object Signing certificate
jcholast commented:
"""
LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/163#issuecomment-254430550
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/157
Title: #157: git: Add commit template
jcholast commented:
"""
Not everyone uses vim. I'd like the comments visually close to the relevant
commit message part, otherwise the visual guides in them do not seem very
useful to
URL: https://github.com/freeipa/freeipa/pull/132
Title: #132: Port all setup.py files to setuptools
jcholast commented:
"""
LGTM, but shouldn't we also move `/setup.py` to `/ipaserver/setup.py`?
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/159
Author: jcholast
Title: #159: spec file: clean up BuildRequires
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/159/head:pr159
git checkout pr159
From
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
The original review thread is available at:
https://www.redhat.com/archives/freeipa-devel/2016-October/msg00578.html
"&quo
URL: https://github.com/freeipa/freeipa/pull/159
Author: jcholast
Title: #159: spec file: clean up BuildRequires
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/159/head:pr159
git checkout pr159
From
URL: https://github.com/freeipa/freeipa/pull/182
Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context
jcholast commented:
"""
This seems rather unnecessary to me, as you can do:
```
$ ipa -e confdir=/path/to/confdir command
```
In case there is some shortcoming
URL: https://github.com/freeipa/freeipa/pull/266
Author: jcholast
Title: #266: ipapython: simplify Env object initialization
Action: edited
Changed field: body
Original value:
"""
Fully initialize Env objects in Env() instead of having to call their
private meth
URL: https://github.com/freeipa/freeipa/pull/266
Author: jcholast
Title: #266: ipapython: simplify Env object initialization
Action: opened
PR body:
"""
Fully initialize Env objects in Env() instead of having to call their
private methods to complete the initialization lat
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization
jcholast commented:
"""
Only now I have noticed that this won't actually help fixing [ticket
6482](https://fedorahosted.org/freeipa/ticket/6482).
Nevermind this PR
URL: https://github.com/freeipa/freeipa/pull/235
Title: #235: Remove unused Knob function
jcholast commented:
"""
There was no reason, I just forgot, so go ahead.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/235#issuecomment-26229003
URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
jcholast commented:
"""
@stlaz, [this thread at
freeipa-devel](https://www.redhat.com/archives/freeipa-devel/2016-November/msg00776.html)
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization
jcholast commented:
"""
Yes, my above comment is wrong (sorry).
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/266#issuecom
URL: https://github.com/freeipa/freeipa/pull/258
Title: #258: Break ipaplatform / ipalib import cycle of hell
jcholast commented:
"""
I'm OK with it.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/258#issuecomment-262797665
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and
ipaclient
jcholast commented:
"""
@tiran, how much granular PRs would you prefer? As @stlaz pointed out, there
isn't actually much going on in this PR
URL: https://github.com/freeipa/freeipa/pull/258
Title: #258: Break ipaplatform / ipalib import cycle of hell
jcholast commented:
"""
The original code is broken by design IMO. The API object is used only to get
the configured service startup timeout and to guess our DS inst
URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]
jcholast commented:
"""
Also LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/244#issuecomment-262162424
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@mbasti-rh: `knob()` already handles choices, it's the built-in `optparse`
module which does not display them. Once the installer code is migrate
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
jcholast commented:
"""
Actually it should be created from domain name, which is the primary identifier
of an IPA domain, not from realm
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
jcholast commented:
"""
Sorry, but this is wrong. `ipa env` is supposed to return local settings unless
run with `--server`. Why was it not fixed instead of adding a new redundant
co
URL: https://github.com/freeipa/freeipa/pull/247
Title: #247: Add 'ipa local-env' subcommand
jcholast commented:
"""
Reopened 6490.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/247#issuecomment-261881844
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/198
Title: #198: Fix missing file that fails DL1 replica installation
jcholast commented:
"""
Please rebase to ipa-4-4.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/198#issuecomment-25750071
URL: https://github.com/freeipa/freeipa/pull/198
Title: #198: Fix missing file that fails DL1 replica installation
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/842bf3d09f4b2de7d4b52005ac970594345455e0
"""
See the full
1 - 100 of 185 matches
Mail list logo
