Re: [PATCH] Improve pow (C, x) -> exp (log (C) * x) optimization (PR middle-end/84309)

2018-02-09 Thread Richard Biener
On February 10, 2018 12:37:38 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >Apparently the new pow(C,x) -> exp(log(C)*x) if C > 0 optimization >breaks some package (Marek should know which), as it has 7ulp error. >Generally one should be prepared for some errors with -ffast-math.

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Jeff Law
On 02/09/2018 09:39 PM, Alexandre Oliva wrote: > On Feb 9, 2018, Alexandre Oliva wrote: > >> On Feb 9, 2018, Jeff Law wrote: >>> On 02/08/2018 08:53 PM, Alan Modra wrote: On Fri, Feb 09, 2018 at 01:21:27AM -0200, Alexandre Oliva wrote: > Here's

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Alexandre Oliva
On Feb 9, 2018, Alexandre Oliva wrote: > On Feb 9, 2018, Jeff Law wrote: >> On 02/08/2018 08:53 PM, Alan Modra wrote: >>> On Fri, Feb 09, 2018 at 01:21:27AM -0200, Alexandre Oliva wrote: Here's what I checked in, right after the LVU patch.

Re: PR84300, ICE in dwarf2cfi on ppc64le

2018-02-09 Thread Alan Modra
On Fri, Feb 09, 2018 at 08:11:44AM -0600, Segher Boessenkool wrote: > On Fri, Feb 09, 2018 at 04:12:47PM +1030, Alan Modra wrote: > > ;; Use r0 to stop regrename twiddling with lr restore insns emitted > > ;; after the call to __morestack. > > (define_insn "split_stack_return" > > -

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Joseph Myers
On Fri, 9 Feb 2018, Joseph Myers wrote: > I'm seeing regressions from my glibc bot for all of arm, mips, s390 and > sh. > > https://sourceware.org/ml/libc-testresults/2018-q1/msg00283.html > > arm and mips are "view number mismatch" building glibc and s390 is the > same error but building

[Fwd: [PATCH][Bug target/84266] mmintrin.h intrinsic headers for PowerPC code fails on power9]

2018-02-09 Thread Steven Munroe
--- Begin Message --- This has a simple fix that I have tested on power8 and Seurer are tested on power9. While there may be a more elegent coding for the require casts, this is the simplest change, considering the current stage. 2018-02-09  Steven Munroe   *

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Alexandre Oliva
On Feb 9, 2018, Jakub Jelinek wrote: > On Fri, Feb 09, 2018 at 07:01:25PM -0200, Alexandre Oliva wrote: >> So, as discussed on IRC, I'm trying to use a target hook to allow >> targets to indicate that their length attrs have been assessed for this >> purpose, and a param to

Re: RFA: Fix PR 68028: LTO error when compiling PowerPC binaries with single precision floating point

2018-02-09 Thread Segher Boessenkool
Hi! On Fri, Feb 09, 2018 at 09:37:28AM +, Nick Clifton wrote: > > I thought you were going to do a patch like the following, to make the > > e500 cores less special (they are not): > > Sorry - my bad. I defer to your patch then. Whatever it takes to get > the BZ fixed and off the books...

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-09 Thread Martin Sebor
On 02/09/2018 12:52 PM, Jason Merrill wrote: On 02/08/2018 04:52 PM, Martin Sebor wrote: I took me a while to find DECL_TEMPLATE_RESULT. Hopefully that's the right way to get the primary from a TEMPLATE_DECL. Yes. Attached is an updated patch. It hasn't gone through full testing yet but

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Jakub Jelinek
On Fri, Feb 09, 2018 at 07:01:25PM -0200, Alexandre Oliva wrote: > So, as discussed on IRC, I'm trying to use a target hook to allow > targets to indicate that their length attrs have been assessed for this > purpose, and a param to make that overridable, but I'm having trouble > initializing the

[PATCH] Improve pow (C, x) -> exp (log (C) * x) optimization (PR middle-end/84309)

2018-02-09 Thread Jakub Jelinek
Hi! Apparently the new pow(C,x) -> exp(log(C)*x) if C > 0 optimization breaks some package (Marek should know which), as it has 7ulp error. Generally one should be prepared for some errors with -ffast-math. Though, in this case, if the target has c99 runtime and C is a positive 0x1pNN it seems

[committed] Better fix for the -fsanitize=undefined -fopemp -flto ICEs (PR sanitizer/83987)

2018-02-09 Thread Jakub Jelinek
Hi! Apparently the cp_free_lang_data fix wasn't sufficient, the DECL_OMP_PRIVATIZED_MEMBER vars can be copied to child functions but without the lang specific data so it doesn't trigger any longer, and even trying to free it in cp_free_lang_data if it satisfies omp_member_access_dummy_var doesn't

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-09 Thread Steve Kargl
On Fri, Feb 09, 2018 at 06:10:46PM +0200, Janne Blomqvist wrote: > Following the change to use size_t for Fortran character lengths (PR > 78534), this patch modifies the Coarray ABI in a similar way. The > single-image implementation that is included in libgfortran is > updated, but this needs

Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)

2018-02-09 Thread Steve Kargl
On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: > > the attached patch fixes some checking code for PASS arguments in > procedure-pointer components, which does not properly account for the > fact that the PASS argument needs to be polymorphic. > > [The reason for this issue is

Re: [PATCH rs6000] Fix for builtins-4-runnable.c testcase FAIL on power7/BE 32-bit

2018-02-09 Thread Segher Boessenkool
Hi Carl, On Fri, Feb 09, 2018 at 08:22:57AM -0800, Carl Love wrote: > The following patch contains fixes for the builtins4-runnable.c test in > 32-bit mode for the current GCC 8 branch. This is issue #290 in Bill > Schmidt's issues. The int128 and uint128 variable types are not > supported in

Re: [RFC][PATCH v2] PR preprocessor/83173: Additional check before decrementing highest_location

2018-02-09 Thread Mike Gulick
Hi David, Here is a new version of the linemap patch (see my earlier emails for an updated version of the test code). I spent several days poring over the line map code, and I think I understand it a little better now. I also discovered -fdump-internal-locations, and it was a big help. If I

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Joseph Myers
I'm seeing regressions from my glibc bot for all of arm, mips, s390 and sh. https://sourceware.org/ml/libc-testresults/2018-q1/msg00283.html arm and mips are "view number mismatch" building glibc and s390 is the same error but building libgcc, so presumably those are the present issue. sh is

Re: [PATCH rs6000] Fix for builtins-4-runnable.c testcase FAIL on power7/BE 32-bit

2018-02-09 Thread Carl Love
expected passes12 # of unsupported tests 6  /home/carll/GCC/build/gcc-builtin4/gcc/xgcc  version 8.0.1 20180209 (experimental) (GCC)  On a Power 8 LE machine I ran:   make -k check-gcc RUNTESTFLAGS="powerpc.exp=builtins-4-int128-runnable.c"

C++ PATCH for c++/81917, ICE with self-referential partial specialization

2018-02-09 Thread Jason Merrill
In this testcase we were managing to instantiate the same class twice, leading to an ICE. Fixed by setting TYPE_BEING_DEFINED before we consider what partial specialization to use. This also causes several existing testcases to error about incomplete types rather than excess template

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Alexandre Oliva
On Feb 9, 2018, Jeff Law wrote: > On 02/08/2018 08:53 PM, Alan Modra wrote: >> On Fri, Feb 09, 2018 at 01:21:27AM -0200, Alexandre Oliva wrote: >>> Here's what I checked in, right after the LVU patch. >>> >>> [IEPM] Introduce inline entry point markers >> >> One of these two

Re: [PATCH, rs6000] (v2) Update vsx-vector-6-le.c tests

2018-02-09 Thread Segher Boessenkool
Hi Will, On Fri, Feb 09, 2018 at 09:44:28AM -0600, Will Schmidt wrote: > Noted during review of test results on P9. Due to changes and improvements, > our codegen is different for this test on power9. > Modified the existing test to target P8 and added a P9 variant with updated > counts. > >

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Richard Biener
On February 9, 2018 7:07:45 PM GMT+01:00, Jakub Jelinek wrote: >On Fri, Feb 09, 2018 at 07:01:08PM +0100, Richard Biener wrote: >> >which indeed fixes the testcase and seems not to break asan.exp. >> >> Huh. Need to double check why that makes sense ;) > >I think it does, for

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-09 Thread Jason Merrill
On 02/08/2018 04:52 PM, Martin Sebor wrote: I took me a while to find DECL_TEMPLATE_RESULT.  Hopefully that's the right way to get the primary from a TEMPLATE_DECL. Yes. Attached is an updated patch.  It hasn't gone through full testing yet but please let me know if you'd like me to make

Go patch committed: Track //go:nointerface in export data

2018-02-09 Thread Ian Lance Taylor
In the Go frontend, the magic //go:nointerface comment, used for field tracking, was only implemented for conversions to interface types in the same package. This patch records it in the export data, so that it works as expected for types imported from a different package. Bootstrapped and ran Go

Re: [PATCH][C++] Fix PR84281

2018-02-09 Thread Jason Merrill
OK. On Fri, Feb 9, 2018 at 7:44 AM, Richard Biener wrote: > > The following patch optimizes the equal element case of > cxx_eval_vec_init_1 to use a RANGE_EXPR in the built CONSTRUCTOR > instead of repeating the same element over and over. This > cuts down memory use of the

C++ PATCH for c++/84296, ICE with qualified-id

2018-02-09 Thread Jason Merrill
In my patch to fix template/inherit4.C after 83714, I made all SCOPE_REFs instantiation-dependent if the current class has dependent bases. This was excessive; only a reference to a non-static member of an unknown base needs to be treated as instantiation-dependent. Tested x86_64-pc-linux-gnu,

patch to fix PR57193

2018-02-09 Thread Vladimir Makarov
  The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57193   The patch introduces a new heuristic to change order of coloring.  Allocnos conflicting with other allocnos preferring hard registers are colored first when other higher-level heuristics can not differ them.  On

Re: PR84239, Reimplement CET intrinsics for rdssp/incssp insn

2018-02-09 Thread Sandra Loosemore
On 02/09/2018 05:50 AM, Tsimbalist, Igor V wrote: Introduce a couple of new CET intrinsics for reading and updating a shadow stack pointer (_get_ssp and _inc_ssp), which are more user friendly. They replace the existing _rdssp[d|q] and _incssp[d|q] instrinsics. The _get_ssp intrinsic has more

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Jakub Jelinek
On Fri, Feb 09, 2018 at 07:01:08PM +0100, Richard Biener wrote: > >which indeed fixes the testcase and seems not to break asan.exp. > > Huh. Need to double check why that makes sense ;) I think it does, for both ASAN_CHECK and ASAN_MARK the pointer argument is the second one, the first one is

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Jakub Jelinek
On Fri, Feb 09, 2018 at 05:40:09PM +0100, Richard Biener wrote: > On February 9, 2018 5:08:24 PM GMT+01:00, Paolo Bonzini > wrote: > >Hi all, > > > >in this PR, a dead reference to a function pointer cannot be optimized > >out by the compiler because some ASAN_MARK UNPOISON

Re: [PATCH] Avoid BSWAP with floating point modes on rs6000 (PR target/84226)

2018-02-09 Thread Segher Boessenkool
Hi Jakub, On Fri, Feb 09, 2018 at 07:43:16AM +0100, Jakub Jelinek wrote: > BSWAP is documented as: > > @item (bswap:@var{m} @var{x}) > Represents the value @var{x} with the order of bytes reversed, carried out > in mode @var{m}, which must be a fixed-point machine mode. > The mode of @var{x}

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Richard Biener
On February 9, 2018 6:23:37 PM GMT+01:00, Paolo Bonzini wrote: >On 09/02/2018 17:40, Richard Biener wrote: >> On February 9, 2018 5:08:24 PM GMT+01:00, Paolo Bonzini > wrote: >>> Another possibility which I considered but did not implement is to >mark >>> the

Re: [PR c/84293] Unexpected strict-alias warning

2018-02-09 Thread Joseph Myers
On Fri, 9 Feb 2018, Nathan Sidwell wrote: > Joseph, are the C bits ok? Yes. -- Joseph S. Myers jos...@codesourcery.com

[PATCH] cortex-a57-fma-steering.c fixes (PR target/84272)

2018-02-09 Thread Jakub Jelinek
Hi! As mentioned in the PR, in the cortex-a57-fma-steering.c optimization pass we may use fma_node/fma_root_node data after they were deleted and leak leaf nodes because of an early continue; (the loop with to_process.safe_push (*child_iter); in the body will do nothing if list is empty, but

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Paolo Bonzini
On 09/02/2018 17:40, Richard Biener wrote: > On February 9, 2018 5:08:24 PM GMT+01:00, Paolo Bonzini > wrote: >> Another possibility which I considered but did not implement is to mark >> the UNPOISON calls so that they do not cause the parameter to escape. > > I'd do this,

Re: Please accept this commit for the trunk

2018-02-09 Thread Segher Boessenkool
Hi Mike, On Thu, Feb 08, 2018 at 06:06:05PM -0800, Mike Stump wrote: > On Feb 8, 2018, at 12:36 PM, Segher Boessenkool > wrote: > > > > On Wed, Feb 07, 2018 at 03:52:27PM -0800, Mike Stump wrote: > >> I dusted the pointed to patch off and check it in. Let us know

[Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)

2018-02-09 Thread Janus Weil
Hi all, the attached patch fixes some checking code for PASS arguments in procedure-pointer components, which does not properly account for the fact that the PASS argument needs to be polymorphic. [The reason for this issue is probably that PPCs were mostly implemented before polymorphism was

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-09 Thread Peter Bergner
On 2/9/18 10:51 AM, Segher Boessenkool wrote: >> +/* { dg-final { scan-assembler-times {\mvclzb\M} 2 } } */ >> +/* { dg-final { scan-assembler-times {\mvclzb\M} 2 } } */ This was a typo in the original test case I didn't notice. Looking closer, they meant one of these to be vclzd. I'll fix

Re: [PATCH] Adjust PR84278 testcase

2018-02-09 Thread Richard Sandiford
Richard Biener writes: > Got quoting of parens wrong. > > Tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2018-02-09 Richard Biener > > PR tree-optimization/84278 > * gcc.target/i386/pr84278.c: Adjust regex. > > Index:

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-09 Thread Segher Boessenkool
Hi! On Thu, Feb 08, 2018 at 12:28:05PM -0600, Peter Bergner wrote: > On 2/8/18 10:38 AM, Peter Bergner wrote: > > * gcc.target/powerpc/builtins-1-be.c: Filter out gimple folding disabled > > message. Fix test for running in 32-bit mode. > > As we talked about offline, here's a bigger

Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Richard Biener
On February 9, 2018 5:08:24 PM GMT+01:00, Paolo Bonzini wrote: >Hi all, > >in this PR, a dead reference to a function pointer cannot be optimized >out by the compiler because some ASAN_MARK UNPOISON calls, which are >placed before the store, cause the containing struct to escape.

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-09 Thread Peter Bergner
On 2/9/18 10:17 AM, Segher Boessenkool wrote: > On Thu, Feb 08, 2018 at 10:38:09AM -0600, Peter Bergner wrote: >> -/* { dg-final { scan-assembler-times "divd" 4 } } */ > >> +/* { dg-final { scan-assembler-times {\mdivd\M} 2 { target lp64 } } } */ > >> +/* { dg-final { scan-assembler-times {\mbl

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-09 Thread Martin Sebor
On 02/09/2018 03:54 AM, Jakub Jelinek wrote: On Fri, Feb 09, 2018 at 11:40:29AM +0100, Richard Biener wrote: I.e., having to track all pointers to d between the call to strncpy and the assignment of the nul and make sure none of them ends up used in a string function. It didn't seem the

[PATCH rs6000] Fix for builtins-4-runnable.c testcase FAIL on power7/BE 32-bit

2018-02-09 Thread Carl Love
GCC maintainers: The following patch contains fixes for the builtins4-runnable.c test in 32-bit mode for the current GCC 8 branch. This is issue #290 in Bill Schmidt's issues. The int128 and uint128 variable types are not supported in 32-bit mode. The tests were moved to a new test file and

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-09 Thread Segher Boessenkool
On Thu, Feb 08, 2018 at 10:38:09AM -0600, Peter Bergner wrote: > On 2/6/18 10:36 AM, Peter Bergner wrote: > > On 2/6/18 10:20 AM, David Edelsohn wrote: > >> Do the gen_XXXdi3 calls work if you use SDI iterator instead of GPR > >> iterator, as Segher suggested? > > > > Well it works _if_ we use

Re: [PATCH, rs6000] PR84220 fix altivec_vec_sld and vec_sldw intrinsic definitions

2018-02-09 Thread Will Schmidt
On Thu, 2018-02-08 at 17:48 -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Feb 07, 2018 at 09:14:59AM -0600, Will Schmidt wrote: > > Our VEC_SLD definitions were mistakenly allowing the third argument to be > > of an invalid type, triggering an ICE (on invalid code) later in the build > >

[PATCH] Character length cleanup for Coarray Fortran library

2018-02-09 Thread Janne Blomqvist
Following the change to use size_t for Fortran character lengths (PR 78534), this patch modifies the Coarray ABI in a similar way. The single-image implementation that is included in libgfortran is updated, but this needs corresponding work in the OpenCoarray library as well for multi-image

[PATCH] Improve dead code elimination with -fsanitize=address (PR84307)

2018-02-09 Thread Paolo Bonzini
Hi all, in this PR, a dead reference to a function pointer cannot be optimized out by the compiler because some ASAN_MARK UNPOISON calls, which are placed before the store, cause the containing struct to escape. (Without -fsanitize=address, the dead code is eliminated by the first DSE pass). The

Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target

2018-02-09 Thread Will Schmidt
On Wed, 2018-02-07 at 12:28 -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Feb 07, 2018 at 11:16:12AM -0600, Will Schmidt wrote: > > Noted during review of test results on P9. Due to changes and > > improvements, > > our codegen is different for this test on power9. > > Modified the

[PATCH, rs6000] (v2) Update vsx-vector-6-le.c tests

2018-02-09 Thread Will Schmidt
Hi, Noted during review of test results on P9. Due to changes and improvements, our codegen is different for this test on power9. Modified the existing test to target P8 and added a P9 variant with updated counts. (v2) Updated/added dg-requires and dg-skip-if stanzas pre review and re-check of

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Jeff Law
On 02/09/2018 03:34 AM, Alexandre Oliva wrote: > On Feb 9, 2018, Jeff Law wrote: > >> On 02/08/2018 08:53 PM, Alan Modra wrote: >>> On Fri, Feb 09, 2018 at 01:21:27AM -0200, Alexandre Oliva wrote: Here's what I checked in, right after the LVU patch. [IEPM]

gotools patch committed: Increase test timeout

2018-02-09 Thread Ian Lance Taylor
I'm finding that on my laptop the cmd/go tests sometimes time out when the laptop is heavily loaded because I'm running all the tests in parallel. The cmd/go tests are really a whole testsuite, not a single test. So bumping the timeout. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.

Re: [PATCH][i386][3/3] PR target/84164: Make *cmpqi_ext_ patterns accept more zero_extract modes

2018-02-09 Thread Kyrill Tkachov
Hi Uros, On 08/02/18 22:54, Uros Bizjak wrote: On Thu, Feb 8, 2018 at 6:11 PM, Kyrill Tkachov wrote: Hi all, This patch fixes some fallout in the i386 testsuite that occurs after the simplification in patch [1/3] [1]. The gcc.target/i386/extract-2.c FAILs

Re: PR84300, ICE in dwarf2cfi on ppc64le

2018-02-09 Thread Segher Boessenkool
On Fri, Feb 09, 2018 at 04:12:47PM +1030, Alan Modra wrote: > This PR is one of those with a really obvious cause, and fix. There's > nothing in the unspec rtl to say the insn needs lr! > Bootstrapped and regression tested powerpc64le-linux. OK? > > PR target/84300 > gcc/ > *

Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
On 02/09/2018 02:53 PM, Pierre-Marie de Rodat wrote: Pasto, or maybe I didn’t properly configure Vim on the machine I used. ;-) I’ll make sure these formatting issues are fixed before committing. Thanks! Committed! That was a Thunderbird pasto. I tried to update the PR. Hoping I did that

[PATCH] Fix PR84037 some more

2018-02-09 Thread Richard Biener
This improves SLP detection when swapping of operands is needed to match up stmts. Formerly we only considered swapping the not "matched" set of stmts but if we have a +- pair that might not have worked (also for other reasons). The following patch makes us instead see if we can eventually swap

Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
On 02/09/2018 02:47 PM, Richard Biener wrote: whitespace fixed here - vertical space missing before the comment and the first line of the comment (or cut error with the patch?) Pasto, or maybe I didn’t properly configure Vim on the machine I used. ;-) I’ll make sure these formatting issues

Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Richard Biener
On Fri, 9 Feb 2018, Pierre-Marie de Rodat wrote: > This patch restricts the set of cases in which we allow the generation of > location attributes for variables that are not defined in the current unit. > For such variables with complex DECL_VALUE_EXPR trees, generating a location > attribute can

Reduce inline limits a bit to compensate changes in inlining metrics

2018-02-09 Thread Jan Hubicka
Hi, this patch addresses the code size regression by reducing max-inline-insns-auto 40->30 and increasing inline-min-speedup 8->15. The main reason why we need retuning is following - inline-min-speedup works in a way that if expected runtime of caller+calee combo after inlining reduces by

[PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
This patch restricts the set of cases in which we allow the generation of location attributes for variables that are not defined in the current unit. For such variables with complex DECL_VALUE_EXPR trees, generating a location attribute can end up creating relocations to text symbols in the

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-09 Thread Nick Clifton
Hi David, Hi Martin, OK, take 3 of the patch is attached. In this version: * The escaping is handled by a new class. * Self-tests have been added (and they helped find a bug - yay!) * The documentation has been extended to mention -fmessage-length's effect on the #-directives, and

PR84239, Reimplement CET intrinsics for rdssp/incssp insn

2018-02-09 Thread Tsimbalist, Igor V
Introduce a couple of new CET intrinsics for reading and updating a shadow stack pointer (_get_ssp and _inc_ssp), which are more user friendly. They replace the existing _rdssp[d|q] and _incssp[d|q] instrinsics. The _get_ssp intrinsic has more deterministic semantic: it returns a value of the

[PR c/84293] Unexpected strict-alias warning

2018-02-09 Thread Nathan Sidwell
This bug comes from python sources. It has some type-punning macros to switch between representation, but these can cause unexpected strict-alias warnings, even though the punning's context is a system header file. (I guess that without macro expansion location information we'd've thought

[PATCH][C++] Fix PR84281

2018-02-09 Thread Richard Biener
The following patch optimizes the equal element case of cxx_eval_vec_init_1 to use a RANGE_EXPR in the built CONSTRUCTOR instead of repeating the same element over and over. This cuts down memory use of the invalid testcase in the PR from tens of GB to nothing and makes us rejct it

[PATCH] POPCOUNT folding optimizations

2018-02-09 Thread Roger Sayle
The following patch implements a number of __builtin_popcount related optimizations. (i) popcount(x) == 0 can be simplified to x==0, and popcount(x) != 0 to x!=0. (ii) popcount(x&1) can be simplified to x&1, and for unsigned x, popcount(x>>31) to x>>31. (iii) popcount (x&6) + popcount(y&16) can

Re: [PATCH][GCC][ARM] Silence more re-definition warnings, make test case failure case more explicit.

2018-02-09 Thread Kyrill Tkachov
Hi Tamar, On 07/02/18 18:35, Tamar Christina wrote: Hi All, The previous testcase would fail on a system where the initial mode is thumb and later switches to an arm mode. This would again cause some warnings to be emitted. This patch visits all builtins defined with

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Alan Modra
On Fri, Feb 09, 2018 at 08:34:08AM -0200, Alexandre Oliva wrote: > * config/rs6000/rs6000.md (blockage): Set length to zero. Thanks! This fixed the ppc64le libdecnumber error for me. -- Alan Modra Australia Development Lab, IBM

[Committed] S/390: Fix PR84295

2018-02-09 Thread Andreas Krebbel
Bootstrapped and regression tested with --with-arch=z14 and --with-arch=z900. Glibc build is clean with that patch using -mindirect-branch=thunk and -mfunction-return=thunk. gcc/ChangeLog: 2018-02-09 Andreas Krebbel PR target/PR84295 *

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-09 Thread Jakub Jelinek
On Fri, Feb 09, 2018 at 11:40:29AM +0100, Richard Biener wrote: > > I.e., having to track all pointers to d between the call to > > strncpy and the assignment of the nul and make sure none of > > them ends up used in a string function. It didn't seem > > the additional complexity would have been

Re: [patch] Do not generate libcalls to __unord[sd]f2 on PowerPC SPE

2018-02-09 Thread Richard Biener
On Fri, Feb 9, 2018 at 11:28 AM, Eric Botcazou wrote: > Hi, > > the change > > 2016-05-02 Marc Glisse > > * match.pd (X u< X, X u> X): New transformations. > > has an annoying effect on targets implementing (most) unordered comparisons in >

Re: [PATCH/RFC] tree-if-conv.c: fix two ICEs seen with -fno-tree-forwprop (PR tree-optimization/84178)

2018-02-09 Thread Richard Biener
On Thu, Feb 8, 2018 at 11:23 PM, David Malcolm wrote: > PR tree-optimization/84178 reports a couple of source files that ICE inside > ifcvt when compiled with -03 -fno-tree-forwprop (trunk and gcc 7). > > Both cases involve problems with ifcvt's per-BB gimplified predicates.

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-09 Thread Richard Biener
On Thu, Feb 8, 2018 at 7:12 PM, Martin Sebor wrote: > On 02/08/2018 07:39 AM, Richard Biener wrote: >> >> On Thu, Feb 8, 2018 at 6:35 AM, Jeff Law wrote: >>> >>> On 02/06/2018 05:57 AM, Jakub Jelinek wrote: On Tue, Feb 06, 2018 at 01:46:21PM +0100,

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-09 Thread Alexandre Oliva
On Feb 9, 2018, Jeff Law wrote: > On 02/08/2018 08:53 PM, Alan Modra wrote: >> On Fri, Feb 09, 2018 at 01:21:27AM -0200, Alexandre Oliva wrote: >>> Here's what I checked in, right after the LVU patch. >>> >>> [IEPM] Introduce inline entry point markers >> >> One of these two

[patch] Do not generate libcalls to __unord[sd]f2 on PowerPC SPE

2018-02-09 Thread Eric Botcazou
Hi, the change 2016-05-02 Marc Glisse * match.pd (X u< X, X u> X): New transformations. has an annoying effect on targets implementing (most) unordered comparisons in hardware but not the UNORDERED operator itself, e.g. PowerPC SPE, because it makes the

Fix ICE with scalar_storage_order attribute at -O

2018-02-09 Thread Eric Botcazou
This is a regression present on the mainline in the form of an assertion failure in optimize_bitfield_assignment_op with a scalar_storage_order attribute specifying the reverse endianness wrt the native endianness. I put this assertion because I failed to cover the path at the time but things

Re: RFA: Fix PR 68028: LTO error when compiling PowerPC binaries with single precision floating point

2018-02-09 Thread Nick Clifton
Hi Segher, > I thought you were going to do a patch like the following, to make the > e500 cores less special (they are not): Sorry - my bad. I defer to your patch then. Whatever it takes to get the BZ fixed and off the books... :-) Cheers Nick

[PATCH] Adjust PR84278 testcase

2018-02-09 Thread Richard Biener
Got quoting of parens wrong. Tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-02-09 Richard Biener PR tree-optimization/84278 * gcc.target/i386/pr84278.c: Adjust regex. Index: gcc/testsuite/gcc.target/i386/pr84278.c

Re: [PATCH] Avoid BSWAP with floating point modes on rs6000 (PR target/84226)

2018-02-09 Thread Richard Biener
On Fri, 9 Feb 2018, Jakub Jelinek wrote: > Hi! > > BSWAP is documented as: > > @item (bswap:@var{m} @var{x}) > Represents the value @var{x} with the order of bytes reversed, carried out > in mode @var{m}, which must be a fixed-point machine mode. > The mode of @var{x} must be @var{m} or

Fix small regression in -fdump-ada-spec

2018-02-09 Thread Eric Botcazou
We cannot generate the 'constant' keyword for components in Ada, it's illegal. Tested on x86_64-suse-linux, applied on the mainline. 2018-02-09 Eric Botcazou c-family/ * c-ada-spec.c (dump_ada_declaration): Do not generate the 'constant' keyword for