Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-13 Thread Richard Biener
On Mon, Nov 12, 2018 at 7:20 PM Kyrill Tkachov wrote: > > > On 12/11/18 14:10, Richard Biener wrote: > > On Fri, Nov 9, 2018 at 6:57 PM Kyrill Tkachov > > wrote: > >> On 09/11/18 12:18, Richard Biener wrote: > >>> On Fri, Nov 9, 2018 at 11:47 AM Kyrill Tkachov > >>> wrote: > Hi all, >

Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 10:04:03AM +0100, Richard Biener wrote: > On Tue, 13 Nov 2018, Jakub Jelinek wrote: > > > Hi! > > > > During analysis, we correctly ignore debug stmt uses, but if we don't > > release the ssa name we stopped using, the debug stmts uses are left in the > > IL. The

Re: [PATCH 21/25] GCN Back-end (part 2/2).

2018-11-13 Thread Andrew Stubbs
On 12/11/2018 18:54, Jeff Law wrote: On 11/12/18 10:52 AM, Andrew Stubbs wrote: On 12/11/2018 17:20, Segher Boessenkool wrote: If you don't want useless USEs deleted, use UNSPEC_VOLATILE instead? Or actually use the register, i.e. as input to an actually needed instruction. They're not

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Aldy Hernandez wrote: > > > > The tricky part starts in the prologue for > > > > > >if (vr0->undefined_p ()) > > > { > > >vr0->deep_copy (vr1); > > >return; > > > } > > > > > > but yes, we probably can factor out a bit more common code > > >

Re: [PATCH 4/6] [ARC] Add peephole rules to combine store/loads into double store/loads

2018-11-13 Thread Andrew Burgess
* claz...@gmail.com [2018-10-31 10:33:33 +0200]: > Thank you for your review. Please find attached a new respin patch with > your feedback in. > > Please let me know if it is ok, > Claudiu > From 4ff7d8419783eceeffbaf27df017d0a93c3af942 Mon Sep 17 00:00:00 2001 > From: Claudiu Zissulescu >

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1); return; } but yes, we probably can factor out a bit more common code here. I'll see to followup with more minor cleanups this week (noticed a few details myself). Like

Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Richard Biener
On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: > > I have rebased my value_range dumping patch after your value_range_base > changes. > > I know you are not a fan of the gimple-pretty-print.c chunk, but I still > think having one set of dumping code is preferable to catering to > possible

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-13 Thread Richard Biener
On Mon, Nov 12, 2018 at 1:00 PM Alexandre Oliva wrote: > > gnattools build machinery uses just-build xgcc and xg++ as $(CC) and > $(CXX) in native builds. However, if C and C++ languages are not > enabled, it won't find them. So, enable C and C++ if Ada is enabled. > Most of the time, this is

Re: [PATCH][lower-subreg] Fix PR87507

2018-11-13 Thread Eric Botcazou
> This has passed bootstrap and regtesting on powerpc64le-linux with no > regressions. Is this ok for mainline? > > Peter > > gcc/ > PR rtl-optimization/87507 > * lower-subreg.c (simple_move_operator): New function. > (simple_move): Strip simple operators. >

Do not generate stack usage files with -flto

2018-11-13 Thread Eric Botcazou
They are empty. Tested on x86-64/Linux, applied on the mainline as obvious. 2018-11-13 Eric Botcazou * toplev.c (output_stack_usage): Turn test on flag_stack_usage into test on stack_usage_file. (lang_dependent_init): Do not open the su file if generating LTO. --

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-13 Thread Mark Eggleston
Jakub, I've applied this patch and tried it out. The following fail to compile: In free form with or without the optional initial & on the continuation line: subroutine one()   include &   &"include_4.inc'   integer(i4) :: i end subroutine one In fixed form:   subroutine one()  

Re: [PATCH 1/3] [ARC] Update EH code.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:11 +0200]: > Our ABI says the blink is pushed first on stack followed by an unknown > number of register saves, and finally by fp. Hence we cannot use the > EH_RETURN_ADDRESS macro as the stack is not finalized at that moment. > The alternative is to use

Re: [PATCH 2/3] [ARC] Do not emit ZOL in the presence of text jump tables.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:12 +0200]: > Avoid emitting lp instruction when in its ZOL body we find a jump table data > in text section. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (hwloop_optimize): Bailout when detecting a > jump table data in

Re: [PATCH 21/25] GCN Back-end (part 2/2).

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 10:23:12AM +, Andrew Stubbs wrote: > Now that Segher says the combine issue is a bug, Well, first show what really happens; if it really deletes a USE, that is a bug yes. rtl.def says: /* Indicate something is used in a way that we don't want to explain. For

[PATCH, csky] Update linux-unwind.h

2018-11-13 Thread 瞿仙淼
Hi, I have submitted a patch to update linux-unwind for C-SKY Index: libgcc/ChangeLog === --- libgcc/ChangeLog(revision 266056) +++ libgcc/ChangeLog(working copy) @@ -1,3 +1,9 @@ +2018-11-13 Xianmiao Qu + +

Re: [C++ PATCH] Implement P0722R3, destroying operator delete.

2018-11-13 Thread Jonathan Wakely
On Tue, 13 Nov 2018 at 04:39, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, applying to trunk. Can someone from the > libstdc++ team clean up my libsupc++ change if it should be formatted > differently? Looks fine to me, thanks.

Re: [PATCH 2/3] Add a pass to automatically add ptwrite instrumentation

2018-11-13 Thread Richard Biener
On Mon, Nov 12, 2018 at 4:16 AM Andi Kleen wrote: > > On Sun, Nov 11, 2018 at 10:06:21AM +0100, Richard Biener wrote: > > That is, usually debuggers look for a location list of a variable > > and find, say, %rax. But for ptwrite the debugger needs to > > examine all active location lists for,

[PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Jakub Jelinek
Hi! During analysis, we correctly ignore debug stmt uses, but if we don't release the ssa name we stopped using, the debug stmts uses are left in the IL. The reset_debug_uses call is needed because the code modifies the division stmt in place. Perhaps better would be not to do that, i.e. create

[PATCH] Fix simplify_merge_mask (PR rtl-optimization/87918)

2018-11-13 Thread Jakub Jelinek
Hi! The BINARY_P predicate is true not just for arithmetic binary ops, but for relational ones too; for the latter, we must not call simplify_gen_binary, but simplify_gen_relational instead. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2018-11-13 Jakub Jelinek

Re: [PATCH] Fix debug stmt handling in optimize_recip_sqrt (PR tree-optimization/87977)

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Jakub Jelinek wrote: > Hi! > > During analysis, we correctly ignore debug stmt uses, but if we don't > release the ssa name we stopped using, the debug stmts uses are left in the > IL. The reset_debug_uses call is needed because the code modifies the > division stmt in

Re: [Ada] Fix wrong code for loops with convoluted control flow

2018-11-13 Thread Eric Botcazou
> Tested on x86_64-suse-linux, applied on the mainline, 8 and 7 branches. > > > 2018-11-08 Eric Botcazou > > * fe.h (Suppress_Checks): Declare. > * gcc-interface/misc.c (gnat_init_gcc_eh): Set -fnon-call-exceptions > only if checks are not suppressed and

Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-13 Thread Kyrill Tkachov
Hi Richard, On 13/11/18 08:24, Richard Biener wrote: On Mon, Nov 12, 2018 at 7:20 PM Kyrill Tkachov wrote: On 12/11/18 14:10, Richard Biener wrote: On Fri, Nov 9, 2018 at 6:57 PM Kyrill Tkachov wrote: On 09/11/18 12:18, Richard Biener wrote: On Fri, Nov 9, 2018 at 11:47 AM Kyrill Tkachov

Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 10:15 AM Kyrill Tkachov wrote: > > Hi Richard, > > On 13/11/18 08:24, Richard Biener wrote: > > On Mon, Nov 12, 2018 at 7:20 PM Kyrill Tkachov > > wrote: > >> > >> On 12/11/18 14:10, Richard Biener wrote: > >>> On Fri, Nov 9, 2018 at 6:57 PM Kyrill Tkachov > >>> wrote: >

[PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839)

2018-11-13 Thread Jakub Jelinek
Hi! The following testcase ICEs because the predicate and constraints on one of the operands of @aarch64_compare_and_swapdi aren't consistent. The RA which goes according to constraints (insn 15 13 16 2 (set (reg:DI 104) (const_int 8589934595 [0x20003])) "pr87839.c":15:3 47

[PATCH] value_range_base leftovers

2018-11-13 Thread Richard Biener
Factors more from the union code and fixes a few leftovers. Bootstrapped & tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-11-13 Richard Biener * tree-ssanames.h (set_range_info): Use value_range_base. (get_range_info): Likewise. * tree-ssanames.c

Re: [PATCH] Fix simplify_merge_mask (PR rtl-optimization/87918)

2018-11-13 Thread Eric Botcazou
> 2018-11-13 Jakub Jelinek > > PR rtl-optimization/87918 > * simplify-rtx.c (simplify_merge_mask): For COMPARISON_P, use > simplify_gen_relational rather than simplify_gen_binary. > > * gcc.target/i386/pr87918.c: New test. OK, thanks. -- Eric Botcazou

Re: Simplify enumerate and array types

2018-11-13 Thread Richard Biener
On Sun, 11 Nov 2018, Jan Hubicka wrote: > Hi, > this patch should be last patch for type simplification (modulo possible bits > that needs clearing I still notice). It does the following > 1) enables the patch to simplify aggregates also for enums. > While this does not affect C++, in C we

Re: [PATCH 2/6] [RS6000] rs6000_output_indirect_call

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 10:44:24AM +1030, Alan Modra wrote: > On Mon, Nov 12, 2018 at 01:44:08PM -0600, Bill Schmidt wrote: > > On 11/6/18 11:37 PM, Alan Modra wrote: > > > + fun, "l" + sibcall); > > > > It's not at all clear to me what {"l" + sibcall} is doing here. > > It's an ancient

Re: [PATCH 4/4] [aarch64] Update xgene1 tuning struct.

2018-11-13 Thread Richard Earnshaw (lists)
On 12/11/2018 19:14, Christoph Muellner wrote: > *** gcc/ChangeLog *** > > 2018-xx-xx Christoph Muellner > > * config/aarch64/aarch64.c (xgene1_tunings): Optimize Xgene1 tunings for > GCC 9. OK. R. > --- > gcc/config/aarch64/aarch64.c | 4 ++-- > 1 file changed, 2

[PATCH 3/6] [RS6000] Replace TLSmode with P, and correct tls call mems

2018-11-13 Thread Alan Modra
Version 2. There is really no need to define a TLSmode mode iterator that is identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P mode iterator. It's nonsense to think we might ever want to support 32-bit TLS on 64-bit or vice versa! The patch also fixes a minor error in the call

[PATCH 2/6] [RS6000] rs6000_indirect_call_template

2018-11-13 Thread Alan Modra
Version 2. Like the last patch for external calls, now handle most assembly code for indirect calls in one place. The patch also merges some insns, correcting some !rs6000_speculate_indirect_jumps cases branching to LR, which don't require a speculation barrier. *

[PATCH] Fix PR87962

2018-11-13 Thread Richard Biener
The following better detects invalid nested cycles in particular those part of an outer reduction. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2018-11-13 Richard Biener PR tree-optimization/87962 * tree-vect-loop.c (vect_is_simple_reduction):

[PATCH] Fix PR87967

2018-11-13 Thread Richard Biener
A simple omission... Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2018-11-13 Richard Biener PR tree-optimization/87967 * tree-vect-loop.c (vect_transform_loop): Also copy PHIs for constants for the scalar loop. *

Re: [PATCH 2/4] [aarch64] Update xgene1_addrcost_table.

2018-11-13 Thread Richard Earnshaw (lists)
On 12/11/2018 19:14, Christoph Muellner wrote: > *** gcc/ChangeLog *** > > 2018-xx-xx Christoph Muellner > > * config/aarch64/aarch64.c (xgene1_addrcost_table): Correct the post > modify > costs. OK. R. > --- > gcc/config/aarch64/aarch64.c | 2 +- > 1 file changed, 1

Re: [PATCH 3/4] [aarch64] Add xgene1 prefetch tunings.

2018-11-13 Thread Richard Earnshaw (lists)
On 12/11/2018 19:14, Christoph Muellner wrote: > *** gcc/ChangeLog *** > > 2018-xx-xx Christoph Muellner > > * config/aarch64/aarch64.c (xgene1_tunings): Add Xgene1 specific > prefetch tunings. OK. R. > --- > gcc/config/aarch64/aarch64.c | 13 - > 1 file changed,

Re: [RS6000] Don't pass -many to the assembler

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 12:02:55PM +1030, Alan Modra wrote: > On Mon, Nov 12, 2018 at 04:34:34PM -0800, Mike Stump wrote: > > On Nov 12, 2018, at 3:13 PM, Alan Modra wrote: > > > > > > For people developing new code, it's the right way to go, and > > > especially so for people working on gcc

Re: [RS6000] Don't put large integer constants in TOC for -mcmodel=medium

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 01:53:20PM +1030, Alan Modra wrote: > For -mcmodel=medium we can use toc-relative addressing to access > constants placed in read-only data, which is better since they can be > merged when in .rodata.cst8. > > Bootstrapped etc. powerpc64le-linux. OK? Okay, thanks!

[PATCH 1/6] [RS6000] rs6000_call_template for external call insn assembly output

2018-11-13 Thread Alan Modra
Version 2. This is a first step in tidying rs6000 call patterns, in preparation to support inline plt calls. * config/rs6000/rs6000-protos.h (rs6000_call_template): Declare. (rs6000_sibcall_template): Declare. (macho_call_template): Rename from output_call. *

[PATCH] Fix PR87931

2018-11-13 Thread Richard Biener
We need to restrict what we handle as last operation in a nested cycle because vectorizable_reduction performs the code-generation in the end. Boostrap and regtest in progress on x86_64-unknown-linux-gnu. Richard. 2018-11-13 Richard Biener PR tree-optimization/87931 *

[PATCH] Fix PR87974

2018-11-13 Thread Richard Biener
Do not look at constant or external defs in reduction stmts to determine the reduction PHI vector type. Those are promoted/demoted as required. This is another fragile area, I'll poke around a bit but nevertheless, bootstrap & regtest queued. Richard. 2018-11-13 Richard Biener PR

Re: [PATCH 1/4] [aarch64/arm] Updating the cost table for xgene1.

2018-11-13 Thread Richard Earnshaw (lists)
On 12/11/2018 19:14, Christoph Muellner wrote: > *** gcc/ChangeLog *** > > 2018-xx-xx Christoph Muellner > > * config/arm/aarch-cost-tables.h (xgene1_extra_costs): Update the cost > table > for Xgene1. OK. R. > --- > gcc/config/arm/aarch-cost-tables.h | 88 >

Re: [RS6000] Remove unnecessary rtx_equal_p

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 02:16:09PM +1030, Alan Modra wrote: > REGs are unique. This patch recognizes that fact, speeding up rs6000 > gcc infinitesimally. Bootstrapped etc. powerpc64le-linux. OK? Of course, fine for trunk. Thanks! Segher > * gcc/config/rs6000/rs6000.c

[PATCH 6/6] [RS6000] inline plt call sequences

2018-11-13 Thread Alan Modra
Version 2. Finally, the point of the previous patches in this series, support for inline PLT calls, keyed off -fno-plt. This emits code using new relocations that tie all insns in the sequence together, so that the linker can edit the sequence back to a direct call should the call target turn

[PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-13 Thread Alan Modra
Version 2. The current code handling __tls_get_addr calls for powerpc*-linux generates a call then overwrites the call insn with a special tls_{gd,ld}_{aix,sysv} pattern. It's done that way to support !TARGET_TLS_MARKERS, where the arg setup insns need to be emitted immediately before the branch

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
On 11/13/18 3:07 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1); return; } but yes, we probably can factor out a bit more common code here. I'll

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 10:06:39AM +, Mark Eggleston wrote: > I've applied this patch and tried it out. > > The following fail to compile: That is IMHO correct, it fails to compile with ifort as well: https://fortran.godbolt.org/z/Aav6dv The problem is in mixing quotes, " vs. ' If I fix

[PATCH 4/6] [RS6000] Remove constraints on call rounded_stack_size_rtx arg

2018-11-13 Thread Alan Modra
Version 2. (Same as before, here for completeness.) This call arg is unused on rs6000. * config/rs6000/darwin.md (call_indirect_nonlocal_darwin64), (call_nonlocal_darwin64, call_value_indirect_nonlocal_darwin64), (call_value_nonlocal_darwin64): Remove constraints from

RE: [PATCH 0/3] [ARC] Glibc required patches

2018-11-13 Thread Claudiu Zissulescu
Thank you for quick review. All the patches are pushed with the suggested mods. Claudiu From: Claudiu Zissulescu [claz...@gmail.com] Sent: Monday, November 12, 2018 12:25 PM To: gcc-patches@gcc.gnu.org Cc: francois.bed...@synopsys.com;

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-13 Thread Alexandre Oliva
On Nov 13, 2018, Richard Biener wrote: >> Please let me know if there are objections to this change in the next >> few days, e.g., if enabling C and C++ for an Ada-only build is too >> onerous. It is certainly possible to rework gnattools build machinery >> so that it uses CC and CXX as

Re: [PATCH 3/3] [ARC] Add support for profiling in glibc.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:13 +0200]: > Use PROFILE_HOOK to add mcount library calls in each toolchain. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.h (FUNCTION_PROFILER): Redefine to empty. > * config/arc/elf.h (PROFILE_HOOK): Define. > *

Re: [RS6000] Ignore "c", "l" and "h" for register preference

2018-11-13 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 01:35:42PM +1030, Alan Modra wrote: > This catches a few places where move insn patterns don't slightly > disparage CTR, LR and VRSAVE regs. Also fixes the doc for the rs6000 > h constraint, and removes an r->cl alternative covered by r->h. > > Segher okayed a patch

[PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-13 Thread Tom de Vries
Hi, The dwz tool attempts to optimize DWARF debugging information contained in ELF shared libraries and ELF executables for size. With the dwz -m option, it attempts to optimize by moving DWARF debugging information entries (DIEs), strings and macro descriptions duplicated in more than one

Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-13 Thread Kyrill Tkachov
On 13/11/18 09:28, Richard Biener wrote: On Tue, Nov 13, 2018 at 10:15 AM Kyrill Tkachov wrote: Hi Richard, On 13/11/18 08:24, Richard Biener wrote: On Mon, Nov 12, 2018 at 7:20 PM Kyrill Tkachov wrote: On 12/11/18 14:10, Richard Biener wrote: On Fri, Nov 9, 2018 at 6:57 PM Kyrill

[PATCH] Fix PR86991

2018-11-13 Thread Richard Biener
This PR shows we have stale reduction groups lying around because the fixup doesn't work reliably with reduction chains. Fixed by delaying the build to after detection is successful. Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2018-11-13 Richard Biener PR

PING^2: [PATCH] apply_subst_iterator: Handle define_split/define_insn_and_split

2018-11-13 Thread H.J. Lu
On Sun, Nov 4, 2018 at 7:24 AM H.J. Lu wrote: > > On Fri, Oct 26, 2018 at 12:44 AM H.J. Lu wrote: > > > > On 10/25/18, Uros Bizjak wrote: > > > On Fri, Oct 26, 2018 at 8:48 AM H.J. Lu wrote: > > >> > > >> On 10/25/18, Uros Bizjak wrote: > > >> > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote:

Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.

2018-11-13 Thread Sudakshina Das
Hi On 02/11/18 18:38, Sudakshina Das wrote: > Hi > > This patch is part of a series that enables ARMv8.5-A in GCC and > adds Branch Target Identification Mechanism. > (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools) > > This patch adds a new pass

Re: [PATCH, GCC, AARCH64, 6/6] Enable BTI: Add configure option for BTI and PAC-RET

2018-11-13 Thread Sudakshina Das
Hi James On 07/11/18 15:36, James Greenhalgh wrote: > On Fri, Nov 02, 2018 at 01:38:46PM -0500, Sudakshina Das wrote: >> Hi >> >> This patch is part of a series that enables ARMv8.5-A in GCC and >> adds Branch Target Identification Mechanism. >>

Re: [PATCH][lower-subreg] Fix PR87507

2018-11-13 Thread Peter Bergner
On 11/13/18 2:53 AM, Eric Botcazou wrote: >> +static rtx >> +simple_move_operator (rtx x) >> +{ >> + /* A word sized rotate of a register pair is equivalent to swapping >> + the registers in the register pair. */ >> + if (GET_CODE (x) == ROTATE >> + && GET_MODE (x) == twice_word_mode

Re: [PATCH] Fix PR86991

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Richard Biener wrote: > > This PR shows we have stale reduction groups lying around because > the fixup doesn't work reliably with reduction chains. Fixed by > delaying the build to after detection is successful. > > Bootstrap & regtest running on x86_64-unknown-linux-gnu.

Re: record_ranges_from_incoming_edge: use value_range API for creating new range

2018-11-13 Thread Aldy Hernandez
With your cleanups, the main raison d'etre for my patch goes away, but here is the promised removal of ignore_equivs_equal_p. I think the == operator is a bit confusing, and equality intent should be clearly specified. I am providing the following for the derived class (with no hidden

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 4:51 PM Alexandre Oliva wrote: > > On Nov 13, 2018, Richard Biener wrote: > > > Reworking gnattools build to always use host CC/CXX in "stage1" (or for > > crosses) > > rather than doing sth different. > > > Yeah, but gnattools is bootstrapped, right? > > No, it's not

RE: [PATCH 2/9][GCC][AArch64][middle-end] Add rules to strip away unneeded type casts in expressions

2018-11-13 Thread Tamar Christina
Hi Joseph, > What types exactly is this meant to apply to? Floating-point? Integer? > Mixtures of those? (I'm guessing not mixtures, because those would be > something other than "convert" here.) Originally I had it for both Floating-point and Integer, but not a mix of the two. > For

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-13 Thread Alexandre Oliva
On Nov 13, 2018, Richard Biener wrote: > Reworking gnattools build to always use host CC/CXX in "stage1" (or for > crosses) > rather than doing sth different. > Yeah, but gnattools is bootstrapped, right? No, it's not built in stage1, it's a post-bootstrap host subpackage. > For

Re: [PATCH][LRA] Fix PR87899: r264897 cause mis-compiled native arm-linux-gnueabihf toolchain

2018-11-13 Thread Peter Bergner
On 11/13/18 9:01 AM, Renlin Li wrote: > I could verify that, your patch fixes all the ICEs I saw with > arm-linux-gnueabihf toolchain! > There are some differences on the test results, because I compare the latest > results with something which is old. > > I haven't test it on bare-metal

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Aldy Hernandez
On 11/13/18 8:58 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: On 11/13/18 3:07 AM, Richard Biener wrote: On Tue, 13 Nov 2018, Aldy Hernandez wrote: The tricky part starts in the prologue for if (vr0->undefined_p ()) { vr0->deep_copy (vr1);

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 2:10 PM Alexandre Oliva wrote: > > On Nov 13, 2018, Richard Biener wrote: > > >> Please let me know if there are objections to this change in the next > >> few days, e.g., if enabling C and C++ for an Ada-only build is too > >> onerous. It is certainly possible to rework

Re: [PATCH] Do not allow -mabi=ms and -fsanitize={,kernel-}address (PR sanitizer/87930).

2018-11-13 Thread Martin Liška
On 11/12/18 1:07 PM, Jakub Jelinek wrote: > On Mon, Nov 12, 2018 at 01:03:41PM +0100, Martin Liška wrote: >> The patch reject usage of the mentioned options. >> >> Ready for trunk? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> 2018-11-12 Martin Liska >> >> PR sanitizer/87930 >> *

Re: [PATCH][LRA] Fix PR87899: r264897 cause mis-compiled native arm-linux-gnueabihf toolchain

2018-11-13 Thread Renlin Li
Hi Peter, I could verify that, your patch fixes all the ICEs I saw with arm-linux-gnueabihf toolchain! There are some differences on the test results, because I compare the latest results with something which is old. I haven't test it on bare-metal toolchain yet. But will do to ensure all

Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.

2018-11-13 Thread Richard Biener
On Sun, Nov 11, 2018 at 9:02 AM bin.cheng wrote: > > Hi, > This patch fixes PR84648 by adjusting exit conditions for loop-until-wrap > cases. > It only handles simple cases in which IV.base are constants because we rely on > current niter analyzer which doesn't handle parameterized bound in

Re: [PATCH] Do not allow -mabi=ms and -fsanitize={,kernel-}address (PR sanitizer/87930).

2018-11-13 Thread Martin Liška
On 11/13/18 4:08 PM, Jakub Jelinek wrote: > On Tue, Nov 13, 2018 at 04:01:56PM +0100, Martin Liška wrote: >> On 11/12/18 1:07 PM, Jakub Jelinek wrote: >>> On Mon, Nov 12, 2018 at 01:03:41PM +0100, Martin Liška wrote: The patch reject usage of the mentioned options. Ready for trunk?

Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839)

2018-11-13 Thread Kyrill Tkachov
Hi Jakub, On 13/11/18 09:28, Jakub Jelinek wrote: Hi! The following testcase ICEs because the predicate and constraints on one of the operands of @aarch64_compare_and_swapdi aren't consistent. The RA which goes according to constraints (insn 15 13 16 2 (set (reg:DI 104) (const_int

Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 10:48 AM Kyrill Tkachov wrote: > > > On 13/11/18 09:28, Richard Biener wrote: > > On Tue, Nov 13, 2018 at 10:15 AM Kyrill Tkachov > > wrote: > >> Hi Richard, > >> > >> On 13/11/18 08:24, Richard Biener wrote: > >>> On Mon, Nov 12, 2018 at 7:20 PM Kyrill Tkachov > >>>

Re: [PATCH, GCC, AARCH64, 1/6] Enable ARMv8.5-A in gcc

2018-11-13 Thread Sudakshina Das
Hi James On 07/11/18 15:16, James Greenhalgh wrote: > On Fri, Nov 02, 2018 at 01:37:33PM -0500, Sudakshina Das wrote: >> Hi >> >> This patch is part of a series that enables ARMv8.5-A in GCC and >> adds Branch Target Identification Mechanism. >>

Re: [PATCH] RFC: machine-readable diagnostic output (PR other/19165)

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 8:58 AM David Malcolm wrote: > > This patch implements a -fdiagnostics-format=json option which > converts the diagnostics to be output to stderr in a JSON format; > see the documentation in invoke.texi. > > Logically-related diagnostics are nested at the JSON level, using

Re: [PATCH] Improve -fprofile-report.

2018-11-13 Thread Richard Biener
On Tue, Nov 6, 2018 at 3:05 PM Martin Liška wrote: > > Hi. > > The patch is based on what was discussed on IRC and in the PR. > Apart from that the reported layout is improved. > > Patch survives regression tests on x86_64-linux-gnu. > > Ready for trunk? OK. Thanks, Richard. > Martin > >

Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 3:43 PM Aldy Hernandez wrote: > > > > On 11/13/18 3:12 AM, Richard Biener wrote: > > On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: > >> > >> I have rebased my value_range dumping patch after your value_range_base > >> changes. > >> > >> I know you are not a fan

Re: [PATCH] More value_range API cleanup

2018-11-13 Thread Richard Biener
On Tue, 13 Nov 2018, Aldy Hernandez wrote: > On 11/13/18 3:07 AM, Richard Biener wrote: > > On Tue, 13 Nov 2018, Aldy Hernandez wrote: > > > > > > > > > > The tricky part starts in the prologue for > > > > > > > > > > if (vr0->undefined_p ()) > > > > > { > > > > >

Re: RFC (branch prediction): PATCH to implement P0479R5, [[likely]] and [[unlikely]].

2018-11-13 Thread Martin Liška
On 11/13/18 5:43 AM, Jason Merrill wrote: > [[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes, > except that they can be applied to arbitrary statements as well as labels; > this is most likely to be useful for marking if/else branches as likely or > unlikely.

Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Aldy Hernandez
On 11/13/18 3:12 AM, Richard Biener wrote: On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: I have rebased my value_range dumping patch after your value_range_base changes. I know you are not a fan of the gimple-pretty-print.c chunk, but I still think having one set of dumping code

Re: [PATCH] Do not allow -mabi=ms and -fsanitize={,kernel-}address (PR sanitizer/87930).

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 04:24:39PM +0100, Martin Liška wrote: > 2018-11-13 Martin Liska > > * pr87930.c: Move from gcc/testsuite/gcc.target/i386/ > into gcc/testsuite/gcc.dg/asan/. * gcc.target/i386/pr87930.c: Move to ... * gcc.dg/asan/pr87930.c: ... here. Guard

Re: [PATCH] Do not allow -mabi=ms and -fsanitize={,kernel-}address (PR sanitizer/87930).

2018-11-13 Thread Martin Liška
On 11/13/18 4:26 PM, Jakub Jelinek wrote: > On Tue, Nov 13, 2018 at 04:24:39PM +0100, Martin Liška wrote: >> 2018-11-13 Martin Liska >> >> * pr87930.c: Move from gcc/testsuite/gcc.target/i386/ >> into gcc/testsuite/gcc.dg/asan/. > > * gcc.target/i386/pr87930.c: Move to ... >

Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses

2018-11-13 Thread Marek Polacek
On Tue, Nov 13, 2018 at 11:49:55AM +0530, Umesh Kalappa wrote: > Hi All, > > the following patch fix the subjected issue > > Index: gcc/cp/parser.c > === > --- gcc/cp/parser.c (revision 266026) > +++ gcc/cp/parser.c (working

Re: [PATCH] [ARC] Cleanup, fix and set LRA default.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:29:33 +0200]: > From: claziss > > Hi Andrew, > > This is a patch which fixes and sets LRA by default. > > OK to apply? > Claudiu > > Commit message > > LP_COUNT register cannot be freely allocated by the compiler as it > size, and/or content

Re: [PATCH] Do not allow -mabi=ms and -fsanitize={,kernel-}address (PR sanitizer/87930).

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 04:01:56PM +0100, Martin Liška wrote: > On 11/12/18 1:07 PM, Jakub Jelinek wrote: > > On Mon, Nov 12, 2018 at 01:03:41PM +0100, Martin Liška wrote: > >> The patch reject usage of the mentioned options. > >> > >> Ready for trunk? > >> Thanks, > >> Martin > >> > >>

[PATCH] update-copyright.py: Add filters for D language sources

2018-11-13 Thread Iain Buclaw
Hi, This adds filters for upstream dmd, druntime, and phobos libraries, so that the update-copyright script doesn't complain or try to update the copyright years for those files. OK for trunk? -- Iain --- contrib/ChangeLog: 2018-11-13 Iain Buclaw * update-copyright.py

[PATCH][RS6000] Fix PR87870: ppc64 generates poor code when loading constants into TImode vars

2018-11-13 Thread Peter Bergner
PR87870 shows a problem loading simple constant values into TImode variables. This is a regression ever since VSX was added and we started using the vsx_mov_64bit pattern. We still get the correct code on trunk if we compile with -mno-vsx, since we fall back to using the older mov_ppc64 move

[PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-13 Thread David Malcolm
On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: > Hi David, > > On 09/11/18 21:00, Jeff Law wrote: > > On 11/9/18 10:51 AM, David Malcolm wrote: > > > One of the concerns noted at Cauldron about -fsave-optimization- > > > record > > > was the size of the output files. > > > > > > This

Re: [PATCH] -fsave-optimization-record: compress the output using zlib

2018-11-13 Thread Kyrill Tkachov
Hi David, On 09/11/18 21:00, Jeff Law wrote: On 11/9/18 10:51 AM, David Malcolm wrote: > One of the concerns noted at Cauldron about -fsave-optimization-record > was the size of the output files. > > This file implements compression of the -fsave-optimization-record > output, using zlib. > > I

Re: [PATCH][lower-subreg] Fix PR87507

2018-11-13 Thread Richard Henderson
On 11/13/18 5:38 PM, Peter Bergner wrote: > On 11/13/18 2:53 AM, Eric Botcazou wrote: >>> +static rtx >>> +simple_move_operator (rtx x) >>> +{ >>> + /* A word sized rotate of a register pair is equivalent to swapping >>> + the registers in the register pair. */ >>> + if (GET_CODE (x) ==

RE: [PATCH 2/9][GCC][AArch64][middle-end] Add rules to strip away unneeded type casts in expressions

2018-11-13 Thread Joseph Myers
On Tue, 13 Nov 2018, Tamar Christina wrote: > Would restricting it to flag_unsafe_math_optimizations not be enough in > this case? Since if it's only done for unsafe math then you likely won't > care about a small loss in precision anyway? We have what should be the right logic (modulo DFP

Re: [RS6000] Don't pass -many to the assembler

2018-11-13 Thread Iain Sandoe
Hi Folks, > On 13 Nov 2018, at 17:48, Peter Bergner wrote: > > On 11/13/18 5:17 AM, Segher Boessenkool wrote: >> On Tue, Nov 13, 2018 at 12:02:55PM +1030, Alan Modra wrote: >>> On Mon, Nov 12, 2018 at 04:34:34PM -0800, Mike Stump wrote: On Nov 12, 2018, at 3:13 PM, Alan Modra wrote:

Re: [PATCH 2/3] Add a pass to automatically add ptwrite instrumentation

2018-11-13 Thread Richard Biener
On November 13, 2018 7:09:15 PM GMT+01:00, Andi Kleen wrote: >On Tue, Nov 13, 2018 at 09:03:52AM +0100, Richard Biener wrote: >> > I even had an earlier version of this that instrumented >> > assembler output of the compiler with PTWRITE in a separate script, >> > and it worked fine too. >> >>

Re: [PATCH] RFC: C/C++: print help when a header can't be found

2018-11-13 Thread Jason Merrill
On Mon, Nov 12, 2018 at 4:01 PM Martin Sebor wrote: > On 11/11/2018 04:33 PM, David Malcolm wrote: > > When gcc can't find a header file, it's a hard error that stops the build, > > typically requiring the user to mess around with compile flags, Makefiles, > > dependencies, and so forth. > > > >

[PATCH] Remove redundant loop in unsynchronized_pool_resource code

2018-11-13 Thread Jonathan Wakely
* src/c++17/memory_resource.cc (bitset::find_first_unset()): Remove unused function. (bitset::get_first_unset()): Remove loop, if there's are unset bits then _M_next_word refers to the first one and there's no need to loop. (_Pool::_Pool(size_t, size_t),

[committed] Fix debug stmt handling in omp-simd-clone.c (PR tree-optimization/87898)

2018-11-13 Thread Jakub Jelinek
Hi! Gimple debug binds (both normal and source) need to have a decl as the first operand. The simd clone adjustment code would in some cases transform that into an ARRAY_REF. The following patch removes such debug stmts. In the future we could have a VAR_DECL with DECL_ABSTRACT_ORIGIN pointing

Re: [PATCH] Remove redundant loop in unsynchronized_pool_resource code

2018-11-13 Thread Jonathan Wakely
On 13/11/18 23:19 +, Jonathan Wakely wrote: On 13/11/18 22:59 +, Jonathan Wakely wrote: * src/c++17/memory_resource.cc (bitset::find_first_unset()): Remove unused function. (bitset::get_first_unset()): Remove loop, if there's are unset bits then

Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-13 Thread Jason Merrill
On Mon, Nov 12, 2018 at 4:32 PM Martin Sebor wrote: > On 11/11/2018 02:02 PM, David Malcolm wrote: > > On Sun, 2018-11-11 at 11:01 -0700, Martin Sebor wrote: > >> On 11/10/2018 12:01 AM, Eric Gallager wrote: > >>> On 11/9/18, David Malcolm wrote: > This patch adds a fix-it hint to various

Re: RFA: vectorizer patches 1/2 : WIDEN_MULT_PLUS support

2018-11-13 Thread Joern Wolfgang Rennecke
On 12/11/18 14:30, Richard Biener wrote: I guess I already asked this question when WIDEN_MULT_PLUS_EXPR was introduced - but isn't that fully contained within a DOT_PROD_EXPR? I'm not sure what exactly you mean here. A mailing list search to find that post was unsuccessful. The earliest

Re: [PATCH][lower-subreg] Fix PR87507

2018-11-13 Thread Eric Botcazou
> PR rtl-optimization/87507 > * lower-subreg.c (operand_for_simple_move_operator): New function. > (simple_move): Strip simple operators. > (find_pseudo_copy): Likewise. > (resolve_operand_for_simple_move_operator): New function. > (resolve_simple_move): Strip

ping x3 [PATCH 0/3] [MSP430] Add methods to extract MCU data from file

2018-11-13 Thread Jozef Lawrynowicz
ping On 29/10/2018 14:22, Jozef Lawrynowicz wrote: The same as previous pings except I removed the patch which updates the hard-coded device data - I'll commit that later as "obvious". Ok for trunk? The following series of patches extends MCU device data handling for the msp430 target,

  1   2   >