Re: [gem5-dev] Review Request: etherlink: add simobjects at the endpoints to the link structure

2013-02-11 Thread Nilay Vaish
On Feb. 10, 2013, 8:26 p.m., Steve Reinhardt wrote: tests/configs/twosys-tsunami-simple-atomic.py, line 62 http://reviews.gem5.org/r/1700/diff/1/?file=33957#file33957line62 I think this is redundant, right? drive_sys should inherit eventq_index from root. For that matter, root

Re: [gem5-dev] Review Request: sim: simulate with multiple event queues

2013-02-11 Thread Nilay Vaish
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote: Hi Nilay, Thanks a lot for posting this. I'm really excited to see you pushing this forward. One high-level thought... now that I've looked at this code again after not having seen it for over a year, the repetition of

Re: [gem5-dev] Review Request: sim: simulate with multiple event queues

2013-02-11 Thread Steve Reinhardt
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote: Hi Nilay, Thanks a lot for posting this. I'm really excited to see you pushing this forward. One high-level thought... now that I've looked at this code again after not having seen it for over a year, the repetition of

Re: [gem5-dev] Review Request: sim: simulate with multiple event queues

2013-02-11 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1667/#review4011 --- Hi Nilay, Thanks for all of this, it's really great to see us making

Re: [gem5-dev] Review Request: etherlink: add simobjects at the endpoints to the link structure

2013-02-11 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4012 --- Ship it! Like Steve i find the changes required to be remarkably small

Re: [gem5-dev] Review Request: sim: simulate with multiple event queues

2013-02-11 Thread Steve Reinhardt
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote: src/python/m5/SimObject.py, line 604 http://reviews.gem5.org/r/1667/diff/2/?file=33931#file33931line604 How does this work? I'm not saying it doesn't I just don't understand what the proxy is doing in this case? Looking for any

[gem5-dev] changeset in gem5: ruby: record fully busy cycle with in the con...

2013-02-11 Thread Nilay Vaish
changeset 28d88a0fda74 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=28d88a0fda74 description: ruby: record fully busy cycle with in the controller This patch does several things. First, the counter for fully busy cycles for a controller is now kept

[gem5-dev] changeset in gem5: ruby: modifies histogram add() function

2013-02-11 Thread Nilay Vaish
changeset 2759161b9d7f in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=2759161b9d7f description: ruby: modifies histogram add() function This patch modifies the Histogram class' add() function so that it can add linear histograms as well. The function

[gem5-dev] changeset in gem5: base: add some mathematical operators to Cycl...

2013-02-11 Thread Nilay Vaish
changeset 66eb324d4de1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=66eb324d4de1 description: base: add some mathematical operators to Cycles class diffstat: src/base/types.hh | 12 1 files changed, 12 insertions(+), 0 deletions(-) diffs (22

[gem5-dev] changeset in gem5: ruby: replaces Time with Cycles in many places

2013-02-11 Thread Nilay Vaish
changeset b03b556a8fbb in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b03b556a8fbb description: ruby: replaces Time with Cycles in many places The patch started of with replacing Time with Cycles in the Consumer class. But to get ruby to compile, the

[gem5-dev] changeset in gem5: ruby: replace Time with Cycles in Message class

2013-02-11 Thread Nilay Vaish
changeset 9c3e3d1c7a87 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=9c3e3d1c7a87 description: ruby: replace Time with Cycles in Message class Concomitant changes are being committed as well, including the io operator for the Cycles class.

[gem5-dev] changeset in gem5: ruby: Replace Time with Cycles in SequencerMe...

2013-02-11 Thread Nilay Vaish
changeset 378817542866 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=378817542866 description: ruby: Replace Time with Cycles in SequencerMessage diffstat: src/mem/ruby/system/Sequencer.cc | 2 +- src/mem/ruby/system/Sequencer.hh | 5 +++-- 2 files changed, 4

[gem5-dev] changeset in gem5: ruby: replace Time with Cycles in Memory Cont...

2013-02-11 Thread Nilay Vaish
changeset 45cd0bc6c507 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=45cd0bc6c507 description: ruby: replace Time with Cycles in Memory Controller diffstat: src/mem/ruby/system/MemoryControl.hh | 2 +- src/mem/ruby/system/MemoryNode.hh| 12

[gem5-dev] changeset in gem5: ruby: replace Time with Cycles in MessageBuffer

2013-02-11 Thread Nilay Vaish
changeset 98ad73bdc579 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=98ad73bdc579 description: ruby: replace Time with Cycles in MessageBuffer diffstat: src/mem/ruby/buffers/MessageBuffer.cc | 22 ++ src/mem/ruby/buffers/MessageBuffer.hh |

[gem5-dev] changeset in gem5: ruby: convert block size, memory size to unsi...

2013-02-11 Thread Nilay Vaish
changeset 5c6de9a7f8d8 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5c6de9a7f8d8 description: ruby: convert block size, memory size to unsigned diffstat: src/mem/ruby/system/RubySystem.py | 2 +- src/mem/ruby/system/System.cc | 8

[gem5-dev] changeset in gem5: ruby: replace Time with Tick in replacement p...

2013-02-11 Thread Nilay Vaish
changeset 66b3ed9a176e in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=66b3ed9a176e description: ruby: replace Time with Tick in replacement policy classes diffstat: src/mem/ruby/system/AbstractReplacementPolicy.hh | 14 +++---

[gem5-dev] changeset in gem5: ruby: replace Time with Cycles in garnet fixe...

2013-02-11 Thread Nilay Vaish
changeset f5335ac67f41 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=f5335ac67f41 description: ruby: replace Time with Cycles in garnet fixed and flexible diffstat: src/mem/ruby/network/garnet/BaseGarnetNetwork.cc | 6 +-

[gem5-dev] changeset in gem5: ruby: replace Time with Cycles (final patch i...

2013-02-11 Thread Nilay Vaish
changeset d2ab6d889fc7 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=d2ab6d889fc7 description: ruby: replace Time with Cycles (final patch in the series) This patch is as of now the final patch in the series of patches that replace Time with

[gem5-dev] changeset in gem5: ruby: enable multiple clock domains

2013-02-11 Thread Nilay Vaish
changeset dde110931867 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=dde110931867 description: ruby: enable multiple clock domains This patch allows ruby to have multiple clock domains. As I understand with this patch, controllers can have different

[gem5-dev] changeset in gem5: ruby: MI protocol: add a missing transition

2013-02-11 Thread Nilay Vaish
changeset 0adea7868e77 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=0adea7868e77 description: ruby: MI protocol: add a missing transition The transition for state MII and event Store was found missing during testing. The transition is being added.

Re: [gem5-dev] Review Request: ruby: record fully busy cycle with in the controller

2013-02-11 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1655/ --- (Updated Feb. 11, 2013, 4:23 p.m.) Review request for Default. Description

Re: [gem5-dev] changeset in gem5: regressions: update stats due to changes to ruby

2013-02-11 Thread Beckmann, Brad
Hi Nilay, Do you know why the stat values changed? The values seem relatively close, but I would have expected no changes in the values. Brad -Original Message- From: gem5-dev-boun...@gem5.org [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Nilay Vaish Sent: Monday, February 11,

Re: [gem5-dev] changeset in gem5: regressions: update stats due to changes to ruby

2013-02-11 Thread Nilay
On Mon, February 11, 2013 6:39 pm, Beckmann, Brad wrote: Hi Nilay, Do you know why the stat values changed? The values seem relatively close, but I would have expected no changes in the values. Hi Brad, There are three different cases in which we can divide the changes to stats: a. changes