> On Feb. 10, 2013, 8:26 p.m., Steve Reinhardt wrote: > > tests/configs/twosys-tsunami-simple-atomic.py, line 62 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33957#file33957line62> > > > > I think this is redundant, right? drive_sys should inherit > > eventq_index from root. For that matter, root should default to 0 as well, > > so only the 'test_sys.eventq_index = 1' line is strictly necessary. I'm > > not opposed to leaving the other lines in for documentation purposes. > >
Yes, you are right. > On Feb. 10, 2013, 8:26 p.m., Steve Reinhardt wrote: > > configs/common/FSConfig.py, line 557 > > <http://reviews.gem5.org/r/1700/diff/1/?file=33952#file33952line557> > > > > It looks like this wouldn't work for the realview system, is that right? Yes. As of now I have only tested with the Alpha regression test. Arm would require its own set of changes, though it might be that a couple of lines in this script and only the decoder needs to change. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4014 ----------------------------------------------------------- On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
