----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1700/#review4012 -----------------------------------------------------------
Ship it! Like Steve i find the changes required to be remarkably small (which is great!). Seeing as there is some subtleness to what is going on it would be very nice to have some comments about what is going on here. Otherwise I'm happy. Thanks again for making this happen, Ali src/dev/Ethernet.py <http://reviews.gem5.org/r/1700/#comment3861> A comment about what there are would be great? src/dev/etherlink.hh <http://reviews.gem5.org/r/1700/#comment3862> same here please - Ali Saidi On Feb. 10, 2013, 1:48 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1700/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:050c11c6e40b > --------------------------- > etherlink: add simobjects at the endpoints to the link structure > > > Diffs > ----- > > configs/common/FSConfig.py ff4b1bde5f60 > src/dev/Ethernet.py ff4b1bde5f60 > src/dev/etherlink.hh ff4b1bde5f60 > src/dev/etherlink.cc ff4b1bde5f60 > src/dev/etherobject.hh ff4b1bde5f60 > tests/configs/twosys-tsunami-simple-atomic.py ff4b1bde5f60 > > Diff: http://reviews.gem5.org/r/1700/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
