Re: [gem5-dev] Review Request 3429: ruby: PerfectCache changes so that we can create with new

l 4, 2016, 11:42 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3429/ > --- > > (Up

Re: [gem5-dev] Review Request 3432: base: stats: add function for printing text to output

be aggregated per system at the end of a simulation. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3432/#review8151 --- On April 4, 2

Re: [gem5-dev] Review Request 3433: ruby: improved component mapping

boards anytime soon; kudos go to him for this. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3433/#review8152 --- On April 4, 2

Re: [gem5-dev] Review Request 3428: ruby: pass in block size to ENTRY objects with block size

lly generated e-mail. To reply, visit: http://reviews.gem5.org/r/3428/#review8153 ----------- On April 4, 2016, 11:42 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews

Re: [gem5-dev] Review Request 3427: ruby: add new rule to grammer to handle new'd objects with parameters

meters) will be using the m_ notation.) This is a hacky way to achieve that and I don't think that the other grammer statements do this for member types. Also, I do not check to verify that this param has been declared witin slicc. I am open to solutions on how to fix that too. - Brandon

Re: [gem5-dev] Review Request 3420: ruby: change MultiBitSelBlockFilter constructor signature

rop the issue? On April 5, 2016, 2:59 p.m., Brandon Potter wrote: > > Couple of small notes, but other than that it's fine. > > > > Any idea why it was originally like this? Seems kinda crazy. I do not know anything about this code or how it was suppossed to be used. I inheri

Re: [gem5-dev] Review Request 3414: ruby: remove unnecessary C-style explicit boolean cast

/TBETable.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/structures/TimerTable.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3414/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5

Re: [gem5-dev] Review Request 3414: ruby: change !! into static_cast calls

reply, visit: http://reviews.gem5.org/r/3414/#review8138 --- On April 4, 2016, 11:38 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-ma

[gem5-dev] Review Request 3442: ruby: allows multiple instances of ruby to be invoked

/MessageBuffer.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3442/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3443: garnet: fix bug where multiple enqueues happen on same tick

, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MESI_Three_Level-L1cache.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MESI_Three_Level-msg.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3441/diff/ Testing --- Thanks, Brandon

[gem5-dev] Review Request 3439: ruby: change Packet* to PacketPtr for consistency

cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3439/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http

[gem5-dev] Review Request 3440: ruby: add L0Cache machine type to MachType enum

11442:8d55f7299d8a --- ruby: add L0Cache machine type to MachType enum Diffs - src/mem/protocol/RubySlicc_Exports.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3440/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3434: ruby: remove unused L3Cntrl class from python files

cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_VIPER_Region.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/MOESI_AMD_Base.py cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3434/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3436: ruby: topology: do not use Machine* functions

: http://reviews.gem5.org/r/3436/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3438: ruby: modify Ruby's set operations to work on uninitialized sets

: http://reviews.gem5.org/r/3438/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3435: ruby: consolidate CntrlBase class definition and add method

cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_VIPER_Region.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/MOESI_AMD_Base.py cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3435/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3431: ruby: convert global statistical variables to local ones.

/stats/__init__.py cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3431/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3432: base: stats: add function for printing text to output

/output.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca src/base/stats/text.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca src/base/stats/text.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3432/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3433: ruby: improved component mapping

--- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3430: ruby: remove the ruby system static related to block size

-TCCdir.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3430/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3429: ruby: PerfectCache changes so that we can create with new

11431:88018e899f82 --- ruby: PerfectCache changes so that we can create with new Diffs - src/mem/ruby/structures/PerfectCacheMemory.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3429/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3428: ruby: pass in block size to ENTRY objects with block size

cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3428/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3427: ruby: add new rule to grammer to handle new'd objects with parameters

cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3427/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3426: ruby: DataBlock method changes w/ manual subsequent initializations

cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3426/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org

[gem5-dev] Review Request 3425: ruby: write mask method changes w/ manual subsequent initializations

cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-SQC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3425/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3422: ruby: change function signature for functional_read/write

cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3422/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3424: ruby: add parameters to functions related to addresses

/Check.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3424/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3423: ruby: add block_size_bits to the testAnd* functions

Diff: http://reviews.gem5.org/r/3423/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3421: ruby: add a couple of members to ruby objects to remove statics

/RubyPort.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/system/RubySystem.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3421/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5

[gem5-dev] Review Request 3419: ruby: remove the SubBlock class

cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/system/VIPERCoalescer.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3419/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman

[gem5-dev] Review Request 3420: ruby: change MultiBitSelBlockFilter constructor signature

- src/mem/ruby/filters/MultiBitSelBloomFilter.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/filters/MultiBitSelBloomFilter.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3420/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3417: ruby: use ENTRY* instead of ENTRY for TBETable

operator for the DataBlock by using ENTRY* in TBETable. Diffs - src/mem/ruby/structures/TBETable.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3417/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

[gem5-dev] Review Request 3416: ruby: copy data to from cache to TBE only when required

/MOESI_CMP_directory-L1cache.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_hammer-cache.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3416/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing

[gem5-dev] Review Request 3418: ruby: fix naming of variables

--- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3415: ruby: remove unused code inside '#if 0 ... #endif'

cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3415/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3414: ruby: change !! into static_cast calls

/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3413: ruby: add newline to RubyNetwork DPRINTF

: http://reviews.gem5.org/r/3413/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3404: style: Add a control character checker

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3404/#review8128 --- Ship it! Ship It! - Brandon Potter On March 29, 2016, 9:28 a.m

Re: [gem5-dev] Review Request 3406: style: Change maximum line length to 79 characters

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3406/#review8127 --- Ship it! Ship It! - Brandon Potter On March 29, 2016, 10:42 a.m

[gem5-dev] changeset in gem5: syscall_emul: fix bugs for mmap2 system call ...

changeset dbbf54058f6f in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=dbbf54058f6f description: syscall_emul: fix bugs for mmap2 system call and x86-32 syscalls diffstat: src/arch/x86/linux/process.cc | 2 +- src/arch/x86/process.cc | 1 +

Re: [gem5-dev] Review Request 3372: mem: FreeBSD does not provide MAP_NORESERVE either

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3372/#review8095 --- Ship it! Ship It! - Brandon Potter On March 10, 2016, 2:36 p.m

[gem5-dev] changeset in gem5: syscall_emul, style: refactor lseek

changeset bfe4c2a8ad36 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=bfe4c2a8ad36 description: syscall_emul, style: refactor lseek diffstat: src/sim/syscall_emul.cc | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diffs (29 lines):

[gem5-dev] changeset in gem5: syscall_emul: update x86 mmap base address

changeset 890c69a8 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=890c69a8 description: syscall_emul: update x86 mmap base address diffstat: src/arch/x86/process.cc | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diffs

[gem5-dev] changeset in gem5: syscall_emul: rename OpenFlagTransTable struct

changeset 516213d2f0cf in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=516213d2f0cf description: syscall_emul: rename OpenFlagTransTable struct The structure definition only had the open system call flag set in mind when it was named, so we rename it

[gem5-dev] changeset in gem5: syscall_emul: add many Linux kernel flags

changeset 654272b82e94 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=654272b82e94 description: syscall_emul: add many Linux kernel flags diffstat: src/arch/alpha/linux/linux.cc | 72 ++-- src/arch/alpha/linux/linux.hh | 66 ++

[gem5-dev] changeset in gem5: syscall_emul: extend mmap system call to supp...

changeset 5ac090acd180 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5ac090acd180 description: syscall_emul: extend mmap system call to support file backed mmaps For O3, which has a stat that counts reg reads, there is an additional reg read per

[gem5-dev] changeset in gem5: syscall_emul, style: fix newline issue inside...

changeset 8457e0a24e5d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=8457e0a24e5d description: syscall_emul, style: fix newline issue inside assert diffstat: src/sim/process.cc | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diffs (13 lines): diff -r

[gem5-dev] changeset in gem5: base: support dynamic loading of Linux ELF ob...

changeset 1e55f16160cb in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1e55f16160cb description: base: support dynamic loading of Linux ELF objects in SE mode diffstat: src/arch/alpha/process.cc | 9 +++- src/arch/arm/process.cc| 13 +++--

[gem5-dev] changeset in gem5: base: add symbol support for dynamic libraries

changeset 5967db4cff04 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5967db4cff04 description: base: add symbol support for dynamic libraries Libraries are loaded into the process address space using the mmap system call. Conveniently, this happens

Re: [gem5-dev] Review Request 3357: ruby: Rename pkt to m_pkt so it may be accessed via SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3357/#review8094 --- Ship it! Ship It! - Brandon Potter On March 4, 2016, 7:52 p.m

Re: [gem5-dev] Review Request 3324: syscall_emul: extend mmap system call to support file backed mmaps

/sparc/solaris/solaris.hh b318499f676cf960be8148635c91f4a4f20c4616 src/arch/sparc/solaris/solaris.cc b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3324/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing

Re: [gem5-dev] Review Request 3324: syscall_emul: extend mmap system call to support file backed mmaps

This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3324/#review8036 --- On Feb. 10, 2016, 6:20 p.m., Brandon Potter wrote: > > -

Re: [gem5-dev] Review Request 3324: syscall_emul: extend mmap system call to support file backed mmaps

ted e-mail. To reply, visit: http://reviews.gem5.org/r/3324/#review8034 --- On Feb. 10, 2016, 6:20 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To

Re: [gem5-dev] Review Request 3321: syscall_emul: add extra debug support for syscalls

------ On Feb. 10, 2016, 6:19 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3321/ > ---

Re: [gem5-dev] Review Request 3325: syscall_emul: fix bugs for mmap2 system call and x86-32 syscalls

-- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3325/#review8005 --- On Feb. 10, 2016, 6:20 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To r

[gem5-dev] Review Request 3319: style: fix newline issue inside assert

11337:741675c2a2cf --- style: fix newline issue inside assert Diffs - src/sim/process.cc b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3319/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3321: syscall_emul: add extra debug support for syscalls

://reviews.gem5.org/r/3321/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3324: syscall_emul: extend mmap system call to support file backed mmaps

b318499f676cf960be8148635c91f4a4f20c4616 src/arch/mips/linux/linux.hh b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3324/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo

[gem5-dev] Review Request 3320: style: refactor lseek

11338:0daaa2da43af --- style: refactor lseek Diffs - src/sim/syscall_emul.cc b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3320/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

[gem5-dev] Review Request 3328: base: style cleanup for ObjectFile and ElfObject

b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3328/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3326: syscall_emul: move mmapGrowsDown() to LiveProcess

b318499f676cf960be8148635c91f4a4f20c4616 src/sim/syscall_emul.hh b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3326/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman

Re: [gem5-dev] Review Request 3326: syscall_emul: move mmapGrowsDown() to LiveProcess

> this line Thanks, missed that one. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3326/#review8000 --- On Feb. 10

[gem5-dev] Review Request 3322: syscall_emul: rename OpenFlagTransTable struct

--- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3326: syscall_emul: move mmapGrowsDown() to LiveProcess

b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3326/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3329: loader: add symbol support for dynamic libraries

b318499f676cf960be8148635c91f4a4f20c4616 src/sim/process.cc b318499f676cf960be8148635c91f4a4f20c4616 src/sim/syscall_emul.hh b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3329/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list

[gem5-dev] Review Request 3325: syscall_emul: fix bugs for mmap2 system call and x86-32 syscalls

b318499f676cf960be8148635c91f4a4f20c4616 Diff: http://reviews.gem5.org/r/3325/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3327: base: support dynamic loading of Linux ELF objects in SE mode

://reviews.gem5.org/r/3327/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

these appear to signal that a component is missing a RubySystem pointer > > when it should have one. In other cases, child classes (e.g. ports within > > other components) can have direct access to the pointer in the parent > > class, since there is sufficient encapsulation/abstraction

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

e > > there times when a NetDest will be created without a RubySystem pointer? > > > > I'm just commenting here, but there are other places too. > > Brandon Potter wrote: > I noticed that after I posted the review. I'll look into it. > > I rebased this p

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

/CacheMemory.cc 3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3113/diff/ Testing --- gem5/util/regress (to check builds) and custom tests (which use the new configuration) Thanks, Brandon Potter ___ gem5-dev mailing

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 src/mem/protocol/MESI_Three_Level-L1cache.sm 3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3113/diff/ Testing --- gem5/util/regress (to check builds) and custom tests (which use the new configuration) Thanks, Brandon Potter

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 src/mem/protocol/MESI_Two_Level-L1cache.sm 3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3113/diff/ Testing --- gem5/util/regress (to check builds) and custom tests (which use the new configuration) Thanks, Brandon Potter

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

Diff: http://reviews.gem5.org/r/3113/diff/ Testing --- gem5/util/regress (to check builds) and custom tests (which use the new configuration) Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5

Re: [gem5-dev] Review Request 3013: ruby: convert global statistical variables to local ones.

Did you have a way to obviate this? Was it even manifesting for you? - Brandon Potter On Sept. 15, 2015, 8:08 p.m., Nilay Vaish wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: [gem5-dev] Review Request 3160: ruby: move testAnd* into DataBlock and change Packet* to PacketPtr

f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3160/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3161: ruby: remove whitespace from end of lines

3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3161/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http

[gem5-dev] Review Request 3160: ruby: move testAnd* into DataBlock and change Packet* to PacketPtr

-cache.sm 3a4d1b5cd05ceed30dd0f5341fac9bbe41a193d6 Diff: http://reviews.gem5.org/r/3160/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3149: ruby: Fix block_on behavior

Can we change the tracking structure to reflect that this is really a vector of addresses for the memory controller that we should be checking instead of a map? Actually, there's only a single address with this new modification since the request will be nack'd back to the requester. - Brandon

Re: [gem5-dev] Review Request 3149: ruby: Fix block_on behavior

> On Oct. 15, 2015, 6:01 p.m., Brandon Potter wrote: > > src/mem/ruby/system/Sequencer.cc, line 393 > > <http://reviews.gem5.org/r/3149/diff/1/?file=50270#file50270line393> > > > > There's no reason that I can see why this should be a std::map. The &

Re: [gem5-dev] Review Request 3149: ruby: Fix block_on behavior

> On Oct. 10, 2015, 8:30 p.m., Nilay Vaish wrote: > > src/mem/ruby/system/Sequencer.cc, lines 180-184 > > > > > > I prefer this check being done just before insertRequest() is called. > > Joel Hestness wrote: > I

Re: [gem5-dev] Review Request 3134: ruby: combine RubyPort and Sequencer and rename as FirstLevelController

> On Sept. 24, 2015, 11:32 p.m., Brad Beckmann wrote: > > Do not check this in. I suggest you stop going in this direction. Any > > performance benefits provided by this patch do not justify the resulting > > duplicate code and downstream re-correlation and development efforts. > > There

Re: [gem5-dev] Review Request 3121: ruby: block size in RubySystem to be object specific

> On Sept. 17, 2015, 5:43 p.m., Brad Beckmann wrote: > > Do *not* check in this patch. I know I've already saidy this, but I will > > repeat, do not make further changes to the sm files until we check in our > > GPU patches. > > > > Even after we check in our GPU patches, this patch must be

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

ion protocol-independent. That might be something that I could try in the future, but not near-term. On D, I noticed this was added to the code and there didn't appear to be a good reason other than encapsulation. I'm not sure that it's even necessary. I can take a crack at

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

ume of conflicts that I had to solve. (The merge conflicts were innumerable; most of them were related to the changes to uint64, Addr, and general code refactoring.) On Sept. 15, 2015, 4:19 p.m., Brandon Potter wrote: > > Is there any way to make m_ruby_system implicit in SLICC? I really

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

g/r/3113/#comment6083> This needs to be reverted to writeAddr. - Brandon Potter On Sept. 14, 2015, 11:58 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

-- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3113/#review7185 ----------- On Sept. 14, 2015, 11:58 p.m., Brandon Potter wrote: > >

[gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

/ Testing --- gem5/util/regress (to check builds) and custom tests (which use the new configuration) Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3013: ruby: convert global statistical variables to local ones.

cleaner if necessary. - Brandon Potter On Aug. 9, 2015, 6:26 p.m., Nilay Vaish wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3076: syscall_emul: create Process output files in output dir

/#comment6020 test - Brandon Potter On Aug. 24, 2015, 6:56 a.m., Steve Reinhardt wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3076

Re: [gem5-dev] Review Request 3076: syscall_emul: create Process output files in output dir

On Aug. 27, 2015, 6:35 p.m., Brandon Potter wrote: src/sim/process.cc, line 127 http://reviews.gem5.org/r/3076/diff/1/?file=49154#file49154line127 test Sorry, Sooraj and I were talking about the Fix It and Ship It option on Reviewboard and I accidentally posted this review

[gem5-dev] Review Request 3034: base: fix small memory leak in the ELF loader

10937:05aacbf2abdf --- base: fix small memory leak in the ELF loader Diffs - src/base/loader/elf_object.cc acd48ddd725fed37a6f8354e1309907154cc3e27 Diff: http://reviews.gem5.org/r/3034/diff/ Testing --- Thanks, Brandon Potter

Re: [gem5-dev] Review Request 1608: config: Remove O3 dependencies

that it should not be possible to do what this code is trying to do. https://docs.python.org/2/whatsnew/2.1.html#pep-227-nested-scopes Is it possible to do this in a different way to get rid of the warning (and make this code work in general)? - Brandon Potter On Jan. 7, 2013, 11:31 a.m

[gem5-dev] Review Request 2992: x86: remove redundant condition check in tlb code

10936:1fa7de22dcfc --- x86: remove redundant condition check in tlb code Diffs - src/arch/x86/tlb.cc acd48ddd725fed37a6f8354e1309907154cc3e27 Diff: http://reviews.gem5.org/r/2992/diff/ Testing --- Thanks, Brandon Potter

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

:›\ ,trail:•,extends:#,nbsp:. - Brandon Potter On July 24, 2015, 4:23 p.m., Tony Gutierrez wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2991

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

On July 24, 2015, 4:47 p.m., Brandon Potter wrote: What about adding the following? set spell #set listchars=tab:›\ ,trail:•,extends:#,nbsp:. Sorry, I meant to comment out the set listchars line by default - not highlight it in Reviewboard. Both are preferences, but help to highlight

[gem5-dev] changeset in gem5: base: refactor process class (specifically Fd...

changeset ddc3d96d6313 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ddc3d96d6313 description: base: refactor process class (specifically FdMap and friends) This patch extends the previous patch's alterations around fd_map. It cleans up some of

[gem5-dev] changeset in gem5: style: change Process function calls to use c...

changeset cafae9abd4e4 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=cafae9abd4e4 description: style: change Process function calls to use camelCase The Process class methods were using an improper style and this subsequently bled into the system

[gem5-dev] changeset in gem5: syscall_emul: file descriptor interface changes

changeset b2bbfec74eca in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b2bbfec74eca description: syscall_emul: file descriptor interface changes This patch gets rid of unused Process::dup_fd method and does minor refactoring in the process class

[gem5-dev] changeset in gem5: ruby: dma sequencer: removes redundant code

changeset afe7e137943a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=afe7e137943a description: ruby: dma sequencer: removes redundant code diffstat: src/mem/ruby/system/DMASequencer.cc | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diffs (13 lines):

<    1   2   3   4   5   6   >