Yes. The review process for these patches petered out.
I remember addressing all reviewer concerns, but I never got a convincing
set of ship it's, so I didn't ask anyone to commit these patches.
I *think* most of the code that these patches apply to hasn't changed too
much. If you're interested
I want to clarify what I believe is an oversight:
With respect to functional reads, it's not really correct to just return
the first valid value found in some ruby structure.
A relaxed protocol (e.g. the quickrelease paper by Blake Hechtman et al.)
might allow two versions of a cache block to
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2471/
---
Review request for Default.
Repository: gem5
Description
---
Note: This was
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2472/
---
Review request for Default.
Repository: gem5
Description
---
Note: This was
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2593/#review5766
---
Ship it!
Looks good to me.
- Marc Orr
On Dec. 23, 2014, 2:51 p.m.,
I've been going through some of the activity on gem5-dev in reverse (as you
may have noticed :-)). This proposal seems very reasonable to me. But
someone more knowledgeable on the InOrder model and the related ISAs should
speak up.
Thanks,
Marc
On Wed, Dec 17, 2014 at 7:59 AM, Andreas Hansson via
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2589/#review5757
---
Ship it!
Not too knowledgable on this. But from a quick scan of the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2602/#review5756
---
Ship it!
Looks ok to me.
- Marc Orr
On Jan. 12, 2015, 4:10 p.m.,
On Jan. 15, 2015, 1:53 p.m., Andreas Hansson wrote:
src/mem/ruby/system/RubyPort.cc, line 195
http://reviews.gem5.org/r/2597/diff/1/?file=43318#file43318line195
The statement is changed and uses the port which we only know after
getting it from the sender state.
Ah. I missed
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2597/#review5761
---
src/mem/ruby/system/RubyPort.cc
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2588/#review5764
---
Ship it!
Given my lack of experience with the InOrder model, others
11 matches
Mail list logo
