Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On June 22, 2016, 3:41 p.m., Jason Lowe-Power wrote: > > Much cleaner! Thanks for making the changes. Is there any chance you could push this Jason? - Andreas --- This is an automatically generated e-mail. To reply, visit:

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8433 --- Ship it! Ship It! - Andreas Sandberg On June 22, 2016, 3:34 p.m.,

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/ --- (Updated Juni 22, 2016, 2:34 nachm.) Review request for Default and Andreas

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8432 --- Ship it! LGTM. Minor nit below. Thanks for the revision!

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/ --- (Updated Juni 22, 2016, 2:28 nachm.) Review request for Default and Andreas

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On Juni 15, 2016, 2:23 nachm., Andreas Sandberg wrote: > > util/tlm/tlm_elastic.py, line 126 > > > > > > This shouldn't be needed since you're not in FS mode (and you're > > simulating a trace CPU). > > Matthias Jung

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On Juni 15, 2016, 2:23 nachm., Andreas Sandberg wrote: > > Thanks for your patch! > > > > I think this config script is independant enough that you should consider > > not using the Options helper in configs/common. I would argue that it just > > creates confusion due to the large number of

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On June 15, 2016, 2:23 p.m., Andreas Sandberg wrote: > > Thanks for your patch! > > > > I think this config script is independant enough that you should consider > > not using the Options helper in configs/common. I would argue that it just > > creates confusion due to the large number of

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8408 --- Thanks for your patch! I think this config script is independant enough

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8399 --- Ship it! Ship It! - Radhika Jagtap On May 28, 2016, 7:18 p.m.,

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8394 --- Ship it! Ship It! - Paul Rosenfeld On May 28, 2016, 7:18 p.m.,

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/ --- (Updated Mai 28, 2016, 7:18 nachm.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On May 26, 2016, 10 a.m., Radhika Jagtap wrote: > > util/tlm/tlm_elastic.py, lines 141-142 > > > > > > CPU should be connected to L1 caches instead of membus. I think it > > would be best to call the

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

> On May 26, 2016, 10 a.m., Radhika Jagtap wrote: > > util/tlm/tlm_elastic.py, lines 141-142 > > > > > > CPU should be connected to L1 caches instead of membus. I think it > > would be best to call the

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8357 --- util/tlm/tlm_elastic.py (line 94)

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8342 --- Hi Matthias, thanks for integrating the elastic trace cpu system into

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8341 --- util/tlm/tlm_elastic.py (line 1)

Re: [gem5-dev] Review Request 3477: misc: SystemC Elastic Trace Player Example

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/ --- (Updated Mai 25, 2016, 10:08 nachm.) Review request for Default. Summary