[gem5-dev] changeset in gem5: dev: Use fixed size member variables to descr...

changeset 288eb5ee4b00 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=288eb5ee4b00 description: dev: Use fixed size member variables to describe fixed size PL111 registers. diffstat: src/dev/arm/pl111.hh | 24 1 files changed, 12

Re: [gem5-dev] Review Request 2513: KVM: Build in most of the KVM stuff even if we're not going to use it.

On Nov. 18, 2014, 2:54 a.m., Ali Saidi wrote: This will break compilation on non-linux platforms, so if we need something like this, it will need to have two checks, one that kvm is possible, and the other that it's enabled. However, that alone doesn't solve the problem because the

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

The member functions before_end_of_elaboration and end_of_elaboration are defined on sc_core::sc_module and the SystemC simulation kernel handles calling them at the appropriate times. Try printing something in main.cc:SimControl::before_end_of_elaboration and you should see that print

Re: [gem5-dev] Review Request 2513: KVM: Build in most of the KVM stuff even if we're not going to use it.

I haven't looked at the code in question, so I'm just going by what I've seen in this email thread. However, it seems like there ought to be some alternative solutions here. I like the general direction Andreas is going, though it would be nice to avoid more multiple inheritance :). The way I

Re: [gem5-dev] Review Request 2513: KVM: Build in most of the KVM stuff even if we're not going to use it.

Is the USE_KVM setting visible as a preprocessor directive in the C++? If so, I could use that to set the kvm pointer to NULL if KVM is turned off instead of getting it from the parameters. Then the question is how to condition adding the KVM parameter to the python version of the device.

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2491/#review5467 --- src/mem/packet.hh http://reviews.gem5.org/r/2491/#comment4917 I

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5469 --- Overall I am fine with the patch. Can we set the size to 1 when the

Re: [gem5-dev] bug? in elf loader

I checked the elf-64 draft and I think you right. But I am not able to understand why do we use p_paddr at all. Should we not be using p_vaddr everywhere? -- Nilay On Tue, 18 Nov 2014, Romana, Alexandre via gem5-dev wrote: Hi everybody, Looks to me like there is a bug/typo in

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

On Nov. 18, 2014, 3:36 p.m., Nilay Vaish wrote: src/mem/port_proxy.cc, line 80 http://reviews.gem5.org/r/2492/diff/1/?file=42518#file42518line80 Do we need this scope resolution? We do. It took me the better part of a day to track it down even... - Andreas

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

On Nov. 18, 2014, 3:44 p.m., Nilay Vaish wrote: Overall I am fine with the patch. Can we set the size to 1 when the prefetch request is being created? I don't see any harm in that. It might incur stats changes...that's my main reason for not changing anything. Perhaps it's worth

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

On Nov. 18, 2014, 3:32 p.m., Nilay Vaish wrote: src/mem/packet.hh, line 860 http://reviews.gem5.org/r/2491/diff/1/?file=42506#file42506line860 I think we can keep the function name as getPtr() and rely on the compiler to pick the right version. Also how about const_castT*

Re: [gem5-dev] Review Request 2462: mem: Page Table map api modification

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2462/#review5474 --- src/arch/x86/pagetable.hh http://reviews.gem5.org/r/2462/#comment4922

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/#review5475 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2491/#review5477 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:13 a.m., Andreas

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

On Nov. 18, 2014, 3:32 p.m., Nilay Vaish wrote: src/mem/packet.hh, line 860 http://reviews.gem5.org/r/2491/diff/1/?file=42506#file42506line860 I think we can keep the function name as getPtr() and rely on the compiler to pick the right version. Also how about const_castT*

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

I did not know about those (timely) systemc callbacks - reading about them now. Thank you for pointing them out! Cagdas On Nov 18, 2014, at 5:10 AM, Andrew Bardsley via gem5-dev gem5-dev@gem5.orgmailto:gem5-dev@gem5.org wrote: The member functions before_end_of_elaboration and

Re: [gem5-dev] [gem5-users] x86 SE mode kvm support?

Hi Mike, There are some patches ready to be committed for this to work. I expect them to be committed by the end of this week. Best regards, Alex -- Forwarded message -- From: Mike Upton via gem5-users

Re: [gem5-dev] Review Request 2513: KVM: Build in most of the KVM stuff even if we're not going to use it.

On Tue, 18 Nov 2014, Steve Reinhardt via gem5-dev wrote: I haven't looked at the code in question, so I'm just going by what I've seen in this email thread. However, it seems like there ought to be some alternative solutions here. I like the general direction Andreas is going, though it would

Re: [gem5-dev] Error while building gem5.fast on latest on copy of gem5

Here are my versions - 1) python 2.7.3 2) SCons by Steven Knight et al.: script: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on ubuntu engine: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on ubuntu engine path: ['/usr/lib/scons/SCons'] Copyright (c) 2001,

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/#review5479 --- I think there are still synchronization issues with curTick and systemc

Re: [gem5-dev] bug? in elf loader

I think there were cases where the ELF loader was used to load to actual physical addresses in FS mode. I don't remember the specifics. Gabe On Tue, Nov 18, 2014 at 8:21 AM, Nilay Vaish via gem5-dev gem5-dev@gem5.org wrote: I checked the elf-64 draft and I think you right. But I am not able

Re: [gem5-dev] Review Request 2313: kvm, x86: Adding support for SE mode execution

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2313/#review5480 --- src/arch/x86/pseudo_inst.hh http://reviews.gem5.org/r/2313/#comment4930