Re: [gem5-dev] Review Request 2593: syscall emulation: Return correct writev value

2015-01-15 Thread Marc Orr via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2593/#review5766 --- Ship it! Looks good to me. - Marc Orr On Dec. 23, 2014, 2:51 p.m.,

Re: [gem5-dev] InOrder CPU with ARM

2015-01-15 Thread Marc Orr via gem5-dev
I've been going through some of the activity on gem5-dev in reverse (as you may have noticed :-)). This proposal seems very reasonable to me. But someone more knowledgeable on the InOrder model and the related ISAs should speak up. Thanks, Marc On Wed, Dec 17, 2014 at 7:59 AM, Andreas Hansson via

Re: [gem5-dev] InOrder CPU with ARM

2015-01-15 Thread Korey Sewell via gem5-dev
I support ideas (2) and (3) by Andreas. For (1), as long as MIPS/SPARC are working for the SimpleCPUs then whoever wants to take up MIPS/SPARC for the new InOrderCPU can do so. It may also make sense to simply rename the current InOrder code to something more innocuous rather than completely

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

2015-01-15 Thread mike upton via gem5-dev
On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

2015-01-15 Thread Gabe Black via gem5-dev
On Jan. 16, 2015, 12:44 a.m., mike upton wrote: src/arch/x86/regs/misc.hh, line 922 http://reviews.gem5.org/r/2557/diff/2/?file=42949#file42949line922 really 32, 0 in the new code? Yeah, I think that should be 31, 0 - Gabe

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

2015-01-15 Thread mike upton via gem5-dev
if you go here: http://reviews.gem5.org/r/2557/ there is a 'Download Diff' button on the first active line of the review (about 3 down from the 'Review board 1.7.9') You download it, and then apply it using the method I PMed you. On Thu, Jan 15, 2015 at 4:36 PM, Amit Gaikwad

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

2015-01-15 Thread mike upton via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5769 --- src/arch/x86/regs/misc.hh http://reviews.gem5.org/r/2557/#comment5108

Re: [gem5-dev] Review Request 2603: config: arm: fix os_flags

2015-01-15 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2603/#review5760 --- Ship it! I'd suggest config, arm: Thanks for fixing this. - Andreas

Re: [gem5-dev] Review Request 2597: mem: Always use SenderState for response routing in RubyPort

2015-01-15 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2597/#review5762 --- src/mem/ruby/system/RubyPort.cc

Re: [gem5-dev] Review Request 2597: mem: Always use SenderState for response routing in RubyPort

2015-01-15 Thread Marc Orr via gem5-dev
On Jan. 15, 2015, 1:53 p.m., Andreas Hansson wrote: src/mem/ruby/system/RubyPort.cc, line 195 http://reviews.gem5.org/r/2597/diff/1/?file=43318#file43318line195 The statement is changed and uses the port which we only know after getting it from the sender state. Ah. I missed

Re: [gem5-dev] Review Request 2597: mem: Always use SenderState for response routing in RubyPort

2015-01-15 Thread Marc Orr via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2597/#review5761 --- src/mem/ruby/system/RubyPort.cc

Re: [gem5-dev] Review Request 2588: tests: Remove deprecated InOrderCPU tests

2015-01-15 Thread Marc Orr via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2588/#review5764 --- Ship it! Given my lack of experience with the InOrder model, others