[gem5-dev] Change in gem5/gem5[develop]: mem: Add Units to mem stats

2021-01-18 Thread Hoa Nguyen (Gerrit) via gem5-dev
Hoa Nguyen has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39276 ) Change subject: mem: Add Units to mem stats .. mem: Add Units to mem stats Change-Id:

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: dtb_addr is already encoding the loadAddrOffset

2021-01-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39216 ) Change subject: arch-arm: dtb_addr is already encoding the loadAddrOffset .. arch-arm: dtb_addr is

[gem5-dev] Re: Re-join debug flags headers

2021-01-18 Thread Jason Lowe-Power via gem5-dev
Thanks for bringing this up, Daniel! I don't have a strong opinion, personally. I see how this makes things a little easier for developers. No longer would we have to teach people that to add a new debug flag you both declare it in the SConscript file and include the named header file. Given that

[gem5-dev] Re: Nightly stuck

2021-01-18 Thread Giacomo Travaglini via gem5-dev
Hi all, This has been fixed and it's going to be merged today. This made me realize we might want to introduce a timeout for our regressions. A global, Jenkins level one is easy to add and doesn't require any code modifications. However a per-test timeout is probably the best approach. In

[gem5-dev] Change in gem5/gem5[develop]: sim: Add units to src/sim

2021-01-18 Thread Hoa Nguyen (Gerrit) via gem5-dev
Hoa Nguyen has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39296 ) Change subject: sim: Add units to src/sim .. sim: Add units to src/sim Change-Id:

[gem5-dev] Re: Nightly stuck

2021-01-18 Thread Bobby Bruce via gem5-dev
Thanks Giacomo, I've jumped in and added timeouts to the Nightly builds and the compiler checks. The Nightly builds will now fail (instead of just "abort", which apparently is a silent failure) after 23 hours. Most of the time the nightly builds complete within 12ish hours (though this does vary

[gem5-dev] Re: Nightly stuck

2021-01-18 Thread Jason Lowe-Power via gem5-dev
Thanks, Giacomo! We may be a bit slow to respond (it's a holiday here in the states today and Bobby is off the next couple of days). I don't think we want to do a global timeout since we have some tests that take days. The compiler test takes about 3 days, IIRC. I think per-test timeout is going

[gem5-dev] Change in gem5/gem5[develop]: base: Remove dubious/unused Flags functions

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38736 ) Change subject: base: Remove dubious/unused Flags functions .. base: Remove dubious/unused Flags functions The

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit tests for flags.hh

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38714 ) Change subject: base: Add unit tests for flags.hh .. base: Add unit tests for flags.hh Add a unit test for flags.hh.

[gem5-dev] Change in gem5/gem5[develop]: base: Rename Flags::update as Flags::replace

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38737 ) Change subject: base: Rename Flags::update as Flags::replace .. base: Rename Flags::update as Flags::replace The

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Collapse away TheISA::advancePC.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39335 ) Change subject: arch,cpu: Collapse away TheISA::advancePC. .. arch,cpu: Collapse away TheISA::advancePC. In most

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Move TheISA::copyRegs to TheISA::ISA::copyRegsFrom.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39336 ) Change subject: arch,cpu: Move TheISA::copyRegs to TheISA::ISA::copyRegsFrom. .. arch,cpu: Move

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu,kern,sim: Eliminate the utility.hh switching header.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39337 ) Change subject: arch,cpu,kern,sim: Eliminate the utility.hh switching header. .. arch,cpu,kern,sim: Eliminate

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: dtb_addr is already encoding the loadAddrOffset

2021-01-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/39216 ) Change subject: arch-arm: dtb_addr is already encoding the loadAddrOffset .. arch-arm: dtb_addr is already encoding

[gem5-dev] Change in gem5/gem5[develop]: arch: Fix the code that computes MaxMiscDestReg.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38383 ) Change subject: arch: Fix the code that computes MaxMiscDestReg. .. arch: Fix the code that computes MaxMiscDestReg. This

[gem5-dev] Change in gem5/gem5[develop]: cpu: Remove the default, globally sized index arrays from StaticInst.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38382 ) Change subject: cpu: Remove the default, globally sized index arrays from StaticInst. .. cpu: Remove the default,

[gem5-dev] Change in gem5/gem5[develop]: arch: Wrap InstObjParams with a class and not a function.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/39275 ) Change subject: arch: Wrap InstObjParams with a class and not a function. .. arch: Wrap InstObjParams with a class and not a

[gem5-dev] Change in gem5/gem5[develop]: arm: Use local src and dest reg index arrays.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38381 ) Change subject: arm: Use local src and dest reg index arrays. .. arm: Use local src and dest reg index arrays. Change-Id:

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Move getExecutingAsid to the ISA class.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39322 ) Change subject: arch,cpu: Move getExecutingAsid to the ISA class. .. arch,cpu: Move getExecutingAsid to the ISA

[gem5-dev] Change in gem5/gem5[develop]: arm: Use the "reg" ABI for gem5 ops.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39316 ) Change subject: arm: Use the "reg" ABI for gem5 ops. .. arm: Use the "reg" ABI for gem5 ops. The generic

[gem5-dev] Change in gem5/gem5[develop]: arch: Remove copyMiscRegs from utility.hh.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39325 ) Change subject: arch: Remove copyMiscRegs from utility.hh. .. arch: Remove copyMiscRegs from utility.hh. This

[gem5-dev] Nightly stuck

2021-01-18 Thread Giacomo Travaglini via gem5-dev
Hi devs, It seems like the following Nightly run #191 is stuck: https://jenkins.gem5.org/job/Nightly/191/ I am running those tests locally to understand if it is a tool problem or broken long regressions are currently broken Will keep you posted Kind Regards Giacomo IMPORTANT NOTICE: The

[gem5-dev] Change in gem5/gem5[develop]: tests: Fix syntax error in cpu_tests/test.py

2021-01-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39295 ) Change subject: tests: Fix syntax error in cpu_tests/test.py .. tests: Fix syntax error in

[gem5-dev] Change in gem5/gem5[develop]: arm,kern: Stop using the getArgument function for kernel events.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39320 ) Change subject: arm,kern: Stop using the getArgument function for kernel events. .. arm,kern: Stop using the

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Move the inUserMode function to the ISA object.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39323 ) Change subject: arch,cpu: Move the inUserMode function to the ISA object. .. arch,cpu: Move the inUserMode

[gem5-dev] Change in gem5/gem5[develop]: riscv: Export the system call ABI for use in gem5 ops.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39318 ) Change subject: riscv: Export the system call ABI for use in gem5 ops. .. riscv: Export the system call ABI for

[gem5-dev] Change in gem5/gem5[develop]: arm: Export the mostly generic syscall ABI.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39315 ) Change subject: arm: Export the mostly generic syscall ABI. .. arm: Export the mostly generic syscall ABI. This

[gem5-dev] Change in gem5/gem5[develop]: riscv: Get rid of some unused constants.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39317 ) Change subject: riscv: Get rid of some unused constants. .. riscv: Get rid of some unused constants. Change-Id:

[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate the getArgument function.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39321 ) Change subject: arch: Eliminate the getArgument function. .. arch: Eliminate the getArgument function. This ISA

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Move buildRetPC into the StaticInst class.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39324 ) Change subject: arch,cpu: Move buildRetPC into the StaticInst class. .. arch,cpu: Move buildRetPC into the

[gem5-dev] Change in gem5/gem5[develop]: sim: Eliminate the generic PseudoInstABI.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39319 ) Change subject: sim: Eliminate the generic PseudoInstABI. .. sim: Eliminate the generic PseudoInstABI. Calls to

[gem5-dev] Change in gem5/gem5[develop]: tests: Stop using memcmp in the circlebuf test.

2021-01-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38895 ) Change subject: tests: Stop using memcmp in the circlebuf test. .. tests: Stop using memcmp in the circlebuf test.