Hi,
There are several files missing license headers - is this a concern?
./dev/phoenix.importorder
./examples/STOCK_SYMBOL.csv
./examples/WEB_STAT.csv
./examples/pig/test.pig
./examples/pig/testdata
./phoenix-core/src/main/resources/java.sql.Driver
(ignoring CHANGES and rat.txt
Thanks for all the feedback. We'll spin up another RC shortly for our 3.0
and 4.0 release with the corrections to our NOTICE and LICENSE files, along
with ensuring that our source release matches the source bundle exactly.
One question: given that we'll indicate the bundled products and their
Below is our updated NOTICE (which includes the copyright for the bundled
bits) and LICENSE (minus the standard Apache 2.0 part).
Would appreciate a review.
Thanks,
James
* NOTICE **
Apache Phoenix (Incubating)
Copyright 2014 The Apache Software
On Wed, Mar 26, 2014 at 12:59 PM, James Taylor jamestay...@apache.org wrote:
Below is our updated NOTICE (which includes the copyright for the bundled
bits) and LICENSE (minus the standard Apache 2.0 part).
Would appreciate a review.
What follows is a superficial review of what I see in this
Thanks, Marvin. So remove the copyrights from NOTICE. Are they required
anywhere then, as their not in the LICENSE file?
On Wed, Mar 26, 2014 at 2:57 PM, Marvin Humphrey mar...@rectangular.comwrote:
On Wed, Mar 26, 2014 at 12:59 PM, James Taylor jamestay...@apache.org
wrote:
Below is our
Marvin -
The one example in that email thread (airavata), has a bunch of copyright
notices in there NOTICE file:
https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE
Is that correct or incorrect?
I think the reason this comes up a lot is
On 26 March 2014 22:45, James Taylor jamestay...@apache.org wrote:
Marvin -
The one example in that email thread (airavata), has a bunch of copyright
notices in there NOTICE file:
https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE
Is
On 26 March 2014 19:59, James Taylor jamestay...@apache.org wrote:
Below is our updated NOTICE (which includes the copyright for the bundled
bits) and LICENSE (minus the standard Apache 2.0 part).
Would appreciate a review.
Thanks,
James
* NOTICE
Thanks, Sebb. I added the version info and the copyright to the LICENSE
file and based on feedback from Marvin removed the copyright info from our
NOTICE file. See this thread:
+1. Downloaded the source, built the package and ran unit tests.
On Tue, Mar 25, 2014 at 9:39 AM, James Taylor jamestay...@apache.org wrote:
Hi everyone,
This is a call for a vote on Apache Phoenix 3.0.0 incubating RC1. Phoenix
is a SQL query engine for Apache HBase, a NoSQL data store. It is
Can you update your notice file? [1]
- John
[1]:
https://git-wip-us.apache.org/repos/asf?p=incubator-phoenix.git;a=blob;f=NOTICE;h=08364793ad096649eb24b3d582b2307376b25863;hb=HEAD
On Tue, Mar 25, 2014 at 2:02 PM, Devaraj Das d...@hortonworks.com wrote:
+1. Downloaded the source, built the
On 25 March 2014 18:11, John D. Ament john.d.am...@gmail.com wrote:
Can you update your notice file? [1]
Please don't; that does not look like a correct NOTICE file.
See
http://www.apache.org/dev/licensing-howto.html#simple (et seq.)
- John
[1]:
On 25 March 2014 16:39, James Taylor jamestay...@apache.org wrote:
Hi everyone,
This is a call for a vote on Apache Phoenix 3.0.0 incubating RC1. Phoenix
is a SQL query engine for Apache HBase, a NoSQL data store. It is accessed
as a JDBC driver and enables querying and managing HBase tables
What do you mean? That was Phoenix's file I was linking to.
On Tue, Mar 25, 2014 at 2:31 PM, sebb seb...@gmail.com wrote:
On 25 March 2014 18:11, John D. Ament john.d.am...@gmail.com wrote:
Can you update your notice file? [1]
Please don't; that does not look like a correct NOTICE file.
On 25 March 2014 18:56, John D. Ament john.d.am...@gmail.com wrote:
What do you mean? That was Phoenix's file I was linking to.
I realise that the file is in the Phoenix Git and is called NOTICE.
However it is not a valid NOTICE file according to:
[0]
On Tue, Mar 25, 2014 at 11:54 AM, sebb seb...@gmail.com wrote:
On 25 March 2014 16:39, James Taylor jamestay...@apache.org wrote:
[...]
The source tarball, including signatures, digests, etc can be found at:
On 25 March 2014 21:56, Andrew Purtell apurt...@apache.org wrote:
On Tue, Mar 25, 2014 at 11:54 AM, sebb seb...@gmail.com wrote:
On 25 March 2014 16:39, James Taylor jamestay...@apache.org wrote:
[...]
The source tarball, including signatures, digests, etc can be found at:
Pardon, got -bin and -src crossed mentally, indeed they are there.
Looks like src was packaged after running the RAT check. Does this require
a new RC?
On Tue, Mar 25, 2014 at 2:59 PM, sebb seb...@gmail.com wrote:
On 25 March 2014 21:56, Andrew Purtell apurt...@apache.org wrote:
On Tue,
On 25 March 2014 22:01, Andrew Purtell apurt...@apache.org wrote:
Pardon, got -bin and -src crossed mentally, indeed they are there.
Looks like src was packaged after running the RAT check. Does this require
a new RC?
If I were the RM I would respin the RC for this sort of packaging error.
James, Mujtaba, et. al.,
Can we add a Releasing page to http://phoenix.incubator.apache.org/ that
includes step by step instructions for packaging a Phoenix release. We can
fine tune this process according to feedback received during RCs. This
could/should include shell commands captured one time
Thanks for the detailed review, Sebb. We really appreciate you spending
your time going through this. Here's the list of TODOs for us:
1) In the binary bundle:
a) Fix the copy/paste error for the URL to SQLLine in the NOTICE file
in the binary bundle as noted by Gabriel here[1].
b) Change
On 25 March 2014 22:27, James Taylor jamestay...@apache.org wrote:
Thanks for the detailed review, Sebb. We really appreciate you spending
your time going through this. Here's the list of TODOs for us:
1) In the binary bundle:
a) Fix the copy/paste error for the URL to SQLLine in the
Our binary distribution bundles sqlline which has a BSD Clause 3 license.
We've included this license with the Apache 2 license in our LICENSE file.
Do we need to include sqlline in the NOTICE file?
Yes, we bundle ANTLR in our binary distribution. Most of the other items
are pulled in based on
This probably belongs in a [DISCUSS] more than in a [VOTE] thread, but in
response to Andrew's comment:
Can we add a Releasing page
to http://phoenix.incubator.apache.org/that
includes step by step instructions for packaging a Phoenix
release.
...I was wondering if this might be useful:
On 25 March 2014 23:06, James Taylor jamestay...@apache.org wrote:
Our binary distribution bundles sqlline which has a BSD Clause 3 license.
We've included this license with the Apache 2 license in our LICENSE file.
Do we need to include sqlline in the NOTICE file?
Depends on its license.
Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated
in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead
of listing these in our LICENSE file. Since all licenses are either Apache
or BSD, this should be fine.
I'm still a bit confused about one thing,
(sorry, meant instead of listing these in our NOTICE file)
On Tue, Mar 25, 2014 at 4:48 PM, James Taylor jamestay...@apache.orgwrote:
Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated
in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead
of
On 25 March 2014 23:48, James Taylor jamestay...@apache.org wrote:
Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated
in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead
of listing these in our LICENSE file. Since all licenses are either Apache
or
On Tue, Mar 25, 2014 at 5:07 PM, sebb seb...@gmail.com wrote:
HBase is ASF code surely?
So why does it need mentioning? - unless its NOTICE file has some
attributions that relate to what you are bundling
Yes, HBase is ASF code. The other stuff we've listed are the transitive
dependencies of
On 26 March 2014 00:23, James Taylor jamestay...@apache.org wrote:
On Tue, Mar 25, 2014 at 5:07 PM, sebb seb...@gmail.com wrote:
HBase is ASF code surely?
So why does it need mentioning? - unless its NOTICE file has some
attributions that relate to what you are bundling
Yes, HBase is ASF
On Tue, Mar 25, 2014 at 4:25 PM, sebb seb...@gmail.com wrote:
Yes, we bundle ANTLR in our binary distribution. Most of the other items
are pulled in based on the transitive dependencies of other jars we've
bundled in our binary distribution.
I see now why I did not notice the 3rd party
On Tue, Mar 25, 2014 at 5:28 PM, sebb seb...@gmail.com wrote:
On 26 March 2014 00:23, James Taylor jamestay...@apache.org wrote:
I think I was confused by the
http://www.apache.org/dev/licensing-howto.html#deps-of-depsinstructions.
What is confusing about that?
If it is not clear, how
On Tue, Mar 25, 2014 at 5:35 PM, Andrew Purtell apurt...@apache.org wrote:
On Tue, Mar 25, 2014 at 4:25 PM, sebb seb...@gmail.com wrote:
Yes, we bundle ANTLR in our binary distribution. Most of the other
items
are pulled in based on the transitive dependencies of other jars we've
On 26 March 2014 00:39, James Taylor jamestay...@apache.org wrote:
On Tue, Mar 25, 2014 at 5:28 PM, sebb seb...@gmail.com wrote:
On 26 March 2014 00:23, James Taylor jamestay...@apache.org wrote:
I think I was confused by the
34 matches
Mail list logo
