Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks, Sebb. I added the version info and the copyright to the LICENSE file and based on feedback from Marvin removed the copyright info from our NOTICE file. See this thread: http://mail-archives.apache.org/mod_mbox/incubator-general/201403.mbox/%3CCAAF1JdgvRpJXBetp9xCgOfE7CEwvnaVcxeE%3D-q3mNMRQq

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread sebb
On 26 March 2014 19:59, James Taylor wrote: > Below is our updated NOTICE (which includes the copyright for the bundled > bits) and LICENSE (minus the standard Apache 2.0 part). > > Would appreciate a review. > > Thanks, > James > > * NOTICE ** > > A

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread sebb
On 26 March 2014 22:45, James Taylor wrote: > Marvin - > The one example in that email thread (airavata), has a bunch of copyright > notices in there NOTICE file: > https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE > > Is that correct or

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Marvin - The one example in that email thread (airavata), has a bunch of copyright notices in there NOTICE file: https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE Is that correct or incorrect? I think the reason this comes up a lot is be

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks, Marvin. So remove the copyrights from NOTICE. Are they required anywhere then, as their not in the LICENSE file? On Wed, Mar 26, 2014 at 2:57 PM, Marvin Humphrey wrote: > On Wed, Mar 26, 2014 at 12:59 PM, James Taylor > wrote: > > Below is our updated NOTICE (which includes the copyrigh

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread Marvin Humphrey
On Wed, Mar 26, 2014 at 12:59 PM, James Taylor wrote: > Below is our updated NOTICE (which includes the copyright for the bundled > bits) and LICENSE (minus the standard Apache 2.0 part). > > Would appreciate a review. What follows is a superficial review of what I see in this email thread -- I h

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Below is our updated NOTICE (which includes the copyright for the bundled bits) and LICENSE (minus the standard Apache 2.0 part). Would appreciate a review. Thanks, James * NOTICE ** Apache Phoenix (Incubating) Copyright 2014 The Apache Software F

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks for all the feedback. We'll spin up another RC shortly for our 3.0 and 4.0 release with the corrections to our NOTICE and LICENSE files, along with ensuring that our source release matches the source bundle exactly. One question: given that we'll indicate the bundled products and their lice

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread Justin Mclean
Hi, There are several files missing license headers - is this a concern? ./dev/phoenix.importorder ./examples/STOCK_SYMBOL.csv ./examples/WEB_STAT.csv ./examples/pig/test.pig ./examples/pig/testdata ./phoenix-core/src/main/resources/java.sql.Driver (ignoring CHANGES and rat.txt files)

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 26 March 2014 00:39, James Taylor wrote: > On Tue, Mar 25, 2014 at 5:28 PM, sebb wrote: > >> On 26 March 2014 00:23, James Taylor wrote: >> > I think I was confused by the >> > http://www.apache.org/dev/licensing-howto.html#deps-of-depsinstructions. >> >> What is confusing about that? >> If i

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
On Tue, Mar 25, 2014 at 5:35 PM, Andrew Purtell wrote: > On Tue, Mar 25, 2014 at 4:25 PM, sebb wrote: > > > > Yes, we bundle ANTLR in our binary distribution. Most of the other > items > > > are pulled in based on the transitive dependencies of other jars we've > > > bundled in our binary distri

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
On Tue, Mar 25, 2014 at 5:28 PM, sebb wrote: > On 26 March 2014 00:23, James Taylor wrote: > > I think I was confused by the > > http://www.apache.org/dev/licensing-howto.html#deps-of-depsinstructions. > > What is confusing about that? > If it is not clear, how could it be made clearer? > > The

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Andrew Purtell
On Tue, Mar 25, 2014 at 4:25 PM, sebb wrote: > > Yes, we bundle ANTLR in our binary distribution. Most of the other items > > are pulled in based on the transitive dependencies of other jars we've > > bundled in our binary distribution. > > I see now why I did not notice the 3rd party binaries. >

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 26 March 2014 00:23, James Taylor wrote: > On Tue, Mar 25, 2014 at 5:07 PM, sebb wrote: >> >> >> HBase is ASF code surely? >> So why does it need mentioning? - unless its NOTICE file has some >> attributions that relate to what you are bundling >> > > Yes, HBase is ASF code. The other stuff we

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
On Tue, Mar 25, 2014 at 5:07 PM, sebb wrote: > > > HBase is ASF code surely? > So why does it need mentioning? - unless its NOTICE file has some > attributions that relate to what you are bundling > Yes, HBase is ASF code. The other stuff we've listed are the transitive dependencies of HBase. Do

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 23:48, James Taylor wrote: > Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated > in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead > of listing these in our LICENSE file. Since all licenses are either Apache > or BSD, this should be

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
(sorry, meant instead of listing these in our NOTICE file) On Tue, Mar 25, 2014 at 4:48 PM, James Taylor wrote: > Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated > in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead > of listing these in our LICEN

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
Ah, I see. Thanks, Sebb. So we should modify our LICENSE file as indicated in http://www.apache.org/dev/licensing-howto.html#permissive-deps instead of listing these in our LICENSE file. Since all licenses are either Apache or BSD, this should be fine. I'm still a bit confused about one thing, tho

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 23:06, James Taylor wrote: > Our binary distribution bundles sqlline which has a BSD Clause 3 license. > We've included this license with the Apache 2 license in our LICENSE file. > Do we need to include sqlline in the NOTICE file? Depends on its license. > Yes, we bundle ANTLR

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Andrew Phillips
This probably belongs in a [DISCUSS] more than in a [VOTE] thread, but in response to Andrew's comment: > Can we add a "Releasing" page  > to http://phoenix.incubator.apache.org/that > includes step by step instructions for packaging a Phoenix  > release. ...I was wondering if this might be usef

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
Our binary distribution bundles sqlline which has a BSD Clause 3 license. We've included this license with the Apache 2 license in our LICENSE file. Do we need to include sqlline in the NOTICE file? Yes, we bundle ANTLR in our binary distribution. Most of the other items are pulled in based on the

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 22:27, James Taylor wrote: > Thanks for the detailed review, Sebb. We really appreciate you spending > your time going through this. Here's the list of TODOs for us: > 1) In the binary bundle: > a) Fix the copy/paste error for the URL to SQLLine in the NOTICE file > in the bin

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
Thanks for the detailed review, Sebb. We really appreciate you spending your time going through this. Here's the list of TODOs for us: 1) In the binary bundle: a) Fix the copy/paste error for the URL to SQLLine in the NOTICE file in the binary bundle as noted by Gabriel here[1]. b) Change "d

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Andrew Purtell
James, Mujtaba, et. al., Can we add a "Releasing" page to http://phoenix.incubator.apache.org/ that includes step by step instructions for packaging a Phoenix release. We can fine tune this process according to feedback received during RCs. This could/should include shell commands captured one tim

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 22:01, Andrew Purtell wrote: > Pardon, got -bin and -src crossed mentally, indeed they are there. > > Looks like src was packaged after running the RAT check. Does this require > a new RC? If I were the RM I would respin the RC for this sort of packaging error. But in this case

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Andrew Purtell
Pardon, got -bin and -src crossed mentally, indeed they are there. Looks like src was packaged after running the RAT check. Does this require a new RC? On Tue, Mar 25, 2014 at 2:59 PM, sebb wrote: > On 25 March 2014 21:56, Andrew Purtell wrote: > > On Tue, Mar 25, 2014 at 11:54 AM, sebb wro

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 21:56, Andrew Purtell wrote: > On Tue, Mar 25, 2014 at 11:54 AM, sebb wrote: > >> On 25 March 2014 16:39, James Taylor wrote: >> [...] >> >> > The source tarball, including signatures, digests, etc can be found at: >> > >> https://dist.apache.org/repos/dist/dev/incubator/phoenix

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Andrew Purtell
On Tue, Mar 25, 2014 at 11:54 AM, sebb wrote: > On 25 March 2014 16:39, James Taylor wrote: > [...] > > > The source tarball, including signatures, digests, etc can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/phoenix/phoenix-3.0.0-incubating-rc1/src/ > > The source bundle

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 18:56, John D. Ament wrote: > What do you mean? That was Phoenix's file I was linking to. I realise that the file is in the Phoenix Git and is called NOTICE. However it is not a valid NOTICE file according to: [0] http://www.apache.org/dev/licensing-howto.html#simple (et seq.)

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread John D. Ament
What do you mean? That was Phoenix's file I was linking to. On Tue, Mar 25, 2014 at 2:31 PM, sebb wrote: > On 25 March 2014 18:11, John D. Ament wrote: > > Can you update your notice file? [1] > > Please don't; that does not look like a correct NOTICE file. > > See > > http://www.apache.org/de

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 16:39, James Taylor wrote: > Hi everyone, > This is a call for a vote on Apache Phoenix 3.0.0 incubating RC1. Phoenix > is a SQL query engine for Apache HBase, a NoSQL data store. It is accessed > as a JDBC driver and enables querying and managing HBase tables using SQL. > This >

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread sebb
On 25 March 2014 18:11, John D. Ament wrote: > Can you update your notice file? [1] Please don't; that does not look like a correct NOTICE file. See http://www.apache.org/dev/licensing-howto.html#simple (et seq.) > - John > > [1]: > https://git-wip-us.apache.org/repos/asf?p=incubator-phoenix.

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread John D. Ament
Can you update your notice file? [1] - John [1]: https://git-wip-us.apache.org/repos/asf?p=incubator-phoenix.git;a=blob;f=NOTICE;h=08364793ad096649eb24b3d582b2307376b25863;hb=HEAD On Tue, Mar 25, 2014 at 2:02 PM, Devaraj Das wrote: > +1. Downloaded the source, built the package and ran unit t

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread Devaraj Das
+1. Downloaded the source, built the package and ran unit tests. On Tue, Mar 25, 2014 at 9:39 AM, James Taylor wrote: > Hi everyone, > This is a call for a vote on Apache Phoenix 3.0.0 incubating RC1. Phoenix > is a SQL query engine for Apache HBase, a NoSQL data store. It is accessed > as a JDBC

[VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-25 Thread James Taylor
Hi everyone, This is a call for a vote on Apache Phoenix 3.0.0 incubating RC1. Phoenix is a SQL query engine for Apache HBase, a NoSQL data store. It is accessed as a JDBC driver and enables querying and managing HBase tables using SQL. This is the next major release of Phoenix compatible with the