Re: Karma request jakarta-site2

2003-02-26 Thread Craig R. McClanahan
On Wed, 26 Feb 2003, O'brien, Tim wrote: > Date: Wed, 26 Feb 2003 19:12:51 -0600 > From: "O'brien, Tim" <[EMAIL PROTECTED]> > Reply-To: Jakarta General List <[EMAIL PROTECTED]> > To: 'Jakarta General List' <[EMAIL PROTECTED]> > Subject: Karma request jakarta-site2 > > Was trying to add my name t

Re: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
> Historically Checkstyle focuses more on coding standards and checks > for things like Javadoc quality, brace placement, use of whitespace, > number of parameters in methods, etc. It does find unused imports and > other QA checks. > > PMD has more of a bent on analysing the meaning of the source c

Re: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
Hi Dion - I'm using JavaNCSS - http://www.kclee.com/clemens/java/javancss/ - v21.41. But I'm only scanning jakarta-turbine-maven/src/java: [EMAIL PROTECTED] jakartafun]$ find jakarta-turbine-maven/ -name "*.java" | wc -l 256 [EMAIL PROTECTED] jakartafun]$ find jakarta-tur

Karma request jakarta-site2

2003-02-26 Thread O'brien, Tim
Was trying to add my name to the whoweare.xml list. Could I get some karma? Tim O'Brien - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Another unused import statement report is out...

2003-02-26 Thread dion
Tom, how are you working out the LOC for Maven? I count approx 280 .java files in the source tree and at 4066 loc, that makes approx 15 loc per file. Either we're really efficient, or there's something being missed. -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/

Re: Another unused import statement report is out...

2003-02-26 Thread Conor MacNeill
Simon Brooke wrote: Do you have a tool for checking for unused imports? I know I have a lot of them in my code, but weeding them takes time and time is something I'm always short of... There are a few - Tom's tool, PMD, will do it, while checkstyle will also do it. Conor ---

Re: Another unused import statement report is out...

2003-02-26 Thread Oliver Burn
Simon, There are numerous tools you can use. The two main ones available are: - Checkstyle (http://checkstyle.sf.net) - PMD (http://pmd.sf.net) Historically Checkstyle focuses more on coding standards and checks for things like Javadoc quality, brace placement, use of whitespace, number of param

Re: Another unused import statement report is out...

2003-02-26 Thread Ben Walding
If you hate unused imports, eclipse (and probably some of the other newer IDEs) support organisation of imports. Simply right click on the root of your source tree, select "Organize Imports" and it's done. If you're looking for a stand-alone tool, CheckStyle is a good place to start. (There i

Re: Another unused import statement report is out...

2003-02-26 Thread Simon Brooke
On Wednesday 26 Feb 2003 7:57 pm, Tom Copeland wrote: > unused imports are down 40% since last November, crikey! > > http://cvs.apache.org/~tcopeland/jakarta_bad_imports.htm > > Past reports can be found here - http://cvs.apache.org/~tcopeland/, and > mad props to the xml-xalan project, who wen

Re: turbine-torque-user list

2003-02-26 Thread Ben Walding
http://db.apache.org/torque/mail-lists.html is a good place to start Cheers, Ben Brian McCallister wrote: I apologize for sending to this list, but both [EMAIL PROTECTED] and [EMAIL PROTECTED] (the one still listed on the Jakarta site) are bouncing right now. What is the list name (and subs

RE: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
> It gets my vote too. I'll use it on Commons projects and see if I get > complaints etc. > I had never even heard of that way of doing the tests - I mean, with a built in failure message thing - until recently when somebody suggested it as a PMD rule. It's a good idea, although I haven't actual

Re: Another unused import statement report is out...

2003-02-26 Thread Henri Yandell
On Wed, 26 Feb 2003, Daniel F. Savarese wrote: > > In message <[EMAIL PROTECTED]>, "Tom Copeland" writes: > >assertTrue("Whoa, doSomething returned a non-Fred type!", doSomething() > >instanceof Fred); > > I retract my comment about needing to do something with the variable. > Tom's comment her

RE: Another unused import statement report is out...

2003-02-26 Thread Henri Yandell
On Wed, 26 Feb 2003, Howard M. Lewis Ship wrote: > I still don't understand what the hubub about unused imports is about. I think it's clean, but if a public report is made on code and shows somethign that is wrong with the code, then I'm happy to put the effort into fixing it. Especially if th

Re: Another unused import statement report is out...

2003-02-26 Thread Daniel F. Savarese
In message <[EMAIL PROTECTED]>, "Tom Copeland" writes: >assertTrue("Whoa, doSomething returned a non-Fred type!", doSomething() >instanceof Fred); I retract my comment about needing to do something with the variable. Tom's comment here, in my opinion, is the best approach. daniel

Re: Another unused import statement report is out...

2003-02-26 Thread Daniel F. Savarese
In message <[EMAIL PROTECTED]>, Hen ri Yandell writes: >Basically. Except it's: > >Fred fred = (Fred)doSomething(); in some cases. Shouldn't you actually do something with the result as a precaution to ensure the assignment doesn't get optimized out (either by the JIT or the compiler)? (Or make

RE: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
> I still don't understand what the hubub about unused imports is about. > Tapestry is pretty clean of them, but even if it wasn't, I > wouldn't say that > code quality suffered. I mean, there's some fractional difference in > compile speed I guess, and a tiny difference in code > comprehension

RE: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
> > Perhaps test code should not be analysed at all. In > HttpClient we are > rigorus about imports (and style in general) in production > code, but are > more lax in test code. Not that test code is in anyway > unimportant, but > just has a different purpose than production code. > Yup,

RE: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
> > Basically. Except it's: > > Fred fred = (Fred)doSomething(); in some cases. > Hmmm it seems like that local variable is unnecessary if it's not being used later on if this is a JUnit test and it's meant to ensure a certain type is return, seems like this: assertTrue("Whoa, doSomet

RE: Another unused import statement report is out...

2003-02-26 Thread Howard M. Lewis Ship
I still don't understand what the hubub about unused imports is about. Tapestry is pretty clean of them, but even if it wasn't, I wouldn't say that code quality suffered. I mean, there's some fractional difference in compile speed I guess, and a tiny difference in code comprehension that is comple

Re: Another unused import statement report is out...

2003-02-26 Thread Jeffrey Dever
Perhaps test code should not be analysed at all. In HttpClient we are rigorus about imports (and style in general) in production code, but are more lax in test code. Not that test code is in anyway unimportant, but just has a different purpose than production code. Henri Yandell wrote: On We

RE: Another unused import statement report is out...

2003-02-26 Thread Henri Yandell
On Wed, 26 Feb 2003, Tom Copeland wrote: > Hi Henri - > > Hm, I'm sorry, I don't understand the TestCase thing... are you doing > something like: > > import junit.framework.*; > public class FooTest extends TestCase { > public void testFiddle() { > Object obj = doSomething(); > } > } > > or

RE: Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
Hi Henri - Hm, I'm sorry, I don't understand the TestCase thing... are you doing something like: import junit.framework.*; public class FooTest extends TestCase { public void testFiddle() { Object obj = doSomething(); } } or something else? I'll email you the unused imports for taglibs offl

Re: Another unused import statement report is out...

2003-02-26 Thread Henri Yandell
Anyway of turning off the: "Avoid unused local variables such as 'obj'" for classes which extend TestCase? It's not something to avoid in a TestCase, as it tests the type of the returned value. These warnings make it hard to see the real problems. Even if it's only a grep for TestCase.java and

Another unused import statement report is out...

2003-02-26 Thread Tom Copeland
unused imports are down 40% since last November, crikey! http://cvs.apache.org/~tcopeland/jakarta_bad_imports.htm Past reports can be found here - http://cvs.apache.org/~tcopeland/, and mad props to the xml-xalan project, who went from 1421 unused imports to 2 in the last month. Yours, Tom

RE: turbine-torque-user list

2003-02-26 Thread Quinton McCombs
[EMAIL PROTECTED] > -Original Message- > From: Brian McCallister [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 26, 2003 7:35 AM > To: Jakarta General List > Subject: turbine-torque-user list > > > I apologize for sending to this list, but both > [EMAIL PROTECTED] and > [EMAIL

turbine-torque-user list

2003-02-26 Thread Brian McCallister
I apologize for sending to this list, but both [EMAIL PROTECTED] and [EMAIL PROTECTED] (the one still listed on the Jakarta site) are bouncing right now. What is the list name (and subscribe request) addy for torque users now? Thanks, Brian -

Re: New Project

2003-02-26 Thread Henri Gomez
Federico wrote: Hi, we are five italian programmers and we have finished some days ago "Puff", a http cache proxy written in java that have some interesting features like a spider that prefetch the web links and an option to convert all images to black and white one to have a speeder connection