Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-06 Thread Alfredo Tupone
On 23:45 Thu 05 Sep , Mike Gilbert wrote: > On Thu, Sep 5, 2019 at 6:47 PM Thomas Deutschmann wrote: > > > > On 2019-09-05 22:16, Michał Górny wrote: > > >> But as per the way the dev manual is written, he arguably *is* > > >> following policy. > > >> > > >> Stop taking the line of assuming

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Michał Górny
On Fri, 2019-09-06 at 00:47 +0200, Thomas Deutschmann wrote: > On 2019-09-05 22:16, Michał Górny wrote: > > > But as per the way the dev manual is written, he arguably *is* > > > following policy. > > > > > > Stop taking the line of assuming he's trying to be belligerent. > > > > He says

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Mike Gilbert
On Wed, Sep 4, 2019 at 7:26 PM Thomas Deutschmann wrote: > If you want to make it clear, change "should" to "must" and maybe > clarify per-package exception and limit to update case if you believe > that really *all* *new* eclasses must be send to mailing list. As a native English

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Mike Gilbert
On Thu, Sep 5, 2019 at 6:47 PM Thomas Deutschmann wrote: > > On 2019-09-05 22:16, Michał Górny wrote: > >> But as per the way the dev manual is written, he arguably *is* > >> following policy. > >> > >> Stop taking the line of assuming he's trying to be belligerent. > > > > He says explicitly

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Thomas Deutschmann
On 2019-09-05 22:16, Michał Górny wrote: >> But as per the way the dev manual is written, he arguably *is* >> following policy. >> >> Stop taking the line of assuming he's trying to be belligerent. > > He says explicitly that he is against fixing devmanual because he likes > the way he can abuse

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Michał Górny
On Fri, 2019-09-06 at 08:08 +1200, Kent Fredric wrote: > On Thu, 05 Sep 2019 21:47:11 +0200 > Michał Górny wrote: > > > So to summarize, instead of working together in order to follow a well- > > established policy, > > You're reading it wrong. If its "established policy", dev manual must >

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Kent Fredric
On Thu, 05 Sep 2019 21:47:11 +0200 Michał Górny wrote: > So to summarize, instead of working together in order to follow a well- > established policy, You're reading it wrong. If its "established policy", dev manual must reflect that. If the dev-manual writes "should" in one place, and implies

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Michał Górny
On Thu, 2019-09-05 at 15:14 +0200, Thomas Deutschmann wrote: > On 2019-09-05 06:02, Michał Górny wrote: > > > In my case I am working on a new mysql eclass to outsource pkg_config > > > function which is shared at least between dev-db/mysql and > > > dev-db/percona-server (and maybe

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread James Le Cuirot
On Fri, 6 Sep 2019 07:26:42 +1200 Kent Fredric wrote: > On Thu, 5 Sep 2019 09:04:23 -0500 > Gordon Pettey wrote: > > > You'll note the bit you quoted in defense of skipping review says > > "changes", and the bit about new eclasses says "do not skip this step". > > Emphasis added: > > -

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Kent Fredric
On Thu, 5 Sep 2019 09:04:23 -0500 Gordon Pettey wrote: > You'll note the bit you quoted in defense of skipping review says > "changes", and the bit about new eclasses says "do not skip this step". Emphasis added: - BEFORE committing a NEW eclass to the tree, it SHOULD be emailed to the

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Gordon Pettey
On Thu, Sep 5, 2019 at 8:15 AM Thomas Deutschmann wrote: > On 2019-09-05 06:02, Michał Górny wrote: > >> In my case I am working on a new mysql eclass to outsource pkg_config > >> function which is shared at least between dev-db/mysql and > >> dev-db/percona-server (and maybe dev-db/mariadb). >

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-05 Thread Thomas Deutschmann
On 2019-09-05 06:02, Michał Górny wrote: >> In my case I am working on a new mysql eclass to outsource pkg_config >> function which is shared at least between dev-db/mysql and >> dev-db/percona-server (and maybe dev-db/mariadb). >> >> For this new eclass I would say it's a "per-package" eclass and

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-04 Thread Michał Górny
On Thu, 2019-09-05 at 01:26 +0200, Thomas Deutschmann wrote: > Hi, > > On 2019-09-04 20:59, Michał Górny wrote: > > Devmanual is pretty clear on the fact that *all* new eclasses require ml > > ^^^ > > review *before* committing: > > I am

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-04 Thread Thomas Deutschmann
Hi, On 2019-09-04 20:59, Michał Górny wrote: > Devmanual is pretty clear on the fact that *all* new eclasses require ml > ^^^ > review *before* committing: I am also working on a new eclass so I looked up details regarding what's needed

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2019-09-04 Thread David Seifert
On Wed, 2019-09-04 at 20:59 +0200, Michał Górny wrote: > On Wed, 2019-09-04 at 18:00 +, Alfredo Tupone wrote: > > commit: 63486fef43c2e0dee3b4128db18fd1a6b4bf9381 > > Author: Tupone Alfredo gentoo org> > > AuthorDate: Wed Sep 4 17:58:49 2019 + > > Commit: Alfredo Tupone

Re: Implicit use of versionator.eclass in ebuilds and eclasses (was: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/)

2018-05-18 Thread M. J. Everitt
On 19/05/18 01:01, Andreas Sturmlechner wrote: > On Freitag, 18. Mai 2018 23:53:06 CEST Michał Górny wrote: >> One of the reasons we do mailing list reviews of widely used eclasses is >> to let people tell you that you've left 'version_is_at_least' here. > I see the error of my ways. > >

Implicit use of versionator.eclass in ebuilds and eclasses (was: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/)

2018-05-18 Thread Andreas Sturmlechner
On Freitag, 18. Mai 2018 23:53:06 CEST Michał Górny wrote: > One of the reasons we do mailing list reviews of widely used eclasses is > to let people tell you that you've left 'version_is_at_least' here. I see the error of my ways. Meanwhile, here's a list of packages implicitly using

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread Luis Ressel
On Sun, 21 May 2017 10:46:25 -0700 Raymond Jennings wrote: > Just out of curiosity, and for the curious: > > 1. How often do cache updates happen? > 2. How long do they take? > 3. Is there any downside to only having one such update running at a > time and just skipping

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread M. J. Everitt
On 21/05/17 20:32, Kent Fredric wrote: > But I'd also like a pony. > I'm hoping for a unicorn still ... [apologies, resending as hit the wrong button in the Compose button..] signature.asc Description: OpenPGP digital signature

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread M. J. Everitt
binsSfjd9wdyD.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread Kent Fredric
On Sun, 21 May 2017 19:34:26 +0200 Michał Górny wrote: > Like, by not using eclasses and instead inlining all the stuff? I'd personally suggest we endeavour towards making systems in place so that the performance overheads of metadata generation is much lower, to the point it

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread Raymond Jennings
On Tue, May 16, 2017 at 12:20 PM, Michał Górny wrote: > Mike, > > I would really appreciate if you cared to follow procedures for eclass > changes. Most notably, if you at least bothered to either ping us *or* > sent the patch to the mailing list beforehand. > > This eclass is

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread Michał Górny
On nie, 2017-05-21 at 11:29 -0500, William Hubbs wrote: > On Sun, May 21, 2017 at 02:46:54PM +, Martin Vaeth wrote: > > Kent Fredric wrote: > > > Fabian Groffen wrote: > > > > > > > Hardware or more deltas to > > > > download by users? Just

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread William Hubbs
On Sun, May 21, 2017 at 02:46:54PM +, Martin Vaeth wrote: > Kent Fredric wrote: > > Fabian Groffen wrote: > > > >> Hardware or more deltas to > >> download by users? Just wondering. > > > > Both. > > > > - End users using git end up having to do

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2017-05-21 Thread Kent Fredric
On Tue, 16 May 2017 21:36:15 +0200 Fabian Groffen wrote: > Hardware or more deltas to > download by users? Just wondering. Both. - End users using git end up having to do massive metadata-updates. - Infra needs to have massive hits to metadata regeneration - End users

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-16 Thread Andreas K. Huettel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Montag, 16. Mai 2016, 18:21:27 schrieb Andrew Savchenko: > > Everyone can and will make mistakes, this is normal. Only those who > do nothing make no mistakes. I see no reason why developer should > be discouraged from contributing for a single

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-16 Thread Andrew Savchenko
On Mon, 16 May 2016 10:05:33 +0100 Ciaran McCreesh wrote: > On Mon, 16 May 2016 15:56:01 +0800 > Ian Delaney wrote: > > As long as this persists and is not intervened to polish and tidy up, > > g-devs will persist in making innocent, naive or incompetent blunders > > and run

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-16 Thread Ciaran McCreesh
On Mon, 16 May 2016 15:56:01 +0800 Ian Delaney wrote: > As long as this persists and is not intervened to polish and tidy up, > g-devs will persist in making innocent, naive or incompetent blunders > and run the gauntlet of being publicly scolded over errata. I can only >

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-16 Thread Aaron Bauman
On Monday, May 16, 2016 3:56:01 PM JST Ian Delaney wrote: > On Sat, 14 May 2016 21:04:17 -0400 > Rich Freeman wrote: > > I hope I won't regret this > > > On Sat, May 14, 2016 at 8:23 PM, Aaron Bauman wrote: > > > On Sunday, May 15, 2016 12:48:12 AM JST Ciaran

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-16 Thread Consus
On 15:56 Mon 16 May, Ian Delaney wrote: > On Sat, 14 May 2016 21:04:17 -0400 > Rich Freeman wrote: > > I hope I won't regret this > > > On Sat, May 14, 2016 at 8:23 PM, Aaron Bauman wrote: > > > On Sunday, May 15, 2016 12:48:12 AM JST Ciaran McCreesh wrote:

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread M. J. Everitt
On 15/05/16 23:55, Duncan wrote: > Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted: > >> If the dev in question hasn't done that before, then it's entirely >> possible they *thought* they tested, or tested it *before* making some >> other edit and absent-mindedly committed.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Rich Freeman
On Sun, May 15, 2016 at 6:46 PM, Duncan <1i5t5.dun...@cox.net> wrote: > > Committing without testing, as long as you don't push, is fine, even > meritorious. It's the push that uploads those commits to the gentoo > reference repo, however, and testing should *definitely* be done before > pushing,

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Daniel Campbell
On 05/15/2016 03:55 PM, Duncan wrote: > Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted: > >> If the dev in question hasn't done that before, then it's entirely >> possible they *thought* they tested, or tested it *before* making some >> other edit and absent-mindedly

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Andreas K. Huettel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Sonntag, 15. Mai 2016, 11:53:27 schrieb Ryan Hill: > > I thought his response was pretty tame actually. If you break the tree > because you couldn't be bothered to do the barest minimum of testing you > absolutely deserve to be called out on

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Brian Dolbec
On Sun, 15 May 2016 04:18:39 -0700 Daniel Campbell wrote: > On 05/15/2016 02:15 AM, Brian Dolbec wrote: > > On Sun, 15 May 2016 11:05:21 +0200 > > Jeroen Roovers wrote: > > > >> On Sat, 7 May 2016 23:25:58 +0200 > >> Michał Górny wrote: >

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Daniel Campbell
On 05/15/2016 02:15 AM, Brian Dolbec wrote: > On Sun, 15 May 2016 11:05:21 +0200 > Jeroen Roovers wrote: > >> On Sat, 7 May 2016 23:25:58 +0200 >> Michał Górny wrote: >> >>> Do you seriously expect this code to work? How about testing? Or >>> reading diffs

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Daniel Campbell
On 05/15/2016 03:29 AM, Michał Górny wrote: > On Sun, 15 May 2016 08:40:39 +0900 > Aaron Bauman wrote: > >> On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: >>> On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: On Friday, May 13, 2016

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Daniel Campbell
On 05/15/2016 02:53 AM, Ryan Hill wrote: > On Sun, 15 May 2016 08:40:39 +0900 > Aaron Bauman wrote: > >> On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: >>> On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: On Friday, May 13, 2016 4:52:09

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Daniel Campbell
On 05/14/2016 01:23 PM, Rich Freeman wrote: > On Sat, May 14, 2016 at 3:21 PM, M. J. Everitt wrote: >> On 14/05/16 18:52, Rich Freeman wrote: >>> On Sat, May 14, 2016 at 1:07 PM, landis blackwell >>> wrote: No fun allowed >>> Are you

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Michał Górny
On Sun, 15 May 2016 08:40:39 +0900 Aaron Bauman wrote: > On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: > > On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: > > > On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: > > >> On Sat, 7

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Brian Dolbec
On Sun, 15 May 2016 11:05:21 +0200 Jeroen Roovers wrote: > On Sat, 7 May 2016 23:25:58 +0200 > Michał Górny wrote: > > > Do you seriously expect this code to work? How about testing? Or > > reading diffs before committing? > > > Somebody could have a go

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-15 Thread Jeroen Roovers
On Sat, 7 May 2016 23:25:58 +0200 Michał Górny wrote: > Do you seriously expect this code to work? How about testing? Or > reading diffs before committing? Somebody could have a go at implementing this: https://bugs.gentoo.org/show_bug.cgi?id=390651 It's been brewing for

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 15/05/16 02:04, Rich Freeman wrote: > On Sat, May 14, 2016 at 8:23 PM, Aaron Bauman wrote: >> On Sunday, May 15, 2016 12:48:12 AM JST Ciaran McCreesh wrote: >>> On Sun, 15 May 2016 08:40:39 +0900 >>> >>> Aaron Bauman wrote: Please enlighten me as to what

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 15/05/16 01:59, Rich Freeman wrote: > On Sat, May 14, 2016 at 7:40 PM, Aaron Bauman wrote: >> Please enlighten me as to what was impolite here? The strong language of >> "seriously" or definitively stating that the individual did not perform the >> necessary QA actions before

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 8:23 PM, Aaron Bauman wrote: > On Sunday, May 15, 2016 12:48:12 AM JST Ciaran McCreesh wrote: >> On Sun, 15 May 2016 08:40:39 +0900 >> >> Aaron Bauman wrote: >> > Please enlighten me as to what was impolite here? The strong >> > language

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 7:40 PM, Aaron Bauman wrote: > > Please enlighten me as to what was impolite here? The strong language of > "seriously" or definitively stating that the individual did not perform the > necessary QA actions before committing? He actually didn't "state"

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Aaron Bauman
On Sunday, May 15, 2016 12:48:12 AM JST Ciaran McCreesh wrote: > On Sun, 15 May 2016 08:40:39 +0900 > > Aaron Bauman wrote: > > Please enlighten me as to what was impolite here? The strong > > language of "seriously" or definitively stating that the individual > > did not

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Ciaran McCreesh
On Sun, 15 May 2016 08:40:39 +0900 Aaron Bauman wrote: > Please enlighten me as to what was impolite here? The strong > language of "seriously" or definitively stating that the individual > did not perform the necessary QA actions before committing? Both of > which are

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Aaron Bauman
On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: > On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: > > On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: > >> On Sat, 7 May 2016 23:25:58 +0200 > >> > >> Michał Górny wrote: > >> > Do

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 3:21 PM, M. J. Everitt wrote: > On 14/05/16 18:52, Rich Freeman wrote: >> On Sat, May 14, 2016 at 1:07 PM, landis blackwell >> wrote: >>> No fun allowed >>> >> Are you saying that you don't want people to have fun developing

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Andreas K. Huettel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Samstag, 14. Mai 2016, 18:59:02 schrieb M. J. Everitt: > > I think the time is coming, given the diversity of members of this list, > to add tags when we are not describing something > literally. wouldnt a tag be sufficient? - -- Andreas

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 14/05/16 18:52, Rich Freeman wrote: > On Sat, May 14, 2016 at 1:07 PM, landis blackwell > wrote: >> No fun allowed >> > Are you saying that you don't want people to have fun developing > Gentoo? Or are you trying to say that it is impossible to have fun > developing

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 1:07 PM, landis blackwell wrote: > No fun allowed > Are you saying that you don't want people to have fun developing Gentoo? Or are you trying to say that it is impossible to have fun developing Gentoo without insulting strangers? I don't

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread landis blackwell
No fun allowed On May 14, 2016 12:06 PM, "Rich Freeman" wrote: > On Sat, May 14, 2016 at 12:59 PM, M. J. Everitt > wrote: > > On 14/05/16 17:53, Chí-Thanh Christopher Nguyễn wrote: > >> Gordon Pettey schrieb: > >> > >>> So, it's perfectly okay to make

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 14/05/16 18:06, Rich Freeman wrote: > > While this is certainly sensible, the irony here is that this whole > discussion was started by somebody making a sarcastic remark when > simply pointing out a mistake would have been just as functional. > > Nobody thinks it is ok to commit broken code.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 12:59 PM, M. J. Everitt wrote: > On 14/05/16 17:53, Chí-Thanh Christopher Nguyễn wrote: >> Gordon Pettey schrieb: >> >>> So, it's perfectly okay to make direct commits of obviously broken >>> code that >>> has no chance of working, because community

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 14/05/16 17:53, Chí-Thanh Christopher Nguyễn wrote: > Gordon Pettey schrieb: > >> So, it's perfectly okay to make direct commits of obviously broken >> code that >> has no chance of working, because community something mumble... > > You may have missed some sarcasm in the post which you replied

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Chí-Thanh Christopher Nguyễn
Gordon Pettey schrieb: So, it's perfectly okay to make direct commits of obviously broken code that has no chance of working, because community something mumble... You may have missed some sarcasm in the post which you replied to. Plus, I don't think anybody said or implied that committing

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Gordon Pettey
On Sat, May 14, 2016 at 6:35 AM, Ciaran McCreesh < ciaran.mccre...@googlemail.com> wrote: > Why? Gentoo is about the community. Requiring a basic standard of commit > quality a) reduces the number of community members who are able to > contribute, 2) leads to fewer forums posts discussing how to

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Rich Freeman
On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: > On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: >> On Sat, 7 May 2016 23:25:58 +0200 >> Michał Górny wrote: >> > >> > Do you seriously expect this code to work? How about testing? Or >> > reading

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Aaron Bauman
On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: > On Sat, 7 May 2016 23:25:58 +0200 > Michał Górny wrote: > > > > Do you seriously expect this code to work? How about testing? Or > > reading diffs before committing? > > Absolutely nothing wrong was said here.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread M. J. Everitt
On 14/05/16 12:35, Ciaran McCreesh wrote: > On Sat, 14 May 2016 11:55:42 +0200 >> Am Freitag, 13. Mai 2016, 10:52:09 schrieb Ian Delaney: >>> On Sat, 7 May 2016 23:25:58 +0200 Do you seriously expect this code to work? How about testing? Or reading diffs before committing? >>> Do you

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Ciaran McCreesh
On Sat, 14 May 2016 11:55:42 +0200 > Am Freitag, 13. Mai 2016, 10:52:09 schrieb Ian Delaney: > > On Sat, 7 May 2016 23:25:58 +0200 > > > Do you seriously expect this code to work? How about testing? Or > > > reading diffs before committing? > > > > Do you seriously expect us to sit and absorb

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-14 Thread Andreas K. Huettel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Freitag, 13. Mai 2016, 10:52:09 schrieb Ian Delaney: > On Sat, 7 May 2016 23:25:58 +0200 > > > > Do you seriously expect this code to work? How about testing? Or > > reading diffs before committing? > > Do you seriously expect us to sit and

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-13 Thread Ian Delaney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Sat, 7 May 2016 23:25:58 +0200 Michał Górny wrote: > On Sat, 7 May 2016 21:19:31 + (UTC) > "Joerg Bornkessel" wrote: > > > commit: 66afcab271f65b97330e610040ad3acc1b812a03 > > Author:

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-05-09 Thread Doug Goldstein
On 5/7/16 4:25 PM, Michał Górny wrote: > On Sat, 7 May 2016 21:19:31 + (UTC) > "Joerg Bornkessel" wrote: > >> commit: 66afcab271f65b97330e610040ad3acc1b812a03 >> Author: Joerg Bornkessel gentoo org> >> AuthorDate: Sat May 7 21:18:48 2016 + >> Commit:

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-17 Thread Luca Barbato
On 18/04/16 00:50, Anthony G. Basile wrote: > Does base-system object if I bump it to EAPI=5 before I commit the > ssl-cert patch? I'll start stabilization too obviously. > Please do.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-17 Thread Anthony G. Basile
On 4/17/16 4:28 AM, Anthony G. Basile wrote: > On 4/17/16 4:15 AM, Fabian Groffen wrote: >> On 16-04-2016 21:05:56 +0200, Michał Górny wrote: >>> Congratulations! You've just committed an invalid dependency that is >>> going to cause true mayhem on every package using the eclass. >> >> I assume

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-17 Thread Anthony G. Basile
On 4/17/16 4:15 AM, Fabian Groffen wrote: > On 16-04-2016 21:05:56 +0200, Michał Górny wrote: >> Congratulations! You've just committed an invalid dependency that is >> going to cause true mayhem on every package using the eclass. > > I assume you've taken proper actions to mitigate this. > >>

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 6:46 PM, Mike Gilbert wrote: > On Sat, Apr 16, 2016 at 6:36 PM, Rich Freeman wrote: >> On Sat, Apr 16, 2016 at 6:24 PM, Mike Gilbert wrote: >>> >>> And I don't really see the point in the libressl USE flag in this >>> case; I think that was only

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 6:36 PM, Rich Freeman wrote: > On Sat, Apr 16, 2016 at 6:24 PM, Mike Gilbert wrote: >> >> And I don't really see the point in the libressl USE flag in this >> case; I think that was only needed so the slot-operator would resolve >> correctly. >> > > Somebody else

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Mike Gilbert
On Sat, Apr 16, 2016 at 6:36 PM, Rich Freeman wrote: > On Sat, Apr 16, 2016 at 6:24 PM, Mike Gilbert wrote: >> >> And I don't really see the point in the libressl USE flag in this >> case; I think that was only needed so the slot-operator would resolve >>

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Rich Freeman
On Sat, Apr 16, 2016 at 6:24 PM, Mike Gilbert wrote: > > And I don't really see the point in the libressl USE flag in this > case; I think that was only needed so the slot-operator would resolve > correctly. > Somebody else may be better informed, but I thought that there was

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Mike Gilbert
On Sat, Apr 16, 2016 at 3:31 PM, Anthony G. Basile wrote: > On 4/16/16 3:27 PM, Anthony G. Basile wrote: >> On 4/16/16 3:05 PM, Michał Górny wrote: >>> On Sat, 16 Apr 2016 19:01:02 + (UTC) >>> "Anthony G. Basile" wrote: >> >> Okay for review. Sorry

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 3:18 PM, Anthony G. Basile wrote: > On 4/16/16 3:16 PM, Rich Freeman wrote: >> On Sat, Apr 16, 2016 at 3:05 PM, Michał Górny wrote: >>> >>> Congratulations! ... But why would anyone... >> >> Not really picking on you in particular, but this is not the first >> snarky

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 3:27 PM, Anthony G. Basile wrote: > On 4/16/16 3:05 PM, Michał Górny wrote: >> On Sat, 16 Apr 2016 19:01:02 + (UTC) >> "Anthony G. Basile" wrote: > > Okay for review. Sorry for the wrap. > > diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass >

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 3:05 PM, Michał Górny wrote: > On Sat, 16 Apr 2016 19:01:02 + (UTC) > "Anthony G. Basile" wrote: Okay for review. Sorry for the wrap. diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass index 002de76..fc2debd 100644 --- a/eclass/ssl-cert.eclass +++

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 3:16 PM, Rich Freeman wrote: > On Sat, Apr 16, 2016 at 3:05 PM, Michał Górny wrote: >> >> Congratulations! ... But why would anyone... > > Not really picking on you in particular, but this is not the first > snarky comment on a commit we've seen today. > > If

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Rich Freeman
On Sat, Apr 16, 2016 at 3:05 PM, Michał Górny wrote: > > Congratulations! ... But why would anyone... Not really picking on you in particular, but this is not the first snarky comment on a commit we've seen today. If somebody makes a mistake, just point it out. I think we

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2016-04-16 Thread Anthony G. Basile
On 4/16/16 3:05 PM, Michał Górny wrote: > On Sat, 16 Apr 2016 19:01:02 + (UTC) > "Anthony G. Basile" wrote: > >> commit: ad0c2ab2bdbd34f4550e49c56cfd5974d6a2c07a >> Author: Anthony G. Basile gentoo org> >> AuthorDate: Sat Apr 16 19:08:23 2016 + >> Commit:

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-17 Thread Rich Freeman
On Tue, Nov 17, 2015 at 3:37 PM, Raymond Jennings wrote: > As a possibly relevant side note, I've observed how api changes are handled > in the linux kernel: > > You can change whatever you want if it's a good idea, but as part of proving > it, you have to be willing to take

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-17 Thread Raymond Jennings
As a possibly relevant side note, I've observed how api changes are handled in the linux kernel: You can change whatever you want if it's a good idea, but as part of proving it, you have to be willing to take over the warranty for anything you break. So basically you change what you please ONLY

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-17 Thread Mike Pagano
On Tuesday, November 17, 2015 08:19:29 AM Michał Górny wrote: > On Mon, 16 Nov 2015 23:38:08 + (UTC) > > "Mike Pagano" wrote: > > commit: aac24917ebe254a23990f0d7fff9f6f570b99d15 > > Author: Mike Pagano gentoo org> Thanks for the review and feedback. Applied

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-16 Thread Rich Freeman
On Mon, Nov 16, 2015 at 4:52 AM, Alexis Ballier wrote: > On Mon, 16 Nov 2015 10:29:43 +0100 > "Justin Lecher (jlec)" wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> On 16/11/15 10:14, Alexis Ballier wrote: >> > Probably those that want

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-16 Thread Justin Lecher (jlec)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 16/11/15 10:01, Alexis Ballier wrote: > On Fri, 13 Nov 2015 23:53:05 + (UTC) "Michał Górny" > wrote: > >> commit: ad4c142684afb096e8fff2937ae5c5c3385dd22e Author: >> Michał Górny gentoo org> AuthorDate: Fri Nov >>

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-16 Thread Alexis Ballier
On Mon, 16 Nov 2015 10:06:17 +0100 "Justin Lecher (jlec)" wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 16/11/15 10:01, Alexis Ballier wrote: > > On Fri, 13 Nov 2015 23:53:05 + (UTC) "Michał Górny" > > wrote: > > > >> commit:

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-16 Thread Alexis Ballier
On Mon, 16 Nov 2015 10:29:43 +0100 "Justin Lecher (jlec)" wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 16/11/15 10:14, Alexis Ballier wrote: > > Probably those that want to ban it should fix the(ir) tree so that > > developers have no pain in bumping to

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-16 Thread Justin Lecher (jlec)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 16/11/15 10:14, Alexis Ballier wrote: > Probably those that want to ban it should fix the(ir) tree so that > developers have no pain in bumping to eapi6? Versioned APIs are made to have incompatible changes. What do you like to see? Someone

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-11 Thread Michał Górny
On Tue, 10 Nov 2015 18:53:03 -0500 Mike Frysinger wrote: > On 31 Oct 2015 09:08, Michał Górny wrote: > > On Sat, 31 Oct 2015 03:06:21 -0400 Mike Frysinger wrote: > > > On 30 Oct 2015 18:20, Michał Górny wrote: > > > > On Fri, 30 Oct 2015 12:03:59 + (UTC) "Justin

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-11 Thread Luca Barbato
On 11/11/15 10:09, Michał Górny wrote: > I'd rather use the old standard 80. Minus 8 characters for friendly > e-mail quoting, which is also kinda 'old standard'. You can suggest as above, with this tone, and probably you would get some consensus. Personally I think 80col is nice since you can

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-10 Thread Mike Frysinger
On 31 Oct 2015 09:08, Michał Górny wrote: > On Sat, 31 Oct 2015 03:06:21 -0400 Mike Frysinger wrote: > > On 30 Oct 2015 18:20, Michał Górny wrote: > > > On Fri, 30 Oct 2015 12:03:59 + (UTC) "Justin Lecher" wrote: > > > > --- a/eclass/distutils-r1.eclass > > > > +++

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-01 Thread Ian Delaney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 30 Oct 2015 18:20:08 +0100 Michał Górny wrote: > On Fri, 30 Oct 2015 12:03:59 + (UTC) > "Justin Lecher" wrote: > > > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > > Author: Justin Lecher

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-10-31 Thread Mike Frysinger
On 30 Oct 2015 18:20, Michał Górny wrote: > On Fri, 30 Oct 2015 12:03:59 + (UTC) "Justin Lecher" wrote: > > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > > Author: Justin Lecher gentoo org> > > AuthorDate: Fri Oct 30 10:18:05 2015 + > > Commit: Justin Lecher gentoo

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-10-31 Thread Gregory Woodbury
Grammar and style police are everywhere! This week are they shooting themselves in the foot over some totally trivial and meaningless extra characters somewhere on a line? Is it a case of "#TriviaDoesntMatter"? AFAICT the limitations on line lengths are are ANCIENT holdovers from days of fixed

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-10-09 Thread Alexis Ballier
On Fri, 9 Oct 2015 17:32:22 +0200 hasufell wrote: > On 10/09/2015 01:17 PM, Alexis Ballier wrote: > > commit: 5220bb29741e1685b42a6312c0b7bf2821672040 > > Author: Alexis Ballier gentoo org> > > AuthorDate: Fri Oct 9 11:16:38 2015 + > > Commit: Alexis

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-10-09 Thread hasufell
On 10/09/2015 06:21 PM, Alexis Ballier wrote: >> Ofc, I will expect people to jump in and say "the council hasn't >> decided on that yet", but well... it mostly works fine and is not >> really controversial. > > not sure if council approval is needed; uniformity and consistency is > way more