Re: [gentoo-portage-dev] [PATCH] sync-rsync-openpgp-key-path -> generic sync-openpgp-key-path

2018-01-30 Thread Zac Medico
On 01/30/2018 10:56 AM, Michał Górny wrote: > W dniu wto, 30.01.2018 o godzinie 09∶32 -0800, użytkownik Zac Medico > napisał: >> On 01/30/2018 08:59 AM, Michał Górny wrote: >>> Rename the 'sync-rsync-openpgp-key-path' to a more generic >>> 'sync-openpgp-key-path'. Op

Re: [gentoo-portage-dev] [PATCH v2] rsync: Fix *-verify-metamanifest boolean parsing

2018-01-30 Thread Zac Medico
On 01/30/2018 11:18 AM, Michał Górny wrote: > Fix sync-rsync-verify-metamanifest to correctly parse yes|no. Also > correct the manpage to use those two terms as they were the ones used > in repos.conf and the news item. > --- > man/portage.5 | 4 ++-- >

Re: [gentoo-portage-dev] [PATCH] rsync: Fix *-verify-metamanifest boolean parsing

2018-01-30 Thread Zac Medico
On 01/30/2018 10:53 AM, Michał Górny wrote: > Fix sync-rsync-verify-metamanifest to correctly parse yes|no. Also > correct the manpage to use those two terms as they were the ones used > in repos.conf and the news item. > --- > man/portage.5 | 4 ++-- >

Re: [gentoo-portage-dev] [PATCH v3] install-qa-check: New QA check/cleanup for empty directories

2018-01-30 Thread Zac Medico
On 01/30/2018 10:18 AM, Zac Medico wrote: > On 01/29/2018 11:23 PM, Michał Górny wrote: >> Warn about empty directories installed to /var in install-qa-check phase >> (that were not "filled" using keepdir), to help developers stop relying >> upon Portage pre

Re: [gentoo-portage-dev] [PATCH v3] install-qa-check: New QA check/cleanup for empty directories

2018-01-30 Thread Zac Medico
On 01/29/2018 11:23 PM, Michał Górny wrote: > Warn about empty directories installed to /var in install-qa-check phase > (that were not "filled" using keepdir), to help developers stop relying > upon Portage preserving them. Those directories are rather unlikely to > be false positives. > >

Re: [gentoo-portage-dev] [PATCH] sync-rsync-openpgp-key-path -> generic sync-openpgp-key-path

2018-01-30 Thread Zac Medico
On 01/30/2018 08:59 AM, Michał Górny wrote: > Rename the 'sync-rsync-openpgp-key-path' to a more generic > 'sync-openpgp-key-path'. OpenPGP is the basis of at least three > different verification schemes (git, rsync, snapshots) and at least > two of them use the same keys. > --- > cnf/repos.conf

Re: [gentoo-portage-dev] [PATCH] rsync: Support overriding number of jobs for verification

2018-01-30 Thread Zac Medico
On 01/30/2018 08:54 AM, Michał Górny wrote: > Requested by Ulrich Müller. > --- > man/portage.5 | 4 > pym/portage/sync/modules/rsync/__init__.py | 1 + > pym/portage/sync/modules/rsync/rsync.py| 5 + > 3 files changed, 10 insertions(+) > > diff --git

Re: [gentoo-portage-dev] Re: [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-29 Thread Zac Medico
On 01/29/2018 07:29 PM, Duncan wrote: > Zac Medico posted on Sun, 28 Jan 2018 22:21:48 -0800 as excerpted: > >> On 01/28/2018 09:49 PM, Zac Medico wrote: >>>> 3) Show a NOTE telling users about --changed-deps=y >>> >>> This is in the HINT section,

[gentoo-portage-dev] [PATCH v4] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
The --dynamic-deps=n default causes confusion for users that are accustomed to dynamic deps, therefore add a --changed-deps-report option that is enabled by default (if --usepkgonly is not enabled). The report is entirely suppressed in the following cases in which the packages with changed

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
On 01/28/2018 09:49 PM, Zac Medico wrote: >> 3) Show a NOTE telling users about --changed-deps=y > > This is in the HINT section, which is displayed if both --changed-deps > and --dynamic-deps are disabled in PATCH v2. Actually, the whole report should be suppressed if either

[gentoo-portage-dev] [PATCH v3] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
The --dynamic-deps=n default causes confusion for users that are accustomed to dynamic deps, therefore add a --changed-deps-report option that is enabled by default (if --usepkgonly is not enabled). The report is entirely suppressed if none of the packages with changed dependencies are in the

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
On 01/28/2018 08:34 PM, Alec Warner wrote: > > > On Sun, Jan 28, 2018 at 8:10 PM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > On 01/28/2018 04:17 PM, Michael Orlitzky wrote: > > Since ::gentoo is the only repositor

[gentoo-portage-dev] [PATCH v2] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
The --dynamic-deps=n default causes confusion for users that are accustomed to dynamic deps, therefore add a --changed-deps-report option that is enabled by default (if --usepkgonly is not enabled). The --quiet option will suppress the report if none of the packages having changed dependencies

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
On 01/28/2018 04:17 PM, Michael Orlitzky wrote: > Since ::gentoo is the only repository governed by the PMS, can't we make > repoman do this? The problem with requiring "repoman --force" for an > in-place dependency change is that repoman generally won't have access > to the unedited ebuild; but

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
On 01/28/2018 09:35 AM, Alec Warner wrote: > > > On Sun, Jan 28, 2018 at 9:51 AM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > The --dynamic-deps=n default causes confusion for users that are > accustomed to dynamic deps, ther

[gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Zac Medico
The --dynamic-deps=n default causes confusion for users that are accustomed to dynamic deps, therefore add a --changed-deps-report option that is enabled by default (if --usepkgonly is not enabled). The --quiet option will suppress the report if none of the packages having changed dependencies

Re: [gentoo-portage-dev] [PATCH v2] install-qa-check: New QA check/cleanup for empty directories

2018-01-28 Thread Zac Medico
On 01/28/2018 01:50 AM, Michał Górny wrote: > Warn about empty directories installed to /var in install-qa-check phase > (that were not "filled" using keepdir), to help developers stop relying > upon Portage preserving them. Those directories are rather unlikely to > be false positives. > >

Re: [gentoo-portage-dev] [PATCH v2 2/2] doebuild: Remove unnecessary restore of PORTAGE_ACTUAL_DISTDIR

2018-01-27 Thread Zac Medico
On 01/27/2018 02:02 AM, Michał Górny wrote: > Now that the DISTDIR override does not leak to global settings instance, > there is no need to restore it afterwards. Suggested by Zac Medico. > --- > pym/portage/package/ebuild/doebuild.py | 5 - > 1 file changed, 5 deletions(-

Re: [gentoo-portage-dev] [PATCH] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Zac Medico
On 01/27/2018 01:38 AM, Zac Medico wrote: > On 01/27/2018 01:01 AM, Michał Górny wrote: >> Fix the duplicate override of DISTDIR that happens when using >> the 'ebuild' tool to run ebuilds. In this case, both the 'config' >> code and the 'prepare_build_dirs' code attem

Re: [gentoo-portage-dev] [PATCH] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Zac Medico
On 01/27/2018 01:01 AM, Michał Górny wrote: > Fix the duplicate override of DISTDIR that happens when using > the 'ebuild' tool to run ebuilds. In this case, both the 'config' > code and the 'prepare_build_dirs' code attempt to replace DISTDIR, > and the shadow distdir symlinks end up pointing to

Re: [gentoo-portage-dev] [PATCH 8/8] eshowkw: Always group Prefix keywords last

2018-01-26 Thread Zac Medico
On 01/26/2018 12:47 AM, Michał Górny wrote: > Dnia 26 stycznia 2018 06:45:25 CET, Zac Medico <zmed...@gentoo.org> > napisał(a): >> On 01/23/2018 03:25 PM, Alec Warner wrote: >>> >>> >>> On Tue, Jan 23, 2018 at 4:48 PM, Michał Górny <mgo...@

Re: [gentoo-portage-dev] Re: [PATCH v2 3/3] _emerge.Ebuild*: delay creating DISTDIR shadow until src_unpack

2018-01-25 Thread Zac Medico
On 01/25/2018 10:42 PM, Michał Górny wrote: > W dniu czw, 25.01.2018 o godzinie 21∶30 -0800, użytkownik Zac Medico > napisał: >> On 01/25/2018 01:11 AM, Michał Górny wrote: >>> W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael >>> Haubenwallner napisał

Re: [gentoo-portage-dev] [PATCH 8/8] eshowkw: Always group Prefix keywords last

2018-01-25 Thread Zac Medico
On 01/23/2018 03:25 PM, Alec Warner wrote: > > > On Tue, Jan 23, 2018 at 4:48 PM, Michał Górny > wrote: > > Always group all Prefix keywords after other types of keywords. This > not only ensures that fbsd sorts first but more importantly

Re: [gentoo-portage-dev] Re: [PATCH v2 3/3] _emerge.Ebuild*: delay creating DISTDIR shadow until src_unpack

2018-01-25 Thread Zac Medico
On 01/25/2018 01:11 AM, Michał Górny wrote: > W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael > Haubenwallner napisał: >> Hi, >> >> ${Subject} ringing a bell here: >> >> dev-db/oracle-instantclient is fetch restricted. As a binary package with >> multiple USE options there's a

Re: [gentoo-portage-dev] [PATCH v4] rsync: Introduce support for running full-tree gemato verification

2018-01-24 Thread Zac Medico
On 01/24/2018 01:36 PM, Michał Górny wrote: > Add two new configuration options to rsync repositories: > sync-rsync-verify-metamanifest and sync-rsync-openpgp-key-path. > The first controls whether gemato verification is run for > the repository (defaults to true for ::gentoo, false otherwise), >

Re: [gentoo-portage-dev] [PATCH] rsync: Introduce support for running full-tree gemato verification

2018-01-24 Thread Zac Medico
On 01/24/2018 01:03 PM, Michał Górny wrote: > diff --git a/pym/portage/sync/modules/rsync/rsync.py > b/pym/portage/sync/modules/rsync/rsync.py > index c80641ba3..f3157d093 100644 > --- a/pym/portage/sync/modules/rsync/rsync.py > +++ b/pym/portage/sync/modules/rsync/rsync.py > @@ -1,4 +1,4 @@ > -#

Re: [gentoo-portage-dev] Plan for initial integration of gemato with portage

2018-01-24 Thread Zac Medico
On 01/24/2018 12:56 AM, Michał Górny wrote: > Hi, everyone. > > Since the initial review of my patch lost focus, and lacked sufficient > context, here's the plan that I'd like to follow in order to initially > integrate gemato with portage and give our users secure checkouts by default. > > 1.

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: fix virtual/rust handling (bug 645416)

2018-01-23 Thread Zac Medico
On 01/23/2018 03:11 PM, Alec Warner wrote: > I'm starting to be a bit sad about this for a couple of reasons. > > 1) dep_zapdeps is pretty big at this point, and every tweak for || () > just grows it. Do we have any idea: >   a) When dep_zapdeps will be 'done'? We're gradually approaching a

[gentoo-portage-dev] [PATCH] dep_zapdeps: fix virtual/rust handling (bug 645416)

2018-01-22 Thread Zac Medico
Fix the code from bug 643974 to set the installed_downgrade flag only if the selected newer package is either installed or in the graph. This is currently needed for appropriate handling of virtual/rust-1.19.0, since there's an upgrade to dev-lang/rust-1.23.0 available which may not be desired

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: exclude virtuals from new_slot_count (bug 645190)

2018-01-20 Thread Zac Medico
On 01/20/2018 07:26 PM, Alec Warner wrote: > On Sat, Jan 20, 2018 at 7:41 PM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > On 01/20/2018 04:23 PM, Alec Warner wrote: > > On Sat, Jan 20, 2018 at 7:10 PM, Zac Medico <z

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: exclude virtuals from new_slot_count (bug 645190)

2018-01-20 Thread Zac Medico
On 01/20/2018 04:23 PM, Alec Warner wrote: > On Sat, Jan 20, 2018 at 7:10 PM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > diff --git a/pym/portage/dep/dep_check.py b/pym/portage/dep/dep_check.py > index 7cf338819..c56f545ec 100644

[gentoo-portage-dev] [PATCH] dep_zapdeps: exclude virtuals from new_slot_count (bug 645190)

2018-01-20 Thread Zac Medico
Fix new_slot_count to exclude virtual packages, since they are considered to have zero-cost. This solves an issue where the catalyst stage1 build would unexpectedly pull in static-dev to satisfy virtual/dev-manager, but eudev is the preferred choice. Bug: https://bugs.gentoo.org/645190 Fixes:

[gentoo-portage-dev] [PATCH] dep_zapdeps: prefer choices with fewer new slots (bug 645002)

2018-01-19 Thread Zac Medico
Prefer choices with fewer new slots, rather than choices with the lowest total number of slots. This fixes a case triggered by the catalyst stage1 build, where paludis was selected to satisfy perl-cleaner dependencies because that choice happened to have a smaller number of slots: || ( (

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-18 Thread Zac Medico
On 01/16/2018 08:43 AM, Michał Górny wrote: > Include a repo.postsync.d hook to verify the rsync checkout using > gemato. Given that not all people will want to have it enabled > unconditionally, no setup.py rules are included -- instead, the file > would be installed conditionally by the ebuild.

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Zac Medico
On 01/17/2018 01:31 PM, Zac Medico wrote: > On 01/17/2018 01:09 PM, Michał Górny wrote: >> W dniu śro, 17.01.2018 o godzinie 12∶50 -0800, użytkownik Zac Medico >> napisał: >>> >>> The thing is, this pubring.gpg path tightly couples the hook to gentoo-keys. >>

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Zac Medico
On 01/17/2018 01:09 PM, Michał Górny wrote: > W dniu śro, 17.01.2018 o godzinie 12∶50 -0800, użytkownik Zac Medico > napisał: >> >> The thing is, this pubring.gpg path tightly couples the hook to gentoo-keys. >> I'd feel much more comfortable about including it with portage

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Zac Medico
On 01/17/2018 07:42 AM, Alec Warner wrote: > On Wed, Jan 17, 2018 at 10:25 AM, Michał Górny <mgo...@gentoo.org > <mailto:mgo...@gentoo.org>> wrote: > > W dniu wto, 16.01.2018 o godzinie 11∶32 -0800, użytkownik Zac Medico > napisał: > > On 01/16/

Re: [gentoo-portage-dev] [PATCH] ebuild: allow RESTRICT=network-sandbox in ebuilds

2018-01-16 Thread Zac Medico
On 01/16/2018 08:32 PM, Mike Gilbert wrote: > On Tue, Jan 16, 2018 at 4:46 PM, Mike Frysinger wrote: >> From: Mike Frysinger >> >> Some ebuilds are a bit hard to fix their use of the network in src >> phases, so allow them to disable things. This allows

Re: [gentoo-portage-dev] [PATCH v2] ebuild: allow RESTRICT=network-sandbox in ebuilds

2018-01-16 Thread Zac Medico
On 01/16/2018 02:19 PM, Mike Frysinger wrote: > From: Mike Frysinger > > Some ebuilds are a bit hard to fix their use of the network in src > phases, so allow them to disable things. This allows us to turn off > access by default and for the vast majority while we work out

Re: [gentoo-portage-dev] [PATCH] ebuild: allow RESTRICT=network-sandbox in ebuilds

2018-01-16 Thread Zac Medico
On 01/16/2018 01:46 PM, Mike Frysinger wrote: > From: Mike Frysinger > > Some ebuilds are a bit hard to fix their use of the network in src > phases, so allow them to disable things. This allows us to turn off > access by default and for the vast majority while we work out

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Zac Medico
On 01/16/2018 10:39 AM, Michał Górny wrote: > W dniu wto, 16.01.2018 o godzinie 12∶44 -0500, użytkownik Alec Warner > napisał: >> On Tue, Jan 16, 2018 at 11:43 AM, Michał Górny wrote: >> >>> Include a repo.postsync.d hook to verify the rsync checkout using >>> gemato. Given

[gentoo-portage-dev] [PATCH] bin/doins.py: avoid timestamp precision loss with python2 (bug 642632)

2018-01-14 Thread Zac Medico
Since conversion to/from float results in timestamp precision loss with less than Python 3.3, do not use the python implementation in this case. Bug: https://bugs.gentoo.org/642632 Fixes: d459f05ff71f ("bin/doins.py: implement install -p option (bug 642632)") --- bin/doins.py | 4 1 file

Re: [gentoo-portage-dev] [PATCH v2 2/2] man/ebuild.5: document the rationale for using keepdir over dodir.

2018-01-13 Thread Zac Medico
On 01/12/2018 02:56 PM, Michael Orlitzky wrote: > --- > man/ebuild.5 | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/man/ebuild.5 b/man/ebuild.5 > index 28e9582d1..8784a14ee 100644 > --- a/man/ebuild.5 > +++ b/man/ebuild.5 > @@ -1285,8 +1285,9 @@ Sets the root

Re: [gentoo-portage-dev] [PATCH v2 1/2] man/ebuild.5: document that dodir is for nonempty directories.

2018-01-13 Thread Zac Medico
On 01/12/2018 02:56 PM, Michael Orlitzky wrote: > --- > man/ebuild.5 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/ebuild.5 b/man/ebuild.5 > index 42a0599fe..28e9582d1 100644 > --- a/man/ebuild.5 > +++ b/man/ebuild.5 > @@ -1271,7 +1271,8 @@ Creates directories

Re: [gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

2018-01-13 Thread Zac Medico
On 01/13/2018 12:50 AM, Michał Górny wrote: > Switch the Portage defaults to the new Gentoo hash set. We're already > far past the initial testing and I have been approached by a few people > who were surprised that Portage does not use new hashes for overlays. > Switching the defaults will remove

Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-11 Thread Zac Medico
On 01/11/2018 05:43 AM, Michał Górny wrote: > W dniu śro, 10.01.2018 o godzinie 14∶56 -0800, użytkownik Zac Medico > napisał: >> On 01/10/2018 02:24 PM, Michał Górny wrote: >>> Enable repoman checks on exp profiles by default to improve >>> the dependency graph integr

Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-10 Thread Zac Medico
On 01/10/2018 02:24 PM, Michał Górny wrote: > Enable repoman checks on exp profiles by default to improve > the dependency graph integrity on those profiles and help them on their > way towards stable status. This is possible now that the dependency > graph problems are warnings rather than

Re: [gentoo-portage-dev] [PATCH v2] install-qa-check: Do not install empty directories

2018-01-10 Thread Zac Medico
On 01/10/2018 01:15 PM, Michael Orlitzky wrote: > On 01/10/2018 03:55 PM, Zac Medico wrote: >>> >>> This is going to break a lot of packages whose build systems create e.g. >>> /var/lib/foo and do nothing with it immediately. The ebuild should be >>> callin

Re: [gentoo-portage-dev] [PATCH v2] install-qa-check: Do not install empty directories

2018-01-10 Thread Zac Medico
On 01/10/2018 12:39 PM, Michael Orlitzky wrote: > On 01/10/2018 03:13 PM, Michał Górny wrote: >> Remove empty directories in install-qa-check phase in order to prevent >> Portage from installing them, and therefore from developers relying >> on them being installed. > > This is going to break a

Re: [gentoo-portage-dev] [PATCH] install-qa-check: Do not install empty directories

2018-01-10 Thread Zac Medico
On 01/10/2018 12:13 PM, Michał Górny wrote: > W dniu śro, 10.01.2018 o godzinie 11∶55 -0500, użytkownik Alec Warner > napisał: >> Please link to documentation on keepdir (e.g. >> https://devmanual.gentoo.org/function-reference/install-functions/index.html) >> in the helper? >> >> I'm not sure

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-10 Thread Zac Medico
On 01/10/2018 09:00 AM, Alec Warner wrote: > The code lgtm. Thanks! > Slightly unsure if we need an entirely new test, as opposed to just > generalizing the test cases (like you did the code). But either way is > probably fine. Well, it seems like the only benefit of combining the tests

[gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-09 Thread Zac Medico
Prefer to install a new package in order to allow upgrade of an installed package. This generalizes the code from bug 635540 so that it both allows desirable upgrades and prevents unwanted downgrades. Fixes: 7c58e3737616 ("dep_zapdeps: install new package, avoid downgrade (bug 635540)") Bug:

Re: [gentoo-portage-dev] [PATCH 2/2] sys-apps/portage: exclude /var/tmp/ccache from tmpfiles cleanup

2018-01-01 Thread Zac Medico
On 01/01/2018 05:00 PM, Mike Gilbert wrote: > On Mon, Jan 1, 2018 at 6:23 PM, Zac Medico <zmed...@gentoo.org> wrote: >> On 12/31/2017 07:22 AM, Mike Gilbert wrote: >>> By default, systemd-tmpfiles removes files older than 30 days from /var/tmp. >>> The default po

Re: [gentoo-portage-dev] [PATCH v2] bin/doins.py: implement install -p option (bug 642632)

2018-01-01 Thread Zac Medico
On 12/31/2017 11:55 AM, Alec Warner wrote: > On Fri, Dec 29, 2017 at 7:19 PM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > Bug: https://bugs.gentoo.org/642632 > --- > [PATCH v2] fix to copy atime, and split out _set_tim

[gentoo-portage-dev] [PATCH v3] bin/doins.py: implement install -p option (bug 642632)

2018-01-01 Thread Zac Medico
Bug: https://bugs.gentoo.org/642632 --- [PATCH v3] update _is_install_allowed docstring to specify that source_stat should be obtained with stat() rather than lstat() bin/doins.py| 34 +- pym/portage/tests/bin/test_doins.py | 6 --

Re: [gentoo-portage-dev] [PATCH 2/2] sys-apps/portage: exclude /var/tmp/ccache from tmpfiles cleanup

2018-01-01 Thread Zac Medico
On 12/31/2017 07:22 AM, Mike Gilbert wrote: > By default, systemd-tmpfiles removes files older than 30 days from /var/tmp. > The default portage config sets CCACHE_DIR=/var/tmp/ccache. > > Bug: https://bugs.gentoo.org/490676#c14 > Package-Manager: Portage-2.3.19_p3, Repoman-2.3.6_p37 > --- >

Re: [gentoo-portage-dev] [PATCH v2] bin/doins.py: implement install -p option (bug 642632)

2017-12-30 Thread Zac Medico
On 12/30/2017 01:45 PM, Mike Gilbert wrote: > On Fri, Dec 29, 2017 at 7:19 PM, Zac Medico <zmed...@gentoo.org> wrote: >> +def _set_timestamps(source_stat, dest): >> + """Apply timestamps from source_stat to dest. >> + >> + A

Re: [gentoo-portage-dev] [PATCH] bin/doins.py: implement install -p option (bug 642632)

2017-12-29 Thread Zac Medico
On 12/29/2017 02:13 PM, Mike Gilbert wrote: > On Fri, Dec 29, 2017 at 3:35 PM, Zac Medico <zmed...@gentoo.org> wrote: >> + if self._parsed_options.preserve_timestamps: >> + if sys.

[gentoo-portage-dev] [PATCH v2] bin/doins.py: implement install -p option (bug 642632)

2017-12-29 Thread Zac Medico
Bug: https://bugs.gentoo.org/642632 --- [PATCH v2] fix to copy atime, and split out _set_timestamps function bin/doins.py| 28 +--- pym/portage/tests/bin/test_doins.py | 6 -- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git

[gentoo-portage-dev] [PATCH] bin/doins.py: implement install -p option (bug 642632)

2017-12-29 Thread Zac Medico
Bug: https://bugs.gentoo.org/642632 --- bin/doins.py| 13 ++--- pym/portage/tests/bin/test_doins.py | 4 ++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/bin/doins.py b/bin/doins.py index 92e450979..dceffee83 100644 --- a/bin/doins.py +++

[gentoo-portage-dev] [PATCH] Handle binary package IUSE_IMPLICIT divergence (bug 640318)

2017-12-10 Thread Zac Medico
Since profile IUSE_IMPLICIT settings may diverge from those that a binary package was built with, consider members of built USE settings to be members of IUSE_EFFECTIVE. Only do this for EAPIs that support IUSE_EFFECTIVE, since built USE settings for earlier EAPIs may contain a large number of

Re: [gentoo-portage-dev] [PATCH] depgraph: eval disjunctive build deps earlier (bug 639346)

2017-12-07 Thread Zac Medico
On 12/04/2017 10:22 AM, Brian Dolbec wrote: > On Sun, 3 Dec 2017 15:19:44 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Since built-time deps tend to be a superset of run-time deps, evaluate >> disjunctive build-time deps before run-time deps, so that cho

Re: [gentoo-portage-dev] Re: Is portage (/usr)/bin-merge safe?

2017-12-07 Thread Zac Medico
On 12/07/2017 12:37 AM, Duncan wrote: > Zac Medico posted on Fri, 31 May 2013 22:49:02 -0700 as excerpted: > >> On 05/31/2013 10:36 PM, Duncan wrote: >>> As in subject, is portage bin/usr-bin merge safe? >>> >>> It appears most of my clashing files are /us

Re: [gentoo-portage-dev] [PATCH] [checksum] Do not use secure memory for pygcrypt backend

2017-12-05 Thread Zac Medico
On 12/05/2017 12:00 PM, Michał Górny wrote: > Disable using secure memory for pygcrypt backend since we are not > processing secrets. This can avoid the libgcrypt memory error; however, > it turned out to be a huge memory/resource leak which needs to be fixed > independently. > --- >

Re: [gentoo-portage-dev] [PATCH] xtermTitle: support st (simple terminal)

2017-12-04 Thread Zac Medico
On 12/04/2017 12:16 AM, Christoph Böhmwalder wrote: > On Mon, Dec 04, 2017 at 06:27:39AM +0100, Christoph Böhmwalder wrote: >> Maybe we should be using the 'stterm' symlinks instead? >> >> -- >> Regards, >> Christoph > > Uh, actually that doesn't make any sense, since the $TERM variable is >

[gentoo-portage-dev] [PATCH] depgraph: eval disjunctive build deps earlier (bug 639346)

2017-12-03 Thread Zac Medico
Since built-time deps tend to be a superset of run-time deps, evaluate disjunctive build-time deps before run-time deps, so that choices for build-time deps influence choices for run-time deps. Also, fix OnlydepsMinimalTestCase to specify ambiguous_merge_order, since the merge order is affected

Re: [gentoo-portage-dev] [PATCH v3]] versions: Drop non-PMS "cvs." prefix in ${PV}

2017-11-28 Thread Zac Medico
On 11/27/2017 03:01 PM, g...@malth.us wrote: > From: "Gregory M. Turner" > > This feature was introduced 12 years ago in (the cvs commit > corresponding to the git commit) 9f3a46665c. There are a lot > of reasons not to keep it around: > > o PMS permits no such prefix in

Re: [gentoo-portage-dev] [PATCH] portage.manifest: Fix mis-parsing Manifests with numerical checksums

2017-11-19 Thread Zac Medico
On 11/19/2017 09:12 AM, Michał Górny wrote: > Fix the regular expression used to parse Manifests not to fail horribly > when one of the checksums accidentally happens to be all-digits. > > The previously used regular expression used to greedily take everything > up to the first number as

Re: [gentoo-portage-dev] [PATCH] dep_check: use DNF to optimize overlapping virtual || deps (bug 632026)

2017-11-13 Thread Zac Medico
On 11/13/2017 01:11 PM, Alec Warner wrote: > > > On Sun, Nov 12, 2017 at 6:48 AM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > diff --git a/pym/portage/dep/_dnf.py b/pym/portage/dep/_dnf.py > new file mode 100644

[gentoo-portage-dev] [PATCH] vardbapi.removeFromContents: update NEEDED (bug 637284)

2017-11-12 Thread Zac Medico
When removing files from CONTENTS, also remove the corresponding lines from NEEDED, so that they do not corrupt LinkageMap data for preserve-libs. Bug: https://bugs.gentoo.org/637284 --- pym/portage/dbapi/vartree.py | 42 -- 1 file changed, 40

[gentoo-portage-dev] [PATCH] dep_check: use DNF to optimize overlapping virtual || deps (bug 632026)

2017-11-12 Thread Zac Medico
Deps like these: || ( foo bar ) || ( bar baz ) Translate to disjunctive normal form (DNF): || ( ( foo bar ) ( foo baz ) ( bar bar ) ( bar baz ) ) Using DNF, if none of the packages are currently installed, then the ( bar bar ) choice will be automatically preferred since it is satisfied by

Re: [gentoo-portage-dev] repos.conf: suppport for syncing from branch/tag

2017-11-09 Thread Zac Medico
On 11/09/2017 06:54 AM, Joakim Tjernlund wrote: > Hi Portage guys > > Looking at repos.conf I do not see a way to pull from a particular > branch (or tag). Maybe I am missing something or it could be added? Yeah we don't have support for that yet. It will use the default branch, but you can

Re: [gentoo-portage-dev] [PATCH v2] Make manifest-required-hashes configurable

2017-11-07 Thread Zac Medico
On 11/07/2017 12:31 PM, Michał Górny wrote: > The set of required hashes specify which hashes must be present for > a distfile not to be refetched. It makes little sense to hardcode this > value, and it is mostly useful for transition periods, so make it > configurable via layout.conf and default

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-07 Thread Zac Medico
On 11/06/2017 10:23 AM, Michał Górny wrote: > W dniu pon, 06.11.2017 o godzinie 08∶52 -0800, użytkownik Zac Medico > napisał: >> On 11/06/2017 08:47 AM, Michał Górny wrote: >>> W dniu pon, 06.11.2017 o godzinie 08∶44 -0800, użytkownik Zac Medico >>> napisał: >&

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-06 Thread Zac Medico
On 11/06/2017 08:47 AM, Michał Górny wrote: > W dniu pon, 06.11.2017 o godzinie 08∶44 -0800, użytkownik Zac Medico > napisał: >> On 11/06/2017 07:27 AM, Michał Górny wrote: >>> @@ -148,15 +147,21 @@ class Manifest(object): >>> self.pkgdir = _unicod

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-06 Thread Zac Medico
On 11/06/2017 07:27 AM, Michał Górny wrote: > @@ -148,15 +147,21 @@ class Manifest(object): > self.pkgdir = _unicode_decode(pkgdir).rstrip(os.sep) + os.sep > self.fhashdict = {} > self.hashes = set() > + self.required_hashes = set() > >

Re: [gentoo-portage-dev] [PATCH 3/3] Remove last traces of Manifest1 code

2017-11-06 Thread Zac Medico
On 11/06/2017 12:14 AM, Michał Górny wrote: > --- > pym/portage/const.py| 1 - > pym/portage/manifest.py | 7 ++- > 2 files changed, 2 insertions(+), 6 deletions(-) This patch series looks good. Please merge. -- Thanks, Zac signature.asc Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, avoid downgrade (bug 635540)

2017-11-02 Thread Zac Medico
On 11/02/2017 07:56 AM, Brian Dolbec wrote: > On Thu, 2 Nov 2017 02:21:14 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Prefer to install a new package rather than to downgrade an >> installed package. If the installed package should be >> downgraded d

[gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, avoid downgrade (bug 635540)

2017-11-02 Thread Zac Medico
Prefer to install a new package rather than to downgrade an installed package. If the installed package should be downgraded due to it being masked, then allow the downgrade. Bug: https://bugs.gentoo.org/635540 --- pym/portage/dep/dep_check.py | 11 ++-

Re: [gentoo-portage-dev] [PATCH v5] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-11-01 Thread Zac Medico
On 11/01/2017 09:31 AM, Brian Dolbec wrote: > On Tue, 24 Oct 2017 11:41:37 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> The sendfile *offset parameter refers to the input file offest, so >> it cannot be used in the same way as the copy_file_range *off_out &

Re: [gentoo-portage-dev] [PATCH] postinst_qa_check: initialize preinst state (bug 635474)

2017-10-26 Thread Zac Medico
On 10/26/2017 12:31 PM, Michał Górny wrote: > W dniu śro, 25.10.2017 o godzinie 23∶16 -0700, użytkownik Zac Medico > napisał: >> In order to prevent false-positives during postinst_qa_check, >> use a preinst_qa_check function to initialize a baseline state >> for the po

[gentoo-portage-dev] [PATCH 2/2] postinst-qa-check.d: fix parallel-install to skip QA Noticre

2017-10-26 Thread Zac Medico
--- bin/postinst-qa-check.d/50gnome2-utils | 3 +++ bin/postinst-qa-check.d/50xdg-utils| 6 ++ 2 files changed, 9 insertions(+) diff --git a/bin/postinst-qa-check.d/50gnome2-utils b/bin/postinst-qa-check.d/50gnome2-utils index 80360cf64..dacc19a43 100644 ---

[gentoo-portage-dev] [PATCH] postinst_qa_check: initialize preinst state (bug 635474)

2017-10-26 Thread Zac Medico
In order to prevent false-positives during postinst_qa_check, use a preinst_qa_check function to initialize a baseline state for the postinst checks. Bug: https://bugs.gentoo.org/635474 --- bin/misc-functions.sh | 18 +++--- bin/postinst-qa-check.d/50gnome2-utils |

[gentoo-portage-dev] [PATCH v5] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Also update cfr_wrapper so that it does not rely on the fd_in

[gentoo-portage-dev] [PATCH v4] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Bug: https://bugs.gentoo.org/635126 --- [PATCH v4] ensures that

[gentoo-portage-dev] [PATCH v3] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Bug: https://bugs.gentoo.org/635126 --- [PATCH v3] adds an

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Do not document internal functions.

2017-10-24 Thread Zac Medico
On 10/24/2017 01:48 AM, Ulrich Müller wrote: > Functions containing "hook" or "prep" in their name may not be used > or relied upon by ebuilds. Therefore they should not be documented > in ebuild(5) which describes the funtions available for ebuilds. > > PMS reference:

[gentoo-portage-dev] [PATCH v2] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-23 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Bug: https://bugs.gentoo.org/635126 --- [PATCH v2] updates

Re: [gentoo-portage-dev] [PATCH] portage.checksum: Support pyblake2 fallback for BLAKE2 hashes

2017-10-20 Thread Zac Medico
On 10/20/2017 12:26 PM, Michał Górny wrote: > --- > .travis.yml | 2 ++ > pym/portage/checksum.py | 15 +-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 20078530e..ebcfbeab9 100644 > --- a/.travis.yml > +++

[gentoo-portage-dev] [PATCH] prepstrip: use debugedit from rpm if necessary (bug 634378)

2017-10-16 Thread Zac Medico
If debugedit is not found in PATH, then use debugedit installed by app-arch/rpm (if available). Suggested-by: Francesco Riosa Bug: https://bugs.gentoo.org/634378 --- bin/ebuild-helpers/prepstrip | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff

[gentoo-portage-dev] [PATCH] install-qa-check.d/10ignored-flags: fix LDFLAGS check (bug 455232)

2017-10-15 Thread Zac Medico
From: Felix Janda Since binutils-2.23.51.0.9+ defaults to hash-style=gnu, use a __gentoo_check_ldflags__ symbol instead. The check is now enabled by adding "-Wl,--defsym=__gentoo_check_ldflags__=0" to LDFLAGS. The symbol will be automatically removed when the binary is

Re: [gentoo-portage-dev] FEATURES=splitdebug and debugedit

2017-10-15 Thread Zac Medico
On 10/12/2017 02:24 PM, Francesco Riosa wrote: > hi, > >     FEATURES=splitdebug at the moment require package dev-util/debugedit > which is a lagging behind upstream. > However package app-arch/rpm (from which debugedit is forked) always > install the same binary in

Re: [gentoo-portage-dev] [PATCH] man: Update URI of GLEP references.

2017-10-14 Thread Zac Medico
On 10/14/2017 06:59 AM, Ulrich Müller wrote: > GLEPs have been moved to https://www.gentoo.org/glep/. > --- > man/ebuild.5| 2 +- > man/emerge.1| 2 +- > man/make.conf.5 | 4 ++-- > man/portage.5 | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) Looks good, please merge. --

Re: [gentoo-portage-dev] [PATCH] want_restart_for_use_change: backtrack only if needed (bug 632598)

2017-10-02 Thread Zac Medico
On 10/02/2017 09:52 AM, Brian Dolbec wrote: > On Sat, 30 Sep 2017 19:48:21 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Only backtrack if changes break a USE dependency. Prior >> to this fix, the included test case succeeded only with >> a --backtr

Re: [gentoo-portage-dev] [PATCH] postinst-qa-check.d: Skip checks if required tools are missing

2017-10-02 Thread Zac Medico
On 10/02/2017 08:36 AM, Michał Górny wrote: > Closes: https://bugs.gentoo.org/631820 > --- > bin/postinst-qa-check.d/50gnome2-utils | 2 ++ > bin/postinst-qa-check.d/50xdg-utils| 4 > 2 files changed, 6 insertions(+) > > diff --git a/bin/postinst-qa-check.d/50gnome2-utils >

[gentoo-portage-dev] [PATCH] want_restart_for_use_change: backtrack only if needed (bug 632598)

2017-09-30 Thread Zac Medico
Only backtrack if changes break a USE dependency. Prior to this fix, the included test case succeeded only with a --backtrack setting of 3 or more, but now it succeeds with a --backtrack setting of 2. X-Gentoo-bug: 632598 X-Gentoo-bug-url: https://bugs.gentoo.org/632598 ---

Re: [gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: make "forced" set recursive (bug 632210)

2017-09-29 Thread Zac Medico
On 09/29/2017 06:16 AM, Brian Dolbec wrote: > On Fri, 29 Sep 2017 00:26:01 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> When the slot conflict solver decides that it is "forced" >> to choose a particular package, recursively force the >&

Re: [gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: handle forced reinstall (bug 632202)

2017-09-29 Thread Zac Medico
On 09/29/2017 06:16 AM, Brian Dolbec wrote: > On Fri, 29 Sep 2017 01:15:59 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix the slot conflict solver to use the _want_installed_pkg >> method to identify installed packages that are intended to >&g

[gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: handle forced reinstall (bug 632202)

2017-09-29 Thread Zac Medico
Fix the slot conflict solver to use the _want_installed_pkg method to identify installed packages that are intended to be reinstalled for some reason (such as @preserved-rebuild). X-Gentoo-bug: 632202 X-Gentoo-bug-url: https://bugs.gentoo.org/632202 --- pym/_emerge/depgraph.py | 3 ++- 1 file

[gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: make "forced" set recursive (bug 632210)

2017-09-29 Thread Zac Medico
When the slot conflict solver decides that it is "forced" to choose a particular package, recursively force the dependencies as well. Prior to this fix, substitution of @world in the arguments for SlotConflictMaskUpdateTestCase caused the test to fail because the solver removed boost-build-1.53.0

<    3   4   5   6   7   8   9   10   11   12   >