Re: [gentoo-portage-dev] [gentoolkit] eshowkw: Improve & reorder keywords for my Bugzie proposal

2018-01-23 Thread Michał Górny
W dniu wto, 23.01.2018 o godzinie 14∶07 +0100, użytkownik Ulrich Mueller napisał: > > > > > > On Tue, 23 Jan 2018, Michał Górny wrote: > > Here's a short set of patches that reworks eshowkw keyword display > > & ordering to match my Bugzilla

[gentoo-portage-dev] [PATCH 2/6] eshowkw: Stop wrongly classifying *-fbsd as Prefix

2018-01-23 Thread Michał Górny
--- pym/gentoolkit/eshowkw/keywords_header.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pym/gentoolkit/eshowkw/keywords_header.py b/pym/gentoolkit/eshowkw/keywords_header.py index f92a96d..5516a72 100644 --- a/pym/gentoolkit/eshowkw/keywords_header.py +++ b/pym/gentoo

[gentoo-portage-dev] [PATCH 3/6] eshowkw: Sort all multi-component keywords after normal

2018-01-23 Thread Michał Górny
Add component count (implied by the count of '-' separators) to sort criteria. This ensures that *-fbsd sorts after regular arches, much like we list it in Bugzilla. --- pym/gentoolkit/eshowkw/keywords_header.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pym/gentoolkit/esh

[gentoo-portage-dev] [PATCH 5/6] eshowkw: Group stable and dev arches together (to match Bugzilla)

2018-01-23 Thread Michał Górny
Since dev profile status implies working towards stable status, and we are currently working on improving the status of dev arches (in particular preventing new depgraph breakages from being committed), we have switched Bugzilla to display both statuses alongside. Update eshowkw to use the same out

[gentoo-portage-dev] [gentoolkit] eshowkw: Improve & reorder keywords for my Bugzie proposal

2018-01-23 Thread Michał Górny
words (prefix). For now, the code hardcodes ~mips and all *-* arches to be pure ~arch. However, this will use arches.desc when the spec is ready. What do you think? [1]:https://archives.gentoo.org/gentoo-dev/message/65a84c7cdd3ffafc8500bf7eefd85635 -- Best regards, Michał Górny

[gentoo-portage-dev] [PATCH 6/6] eshowkw: Sort pure ~arch arches after stable keyword arches

2018-01-23 Thread Michał Górny
To match the new ordering on Bugzilla, order arches with pure ~arch keywords after those having stable keywords. The idea behind it is to make it easier to determine which arches to CC on stablereqs. The pure ~arch arch list is hardcoded for now to mips + *-* (fbsd, prefix). However, in the future

[gentoo-portage-dev] [PATCH 1/6] eshowkw: Split Prefix keyword test into separate function

2018-01-23 Thread Michał Górny
--- pym/gentoolkit/eshowkw/keywords_header.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pym/gentoolkit/eshowkw/keywords_header.py b/pym/gentoolkit/eshowkw/keywords_header.py index 9c6538c..f92a96d 100644 --- a/pym/gentoolkit/eshowkw/keywords_header.py +++ b/pym/

[gentoo-portage-dev] [PATCH 4/6] eshowkw: Remove meaningless duplicate sort of Prefix keywords

2018-01-23 Thread Michał Górny
--- pym/gentoolkit/eshowkw/keywords_header.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pym/gentoolkit/eshowkw/keywords_header.py b/pym/gentoolkit/eshowkw/keywords_header.py index bb4bf91..1ce804a 100644 --- a/pym/gentoolkit/eshowkw/keywords_header.py +++ b/pym/gentoolkit/eshowkw/keyword

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-19 Thread Michał Górny
W dniu czw, 18.01.2018 o godzinie 09∶27 -0800, użytkownik Zac Medico napisał: > On 01/16/2018 08:43 AM, Michał Górny wrote: > > Include a repo.postsync.d hook to verify the rsync checkout using > > gemato. Given that not all people will want to have it enabled > > uncondi

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Michał Górny
W dniu śro, 17.01.2018 o godzinie 12∶50 -0800, użytkownik Zac Medico napisał: > On 01/17/2018 07:42 AM, Alec Warner wrote: > > On Wed, Jan 17, 2018 at 10:25 AM, Michał Górny > <mailto:mgo...@gentoo.org>> wrote: > > > > W dniu wto, 16.01.2018 o godzinie 1

Re: [gentoo-portage-dev] [PATCH] ebuild: allow RESTRICT=network-sandbox in ebuilds

2018-01-17 Thread Michał Górny
ddressing it in as narrow scope as possible -- i.e. it is usually enough to disable sandbox for the execution of a single command rather than the whole ebuild. That said, app-portage/unsandbox is much cleaner solution here. -- Best regards, Michał Górny

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Michał Górny
W dniu wto, 16.01.2018 o godzinie 11∶32 -0800, użytkownik Zac Medico napisał: > On 01/16/2018 10:39 AM, Michał Górny wrote: > > W dniu wto, 16.01.2018 o godzinie 12∶44 -0500, użytkownik Alec Warner > > napisał: > > > On Tue, Jan 16, 2018 at 11:43 AM, Michał Górny wrote:

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Michał Górny
E-conditional dep on gemato. However, gemato doesn't require the hook unconditionally, so we end up with two USE flags that need to be switched together == a mess. -- Best regards, Michał Górny

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Michał Górny
W dniu wto, 16.01.2018 o godzinie 12∶44 -0500, użytkownik Alec Warner napisał: > On Tue, Jan 16, 2018 at 11:43 AM, Michał Górny wrote: > > > Include a repo.postsync.d hook to verify the rsync checkout using > > gemato. Given that not all people will want to have it enabled &

[gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Michał Górny
Include a repo.postsync.d hook to verify the rsync checkout using gemato. Given that not all people will want to have it enabled unconditionally, no setup.py rules are included -- instead, the file would be installed conditionally by the ebuild. [v2: included link to the wiki page] --- MANIFEST.i

[gentoo-portage-dev] [PATCH] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Michał Górny
Include a repo.postsync.d hook to verify the rsync checkout using gemato. Given that not all people will want to have it enabled unconditionally, no setup.py rules are included -- instead, the file would be installed conditionally by the ebuild. --- MANIFEST.in | 2 +- misc/repo

Re: [gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

2018-01-13 Thread Michał Górny
Dnia 13 stycznia 2018 11:40:09 CET, Zac Medico napisał(a): >On 01/13/2018 12:50 AM, Michał Górny wrote: >> Switch the Portage defaults to the new Gentoo hash set. We're already >> far past the initial testing and I have been approached by a few >people >> who were su

[gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

2018-01-13 Thread Michał Górny
Switch the Portage defaults to the new Gentoo hash set. We're already far past the initial testing and I have been approached by a few people who were surprised that Portage does not use new hashes for overlays. Switching the defaults will remove the need for custom hashes in layout.conf. --- pym/

Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-11 Thread Michał Górny
W dniu śro, 10.01.2018 o godzinie 14∶56 -0800, użytkownik Zac Medico napisał: > On 01/10/2018 02:24 PM, Michał Górny wrote: > > Enable repoman checks on exp profiles by default to improve > > the dependency graph integrity on those profiles and help them on their > > way

Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-10 Thread Michał Górny
Dnia 11 stycznia 2018 07:54:40 CET, Mike Gilbert napisał(a): >On Wed, Jan 10, 2018 at 11:10 PM, Michał Górny >wrote: >> W dniu śro, 10.01.2018 o godzinie 21∶45 -0500, użytkownik Mike >Gilbert >> napisał: >>> On Wed, Jan 10, 2018 at 5:56 PM, Zac Medico >wr

Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-10 Thread Michał Górny
W dniu śro, 10.01.2018 o godzinie 21∶45 -0500, użytkownik Mike Gilbert napisał: > On Wed, Jan 10, 2018 at 5:56 PM, Zac Medico wrote: > > On 01/10/2018 02:24 PM, Michał Górny wrote: > > > Enable repoman checks on exp profiles by default to improve > > > the dependen

[gentoo-portage-dev] [PATCH 1/2] repoman: Add a new 'badinexp' warning class for exp profiles

2018-01-10 Thread Michał Górny
Add a new 'badinexp' (+ 'badmaskedinexp') warning class that is likewise 'badindev' but for 'exp' profiles. This will allow us to more proactively inform developers of exp profile breakages without actually making them fatal errors like they are now. --- repoman/man/repoman.1

[gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default

2018-01-10 Thread Michał Górny
Enable repoman checks on exp profiles by default to improve the dependency graph integrity on those profiles and help them on their way towards stable status. This is possible now that the dependency graph problems are warnings rather than errors. --- repoman/pym/repoman/argparser.py | 2 +- 1 fil

Re: [gentoo-portage-dev] [PATCH v2] install-qa-check: Do not install empty directories

2018-01-10 Thread Michał Górny
W dniu śro, 10.01.2018 o godzinie 15∶39 -0500, użytkownik Michael Orlitzky napisał: > On 01/10/2018 03:13 PM, Michał Górny wrote: > > Remove empty directories in install-qa-check phase in order to prevent > > Portage from installing them, and therefore from developers relying &g

Re: [gentoo-portage-dev] [PATCH] install-qa-check: Do not install empty directories

2018-01-10 Thread Michał Górny
t? Done. > > Also looking at https://devmanual.gentoo.org/eclass-reference/ebuild/ > > It says "keepdir functions the same as dodir" but this has not been true > for a while? No clue where that comes from. I suppose it's some Portage manpage? > > -A > &g

[gentoo-portage-dev] [PATCH v2] install-qa-check: Do not install empty directories

2018-01-10 Thread Michał Górny
Remove empty directories in install-qa-check phase in order to prevent Portage from installing them, and therefore from developers relying on them being installed. The PMS specifies the behavior upon merging empty directories as undefined, and specifically prohibits ebuilds from attempting to inst

[gentoo-portage-dev] [PATCH] install-qa-check: Do not install empty directories

2018-01-10 Thread Michał Górny
Remove empty directories in install-qa-check phase in order to prevent Portage from installing them, and therefore from developers relying on them being installed. The PMS specifies the behavior upon merging empty directories as undefined, and specifically prohibits ebuilds from attempting to inst

Re: [gentoo-portage-dev] [PATCH] Disable dynamic-deps by default

2017-12-19 Thread Michał Górny
W dniu nie, 17.12.2017 o godzinie 13∶03 +0100, użytkownik Michał Górny napisał: > We have prepared for this for quite a while and it's time to pull > the plug. Disable dynamic-deps by default and restore the standard > PMS behavior. This will cause some one-time pain but eventually

[gentoo-portage-dev] [PATCH] Disable dynamic-deps by default

2017-12-17 Thread Michał Górny
We have prepared for this for quite a while and it's time to pull the plug. Disable dynamic-deps by default and restore the standard PMS behavior. This will cause some one-time pain but eventually will result in improvement of ebuild quality, especially when developers start experiencing the need f

[gentoo-portage-dev] [PATCH] [checksum] Do not use secure memory for pygcrypt backend

2017-12-05 Thread Michał Górny
Disable using secure memory for pygcrypt backend since we are not processing secrets. This can avoid the libgcrypt memory error; however, it turned out to be a huge memory/resource leak which needs to be fixed independently. --- pym/portage/checksum.py | 3 ++- 1 file changed, 2 insertions(+), 1 d

[gentoo-portage-dev] [PATCH v2] [checksum] Disable pygcrypt backend due to breakage

2017-12-05 Thread Michał Górny
Closes: https://bugs.gentoo.org/615620 --- pym/portage/checksum.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py index 5424ce56b..9e7bffea9 100644 --- a/pym/portage/checksum.py +++ b/pym/portage/checksum.py @@ -150,7 +150

[gentoo-portage-dev] [PATCH] [checksum] Disable pygcrypt backend due to breakage

2017-12-05 Thread Michał Górny
Closes: https://bugs.gentoo.org/615620 --- pym/portage/checksum.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py index 5424ce56b..0841ab231 100644 --- a/pym/portage/checksum.py +++ b/pym/portage/checksum.py @@ -150,7 +150,

[gentoo-portage-dev] [PATCH] portage.manifest: Fix mis-parsing Manifests with numerical checksums

2017-11-19 Thread Michał Górny
Fix the regular expression used to parse Manifests not to fail horribly when one of the checksums accidentally happens to be all-digits. The previously used regular expression used to greedily take everything up to the first number as filename. If one of the checksums happened to be purely numeric

[gentoo-portage-dev] [PATCH v2] Make manifest-required-hashes configurable

2017-11-07 Thread Michał Górny
The set of required hashes specify which hashes must be present for a distfile not to be refetched. It makes little sense to hardcode this value, and it is mostly useful for transition periods, so make it configurable via layout.conf and default to all hashes in manifest-hashes. --- man/portage.5

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-07 Thread Michał Górny
W dniu wto, 07.11.2017 o godzinie 11∶21 -0800, użytkownik Zac Medico napisał: > On 11/06/2017 10:23 AM, Michał Górny wrote: > > W dniu pon, 06.11.2017 o godzinie 08∶52 -0800, użytkownik Zac Medico > > napisał: > > > On 11/06/2017 08:47 AM, Michał Górny wrote: > >

Re: [gentoo-portage-dev] [PATCH 1/3] portage.const: Remove obsolete manifest-hashes comment

2017-11-06 Thread Michał Górny
Dnia 7 listopada 2017 00:01:18 CET, "Robin H. Johnson" napisał(a): >On Mon, Nov 06, 2017 at 09:14:56AM +0100, Michał Górny wrote: >> -# Future events: >> -# >> -# After WHIRLPOOL is supported in stable portage for at least 1 >year: >> -# - Cha

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-06 Thread Michał Górny
W dniu pon, 06.11.2017 o godzinie 08∶52 -0800, użytkownik Zac Medico napisał: > On 11/06/2017 08:47 AM, Michał Górny wrote: > > W dniu pon, 06.11.2017 o godzinie 08∶44 -0800, użytkownik Zac Medico > > napisał: > > > On 11/06/2017 07:27 AM, Michał Górny wrote: > > &

Re: [gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-06 Thread Michał Górny
W dniu pon, 06.11.2017 o godzinie 08∶44 -0800, użytkownik Zac Medico napisał: > On 11/06/2017 07:27 AM, Michał Górny wrote: > > @@ -148,15 +147,21 @@ class Manifest(object): > > self.pkgdir = _unicode_decode(pkgdir).rstrip(os.sep) + os.sep > >

[gentoo-portage-dev] [PATCH] Make manifest-required-hashes configurable

2017-11-06 Thread Michał Górny
The set of required hashes specify which hashes must be present for a distfile not to be refetched. It makes little sense to hardcode this value, and it is mostly useful for transition periods, so make it configurable via layout.conf and default to all hashes in manifest-hashes. --- pym/portage/_e

[gentoo-portage-dev] [PATCH 1/3] portage.const: Remove obsolete manifest-hashes comment

2017-11-06 Thread Michał Górny
The comment is based upon the wrong assumption that the world is Portage-centric. We are keeping the manifest-hashes in layout.conf indefinitely, and we will most likely take BLAKE2 instead of SHA3. --- pym/portage/const.py | 23 --- 1 file changed, 23 deletions(-) diff --git

[gentoo-portage-dev] [PATCH 3/3] Remove last traces of Manifest1 code

2017-11-06 Thread Michał Górny
--- pym/portage/const.py| 1 - pym/portage/manifest.py | 7 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pym/portage/const.py b/pym/portage/const.py index 98b7c88c9..0af57d0e2 100644 --- a/pym/portage/const.py +++ b/pym/portage/const.py @@ -205,7 +205,6 @@ SUPPORTED_F

[gentoo-portage-dev] [PATCH 2/3] Replace static MANIFEST2_HASH_FUNCTIONS with dynamic list

2017-11-06 Thread Michał Górny
Remove the MANIFEST2_HASH_FUNCTIONS const and replace it with (deduplicated) calls to get_valid_checksum_keys(). We want Portage to always complain whenever one of the hashes is not available even if it is technically supported by the specific Portage version. Closes: https://bugs.gentoo.org/63481

Re: [gentoo-portage-dev] [PATCH] postinst_qa_check: initialize preinst state (bug 635474)

2017-10-26 Thread Michał Górny
. The same effect could be achieved by adding a small pkg_postinst() to sys-apps/portage. -- Best regards, Michał Górny

[gentoo-portage-dev] [PATCH] portage.checksum: Support pyblake2 fallback for BLAKE2 hashes

2017-10-20 Thread Michał Górny
--- .travis.yml | 2 ++ pym/portage/checksum.py | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 20078530e..ebcfbeab9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,6 +12,8 @@ install: # python3.6+ has sha3 b

[gentoo-portage-dev] [PATCH] postinst-qa-check.d: Skip checks if required tools are missing

2017-10-02 Thread Michał Górny
Closes: https://bugs.gentoo.org/631820 --- bin/postinst-qa-check.d/50gnome2-utils | 2 ++ bin/postinst-qa-check.d/50xdg-utils| 4 2 files changed, 6 insertions(+) diff --git a/bin/postinst-qa-check.d/50gnome2-utils b/bin/postinst-qa-check.d/50gnome2-utils index 569633fe3..7f1b0b847 1006

Re: [gentoo-portage-dev] Portage patch now on gentoo-portage-dev ml

2017-09-12 Thread Michał Górny
ortage tree > available from git or some url for syncing? > I don't really understand what you're asking for. Is it about the failures with commands in global scope? If it's that, then it's already merged and available via =sys-apps/portage-. -- Best regards, Michał Górny

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-09-08 Thread Michał Górny
W dniu pią, 08.09.2017 o godzinie 14∶48 -0400, użytkownik Alec Warner napisał: > Why PATH=/dev/null vs export PATH="" + # note: we can't use empty because it implies current directory > > On Thu, Sep 7, 2017 at 3:36 AM, Michał Górny wrote: > > > Dn

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-09-07 Thread Michał Górny
Dnia 31 sierpnia 2017 22:45:42 CEST, "Michał Górny" napisał(a): >Set PATH to /dev/null when sourcing the ebuild for dependency >resolution >in order to prevent shell from finding external commands via PATH >lookup. While this does not prevent executing programs via full p

[gentoo-portage-dev] [PATCH v2 2/2] repoman: Update --bug/--closes description for bugs.g.o hooks

2017-09-02 Thread Michał Górny
Update the description for --bug and --closes to account for the fact that the tags are now handled by git hooks on Gentoo Infra, and cause actions on Gentoo Bugzilla. --- repoman/man/repoman.1 | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/repoman/man/repoman.1

[gentoo-portage-dev] [PATCH v2 1/2] repoman: Unify usage of --bug and --closes options

2017-09-02 Thread Michał Górny
Replace the different logic used for --bug and --closes options with a uniform solution. As a result, --closes now interprets numbers as Gentoo bug numbers rather than GitHub pull request numbers. This change is mostly done since the 'Closes' tag now started being used to resolve Gentoo bugs. Whil

Re: [gentoo-portage-dev] [PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

2017-09-02 Thread Michał Górny
W dniu sob, 02.09.2017 o godzinie 14∶33 -0700, użytkownik Zac Medico napisał: > On 09/02/2017 12:10 PM, Michał Górny wrote: > > Update the description for --bug and --closes to account for the fact > > that the tags are now handled by git hooks on Gentoo Infra, and cause > &

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Michał Górny
W dniu sob, 02.09.2017 o godzinie 14∶23 -0700, użytkownik Zac Medico napisał: > On 09/02/2017 02:05 PM, Michał Górny wrote: > > W dniu sob, 02.09.2017 o godzinie 12∶19 -0700, użytkownik Zac Medico > > napisał: > > > On 09/02/2017 10:46 AM, Michał Górny wrote: > >

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Michał Górny
W dniu sob, 02.09.2017 o godzinie 23∶05 +0200, użytkownik Michał Górny napisał: > W dniu sob, 02.09.2017 o godzinie 12∶19 -0700, użytkownik Zac Medico > napisał: > > On 09/02/2017 10:46 AM, Michał Górny wrote: > > > dev-python/pycparser-2.18+ exposes a design flaw i

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Michał Górny
W dniu sob, 02.09.2017 o godzinie 12∶19 -0700, użytkownik Zac Medico napisał: > On 09/02/2017 10:46 AM, Michał Górny wrote: > > dev-python/pycparser-2.18+ exposes a design flaw in dev-python/ply that > > makes it unable to work with -OO code. Remove the optimizations from > >

[gentoo-portage-dev] [PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

2017-09-02 Thread Michał Górny
Update the description for --bug and --closes to account for the fact that the tags are now handled by git hooks on Gentoo Infra, and cause actions on Gentoo Bugzilla. // NB: It would probably make sense for --closes to default to Gentoo bug numbers now. However, I have doubts that some people mig

[gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Michał Górny
dev-python/pycparser-2.18+ exposes a design flaw in dev-python/ply that makes it unable to work with -OO code. Remove the optimizations from Portage shebangs to prevent triggering the issue until we find a proper solution for it. Bug: https://bugs.gentoo.org/628386 --- bin/clean_locks | 2 +- b

[gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-08-31 Thread Michał Górny
Set PATH to /dev/null when sourcing the ebuild for dependency resolution in order to prevent shell from finding external commands via PATH lookup. While this does not prevent executing programs via full path, it should catch the majority of accidental uses. Closes: https://github.com/gentoo/portag

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Michał Górny
W dniu czw, 31.08.2017 o godzinie 10∶42 -0700, użytkownik Zac Medico napisał: > On 08/31/2017 07:56 AM, Michał Górny wrote: > > The PMS specifies that ebuilds must not call external commands in global > > scope. We can not prevent that from happening at the moment since a few > &

[gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Michał Górny
The PMS specifies that ebuilds must not call external commands in global scope. We can not prevent that from happening at the moment since a few ebuilds in Gentoo are still doing that. Instead, start increasing strictness by explicitly failing if ebuilds call external commands that are not found.

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-31 Thread Michał Górny
W dniu śro, 30.08.2017 o godzinie 23∶36 -0700, użytkownik Zac Medico napisał: > On 08/30/2017 01:45 PM, Michał Górny wrote: > > W dniu śro, 30.08.2017 o godzinie 13∶35 -0700, użytkownik Zac Medico > > napisał: > > > On 08/30/2017 01:31 PM, Michał Górny wrote: > >

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Michał Górny
W dniu śro, 30.08.2017 o godzinie 13∶35 -0700, użytkownik Zac Medico napisał: > On 08/30/2017 01:31 PM, Michał Górny wrote: > > W dniu śro, 30.08.2017 o godzinie 10∶48 -0700, użytkownik Zac Medico > > napisał: > > > On 08/30/2017 02:06 AM, Michał Górny wrote: > &g

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Michał Górny
W dniu śro, 30.08.2017 o godzinie 10∶48 -0700, użytkownik Zac Medico napisał: > On 08/30/2017 02:06 AM, Michał Górny wrote: > > The value of get_libdir depends on the profile, and so it is not useful > > for dependency calculations. Furthermore, it seems that Portage does > >

[gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Michał Górny
The value of get_libdir depends on the profile, and so it is not useful for dependency calculations. Furthermore, it seems that Portage does not handle defining it in global scope well due to EAPI checking magic. Ban it completely where it is defined as EAPI function to let developers catch their m

[gentoo-portage-dev] [PATCH] gnome2-utils postinst: Restrict file types to fix false positives

2017-08-29 Thread Michał Górny
Restrict the file types checked by the gtk-icon-cache-update check to match the one used inside the tool. This ensures that we do not report any false positives for files that are intentionally skipped. Bug: https://bugs.gentoo.org/629148 --- bin/postinst-qa-check.d/50gnome2-utils | 7 ++- 1

Re: [gentoo-portage-dev] [PATCH v2 1/4] Support post-postinst QA checks

2017-08-26 Thread Michał Górny
W dniu śro, 16.08.2017 o godzinie 20∶09 +0200, użytkownik Michał Górny napisał: > Extend the QA check mechanics in Portage to support post-postinst QA > checks. They are like post-install QA checks, except they are run after > pkg_postinst(), and so they can be used to verify that

Re: [gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526)

2017-08-23 Thread Michał Górny
; -d $x && ! -L $x ]] ; then > - if [ "${DOINSRECUR}" == "n" ] ; then > - if [[ ${helper} == dodoc ]] ; then > - echo "!!! ${helper}: $x is a directory" 1>&2 > - ((failed|=1)) > - fi > - continue > - fi > - > - while [ "$x" != "${x%/}" ] ; do > - x=${x%/} > - done > - if [ "$x" = "${x%/*}" ] ; then > - pushd "$PWD" >/dev/null > - else > - pushd "${x%/*}" >/dev/null > - fi > - x=${x##*/} > - x_orig=$x > - # Follow any symlinks recursively until we've got > - # a normal directory for 'find' to traverse. The > - # name of the symlink will be used for the name > - # of the installed directory, as discussed in > - # bug #239529. > - while [ -L "$x" ] ; do > - pushd "$(readlink "$x")" >/dev/null > - x=${PWD##*/} > - pushd "${PWD%/*}" >/dev/null > - done > - if [[ $x != $x_orig ]] ; then > - mv "$x" "$TMP/1/$x_orig" > - pushd "$TMP/1" >/dev/null > - fi > - find "$x_orig" -type d -exec dodir "${INSDESTTREE}/{}" \; > - find "$x_orig" \( -type f -or -type l \) -print0 | _xdoins > - if [[ ${PIPESTATUS[1]} -eq 0 ]] ; then > - # NOTE: Even if only an empty directory is installed > here, it > - # still counts as success, since an empty directory > given as > - # an argument to doins -r should not trigger failure. > - ((success|=1)) > - else > - ((failed|=1)) > - fi > - if [[ $x != $x_orig ]] ; then > - popd >/dev/null > - mv "$TMP/1/$x_orig" "$x" > - fi > - while popd >/dev/null 2>&1 ; do true ; done > - else > - _doins "${x}" > - if [[ $? -eq 0 ]] ; then > - ((success|=1)) > - else > - ((failed|=1)) > - fi > - fi > -done > -rm -rf "$TMP" > -[[ $failed -ne 0 || $success -eq 0 ]] && { __helpers_die "${helper} failed"; > exit 1; } || exit 0 > +"${PORTAGE_PYTHON:-/usr/bin/python}" \ > + "${PORTAGE_BIN_PATH:-/usr/lib/portage/bin}"/doins.py \ > + ${RECURSIVE_OPTION} ${SYMLINK_OPTION} \ > + --helper "${helper}" --dest "${ED}${INSDESTTREE}" "$@" || \ > +{ __helpers_die "${helper} failed"; exit 1; } To be honest, I don't like the idea of using more Python inside ebuild helpers. But if you're sure this is safe and not going to collide with ebuilds doing random stuff with Python, feel free to proceed with it. -- Best regards, Michał Górny

Re: [gentoo-portage-dev] [PATCH] elog mod_echo: Print log path if PORT_LOGDIR is used

2017-08-17 Thread Michał Górny
W dniu śro, 16.08.2017 o godzinie 09∶12 -0700, użytkownik Brian Dolbec napisał: > On Wed, 16 Aug 2017 12:10:52 +0200 > Michał Górny wrote: > > > Include the path to the log file if PORT_LOGDIR is being used > > (and therefore the log is going to be preserved past the build

[gentoo-portage-dev] [PATCH v2 2/4] Add post-postinst checks for a few missed cache updates

2017-08-16 Thread Michał Górny
Add postinst-qa-check.d checks for missed desktop, mime-info and GTK+ icon cache updates. In all of the cases the checks simply look for any installed files that are newer than the cache. This check has some limitations: it assumes that mtime is not preserved when copying files to D, it can't dist

[gentoo-portage-dev] [PATCH v2 4/4] Update caches after reporting missing cache updates

2017-08-16 Thread Michał Górny
Call the appropriate updater to update caches after reporting a missing cache update, in order to stop repeating the same issue on subsequent packages that did not install any relevant files. --- bin/postinst-qa-check.d/50gnome2-utils | 9 + bin/postinst-qa-check.d/50xdg-utils| 18 +++

[gentoo-portage-dev] [PATCH v2 3/4] Use ctime in cache post-postinst checks

2017-08-16 Thread Michał Górny
Use ctime rather than mtime in cache post-postinst checks since mtime may be preserved from the original tarball, and therefore be 'long time ago'. ctime is more reliable in this regard. --- bin/postinst-qa-check.d/50gnome2-utils | 2 +- bin/postinst-qa-check.d/50xdg-utils| 4 ++-- 2 files cha

[gentoo-portage-dev] [PATCH v2 1/4] Support post-postinst QA checks

2017-08-16 Thread Michał Górny
Extend the QA check mechanics in Portage to support post-postinst QA checks. They are like post-install QA checks, except they are run after pkg_postinst(), and so they can be used to verify that necessary postinst actions were performed (e.g. regenerating caches). --- bin/misc-functions.sh

Re: [gentoo-portage-dev] [PATCH 3/2] Update caches after reporting missing cache updates

2017-08-16 Thread Michał Górny
W dniu śro, 16.08.2017 o godzinie 16∶22 +0200, użytkownik Michał Górny napisał: > Call the appropriate updater to update caches after reporting a missing > cache update, in order to stop repeating the same issue on subsequent > packages that did not install any relevant files. >

[gentoo-portage-dev] [PATCH 3/2] Update caches after reporting missing cache updates

2017-08-16 Thread Michał Górny
Call the appropriate updater to update caches after reporting a missing cache update, in order to stop repeating the same issue on subsequent packages that did not install any relevant files. --- bin/postinst-qa-check.d/50gnome2-utils | 8 bin/postinst-qa-check.d/50xdg-utils| 16

[gentoo-portage-dev] [PATCH] elog mod_echo: Print log path if PORT_LOGDIR is used

2017-08-16 Thread Michał Górny
Include the path to the log file if PORT_LOGDIR is being used (and therefore the log is going to be preserved past the build). This is useful when elog messages contain QA warnings or other errors that require reporting a bug. In such case, having a path to the log is handy. After this commit, the

[gentoo-portage-dev] [PATCH 2/2] Add post-postinst checks for a few missed cache updates

2017-08-15 Thread Michał Górny
Add postinst-qa-check.d checks for missed desktop, mime-info and GTK+ icon cache updates. In all of the cases the checks simply look for any installed files that are newer than the cache. This check has some limitations: it assumes that mtime is not preserved when copying files to D, it can't dist

[gentoo-portage-dev] [PATCH 1/2] Support post-postinst QA checks

2017-08-15 Thread Michał Górny
Extend the QA check mechanics in Portage to support post-postinst QA checks. They are like post-install QA checks, except they are run after pkg_postinst(), and so they can be used to verify that necessary postinst actions were performed (e.g. regenerating caches). --- bin/misc-functions.sh

Re: [gentoo-portage-dev] [PATCH v4] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-06 Thread Michał Górny
On nie, 2017-08-06 at 00:18 -0700, Zac Medico wrote: > On Sat, Aug 5, 2017 at 11:53 PM, Michał Górny wrote: > > Support two new options: --bug (-b) and --closes (-c) to add a plain > > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both &g

Re: [gentoo-portage-dev] [PATCH] repoman commit: Merge code generating common part of the footer (DCO)

2017-08-05 Thread Michał Górny
On sob, 2017-08-05 at 22:50 -0700, Zac Medico wrote: > On Thu, Aug 3, 2017 at 6:55 AM, Michał Górny wrote: > > The DCO Signed-off-by footer looks the same on the git branch, and on > > the branch for other VCS-es. Therefore, move the code generating it > > above the spli

[gentoo-portage-dev] [PATCH v4] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-05 Thread Michał Górny
Support two new options: --bug (-b) and --closes (-c) to add a plain 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both options can be specified multiple times, resulting in multiple footer tags being written. The --bug option accepts either a Gentoo Bugzilla bug number or an UR

[gentoo-portage-dev] [PATCH v3] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-05 Thread Michał Górny
Support two new options: --bug (-b) and --closes (-c) to add a plain 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both options can be specified multiple times, resulting in multiple footer tags being written. The --bug option accepts either a Gentoo Bugzilla bug number or an UR

Re: [gentoo-portage-dev] [PATCH v2] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-05 Thread Michał Górny
On sob, 2017-08-05 at 17:11 -0400, Alec Warner wrote: > On Fri, Aug 4, 2017 at 6:37 PM, Michał Górny wrote: > > > Support two new options: --bug (-b) and --closes (-c) to add a plain > > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both

[gentoo-portage-dev] [PATCH v2] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-04 Thread Michał Górny
Support two new options: --bug (-b) and --closes (-c) to add a plain 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both options can be specified multiple times, resulting in multiple footer tags being written. The --bug option accepts either a Gentoo Bugzilla bug number or an UR

Re: [gentoo-portage-dev] [PATCH] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-03 Thread Michał Górny
On czw, 2017-08-03 at 11:18 -0400, Alec Warner wrote: > On Thu, Aug 3, 2017 at 10:18 AM, Michał Górny wrote: > > > Support two new options: --bug (-b) and --closes (-c) to add a plain > > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both

[gentoo-portage-dev] [PATCH] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-03 Thread Michał Górny
Support two new options: --bug (-b) and --closes (-c) to add a plain 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both options can be specified multiple times, resulting in multiple footer tags being written. The --bug option accepts either a Gentoo Bugzilla bug number or an UR

[gentoo-portage-dev] [PATCH] repoman commit: Merge code generating common part of the footer (DCO)

2017-08-03 Thread Michał Górny
The DCO Signed-off-by footer looks the same on the git branch, and on the branch for other VCS-es. Therefore, move the code generating it above the split branches. This also prepares the code for further footer elements being added. --- repoman/pym/repoman/actions.py | 13 +++-- 1 file cha

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-08-02 Thread Michał Górny
On śro, 2017-08-02 at 00:30 -0700, Zac Medico wrote: > On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny wrote: > > Enable the multilib-strict feature necessary for Portage to detect > > ebuilds not respecting libdir for libraries. Since those issues were > > reliably fixed ove

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-31 Thread Michał Górny
Dnia 31 lipca 2017 10:17:56 CEST, Zac Medico napisał(a): >On Wed, Jul 26, 2017 at 1:44 PM, Michał Górny >wrote: >> On śro, 2017-07-26 at 11:29 -0700, Zac Medico wrote: >>> You might think that, but I just checked our profiles and the only >one >>> that currentl

Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages

2017-07-29 Thread Michał Górny
ng it but we have already: PORTAGE_COMPRESS PORTAGE_COMPRESS_FLAGS ^^ and you've added: BINPKG_COMPRESSION ^^^ BINPKG_COMPRESSION_ARGS Wouldn't it be better to at least try having consistent variable naming? -- Best regards, Micha

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-26 Thread Michał Górny
On śro, 2017-07-26 at 11:29 -0700, Zac Medico wrote: > On Wed, Jul 26, 2017 at 10:11 AM, Michał Górny wrote: > > On śro, 2017-07-26 at 09:58 -0700, Zac Medico wrote: > > > On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny wrote: > > > > Enable the multilib-strict fe

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-26 Thread Michał Górny
On śro, 2017-07-26 at 09:58 -0700, Zac Medico wrote: > On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny wrote: > > Enable the multilib-strict feature necessary for Portage to detect > > ebuilds not respecting libdir for libraries. Since those issues were > > reliably fixed ove

[gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-26 Thread Michał Górny
Enable the multilib-strict feature necessary for Portage to detect ebuilds not respecting libdir for libraries. Since those issues were reliably fixed over the years and we're nearing the removal of 'lib' symlink, I think we can safely enable it by default for our users without risking many additio

Re: [gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files

2017-07-09 Thread Michał Górny
On nie, 2017-07-02 at 11:57 -0700, Brian Dolbec wrote: > On Sun, 2 Jul 2017 19:57:57 +0200 > Michał Górny wrote: > > > Passing compressed files to doman is not permitted by the PMS. > > However, Portage permitting it results in many developers repeatedly > > violating

Re: [gentoo-portage-dev] Leader election

2017-07-09 Thread Michał Górny
d Sunday, July 2 at 4:00 PM UTC > > > > > > > We've decided (the members in attendance), to do the lead election via > > > email. > > > So, nominations are open from now to July 5, 2017. > > > Voting will be closed July 10, 2017, results posted here again. > > > - -- > > > Brian Dolbec > > > > > > I nominate Zac > > Thank you, I accept. > > I also nominate Brian Dolbec and Alexander Berntsen. My vote goes for Zac as well. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part

Re: [gentoo-portage-dev] [PATCH] Support different (de)compressors for binary packages

2017-07-05 Thread Michał Górny
ething a standard install doesn't include. > > Assume all binpkgs are set to be compressed with zstd, the patch makes > sure an app-arch/zstd binpkg will still be compressed with bzip2. And app-arch/bzip2 binpackage? In other words, that's the wrong approach. If I set binpackages to use X, I want them to use X, not 'use X if someone thought it correct to use X'. Just do what the user says to do. If you try to outsmart him, you're building another Windows. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part

[gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files

2017-07-02 Thread Michał Górny
Passing compressed files to doman is not permitted by the PMS. However, Portage permitting it results in many developers repeatedly violating this and arguing that it's permitted because nobody explicitly forbids it. Add an explicit QA warning to Portage to cease it. --- bin/ebuild-helpers/doman |

Re: [gentoo-portage-dev] [PATCH v2] checks: Add more deprecated eclasses

2017-07-02 Thread Michał Górny
On pon, 2017-06-19 at 07:48 -0700, Brian Dolbec wrote: > On Mon, 19 Jun 2017 15:35:49 +0200 > Michał Górny wrote: > > > Changes in v2: > > * multilib-minimal is suggested replacement of autotools-multilib. > > > > --- > > repoman/pym/repoman/modules/scan

[gentoo-portage-dev] [PATCH v2] checks: Add more deprecated eclasses

2017-06-19 Thread Michał Górny
Changes in v2: * multilib-minimal is suggested replacement of autotools-multilib. --- repoman/pym/repoman/modules/scan/ebuild/checks.py | 5 + 1 file changed, 5 insertions(+) diff --git a/repoman/pym/repoman/modules/scan/ebuild/checks.py b/repoman/pym/repoman/modules/scan/ebuild/checks.py i

[gentoo-portage-dev] [PATCH] checks: Add more deprecated eclasses

2017-06-19 Thread Michał Górny
--- repoman/pym/repoman/modules/scan/ebuild/checks.py | 5 + 1 file changed, 5 insertions(+) diff --git a/repoman/pym/repoman/modules/scan/ebuild/checks.py b/repoman/pym/repoman/modules/scan/ebuild/checks.py index e6e5d78ba..a1fa066be 100644 --- a/repoman/pym/repoman/modules/scan/ebuild/chec

Re: [gentoo-portage-dev] [PATCH] const: Change the MANIFEST2_REQUIRED_HASH to SHA512

2017-06-15 Thread Michał Górny
On czw, 2017-06-15 at 09:49 -0700, Zac Medico wrote: > On Thu, Jun 15, 2017 at 12:42 AM, Michał Górny wrote: > > > > Following the plan established in GLEP 59, we're long overdue > > deprecating SHA256. Since we have finally got rid of the last packages > >

Re: [gentoo-portage-dev] [PATCH] const: Remove unused MANIFEST1_REQUIRED_HASH

2017-06-15 Thread Michał Górny
On czw, 2017-06-15 at 09:08 -0700, Zac Medico wrote: > On Thu, Jun 15, 2017 at 12:27 AM, Michał Górny wrote: > > > The MANIFEST1_REQUIRED_HASH constant is not used anywhere, so it should > > be possible to remove it safely. > > --- > > pym/portage/const.py | 1 - &

<    1   2   3   4   5   6   7   8   9   10   >